Re: [libvirt] [PATCH] libxl: fix domxml-to-native wrong output for qcow2 format

:) . but it should be(if with this patch) qcow2:/var/lib/xen/images/001/disk0.qcow2,hdc,w Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/xenxs/xen_xm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c index b2db97d

[libvirt] [PATCH] libxl: fix domxml-to-native wrong output for qcow2 format

but it should be(if with this patch) qcow2:/var/lib/xen/images/001/disk0.qcow2,hdc,w Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/xenxs/xen_xm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c index b2db97d..29835b4

[libvirt] [PATCH] libxl: fix segfault when domain create fail

there is a segfault in libxl logging in libxl_ctx_free when domain create fail. because the log output handler vmessage is freed by xtl_logger_destroy before libxl_ctx_free in virDomainObjListRemove. move xtl_logger_destroy after libxl_ctx_free could fix this bug. Signed-off-by: Bamvor Jian Zhang

[libvirt] [PATCH] fix api changes in xen restore

LIBXL_HAVE_DOMAIN_CREATE_RESTORE_PARAMS in libxl.h in order to make libvirt could compile with old and new xen. the params checkpointed_stream is useful if libvirt libxl driver support migration. for new, set it as zero. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_driver.c | 9 + 1 file

Re: [libvirt] [PATCH] add migration APIs to libxl driver

--- src/libxl/libxl_conf.h |4 + src/libxl/libxl_driver.c | 641 ++ src/libxl/libxl_driver.h |5 + 3 files changed, 650 insertions(+), 0 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index

[libvirt] [PATCH V5] add console support in libxl

this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- Changes since V4: 1), using proper error instead

[libvirt] [PATCH V4] add console support in libxl

this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- Changes since V3: implicity forbit dev_name pass to libxl driver

[libvirt] [PATCH V4] add console support in libxl

this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- Changes since V3: implicity forbit dev_name pass to libxl driver due

Re: [libvirt] [PATCH V3] add console support in libxl

Hi, Denial thanks your reply. Daniel P. Berrange 2013-7-19 下午 23:53 On Fri, Jul 19, 2013 at 11:48:56PM +0800, Bamvor Jian Zhang wrote: this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which

[libvirt] [PATCH V3] add console support in libxl

this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- Changes since V2: 1), forbid parallel configure because libxl do

[libvirt] [PATCH V2] add console support in libxl

this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- changes since V1: 1), add virDomainOpenConsoleEnsureACL 3), remove

Re: [libvirt] [PATCH] add console support in libxl

Hi, Jim thanks your reply. one comment below. 已写入 Jim Fehlig jfeh...@suse.com On 07/04/2013 05:58 AM, Bamvor Jian Zhang wrote: this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted

[libvirt] [PATCH] add console support in libxl

this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in commit dfa1e1dd. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_conf.c | 97

[libvirt] [PATCH] fix segfault during virsh save in pv guest

- destroy - create - setmem - setvcpus - destroy. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_driver.c | 39 +-- 1 files changed, 21 insertions(+), 18 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index

[libvirt] [PATCH] fix typo introduced by 90430791

From: Bamvor Jian Zhang bamv2...@gmail.com Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/node_device/node_device_hal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_device/node_device_hal.c b/src/node_device/node_device_hal.c index 4a430dc..63245a9

[libvirt] [PATCH V2] implement managedsave in libvirt xen legacy driver

to add this flags in xen. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- Changes since v1: (1), add save dir in libvirt.spec.in and src/Makefile.am (2), misc changes for return value and memory leak. i have test the following case for this patch: 1), virsh managedsave save domain to /var

[libvirt] [PATCH] implement managedsave in libvirt xen legacy driver

Implement the domainManagedSave, domainHasManagedSaveImage, and domainManagedSaveRemove functions in the libvirt legacy xen driver. domainHasManagedSaveImage check the managedsave image from filesystem everytime. This is different from qemu and libxl driver. In qemu or libxl driver, there is a

Re: [libvirt] [PATCH 2/2] Add lock in libxl api

Jim Fehlig jfeh...@suse.com wrote: Bamvor Jian Zhang wrote: Add long-running jobs for save, dump. Add normal job for the api maybe modify the domain. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_driver.c | 219

Re: [libvirt] [PATCH 1/2] Introduce a lock for libxl long-running api

Hi, Jim thanks your reply. i have update my patch and resend to the list. besides, there are two comments from you not modify in my v2 patch. see my comments below. Jim Fehlig jfeh...@suse.com wrote: Bamvor Jian Zhang wrote: This patch introduce a lock for protecting the long-running

[libvirt] [PATCH 2/2] Add lock for libxl api

Add long-running jobs for save, dump. Add normal job for the api maybe modify the domain. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_driver.c | 219 ++- 1 file changed, 158 insertions(+), 61 deletions(-) diff --git a/src

[libvirt] [PATCH 0/2] Add lock in libxl

the cancellation of user. Update compare to v1: 1, remove migration relative job functions from lock patch. 2, update comments according to upstream's comments. Bamvor Jian Zhang (2): Introduce a lock for libxl long-running api Add lock for libxl api src/libxl/libxl_conf.h | 56 + src/libxl

[libvirt] [PATCH 1/2] Introduce a lock for libxl long-running api

This patch introduce a lock for protecting the long-running api (save, dump, migration and so on) from the other api which may update the status of the virtual machine. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_conf.h | 56 +++ src/libxl/libxl_driver.c | 419

[libvirt] [PATCH 2/2] Add lock in libxl api

Add long-running jobs for save, dump. Add normal job for the api maybe modify the domain. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_driver.c | 219 ++- 1 file changed, 158 insertions(+), 61 deletions(-) diff --git a/src

[libvirt] [PATCH 0/2] Add lock in libxl

the cancellation of user. Bamvor Jian Zhang (2): Introduce a lock for libxl long-running api Add lock for libxl api src/libxl/libxl_conf.h | 58 + src/libxl/libxl_driver.c | 665 ++- 2 files changed, 662 insertions(+), 61 deletions(-) -- 1.7.12

[libvirt] [PATCH 1/2] Introduce a lock for libxl long-running api

This patch introduce a lock for protecting the long-running api (save, dump, migration and so on) from the other api which may update the status of the virtual machine. Signed-off-by: Bamvor Jian Zhang bjzh...@suse.com --- src/libxl/libxl_conf.h | 58 ++ src/libxl/libxl_driver.c | 446