On 05/13/2015 10:30 PM, Laine Stump wrote:
On 05/13/2015 05:57 AM, Daniel P. Berrange wrote:
On Wed, May 13, 2015 at 11:36:30AM +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration
On 05/13/2015 04:17 PM, Peter Krempa wrote:
On Wed, May 13, 2015 at 11:36:29 +0800, Chen Fan wrote:
currently, we only support PCI host devices with ephemeral flag.
and USB already supports migration. so maybe in the near future we
can support SCSI.
Signed-off-by: Chen Fan chen.fan.f
On 05/13/2015 04:36 PM, Peter Krempa wrote:
On Wed, May 13, 2015 at 11:36:30 +0800, Chen Fan wrote:
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan chen.fan.f
the ephemeral flag helps support migration with PCI-passthrough.
An ephemeral hostdev is automatically unplugged before migration
and replugged (if one is available on the destination) after
migration.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
docs/schemas/domaincommon.rng
add migration support for ephemeral host devices, introduce
two 'detach' and 'restore' functions to unplug/plug host devices
during migration.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_migration.c | 171 --
src/qemu
) unplug the ephemeral devices before migration
2) do native migration
3) when migration finished, hotplug the ephemeral devices
TODO:
keep network connectivity on guest level by bonding device.
Chen Fan (6):
conf: add ephemeral element for hostdev supporting migration
qemu: Save ephemeral
we should save the XML information to image head before we
hotunplug the ephemeral devices. so here we handle XML
ahead.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 40
1 file changed, 20 insertions(+), 20 deletions
currently, we only support PCI host devices with ephemeral flag.
and USB already supports migration. so maybe in the near future we
can support SCSI.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_command.c | 10 ++
src/qemu/qemu_migration.c | 11 +++
2
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 8
src/qemu/qemu_process.c | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 86d93d2..112acb1 100644
--- a/src/qemu/qemu_driver.c
after migration we should restore the ephemeral devices.
so we save them to qemuDomainObjPrivate.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_domain.c | 5 +
src/qemu/qemu_domain.h | 3 +++
2 files changed, 8 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src
On 04/20/2015 06:29 AM, Laine Stump wrote:
On 04/17/2015 04:53 AM, Chen Fan wrote:
backgrond:
Live migration is one of the most important features of virtualization
technology.
With regard to recent virtualization techniques, performance of network I/O is
critical.
Current network I/O
, Laine Stump wrote:
On 04/17/2015 04:53 AM, Chen Fan wrote:
backgrond:
Live migration is one of the most important features of virtualization
technology.
With regard to recent virtualization techniques, performance of network I/O is
critical.
Current network I/O virtualization (e.g. Para
For bond device, we can support the migrate, we can simple
to hot remove the device from source side, and after migration
end, we hot add the new device at destination side.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_driver.c| 57
Add a corresponding command to guest-network-set-interface.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
qga/commands-posix.c | 51 +++
qga/commands-win32.c | 6 ++
qga/qapi-schema.json | 11 +++
3 files changed, 68
consider bonding driver to support add interfaces dynamically.
This is an example on how this might work, so I want to hear some voices about
this scenario.
Thanks,
Chen
Chen Fan (7):
qemu-agent: add agent init callback when detecting guest setup
qemu: add guest init event callback to do
. the active-backup mode can be used for an
automatic switch. so this patch is adding a guest-network-set-interface
command for creating bond device. so the management can easy to create
a bond device dynamically when guest running.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
configure
sometimes, we want to do some initialize work in guest when guest startup,
but currently, qemu-agent doesn't support that. so here we add an init
callback, when guest startup, notify libvirt it has been up, then
libvirt can do some work for guest.
Signed-off-by: Chen Fan chen.fan.f
the patches is for libvirt to support migration with passthrough
device using existing feacture.
Chen Fan (3):
qemu-agent: add guest-network-set-interface command
qemu-agent: add guest-network-delete-interface command
qemu-agent: add notify for qemu-ga boot
configure| 16
='0.0.0.0' gateway='192.168.122.1'/
interface address='52:54:00:e8:c0:f3'/
interface address='44:33:4c:06:f5:8e'/
/bond
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
docs/schemas/domaincommon.rng | 21 +++
src/conf/domain_conf.c| 87
we add a migrate status for hostdev to specify the device don't
need to initialze when VM startup, after migration end, we add
the migrate status hostdev, so can support hostdev migration.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/domain_conf.c| 3 ++
src/conf
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_domain.h | 7 +++
src/qemu/qemu_driver.c | 32
src/qemu/qemu_process.c | 22 ++
3 files changed, 61 insertions(+)
diff --git a/src/qemu/qemu_domain.h b/src/qemu
this 'bond' element is to create bond device when guest startup,
the xml like:
hostdev mode='subsystem' type='pci' managed='yes'
driver name='vfio' type='bond'/
bond
interface address='XXX'/
interface address='XXX1'/
/bond
/hostdev
Signed-off-by: Chen Fan chen.fan.f
via initialize callback to create bond device.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_agent.c | 118
src/qemu/qemu_agent.h | 10
src/qemu/qemu_domain.c | 70
src/qemu
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
qga/main.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/qga/main.c b/qga/main.c
index 9939a2b..f011ce0 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -1170,6 +1170,19 @@ int main(int argc, char **argv)
g_critical
because network address is required by route, so
here we should add one avoid user misunderstand.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
docs/formatdomain.html.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs
via - gateway
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
docs/formatdomain.html.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 82aa14f..3b3d2d9 100644
--- a/docs/formatdomain.html.in
+++ b
Chen Fan (2):
docs: no 'via' attribute in route element
docs: route element must specify network address
docs/formatdomain.html.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
--
1.9.3
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman
: qemuAgentGetFSInfo (qemu_agent.c:1837)
==10670==by 0x1A03CF91: qemuDomainGetFSInfo (qemu_driver.c:19238)
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt-domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 04545fd..7f8a7ce 100644
On 03/10/2015 05:32 PM, Ján Tomko wrote:
On Tue, Mar 10, 2015 at 01:56:11PM +0800, Chen Fan wrote:
in virDomainFSInfoFree(), don't free the virDomainFSInfo data.
==10670== 80 bytes in 2 blocks are definitely lost in loss record 576 of 793
==10670==at 0x4A06BC3: calloc (vg_replace_malloc.c
this patch fix some weird typos:
1. hostdev = hostdev
2. type= type
3. virtualport = virtualport
4. redundant comma
5. missing right-half bracket
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
docs/formatnetwork.html.in | 10 +-
1 file changed, 5
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 9364eb5..6a15074 100644
--- a/docs/formatdomain.html.in
+++ b/docs
introduce by commit c63ef0452b, when nodeset is NULL, validation
will pass in virNumaSetupMemoryPolicy, but virBitmapNextSetBit
must ensure bitmap is not Null. there will cause a segmentation
fault. this patch fixed it.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virnuma.c
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote:
On Thu, Oct 30, 2014 at 01:44:17PM +0800, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt_private.syms | 1 +
src/util/virbitmap.c | 45 +
src
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote:
On Thu, Oct 30, 2014 at 01:44:18PM +0800, Chen Fan wrote:
There was no check for 'nodeset' attribute in numatune-related
elements. This patch adds validation that any nodeset specified does
not exceed maximum host node.
Signed
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote:
On Thu, Oct 30, 2014 at 01:44:19PM +0800, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virnuma.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote:
On Thu, Oct 30, 2014 at 01:44:16PM +0800, Chen Fan wrote:
when setting elements memnode and nodeset in attribute numatune more
than the host nodes in XML file, VM boot should fail. so add check for
that.
You should run make
There was no check for 'nodeset' attribute in numatune-related
elements. This patch adds validation that any nodeset specified does
not exceed maximum host node.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/numatune_conf.c | 28
when setting elements memnode and nodeset in attribute numatune more
than the host nodes in XML file, VM boot should fail. so add check for
that.
Chen Fan (3):
bitmap: add virBitmapLastSetBit for finding the last bit position of
bitmap
numatune: add check for numatune nodeset range
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt_private.syms | 1 +
src/util/virbitmap.c | 45 +
src/util/virbitmap.h | 3 +++
tests/virbitmaptest.c| 13 -
4 files changed, 61 insertions(+), 1 deletion
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virnuma.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/util/virnuma.c b/src/util/virnuma.c
index 2540bd2..89435de 100644
--- a/src/util/virnuma.c
+++ b/src/util/virnuma.c
@@ -98,16 +98,13
On Thu, 2014-10-30 at 07:55 +0100, Martin Kletzander wrote:
On Thu, Oct 30, 2014 at 02:23:00AM +, Chen, Fan wrote:
On Wed, 2014-10-29 at 14:20 +0100, Martin Kletzander wrote:
On Wed, Oct 29, 2014 at 08:33:32PM +0800, Chen Fan wrote:
diff --git a/src/util/virnuma.c b/src/util/virnuma.c
On Wed, 2014-10-29 at 08:00 +0100, Martin Kletzander wrote:
On Tue, Oct 28, 2014 at 04:22:22PM +0800, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lxc
On Wed, 2014-10-29 at 07:58 +0100, Martin Kletzander wrote:
On Tue, Oct 28, 2014 at 04:22:21PM +0800, Chen Fan wrote:
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index 1861dd6..a23dff7 100644
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
@@ -689,6 +689,7
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss. there probably was qemu's
bug too.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virnuma.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/src/util/virnuma.c b/src/util/virnuma.c
index fbe8fd1..5a08049 100644
--- a/src/util/virnuma.c
+++ b/src/util/virnuma.c
@@ -95,31 +95,16
On Wed, 2014-10-29 at 14:23 +0100, Martin Kletzander wrote:
On Wed, Oct 29, 2014 at 08:33:34PM +0800, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virnuma.c | 15 ---
1 file changed, 15 deletions(-)
I think this harmless check may
On Wed, 2014-10-29 at 14:20 +0100, Martin Kletzander wrote:
On Wed, Oct 29, 2014 at 08:33:32PM +0800, Chen Fan wrote:
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started
when setting elements memnode and nodeset in attribute numatune more
than the host nodes in XML file, VM boot should fail. so add check for
that.
Chen Fan (3):
bitmap: add virBitmapLastSetBit for finding the last bit position of
bitmap
numatune: add check for numatune nodeset range
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt_private.syms | 1 +
src/util/virbitmap.c | 45 +
src/util/virbitmap.h | 3 +++
tests/virbitmaptest.c| 13 -
4 files changed, 61 insertions(+), 1 deletion
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virnuma.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/src/util/virnuma.c b/src/util/virnuma.c
index 4188ef5..613a43c 100644
--- a/src/util/virnuma.c
+++ b/src/util/virnuma.c
There was no check for 'nodeset' attribute in numatune-related
elements. This patch adds validation that any nodeset specified does
not exceed maximum host node.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/numatune_conf.c | 28
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss. there probably was qemu's
bug too.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf
when setting elements memnode and nodeset in attribute numatune more
than the host nodes in XML file, VM boot should fail. so add check for
that.
Chen Fan (3):
numatune: add check for numatune nodeset range
lxc controller: add check for numatune
virnuma: remove redundant check for numanode
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virnuma.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/src/util/virnuma.c b/src/util/virnuma.c
index 411719d..8431b3c 100644
--- a/src/util/virnuma.c
+++ b/src/util/virnuma.c
@@ -95,31 +95,16
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/lxc/lxc_controller.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index 1861dd6..1ee89ab 100644
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virsocketaddr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index a19e3af..8c9f05f 100644
--- a/src/util/virsocketaddr.c
+++ b/src/util/virsocketaddr.c
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virsocketaddr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index a19e3af..8c9f05f 100644
--- a/src/util/virsocketaddr.c
+++ b/src/util/virsocketaddr.c
On Wed, 2014-10-15 at 04:46 -0400, John Ferlan wrote:
This patch has triggered a Coverity RESOURCE_LEAK (3 actually)
Right, I will make a patch to fix it.
Thank you for catching that.
On 10/08/2014 09:54 PM, Chen, Fan wrote:
On Wed, 2014-10-08 at 12:33 +0200, Ján Tomko wrote:
On 10/07
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/util/virsocketaddr.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index 8c9f05f..5f54e68 100644
--- a/src/util/virsocketaddr.c
+++ b/src/util
On Fri, 2014-10-10 at 13:58 +0800, Wang Rui wrote:
Ping?
I found some wrong indentation in the 3 patches.
like following in patch 1/3:
+static int virLXCCgroupSetupCpusetTuneForEmulator(virDomainDefPtr def,
+ virCgroupPtr cgroup,
+
On Thu, 2014-10-09 at 14:54 +0200, Ján Tomko wrote:
On 10/07/2014 06:07 AM, Chen Fan wrote:
add some check in migration configuration.
Chen Fan (3):
migration: add migration_host support for Ipv6 address without
brackets
conf: add check if migration_host is a localhost
On Wed, 2014-10-08 at 12:33 +0200, Ján Tomko wrote:
On 10/07/2014 06:07 AM, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_conf.c | 50
src/qemu
On Tue, 2014-10-07 at 11:08 +0200, Ján Tomko wrote:
On 10/07/2014 06:07 AM, Chen Fan wrote:
if specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
tcp:[2001
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_conf.c | 50
src/qemu/qemu_conf.h | 2 ++
src/util/virsocketaddr.c | 24 +++
src/util/virsocketaddr.h | 2 ++
5
if specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
tcp:[2001:0DB8::1428]:
so we should add brackets when parsing it.
Signed-off-by: Chen Fan chen.fan.f
add some check in migration configuration.
Chen Fan (3):
migration: add migration_host support for Ipv6 address without
brackets
conf: add check if migration_host is a localhost address
conf: Check migration_address whether is localhost
src/libvirt_private.syms | 3 +-
src
When enabling the migration_address option, by default it is
set to 127.0.0.1, but it's not a valid address for migration.
so we should add verification and set the default migration_address
to 0.0.0.0.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu.conf
On Fri, 2014-10-03 at 15:58 +0200, Ján Tomko wrote:
On 09/23/2014 06:04 AM, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_conf.c | 8
src/util/virsocketaddr.c | 35
On Fri, 2014-10-03 at 15:58 +0200, Ján Tomko wrote:
On 09/23/2014 06:04 AM, Chen Fan wrote:
if specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
tcp:[2001
any feedback?
Thanks,
Chen
On Thu, 2014-09-25 at 01:10 +, Chen, Fan wrote:
ping?
On Tue, 2014-09-23 at 12:04 +0800, Chen Fan wrote:
add some check in migration configuration.
Chen Fan (4):
virsocketaddr: return address family in virSocketAddrIsNumeric
migration: add
ping?
On Tue, 2014-09-23 at 12:04 +0800, Chen Fan wrote:
add some check in migration configuration.
Chen Fan (4):
virsocketaddr: return address family in virSocketAddrIsNumeric
migration: add migration_host support for Ipv6 address without
brackets
conf: add
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss. there probably was qemu's
bug too.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf
use virDomainNumatuneNodeSetIsAvailable() to verify momory.nodeset
whether is out of range. and move up the verification.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/numatune_conf.c | 3 +++
src/util/virnuma.c | 15 ---
2 files changed, 3 insertions
for memnode.nodeset in numatune, when setting it more
than the host nodes, it should fail.
Chen Fan (2):
numatune: add check for memnode.nodeset range
numatune: move up verification codes in virNumaSetupMemoryPolicy
src/conf/numatune_conf.c | 32
src/conf
On Tue, 2014-09-23 at 14:41 +0200, Michal Privoznik wrote:
On 23.09.2014 11:34, Chen Fan wrote:
For memnode in numatune element, the range of attribute 'nodeset'
was not validated. on my host maxnodes was 1, but when setting nodeset
to '0-2' or more, guest also started succuss
On Tue, 2014-09-23 at 14:42 +0200, Michal Privoznik wrote:
On 23.09.2014 11:34, Chen Fan wrote:
use virDomainNumatuneNodeSetIsAvailable() to verify momory.nodeset
whether is out of range. and move up the verification.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src
On Mon, 2014-09-22 at 15:34 +0200, Ján Tomko wrote:
On 09/12/2014 06:33 AM, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_conf.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/cpu_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 6c454ee..116aa58 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -413,7 +413,7
On Mon, 2014-09-22 at 15:34 +0200, Ján Tomko wrote:
On 09/12/2014 06:31 AM, Chen Fan wrote:
when specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
tcp:[2001
if specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
tcp:[2001:0DB8::1428]:
so we should add brackets when parsing it.
Signed-off-by: Chen Fan chen.fan.f
nowadays, virSocketAddrIsNumeric only validated the income address
if numeric, but sometimes we need to know whether the address is
an IPv4 or an IPv6 address.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_migration.c | 4 ++--
src/util/virsocketaddr.c | 13
When enabling the migration_address option, by default it is
set to 127.0.0.1, but it's not a valid address for migration.
so we should add verification and set the default migration_address
to 0.0.0.0.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu.conf
add some check in migration configuration.
Chen Fan (4):
virsocketaddr: return address family in virSocketAddrIsNumeric
migration: add migration_host support for Ipv6 address without
brackets
conf: add virSocketAddrIsLocalhost to Check migration_host
conf: Check migration_address
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_conf.c | 8
src/util/virsocketaddr.c | 35 +++
src/util/virsocketaddr.h | 3 +++
4 files changed, 47 insertions(+)
diff --git a/src
Hi jiri,
Please help to review this patches.
Thanks,
Chen
On Fri, 2014-09-12 at 12:32 +0800, Chen Fan wrote:
This version differs from the patch set
conf: Check migration_host is valid or not during libvirt restarts
I posted 2 weeks ago, I droped checking the migration_host on target
when specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
tcp:[2001:0DB8::1428]:
so we should add brackets when parsing it.
Signed-off-by: Chen Fan chen.fan.f
This version differs from the patch set
conf: Check migration_host is valid or not during libvirt restarts
I posted 2 weeks ago, I droped checking the migration_host on target
host. and find an issue when setting migration_host.
Chen Fan (3):
migration: add migration_host support for Ipv6
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_conf.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index ac10b64..013f3de 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -707,6 +707,17 @@ int
When enabling the migration_address option, by default it is
set to 127.0.0.1, but it's not a valid address for migration.
so we should add verification and set the default migration_address
to 0.0.0.0.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu.conf
if user specified an invalid strings as migration hostname,
like setting: migration_host = XXX, libvirt should check
it and return error during lbivirt restart.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_conf.c | 40
1 file
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/storage/storage_driver.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 3604613..5ddc23a 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage
domain XML like:
...
cpu
numa
cell cpus='0-1' memdev='ram0'/
/numa
/cpu
...
devices
memdev type='ram' merge='yes' dump='yes' prealloc='yes'
nameram0/name
capacity unit='MiB'1000/capacity
source host-nodes='0-1' policy='bind' /
/memdev
/devices
Chen Fan
Since qemu has supported '-numa memdev=ram0' command option, so libvirt
should add numa element to support specified memdev attrubute in XML.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/cpu_conf.c | 73 +++--
src/conf
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
docs/formatdomain.html.in | 71 +++-
docs/schemas/domaincommon.rng | 76 +-
tests/qemuxml2argvdata/qemuxml2argv-cpu-numa3.args | 9 +++
tests
='MiB'1000/capacity
source host-nodes='0-1' policy='bind' /
/memdev
then we enable to support -numa memdev=ram0 command line for binding guest
numa nodes to host numa nodes.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/domain_conf.c | 203
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 02c394f..b7aa4f5 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -4261,7
the 'migration_host' description maybe have a bit of difficulty to
understand for user, so add this manual for them.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
tools/virsh.pod | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools
the 'migration_host' description maybe have a bit of difficulty to
understand for user, so add this manual for them.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
tools/virsh.pod | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tools/virsh.pod b/tools
option on dest host to save the
default value set which can be specified to a migration hostname or
one of this host's addresses used for transferring data, thus user doesn't
boring to specify it in command line everytime.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
v4-v5: using
1 - 100 of 138 matches
Mail list logo
