generated when no method is available to expand cpu featues.
The useQEMU option will be introduced in a future patch for using QEMU
to compute baseline rather than using libvirt.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 19 +++
1 file changed, 15 insertions
QEMU)
in a later patch.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 97 ++
1 file changed, 97 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e9f5686dbe..5068805f51 100644
--- a/src/qemu/qemu_driver.c
+++ b
x86.
After this change,
immediately default prop->migratable = _YES for all props
when we know QEMU only included migratable props in CPU Model.
Set model->migratability = true when we have set prop->migratable.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_
virQEMUCapsCPUModelInfoToCPUDef
function.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 52
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 53 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 2bb56763b0
qemuProcessQMPStop is one of the 4 public functions used to create and
manage a Qemu process for QMP command exchanges.
Add comment header and debug message.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/qemu
The monitor config data is removed from the qemuProcessQMP struct.
The monitor config data can be initialized immediately before call to
qemuMonitorOpen and does not need to be maintained after the call
because qemuMonitorOpen copies any strings it needs.
Signed-off-by: Chris Venteicher
n reason for the static functions.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 4 +-
src/qemu/qemu_process.c | 93 +++-
src/qemu/qemu_process.h | 2 +-
3 files changed, 94 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_
: Chris Venteicher
---
src/qemu/qemu_process.c | 29 -
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 91532c19ce..58842a0f1c 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -8220,6
qemuMonitorSetCapabilities to send the
message to switch to command mode because the test code does not use the
qemuProcessQMP command that internally calls qemuMonitorSetCapabilities.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 12
src/qemu/qemu_process.c | 8
eanup" rather than "error".
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 44 +
1 file changed, 23 insertions(+), 21 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index dc2237f0e6..430136251d 1
model in
architectures where QEMU is used for baseline so no attempt is made to
ask for non-migratable features in expansions when using QEMU for
baseline.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 25 +
src/qemu/qemu_monitor.c | 30
into a utility function
wrapper.
s/cpu/*baseline/ (change output variable name ) and
initialize variable "rc" are the only code changes.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 78 --
1 file changed, 52 insertions(+), 26
Move existing code to convert between cpu model info structures
(qemuMonitorCPUModelInfoPtr into virCPUDef)
into a reusable function.
The new function is used in this and future patches.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 88
tions and making the inputs and outputs clearer.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 130 ---
1 file changed, 91 insertions(+), 39 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 02911
de is updated to make all
errors fatal for consistency.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 14 ++
src/qemu/qemu_process.c | 15 +++
2 files changed, 5 insertions(+), 24 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src
Use a helper function to allocate and initializes CPU Model Info structs.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 8
src/qemu/qemu_monitor.c | 27 ++-
src/qemu/qemu_monitor.h | 2 ++
src/qemu/qemu_monitor_json.c | 5
Store libDir path in the qemuProcessQMP struct in anticipation of moving
path construction code into qemuProcessQMPInit function.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 8 +---
src/qemu/qemu_process.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git
A Full CPUModelInfo structure with props is sent to QEMU for expansion.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 8 +---
src/qemu/qemu_monitor.c | 20 +++-
src/qemu/qemu_monitor.h | 5 +++--
src/qemu/qemu_monitor_json.c | 12
o the capabilities usecase and are
more generic in terms of being used for any general purpose QMP message
exchanges with a QEMU process that is not associated with a domain.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 25 +++--
src/qemu/qemu_process.h | 1
Catch execution paths where qemuProcessQMPFree is called before
qemuProcessQMPStop then report error and force stop before proceeding.
Also added public function header and debug message.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 17 -
1 file changed, 16
igned-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 48 -
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 3b785d64e5..5492ff5a19 100644
--- a/src/qemu/qemu_process.c
+++ b/src
process
to issue multiple different QMP commands.
This patch changes the variable naming from cmd to proc to put focus
on the process being maintained to issue commands.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 18 ++---
src/qemu/qemu_process.c | 140
emuMonitorJSONGetCPUModelExpansion makes full use of conversions and
propAdd in prep to support input of full cpu model in future.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_monitor.c | 25 ++
src/qemu/qemu_monitor.h | 5 ++
src/qemu/qemu_monitor_json.c | 152 +
virQEMUCapsInitQmp where we can
detect that the -first- (not subsequent) QEMU process activation failed
with nonzero status.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 73 ++--
src/qemu/qemu_process.c | 9 +++--
src/qemu/qemu_process.h | 1 +
3
using qemu qmp command (future)
Future patches are easier to follow if the code for using libvirt is
consolidated.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_driver.c b
.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_process.c | 6 +++---
src/qemu/qemu_process.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index e062e4daa8
Introduce monitor functions to use QEMU to compute baseline cpu
from an input of two cpu models.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 6
src/qemu/qemu_monitor_json.c | 60
src
processes in terms of sockets and
file system footprint.
The remaining (non-process) patches in v4 address all issues in v1-v4 of
'BaselineHypervisorCPU using QEMU QMP exchanges'
Thanks,
Chris
*** BLURB HERE ***
Chris Venteicher (33):
qEmu_process: Move process code from qemu
x27;t use KVM) will be passed when the
qemuProcessQMP struct is initialized since the qemuProcessQMP struct
won't be reused.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 19 +++
src/qemu/qemu_process.c | 9 +
src/qemu/qemu_process.h
. **
Then, subsequent patches modify the process code
to make function prefixes and variable names match qemu_process,
and make the code usable for more than the capabilities usecase.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 218 +--
src/qemu
.)
The stderr buffer no longer needs to be maintained outside of the
qemuProcessQMP structure because the structure is used for a single QEMU
process and the structures can be maintained as long as required
to retrieve the process error info.
Signed-off-by: Chris Venteicher
---
src/qemu
freed.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 1 +
src/qemu/qemu_process.c | 22 +++---
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 2bacd5e40a..73380fdc2b 100644
Add the const qualifier on non modified strings
(string only copied inside qemuProcessQMPNew)
so that const strings can be used directly in calls to
qemuProcessQMPNew in future patches.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 2 +-
src/qemu/qemu_process.h | 2 +-
2 files
s/virQEMUCapsInitQMPCommand/qemuProcessQMP/
No functionality change.
Use file appropriate prefix in moved code.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 14 +++---
src/qemu/qemu_process.c | 28 ++--
src/qemu/qemu_process.h
Quoting Jiri Denemark (2019-01-03 08:54:21)
> On Sun, Dec 02, 2018 at 23:10:14 -0600, Chris Venteicher wrote:
> > qemuProcessQmpStart starts a QEMU process and monitor connection that
> > can be used by multiple functions possibly for multiple QMP commands.
> >
> &g
Quoting Jiri Denemark (2019-01-03 08:18:15)
> On Sun, Dec 02, 2018 at 23:10:04 -0600, Chris Venteicher wrote:
> > Move a step closer to the function structure used elsewhere in
> > qemu_process where qemuProcessStart and qemuProcessStop are the exposed
> > functions.
> &g
model in
architectures where QEMU is used for baseline so no attempt is made to
ask for non-migratable features in expansions when using QEMU for
baseline.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src
QEMU)
in a later patch.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 97 ++
1 file changed, 97 insertions(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 4e8a3902d3..8c6838f584 100644
--- a/src/qemu/qemu_driver.c
+++ b
generated when no method is available to expand cpu featues.
The useQEMU option will be introduced in a future patch for using QEMU
to compute baseline rather than using libvirt.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 19 +++
1 file changed, 15 insertions
of true/false CPUModelInfo props
A utility function is created to squash CPU properties list in
qemuMonitorCPUmodelInfo structure by removing boolean properties
of matching value.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 4
src/qemu/qemu_monitor.c | 30
x86.
After this change,
immediately default prop->migratable = _YES for all props
when we know QEMU only included migratable props in CPU Model.
Set model->migratability = true when we have set prop->migratable.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_
using qemu qmp command (future)
Future patches are easier to follow if the code for using libvirt is
consolidated.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/src/qemu/qemu_driver.c b
into a utility function
wrapper.
s/cpu/*baseline/ (change output variable name ) and
initialize variable "rc" are the only code changes.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_driver.c | 78 --
1 file changed, 52 insertions(+), 26
Move existing code to convert between cpu model info structures
(qemuMonitorCPUModelInfoPtr into virCPUDef)
into a reusable function.
The new function is used in this and future patches.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 84
virQEMUCapsCPUModelInfoToCPUDef
function.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 46
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 47 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 74f670459f
tions and making the inputs and outputs clearer.
The patch also sets cpuData->info = NULL to make sure bad data does not
remain in failure cases.
Q) Can the right people quickly determine if they should review this?
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities
A Full CPUModelInfo structure with props is sent to QEMU for expansion.
virQEMUCapsProbeQMPHostCPU migratability logic partitioned into new function
for clarity.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 8 +---
src/qemu/qemu_monitor.c | 31
emuMonitorJSONGetCPUModelExpansion makes full use of conversions and
propAdd in prep to support input of full cpu model in future.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_monitor.c | 24 ++
src/qemu/qemu_monitor.h | 5 ++
src/qemu/qemu_monitor_json.c | 154 +
Introduce monitor functions to use QEMU to compute baseline cpu
from an input of two cpu models.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 6
src/qemu/qemu_monitor_json.c | 60
src
: Chris Venteicher
---
src/qemu/qemu_process.c | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 31d41688fe..faf86dac5d 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
qemuProcessQmpStop is one of the 4 public functions used to create and
manage a Qemu process for QMP command exchanges.
Add comment header and debug message.
Other minor code formatting cleanup.
No change in functionality is intended.
Signed-off-by: Chris Venteicher
---
src/qemu
Qemu process code for capababilities doesn't use monitor callbacks and
defines empty callback functions.
Allow NULL to be passed to qemuMonitorOpen for callbacks and remove the
empty functions from the QMP process code.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_monitor.c | 4 ++--
Catch execution paths where qemuProcessQmpFree is called before
qemuProcessQmpStop then report error and force stop before proceeding.
Also added public function header and debug message.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 17 -
1 file changed, 16
qemuMonitorSetCapabilities to send the
message to switch to command mode because the test code does not use the
qemuProcessQmp command that internally calls qemuMonitorSetCapabilities.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 12
src/qemu/qemu_process.c | 8
Use a helper function to allocate and initializes CPU Model Info structs.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_monitor.c | 32 +++-
src/qemu/qemu_monitor.h | 2 ++
3 files changed, 30 insertions(+), 6
o the capabilities usecase and are
more generic in terms of being used for any general purpose QMP message
exchanges with a QEMU process that is not associated with a domain.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 24 ++--
src/qemu/qemu_process.h | 1
h the qemuConnectMonitor code used to establish the
monitor when QEMU process is started for domains.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 26ba59143d..b491f9f91a 100644
--- a/src
will be removed in future patch so we prep for passing
NULL for the callback pointer.
Set proc->mon to NULL then use VIR_STEAL_PTR if successful to be
consistent with other functions.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 29 +++--
1 file chan
Store libDir path in the qemuProcessQmp struct in anticipation of moving
path construction code into qemuProcessQmpInit function.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 8 +---
src/qemu/qemu_process.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git
igned-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 50 -
1 file changed, 24 insertions(+), 26 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 938d328235..a688be7f2c 100644
--- a/src/qemu/qemu_process.c
+++ b/src
The monitor config data is removed from the qemuProcessQmp struct.
The monitor config data can be initialized immediately before call to
qemuMonitorOpen and does not need to be maintained after the call
because qemuMonitorOpen copies any strings it needs.
Signed-off-by: Chris Venteicher
freed.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 1 +
src/qemu/qemu_process.c | 19 ---
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index d903fbddf8..a79329a134 100644
---
n reason for the static functions.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 4 +-
src/qemu/qemu_process.c | 94 +++-
src/qemu/qemu_process.h | 2 +-
3 files changed, 95 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_
ockets and
file system footprint.
The BaselineHypervisorCPU changes (patches 22-36)...
- Fix all issues raised in patch sets 1-4.
Thanks,
Chris
Chris Venteicher (36):
qemu_process: Move process code from qemu_capabilities to qemu_process
qemu_process: Use qemuProcessQmp prefix
qemu_proc
eanup" rather than "error".
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 46 +
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index d4025ac1bc..fc15cb1a3c 1
query.)
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 83
src/qemu/qemu_process.c | 24 ---
src/qemu/qemu_process.h | 1 +
3 files changed, 45 insertions(+), 63 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src
.)
The stderr buffer no longer needs to be maintained outside of the
qemuProcessQmp structure because the structure is used for a single QEMU
process and the structures can be maintained as long as required
to retrieve the process error info.
Signed-off-by: Chris Venteicher
---
src/qemu
s/virQEMUCapsInitQMPCommand/qemuProcessQmp/
No functionality change.
Use file appropriate prefix in moved code.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 14 +++---
src/qemu/qemu_process.c | 28 ++--
src/qemu/qemu_process.h
x27;t use KVM) will be passed when the
qemuProcessQmp struct is initialized since the qemuProcessQmp struct
won't be reused.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 20
src/qemu/qemu_process.c | 10 ++
src/qemu/qemu_process.h
process
to issue multiple different QMP commands.
This patch changes the variable naming from cmd to proc to put focus
on the process being maintained to issue commands.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 18 ++---
src/qemu/qemu_process.c | 138
. **
(Exception: I did change a function prototype in qemu_process.h to be one
parameter per line.)
Then, subsequent patches modify the process code
to make function prefixes and variable names match qemu_process,
and make the code usable for more than the capabilities usecase.
Signed-off-by: Chris
.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_process.c | 6 +++---
src/qemu/qemu_process.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 41a0dfa844
Add the const qualifier on non modified strings
(string only copied inside qemuProcessQmpNew)
so that const strings can be used directly in calls to
qemuProcessQmpNew in future patches.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 2 +-
src/qemu/qemu_process.h | 2 +-
2 files
Quoting Michal Privoznik (2018-11-14 09:45:06)
> On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> > Make process code usable outside qemu_capabilities by moving code
> > from qemu_capabilities to qemu_process and exposing public functions.
> >
> > The process cod
Quoting Michal Privoznik (2018-11-14 09:45:07)
> On 11/11/2018 08:59 PM, Chris Venteicher wrote:
> > Move a step closer to the function structure used elsewhere in
> > qemu_process where qemuProcessStart and qemuProcessStop are the exposed
> > functions.
> >
>
Quoting Collin Walling (2018-11-09 10:44:41)
> Hi Chris,
>
> On 11/9/18 11:27 AM, Chris Venteicher wrote:
> > Quoting Chris Venteicher (2018-11-02 22:13:01)
> >> Some architectures (S390) depend on QEMU to compute baseline CPU model and
> >> expand a models featur
qemuMonitorSetCapabilities to send the
message to switch to command mode because the test code does not use the
qemuProcess command that internally calls qemuMonitorSetCapabilities.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 14 --
src/qemu/qemu_process.c | 8
tests
are made.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 55a092ecbb..5ff7d6878c 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu
The monitor config data is removed from the qemuProcess struct.
The monitor config data can be initialized immediately before call to
qemuMonitorOpen and does not need to be maintained after the call
because qemuMonitorOpen copies any strings it needs.
Signed-off-by: Chris Venteicher
---
src
code used to establish the
monitor when QEMU process is started for domains.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 4dbc7038fd..2f9c1701a3 100644
--- a/src
Qemu process code for capababilities doesn't use monitor callbacks and
defines empty callback functions.
Allow NULL to be passed to qemuMonitorOpen for callbacks and remove the
empty functions from the QMP process code.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_monitor.c | 4 ++--
o the capabilities usecase and are
more generic in terms of being used for any general purpose QMP message
exchanges with a QEMU process that is not associated with a domain.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 26 --
src/qemu/qemu_process.h | 1
lized since the qemuProcess struct won't be
reused.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 16
src/qemu/qemu_process.c | 11 +++
src/qemu/qemu_process.h | 6 --
3 files changed, 23 insertions(+), 10 deletions(-)
diff --git
change,
however goto is now "cleanup" rather than "error".
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 42 +
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_proces
Store libDir path in the qemuProcess struct in anticipation of moving
path construction code into qemuProcessInitQmp function.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 8 +---
src/qemu/qemu_process.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a
The same error and log message should be generated, in the same
conditions, after this patch as before.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 27 ---
src/qemu/qemu_process.c | 12
src/qemu/qemu_process.h | 6 --
3 fil
Prevent compile errors due to trying to use a const string as a
non-const input to qemuProcessNew.
No functionality change.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 2 +-
src/qemu/qemu_process.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src
process
to issue multiple different QMP commands.
This patch changes the variable naming from cmd to proc to put focus
on the process being maintained to issue commands.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 14 ++--
src/qemu/qemu_process.c | 140
rms of sockets and
file system footprint.
Every patch should compile independently if applied in sequence.
Chris Venteicher (22):
qemu_process: Move process code from qemu_capabilities to qemu_process
qemu_process: Use qemuProcess prefix
qemu_process: Limit qemuProcessNew to const input st
qemuProcessStopQmp is one of the 4 public functions used to create and
manage a Qemu process for QMP command exchanges.
Add comment header and debug message.
Other minor code formatting cleanup.
No change in functionality is intended.
Signed-off-by: Chris Venteicher
---
src/qemu
Catch execution paths where qemuProcessFree is called before
qemuProcessStopQmp then report error and force stop before proceeding.
Also added public function header and debug message.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 19 ---
1 file changed, 16
will be removed in future patch so we prep for passing
NULL for the callback pointer.
Set proc->mon to NULL then use VIR_STEAL_PTR if successful to be
consistent with other functions.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_process.c | 27 +--
1 file changed,
until the process data structure is freed.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 73ec8e5c6e..082874082b 100644
--- a/src/qemu/qemu_capabilities.c
+++ b
. Improvements in later patch.
Only intended functional change in this patch is we don't
move (include) code to initiate process stop on failure to create monitor.
As comments in qemuProcessStartQmp say... Client must always call
qemuProcessStop and qemuProcessFree, even in error cases.
Signed-off-by:
subsequent patches will partition code from
qemuProcessLaunchQmp.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 4 +-
src/qemu/qemu_process.c | 96 +++-
src/qemu/qemu_process.h | 2 +-
3 files changed, 97 insertions(+), 5 deletions
is added to the end of qemuProcessStop to differentiate between the
Domain and new non-domain version of the functions. qemuProcessStartQmp
will be used in a future patch to mirror the qemuProcessStart function
with a non-domain equivalent.
Signed-off-by: Chris Venteicher
---
src/qemu
simplifies logic and is more consistent with the operation of existing
qemu_process functions.
A macro is introduced to easily obtain the monitor pointer from the
qemuProcess structure.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 28 ++--
src/qemu
s/virQEMUCapsInitQMPCommand/qemuProcess/
No functionality change.
Use appropriate prefix in moved code.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 14 +++---
src/qemu/qemu_process.c | 28 ++--
src/qemu/qemu_process.h | 22
.
Following patches modify the process code
making it more generic and consistent with qemu_process.
Signed-off-by: Chris Venteicher
---
src/qemu/qemu_capabilities.c | 218 +--
src/qemu/qemu_process.c | 201
src/qemu/qemu_process.h
Quoting Chris Venteicher (2018-11-02 22:13:01)
> Some architectures (S390) depend on QEMU to compute baseline CPU model and
> expand a models feature set.
>
> Interacting with QEMU requires starting the QEMU process and completing one or
> more query-cpu-model-baseline QMP exchang
1 - 100 of 220 matches
Mail list logo