Re: [libvirt PATCH 00/20] qemu: Introduce hvf domain type for Hypervisor.framework

Hey, I tested this on an intel macbook, virsh capabilities shows 'hvf' for the x86_64 qemu binary, I started a f35 guest, -accel hvf is present on the command line, and the VM is a lot faster than without hvf. Feel free to add my Tested-by to the series: Tested-by: Christophe Fergeau Christophe

Re: [libvirt] [PATCH v2 1/2] qemu: Fix "boolen" typo in API doc

Hey, On Wed, Mar 27, 2019 at 01:32:44PM +0100, Ján Tomko wrote: > Please use --cover-letter for series with two or more patches for neater > alignment of e-mails. > > On Wed, Mar 27, 2019 at 12:21:24PM +0100, Christophe Fergeau wrote: > > This also adjusts the argument

[libvirt] [PATCH v2 1/2] qemu: Fix "boolen" typo in API doc

This also adjusts the argument name which should be 'isListen' in both cases rather than 'listen'. Signed-off-by: Christophe Fergeau --- Changes since v1: - really fix 'boolen' typo src/qemu/qemu_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu

[libvirt] [PATCH v2 2/2] doc: Fix 'encryption' documentation

This also matches what virStorageEncryptionParseNode() is doing. Signed-off-by: Christophe Fergeau --- docs/formatdomain.html.in | 2 +- docs/formatstorage.html.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs

Re: [libvirt] [PATCH 1/2] qemu: Fix "boolen" typo in API doc

On Wed, Mar 27, 2019 at 12:13:41PM +0100, Pino Toscano wrote: > On Wednesday, 27 March 2019 12:00:21 CET Christophe Fergeau wrote: > > This also adjusts the argument name which should be 'isListen' in both > > cases rather than 'listen'. > > > > Signed-off-by: Christoph

[libvirt] [PATCH 2/2] doc: Fix 'encryption' documentation

This also matches what virStorageEncryptionParseNode() is doing. Signed-off-by: Christophe Fergeau --- docs/formatdomain.html.in | 2 +- docs/formatstorage.html.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs

[libvirt] [PATCH 1/2] qemu: Fix "boolen" typo in API doc

This also adjusts the argument name which should be 'isListen' in both cases rather than 'listen'. Signed-off-by: Christophe Fergeau --- src/qemu/qemu_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

[libvirt] [libvirt-glib 1/3] config: Fix gvir_config_xml_node_to_string() leak

If xmlNodeDump() fails, we would be leaking the xmlBuffer we created. This commit ensures we don't return early before this buffer is freed. Signed-off-by: Christophe Fergeau --- libvirt-gconfig/libvirt-gconfig-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [libvirt-glib 3/3] events: Mark 'eventlock' as static

It's not used outside of the libvirt-glib-event.c file, so there is no good reason for not having it static. As it was not listed in libvirt-glib.sym, this will make no changes to the publicly exported symbols (ie this is not an ABI change). Signed-off-by: Christophe Fergeau --- libvirt-glib

[libvirt] [libvirt-glib 2/3] object: Fix gvir_connection_create_storage_pool() leak

We need to free the string returned by gvir_config_object_to_xml() after using it. Signed-off-by: Christophe Fergeau --- libvirt-gobject/libvirt-gobject-connection.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt

[libvirt] [libvirt-glib] gconfig: Add gvir_config_storage_vol_target_set_features

Only one feature is supported at the moment, 'lazy refcount' Signed-off-by: Christophe Fergeau --- .../libvirt-gconfig-storage-vol-target.c | 14 ++ .../libvirt-gconfig-storage-vol-target.h | 6 ++ libvirt-gconfig/libvirt-gconfig.sym| 6

Re: [libvirt] [libvirt PATCH] qemu: Add support for specifying SPICE TLS ciphers

On Wed, Apr 04, 2018 at 09:11:25AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 03, 2018 at 08:11:05PM +0200, Jiri Denemark wrote: > > On Tue, Apr 03, 2018 at 17:23:50 +0200, Ján Tomko wrote: > > > From: Christophe Fergeau <cferg...@redhat.com> > > > > >

Re: [libvirt] How to generate better API documentation?

On Mon, Jan 16, 2017 at 09:17:03AM +, Daniel P. Berrange wrote: > > To me the key factor is what the end result looks like, how easy it is to > navigate & find stuff. From that POV doxygen is ruled out as the HTML it > generates is just awful - I despair every time i find a project which has

[libvirt] [libvirt-glib] tests: Don't leak xml data in test-gconfig-device-unknown

--- tests/test-gconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c index 9cf3f12..2c98c25 100644 --- a/tests/test-gconfig.c +++ b/tests/test-gconfig.c @@ -782,6 +782,7 @@ static void test_domain_device_unknown(void)

Re: [libvirt] [PATCH v3] [glib 5/5] gconfig, tests: Add test case for unknown devices

On Thu, Nov 03, 2016 at 02:40:58PM +0100, Zeeshan Ali wrote: > --- > tests/test-gconfig.c| 24 > tests/xml/gconfig-domain-device-unknown.xml | 5 + > 2 files changed, 29 insertions(+) > create mode 100644

Re: [libvirt] [PATCH v2] [glib 5/5] gconfig, tests: Add test case for unknown devices

On Thu, Nov 03, 2016 at 02:05:46PM +0100, Zeeshan Ali wrote: > On Thu, Nov 3, 2016 at 1:03 PM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > On Thu, Nov 03, 2016 at 10:06:22AM +0100, Zeeshan Ali wrote: > >> --- > >> tests/test-g

Re: [libvirt] [PATCH v2] [glib 5/5] gconfig, tests: Add test case for unknown devices

On Thu, Nov 03, 2016 at 10:06:22AM +0100, Zeeshan Ali wrote: > --- > tests/test-gconfig.c| 22 ++ > tests/xml/gconfig-domain-device-unknown.xml | 5 + > 2 files changed, 27 insertions(+) > create mode 100644

Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

On Thu, Nov 03, 2016 at 10:00:56AM +0100, Zeeshan Ali wrote: > Hi Christophe, > > On Wed, Nov 2, 2016 at 6:21 PM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > Hey, > > > > On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: > >> Cur

Re: [libvirt] [glib 3/5] gconfig: Create objects for all domain device nodes

Hey, On Tue, Nov 01, 2016 at 05:46:05PM +0100, Zeeshan Ali wrote: > Currently we can and do get into serious trouble with this kind of code: > > devices = gvir_config_domain_get_devices(domain); > gvir_config_domain_set_devices(domain, domain); > > since the first call above won't return a

Re: [libvirt] [libvirt-glib 03/20] gconfig: Introduce GVirConfigDomainGraphicsListenAddress

hey, On Tue, Oct 04, 2016 at 04:30:14PM +0100, Daniel P. Berrange wrote: > > + > > +/** > > + * gvir_config_domain_graphics_listen_address_get_inet_address: > > + * > > + * Returns the #GInetAddress associated with the > > #GVirConfigDomainGraphicsListenAddress. > > + * > > + * Returns:

[libvirt] [libvirt-glib 15/20] gconfig: Adapt GVirConfigDomainGraphicsVnc to GVirConfigDomainGraphicsRemote

From: Fabiano Fidêncio This patch adapts GVirConfigDomainGraphicsVnc to the new GVirConfigDomainGraphicsRemote, inheriting from it and using its helper functions for getting auport and port properties. As GVirConfigDomainGraphicsVnc now inherits from

[libvirt] [libvirt-glib 20/20] gconfig: Move 'listen' handling to GVirConfigDomainGraphicsRemote

It's only useful in the remote case, and removes duplication between GVirConfigDomainGraphicsSpice and GVirConfigDomainGraphicsVnc. Since the spice/vnc listen API was not in a libvirt-gconfig release, we can remove it without breaking API/ABI. --- .../libvirt-gconfig-domain-graphics-remote.c

[libvirt] [libvirt-glib 11/20] gconfig: Implement gvir_config_domain_graphics_spice_get_tls_port()

From: Fabiano Fidêncio Signed-off-by: Fabiano Fidêncio --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 8 libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 1 + libvirt-gconfig/libvirt-gconfig.sym | 1

[libvirt] [libvirt-glib 19/20] gconfig: Add precondition to gvir_config_object_get_xml_node()

This will catch (among other things) cases when gvir_config_object_get_xml_node() is called with a NULL argument. Not catching this could cause a crash later on in cases when gvir_config_object_new_from_xml() is called and returns NULL, and then we call gvir_config_object_get_attribute() on it.

[libvirt] [libvirt-glib 16/20] gconfig: Add GVirCofigDomainGraphicsLocal class

From: Fabiano Fidêncio Adding this class more fore completness to the GVirConfigDomainGraphicsRemote than for any other reason. This patch introduces a new hierarchy in the project, where, instead of having GVirConfigDomainGraphics{Desktop,Sdl} inheriting from

[libvirt] [libvirt-glib 14/20] gconfig: Adapt GVirConfigDomainGraphicsRdp to GVirConfigDomainGraphicsRemote

From: Fabiano Fidêncio This patch adapts GVirConfigDomainGraphicsRdp to the new GVirConfigDomainGraphicsRemote, inheriting from it and using its helper functions for getting autoport and port properties. As GVirConfigDomainGraphicsRdp now inherits from

[libvirt] [libvirt-glib 17/20] gconfig: Adapt GVirConfigDomainGraphicsSdl to GVirConfigDomainGraphicsLocal

From: Fabiano Fidêncio This patch adapts GVirConfigDomainGraphicsSdl to the new GVirConfigDomainGraphicsLocal, inheriting from it and using its helper functions for getting the display and fullscreen properties. As GVirConfigDomainGraphicsSdl now inherits from

[libvirt] [libvirt-glib 03/20] gconfig: Introduce GVirConfigDomainGraphicsListenAddress

From: Visarion Alexandru This is needed to be able to change the address a graphics device is listening for. --- libvirt-gconfig/Makefile.am| 2 + ...ibvirt-gconfig-domain-graphics-listen-address.c | 131 +

[libvirt] [libvirt-glib 12/20] gconfig: Add GVirConfigDomainGraphicsRemote class

From: Fabiano Fidêncio Seems that GVirConfigDomainGraphics* were built with a strong focus on writing/setting configs, but not reading those. For instance, considering virt-viewer's case, where the app is just consuming an already built xml, for getting the port attribute

[libvirt] [libvirt-glib 01/20] libvirt-gconfig: Include GIO dependency

From: Visarion Alexandru We will need a GInetAddress for setting a graphics device's listen address, so let's include GIO2 in libvirt-gconfig. --- libvirt-gconfig-1.0.pc.in | 2 +- libvirt-gconfig/Makefile.am | 6 -- vapi/Makefile.am| 1 + 3 files

[libvirt] [libvirt-glib 18/20] gconfig: Adapt GVirConfigDomainGraphicsDesktop to GVirConfigDomainGraphicsLocal

From: Fabiano Fidêncio This patch adapts GVirConfigDomainGraphicsDesktop to the new GVirConfigDomainGraphicsLocal, inheriting from it and using its helper functions for getting display and fullscreen properties. As GVirConfigDomainGraphicsDesktop now inherits from

[libvirt] [libvirt-glib 05/20] config: Add spice listen getter/setter

From: Visarion Alexandru Learn to get/set the listen devices that spice graphics is using. When setting the listen devices, first remove the 'listen' attribute to avoid the inconsistencies checks between the 'listen' attribute and the 'address' attribute of the

[libvirt] [libvirt-glib 06/20] tests: Add test for GVirConfigDomainGraphicsListenAddress

From: Visarion Alexandru --- tests/test-gconfig.c | 39 ++ .../xml/gconfig-domain-device-graphics-listen.xml | 7 2 files changed, 46 insertions(+) create mode 100644

[libvirt] [libvirt-glib 07/20] gconfig: Introduce GVirConfigDomainGraphicsListenNone

for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Author: Christophe Fergeau <cferg...@redhat.com> + */ + +#include + +#include + +#include "libvir

[libvirt] [libvirt-glib 04/20] config: Add vnc listen getter/setter

From: Visarion Alexandru Learn to get/set the listen devices that vnc is using. When setting the listen devices, first remove the 'listen' attribute to avoid inconsistencies checks between the 'listen' attribute and the 'address' attribute of the 'listen' node. ---

[libvirt] [libvirt-glib 13/20] gconfig: Adapt GVirConfigDomainGraphicsSpice to GVirConfigDomainGraphicsRemote

From: Fabiano Fidêncio This patch adapts GVirConfigDomainGraphicsSpice to the new GVirConfigDomainGraphicsRemote, inheriting from it and using its helper functions for getting autoport and port properties. As GVirConfigDomainGraphicsSpice now inherits from

[libvirt] [libvirt-glib 00/20] gconfig: configuration work

Hey, This series groups 2 series which were sent previously for review, one from Visarion https://www.redhat.com/archives/libvir-list/2016-August/msg00868.html and one from Fidencio https://www.redhat.com/archives/libvir-list/2016-March/msg00993.html I'm putting them together as they touch the

[libvirt] [libvirt-glib 02/20] gconfig: Introduce GVirConfigDomainGraphicsListen

From: Visarion Alexandru Abstract class which represents a listen child node of the graphics device. --- libvirt-gconfig/Makefile.am| 2 + .../libvirt-gconfig-domain-graphics-listen.c | 49

[libvirt] [libvirt-glib 09/20] gconfig: Add gvir_config_domain_graphics_{spice, vnc}_add_listen

--- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 17 + libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 2 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 17 + libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 2 ++

[libvirt] [libvirt-glib 10/20] gconfig: Remove 'socket' attribute from gvir_config_domain_graphics_{spice, vnc}_set_listen

This is a legacy attribute which is going to conflict with listen nodes when we set some. --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 2 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 2 ++ 2 files changed, 4 insertions(+) diff --git

[libvirt] [libvirt-glib 08/20] gconfig: Introduce GVirConfigDomainGraphicsListenUnix

License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Author: Christophe Fergeau <cferg...@redhat.com> + */ + +#include + +#include + +#include &quo

Re: [libvirt] [gconfig v2 4/6] config: Add vnc listen getter/setter

Hey, On Mon, Sep 12, 2016 at 01:10:28AM +0300, Visarion-Mingopol Alexandru-Viorel wrote: > Hi! Sorry for the delay, I had some exams. > > _set_listen_list () is the only other name that comes into my mind. > > I also think _set_listens () is a bit odd, but _set_listen_nodes () > doesn't sound

Re: [libvirt] [PATCH] virsh: Fix *-event error string

On Tue, Sep 06, 2016 at 03:07:37PM +0200, Erik Skultety wrote: > ACK, although, I have a really small nitpick the decision on fixing of > which I leave to you. After the fix, "--list or --event type...", at > least to me, sounds like "--event" was the mentioned type itself which > is of course

[libvirt] [PATCH] virsh: Fix *-event error string

When using virsh net-event non-existing-net the error message says that 'either --list or event type is required' This is misleading as 'virsh net-event $valid-event-type' is not going to work either. What is expected is 'virsh net-event --event $valid-event-type' This commit fixes the string in

Re: [libvirt] [libvirt-glib/libvirt-gconfig 17/17] gconfig, graphics: Avoid crash when gvir_config_object_new_from_xml() returns NULL

On Thu, Apr 21, 2016 at 01:05:45PM +0200, Christophe Fergeau wrote: > This issues is more widespread than that, it would be better to fix it > everywhere in one go (maybe through a gvir_config_object_check_type() or > something like this?) I believe this patch should do for now (wit

Re: [libvirt] [libvirt-glib/libvirt-gconfig 06/17] gconfig: Implement gvir_config_domain_graphics_spice_get_tls_port()

On Thu, Apr 21, 2016 at 12:12:19PM +0200, Christophe Fergeau wrote: > For patches up to this one: > > Acked-by: Christophe Fergeau <cferg...@redhat.com> On second thought, the API added by the patches before this one becomes redundant and deprecated once the Remote/Local classes

Re: [libvirt] [gconfig v2 6/6] tests: Add test for GVirConfigDomainGraphicsListenAddress

On Wed, Aug 17, 2016 at 06:58:51PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > --- > tests/test-gconfig.c | 36 > ++ > .../xml/gconfig-domain-device-graphics-listen.xml | 7 + > 2 files

Re: [libvirt] [gconfig v2 5/6] config: Add spice listen getter/setter

On Wed, Aug 17, 2016 at 06:58:50PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > Learn to get/set the listen devices that spice graphics is using. > > When setting the listen devices, first remove the 'listen' > attribute to avoid the inconsistencies

Re: [libvirt] [gconfig v2 4/6] config: Add vnc listen getter/setter

ly sure how to name the API though. _set_listen_nodes() is the only thing which comes to mind, and I don't think it's great. Another options would be just _set_listens(), but that's odd too. Any better suggestion? Apart from this naming issue (which has to be fixed before pushing), Acked-by: Christ

Re: [libvirt] [gconfig v2 3/6] Introduce libvirt-gconfig-domain-graphics-listen-address

> GInetAddress *address) > +{ > +g_return_if_fail(GVIR_CONFIG_IS_DOMAIN_GRAPHICS_LISTEN_ADDRESS(listen)); > + > +gvir_config_object_set_attribute(GVIR_CONFIG_OBJECT(listen), > + "address", g_inet_addre

Re: [libvirt] [gconfig v2 2/6] Introduce libvirt-domain-graphics-listen

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Wed, Aug 17, 2016 at 06:58:47PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru <viorel.visar...@gmail.com> > > Abstract class which represents a listen child node > of the graphics device. > --- >

Re: [libvirt] [gconfig v2 1/6] libvirt-gconfig: Include GIO dependency

o-2.0 >= $GLIB2_REQUIRED) > +AC_SUBST(GIO2_CFLAGS) > +AC_SUBST(GIO2_LIBS) This is not needed, PKG_CHECK_MODULES() already does it for you (I've fixed it locally, so no need to resend a patch). Acked-by: Christophe Fergeau <cferg...@redhat.com> Christophe signature.asc Description:

[libvirt] [libvirt-glib 2/2] object: Fix gvir_connection_create_storage_pool() leak

We need to free the string returned by gvir_config_object_to_xml() after using it. --- libvirt-gobject/libvirt-gobject-connection.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c

[libvirt] [libvirt-glib 1/2] config: Fix gvir_config_xml_node_to_string() leak

If xmlNodeDump() fails, we would be leaking the xmlBuffer we created. This commit ensures we don't return early before this buffer is freed. --- libvirt-gconfig/libvirt-gconfig-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig-helpers.c

Re: [libvirt] [libvirt-php][PATCH] m4: Check for php modules more wisely

Hey, On Thu, Sep 01, 2016 at 01:30:33PM +0200, Michal Privoznik wrote: > I've got two version of PHP installed on my system, however one > of them has imagick the other one doesn't. During configure I've > noticed that wrong assumption has been made. Configure script > wrongly assumed the plugin

[libvirt] [PATCH] docs: Add missing / to closing tag

The iothread example for virtio-scsi should be rather than for the XML to be valid. --- I've already pushed this under the docs/trivial rule. Christophe docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in

Re: [libvirt] [gconfig v2 4/4] config: Add spice host setter

Same minor comments as the previous patch, Adding some test case to tests/test-gconfig.c would be good to have imo. Acked-by: Christophe Fergeau <cferg...@redhat.com> Christophe On Mon, Aug 01, 2016 at 11:52:40PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru <

Re: [libvirt] [gconfig v2 3/4] config: Add vnc host setter

bvirt-gconfig/libvirt-gconfig.sym > b/libvirt-gconfig/libvirt-gconfig.sym > index fab6059..117a648 100644 > --- a/libvirt-gconfig/libvirt-gconfig.sym > +++ b/libvirt-gconfig/libvirt-gconfig.sym > @@ -768,6 +768,7 @@ global: > gvir_config_domain_graphics_listen_address_get_type; > gvir_config_domain_graph

Re: [libvirt] [gconfig v2 2/4] Introduce libvirt-gconfig-domain-graphics-listen-address

On Mon, Aug 01, 2016 at 11:52:38PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > This is needed to be able to change the address a graphics > device is listening on. > --- > libvirt-gconfig/Makefile.am| 2 + >

Re: [libvirt] [gconfig v2 1/4] Introduce libvirt-domain-graphics-listen

Hey, On Mon, Aug 01, 2016 at 11:52:37PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > Abstract class which represents a listen child node > of the graphics device. > --- > libvirt-gconfig/Makefile.am| 2 + >

Re: [libvirt] [PATCH glib] Delete the manually written python binding

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Tue, Aug 02, 2016 at 02:34:33PM +0100, Daniel P. Berrange wrote: > The python binding only supports python2, only supports > 1 single API in libvirt-glib and has not even been enabled > in RPM builds since Fedora 15. Any di

Re: [libvirt] [gconfig v2 1/2] config: Add vnc host setter

Hey, On Thu, Jul 28, 2016 at 06:16:38PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > Learn to set the address that vnc is listening on. > --- > libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 9 + >

Re: [libvirt] [gconfig v2 0/2] Add host setters

Hey, On Thu, Jul 28, 2016 at 06:16:37PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > These new patches are a bit different than the last ones. > I first delete the child node and > then I modify the attribute. You could mention this in the commit

Re: [libvirt] [PATCH libvirt-glib] docs: Document gvir_connection_get_{storage_pools, networks, domains}

Acked-by: Christophe Fergeau <cferg...@redhat.com> (I'm assuming you can push to libvirt-glib, let me know if that's not the case). Christophe On Wed, Jul 27, 2016 at 08:59:54AM +0200, Guido Günther wrote: > In contrast to libvirt itself all get_* methods need to prefetch the > c

Re: [libvirt] [libvirt-glib v8 5/5] tests: Add test for GVirConfigDomainHostdevPci API

; Changes in v8: gvir_config_domain_hostdev_pci_get_rom_bar() simplified > as per review comment. For the series: Acked-by: Christophe Fergeau <cferg...@redhat.com> signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib v8 3/5] gconfig: Add GVirConfigDomainHostdevPci

On Mon, Jul 25, 2016 at 12:46:52PM +0100, Zeeshan Ali (Khattak) wrote: > +void gvir_config_domain_hostdev_pci_set_address(GVirConfigDomainHostdevPci > *hostdev, > +GVirConfigDomainAddressPci > *address) > +{ > +GVirConfigObject *source; > +

Re: [libvirt] [libvirt-glib v7 3/5] gconfig: Add GVirConfigDomainHostdevPci

On Fri, Jul 22, 2016 at 01:43:35PM +0100, Zeeshan Ali (Khattak) wrote: > +gboolean > gvir_config_domain_hostdev_pci_get_rom_bar(GVirConfigDomainHostdevPci > *hostdev) > +{ > +xmlNodePtr hostdev_node; > +xmlNodePtr rom_node; > +const gchar *bar_str; > + > +

Re: [libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

On Fri, Jul 22, 2016 at 01:34:09PM +0100, Zeeshan Ali (Khattak) wrote: > > Thanks. If there is a way to also set the address to send emails to, > I'll gladly drop my commands (actually they are git aliases). That's git config sendemail.to f...@example.com Christophe signature.asc Description:

Re: [libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

On Thu, Jul 21, 2016 at 06:11:36PM +0100, Zeeshan Ali (Khattak) wrote: > Hi, > > On Mon, Jul 18, 2016 at 3:54 PM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > Please add a gconfig: prefix to the subject line. > > I have a custom git command to add 'l

Re: [libvirt] [gconfig v2 1/2] config: Add spice listen setter

Hey, On Mon, Jul 18, 2016 at 04:36:39PM +0300, Visarion Alexandru wrote: > Learn to set the address that spice is listening on. > --- > .../libvirt-gconfig-domain-graphics-spice.c| 18 > ++ > .../libvirt-gconfig-domain-graphics-spice.h| 3 +++ >

Re: [libvirt] [gconfig v2 2/2] config: Add vnc listen setter

Hey, On Mon, Jul 18, 2016 at 04:36:40PM +0300, Visarion Alexandru wrote: > Learn to set the address that vnc is listening on. For what it's worth, this patch series https://www.redhat.com/archives/libvir-list/2016-March/msg00993.html would have allowed not to have to implement this both for VNC

Re: [libvirt] [PATCHv5 5/5] Add test for GVirConfigDomainHostdevPci API

Acked-by: Christophe Fergeau <cferg...@redhat.com> On Wed, Jul 06, 2016 at 10:45:55PM +0100, Zeeshan Ali (Khattak) wrote: > --- > tests/test-gconfig.c| 43 > + > tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++

Re: [libvirt] [PATCHv5 3/5] Add GVirConfigDomainHostdevPci

_attribute_content(rom_node, "bar"); > +if (g_strcmp0(bar_str, "on")) > +return TRUE; > +else > +return FALSE; Wouldn't: bar_str = gvir_config_object_get_attribute(GVIR_CONFIG_OBJECT(hostdev), "rom", "bar"); retur

Re: [libvirt] [PATCHv5 2/5] Add GVirConfigDomainHostdev

Please add a gconfig: prefix to the subject line. Acked-by: Christophe Fergeau <cferg...@redhat.com> Christophe On Wed, Jul 06, 2016 at 10:45:52PM +0100, Zeeshan Ali (Khattak) wrote: > Add API to read and write domain/devices/hostdev nodes. This patch only > adds the basecla

Re: [libvirt] [libvirt-glib] gconfig: Add gvir_config_domain_video_get_model()

On Thu, Jul 14, 2016 at 02:11:05PM +0100, Zeeshan Ali (Khattak) wrote: > Add a getter for model of domain video device. > --- > libvirt-gconfig/libvirt-gconfig-domain-video.c | 12 > libvirt-gconfig/libvirt-gconfig-domain-video.h | 1 + > libvirt-gconfig/libvirt-gconfig.sym

Re: [libvirt] [PATCH] config: Add listen setter

On Thu, Jul 14, 2016 at 06:57:35PM +0100, Zeeshan Ali (Khattak) wrote: > Oh and when you provide updated patches, please make the subject > prefix on emails 'gconfig' or 'libvirt-gconfig' so context is very > clear. You'll want version too so --subject-prefix="gconfig v2" would > be good. I

Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

On Wed, Jul 06, 2016 at 10:11:18PM +0100, Zeeshan Ali (Khattak) wrote: > On Thu, May 12, 2016 at 1:28 PM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > Looks I never answered this one. > > > > On Tue, Apr 26, 2016 at 05:04:30PM +0100, Zeeshan Ali (Khatta

Re: [libvirt] [PATCH v5 1/6] graphics: introduce listen type socket and use it for VNC

On Tue, May 24, 2016 at 04:45:53PM +0200, Pavel Hrdina wrote: > Introduce a new listen type that will be used to tell a graphics device > to listen on unix socket and use it for VNC graphics instead of socket > attribute. The socket attribute will remain in the XML for backward > compatibility. >

Re: [libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional

On Tue, May 17, 2016 at 08:03:11AM -0400, Cole Robinson wrote: > On 05/17/2016 06:11 AM, Christophe Fergeau wrote: > > Hey, > > > > After this patch series, the QEMU command line may not contain port nor > > tls-port if they both were set to '0'. However, QEMU ve

Re: [libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional

On Tue, May 17, 2016 at 02:10:16PM +0200, Ján Tomko wrote: > On Tue, May 17, 2016 at 12:11:38PM +0200, Christophe Fergeau wrote: > > Hey, > > > > After this patch series, the QEMU command line may not contain port nor > > tls-port if they both were set to '0'. Howeve

Re: [libvirt] [PATCH v3 00/14] improve graphics listen configuration

On Mon, May 16, 2016 at 10:59:47AM -0400, Cole Robinson wrote: > On 05/13/2016 12:35 PM, Christophe Fergeau wrote: > > Hey, > > > > Something which I forgot to mention/test when going through the first > > iteration is virsh domdisplay, it's currently failing with >

Re: [libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional

to keep supporting older QEMU binaries, and that this needs to be fixed on libvirt side? Christophe On Wed, Mar 16, 2016 at 05:45:03PM +0100, Christophe Fergeau wrote: > The end goal is to avoid adding -spice port=0,addr=127.0.0.1 to QEMU command > line when no SPICE port is specified in libvi

Re: [libvirt] [PATCH v3 00/14] improve graphics listen configuration

Hey, Something which I forgot to mention/test when going through the first iteration is virsh domdisplay, it's currently failing with I think something like 'spice+unix:///tmp/foo' is expected. This can be addressed as a follow-up to this series though. Christophe On Thu, May 12, 2016 at

Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

Looks I never answered this one. On Tue, Apr 26, 2016 at 05:04:30PM +0100, Zeeshan Ali (Khattak) wrote: > >> +const gchar > >> *gvir_config_domain_hostdev_pci_get_rom_file(GVirConfigDomainHostdevPci > >> *hostdev) > >> +{ > >> +return

Re: [libvirt] [PATCH v2 12/12] spice: introduce listen type none

On Wed, May 11, 2016 at 05:08:31PM +0200, Pavel Hrdina wrote: > This new listen type is currently supported only by spice graphics. > It's introduced to make it easier and clearer specify to not listen > anywhere in order to start a guest with OpenGL support. > > The old way to do this was set

Re: [libvirt] [PATCH v2 12/12] spice: introduce listen type none

On Thu, May 12, 2016 at 08:43:38AM +0200, Pavel Hrdina wrote: > > > @@ -21630,8 +21661,6 @@ virDomainGraphicsDefFormat(virBufferPtr buf, > > > } > > > > > > for (i = 0; i < def->nListens; i++) { > > > -if (def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE) > > > -

Re: [libvirt] [PATCH v2 11/12] spice: introduce spice_auto_unix_socket config option

On Wed, May 11, 2016 at 05:08:30PM +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu.conf | 11 +++ > src/qemu/qemu_conf.c | 1 + > src/qemu/qemu_conf.h

Re: [libvirt] [PATCH v2 05/12] graphics: move port definition to listen element

On Wed, May 11, 2016 at 05:08:24PM +0200, Pavel Hrdina wrote: > So far we have only two listen types that supports only address:port > method, but in the future we may want to add a new different listen > type, for example socket. > > This patch moves the ports values out of graphics unions into

Re: [libvirt] [PATCH v2 08/12] spice: add support for listen type socket

Hey, On Wed, May 11, 2016 at 05:08:27PM +0200, Pavel Hrdina wrote: > @@ -7665,40 +7694,12 @@ > qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg, > break; > > case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_INSECURE: > -if (glisten->port <= 0) { > -

Re: [libvirt] [PATCH v2 06/12] graphics: introduce listen type=socket and use it for VNC

Hey, On Wed, May 11, 2016 at 05:08:25PM +0200, Pavel Hrdina wrote: > Introduce a new listen type that will be used to tell a graphics device > to listen on unix socket and use it for VNC graphics instead of socket > attribute. The socket attribute will remain in the XML for backward >

[libvirt] [PATCH] schemas: Improve outdated comment

--- docs/schemas/domaincommon.rng | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 273715c..8798001 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -2622,10 +2622,7 @@

Re: [libvirt] [PATCH v4 6/6] Add test for GVirConfigDomainHostdevPci API

On Tue, Apr 26, 2016 at 04:47:58PM +0100, Zeeshan Ali (Khattak) wrote: > On Thu, Apr 21, 2016 at 3:14 PM, Christophe Fergeau <cferg...@redhat.com> > wrote: > > And one more. > > Yours? AFAIK it's mine. Yes, you're right, sorry, I was too eager to get to the end

Re: [libvirt] [PATCH v4 6/6] Add test for GVirConfigDomainHostdevPci API

And one more. On Fri, Apr 15, 2016 at 02:38:24PM +0100, Zeeshan Ali (Khattak) wrote: > --- > tests/test-gconfig.c| 43 > + > tests/xml/gconfig-domain-device-pci-hostdev.xml | 11 +++ > 2 files changed, 54 insertions(+) > create mode

Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

> + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library. If not, see > + * <http://www.gnu.org/licenses/>. > + * > + * Authors: Zeeshan Ali (Khattak) <zeesha...@gnome.org> > + *

Re: [libvirt] [PATCH v4 3/6] libvirt-gconfig: Accept on/off as boolean attributes

On Fri, Apr 15, 2016 at 02:38:21PM +0100, Zeeshan Ali (Khattak) wrote: > gvir_config_object_get_attribute_boolean() currently only accepts yes/no > as boolean attribute values. Let's also accept on/off as valid values > too. As said in 4/6, I prefer to have the "on"/"off" check in the getter

Re: [libvirt] [PATCH v4 5/6] gconfig: Add GVirConfigDomainAddressPci getters

Another patch that I wrote... Christophe On Fri, Apr 15, 2016 at 02:38:23PM +0100, Zeeshan Ali (Khattak) wrote: > From: Christophe Fergeau <cferg...@redhat.com> > > They will be useful to do more checks in the GVirDomainDeviceHostdev > unit test. > --- > .../libvir

Re: [libvirt] [PATCH v4 1/6] gconfig: Add gvir_config_object_has_child

On Fri, Apr 15, 2016 at 02:38:19PM +0100, Zeeshan Ali (Khattak) wrote: > From: Christophe Fergeau <cferg...@redhat.com> This patch is mine, hopefully someone else will review it ;) Christophe signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.

Re: [libvirt] [PATCH v4 2/6] Add GVirConfigDomainHostdev

areable: > + * @hostdev: the host device > + * @shareable: the new shareable status > + * > + * Set the whether or not @hostdev is shared between domains. > + */ Extra "the" Acked-by: Christophe Fergeau <cferg...@redhat.com> Christophe signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] gconfig: Add hostdev support v4

On Fri, Apr 15, 2016 at 02:38:18PM +0100, Zeeshan Ali (Khattak) wrote: > Finally I got the time to clean-up and fix the patches. It's been a > while last i looked into them already and I got a bit confused at some > point so I appologize if I didn't address some of the review comments. Changes

Re: [libvirt] [libvirt-glib] events: Mark 'eventlock' as static

Ping? Christophe On Fri, Jan 29, 2016 at 09:32:51AM +0100, Christophe Fergeau wrote: > It's not used outside of the libvirt-glib-event.c file, so there is no > good reason for not having it static. As it was not listed in > libvirt-glib.sym, this will make no change to the publicly

  1   2   3   4   5   6   7   8   9   10   >