Re: [libvirt PATCH 0/3] tests: Fix qemucapabilitiestest on macOS

2022-08-10 Thread Christophe de Dinechin
k: 252 Expected Fail: 0 Fail: 0 Unexpected Pass:0 Skipped:19 Timeout: 0 For the series: Reviewed-by: Christophe de Dinechin Tested-by: Christophe de Dinechin -- Cheers, Christophe de Dinechin (https://c3d.github.io)

Re: Test failures on macOS 12

2022-08-09 Thread Christophe de Dinechin
> On 9 Aug 2022, at 11:50, Andrea Bolognani wrote: > > On Tue, Aug 09, 2022 at 11:34:20AM +0200, Christophe de Dinechin wrote: >> On 9 Aug 2022, at 11:28, Andrea Bolognani wrote: >>> Yeah, this seems to help and the change makes sense to me. >>> >>>

Re: Test failures on macOS 12

2022-08-09 Thread Christophe de Dinechin
> On 9 Aug 2022, at 11:28, Andrea Bolognani wrote: > > On Mon, Aug 08, 2022 at 08:19:28PM +0200, Christophe de Dinechin wrote: >> Hi Andrea, >> >> I saw your call to Sergio and Marc-André on IRC, and I thought I would >> spend a few minutes inviestigatin

Re: Test failures on macOS 12

2022-08-08 Thread Christophe de Dinechin
> On 10 Jun 2022, at 11:34, Andrea Bolognani wrote: > > On Fri, May 06, 2022 at 03:00:14AM -0700, Andrea Bolognani wrote: >> I'm trying to enable CI coverage for macOS 12, but I'm running into a >> couple of issues that I'm not sure how to handle. >> >> Note that the test suite currently pass

Re: Test failures on macOS 12

2022-08-08 Thread Christophe de Dinechin
ms like a pretty good indication >> that virrandommock is not being picked up correctly. This is not the >> only test program that uses that specific mock though, so I'm not >> sure what makes it fail when all the others are succeeding. I believe that the following patch fixes

Kata needs for device addressing (was Re: libvirt-devaddr: a new library for device address assignment)

2020-05-04 Thread Christophe de Dinechin
> On 4 Mar 2020, at 13:50, Daniel P. Berrangé wrote: > > We've been doing alot of refactoring of code in recent times, and also > have plans for significant infrastructure changes. We still need to > spend time delivering interesting features to users / applications. > This mail is to introduc

Re: On the need to move to a merge request workflow

2020-03-17 Thread Christophe de Dinechin
+1 on the initial thread b > On 6 Mar 2020, at 15:54, Daniel Henrique Barboza > wrote: > > > > On 3/6/20 8:44 AM, Daniel P. Berrangé wrote: > > > [...] > > > What happens with this mailing list when the migration to the new workflow is > completed with all the repos? Is it still going to

Re: qemu:///embed and isolation from global components

2020-03-11 Thread Christophe de Dinechin
Le 9 mars 2020 à 14:03, Michal Privoznik a écrit : > > On 3/6/20 6:49 PM, Daniel P. Berrangé wrote: >>> On Fri, Mar 06, 2020 at 06:24:15PM +0100, Andrea Bolognani wrote: >>> Recently I've been working on integrating qemu:///embed into an >>> application. It's been reasonably smooth so far :) >>>

Re: [libvirt PATCHv5 06/15] docs: add virtiofs kbase

2020-02-26 Thread Christophe de Dinechin
> On 26 Feb 2020, at 12:57, Ján Tomko wrote: > > Add a document describing the usage of virtiofs. > --- > docs/kbase.html.in | 3 + > docs/kbase/virtiofs.rst | 152 > 2 files changed, 155 insertions(+) > create mode 100644 docs/kbase/virtiofs.rst >

Re: [libvirt] [PATCH] doc: vtpm only support secrets by UUID at this point

2019-12-10 Thread Christophe de Dinechin
on> element of > + for the secret. The vTPM secret can then be used by UUID > + via the <encryption> element of > a tpm when using an > emulator. > Since 5.6.0. The following is an example > -- > 2.24.0.308.g228f53135a Reminds me

Re: [libvirt] [PATCH] virkeyfile: fix compilation error with clang

2019-12-10 Thread Christophe de Dinechin
> On 10 Dec 2019, at 15:11, Pavel Hrdina wrote: > > Clang complains about condition being always true: > > src/util/virkeyfile.c:113:23: error: result of comparison of constant 128 > with expression of type 'const char' is always true > [-Werror,-Wtautological-constant-out-of-range-compare]

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-11-22 Thread Christophe de Dinechin
> On 22 Nov 2019, at 09:41, Markus Armbruster wrote: > > Reviving this old thread, because I'd like to connect it to more recent > discussions. > > Christophe de Dinechin mailto:dinec...@redhat.com>> > writes: > >> Markus Armbru

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

2019-10-17 Thread Christophe de Dinechin
> On 17 Oct 2019, at 14:35, Cole Robinson wrote: > > Hmm why wasn't I in to/cc list, was that intentional? Not at all. I assumed a reply-to would add it automatically and did not bother checking. Probably something wrong in my mu4e config. > > On 10/17/19 5:26 AM, Ch

Re: [libvirt] [PATCH 12/30] storagefile: Fix backing format \0 check

2019-10-17 Thread Christophe de Dinechin
that is the way email "protects" lines that begin with "From". You rarely see it nowadays because the mail itself is encoded, but if you use plain text and send in ASCII, this will happen. See page 78 of "The Unix Haters Handbook" [1] for details [1] https://we

Re: [libvirt] [PATCH 00/30] storagefile, security: qcow2 data_file support

2019-10-17 Thread Christophe de Dinechin
startup/shutdown. > The main functional changes are > > * Teach storagefile how to parse out data_file from the qcow2 header > * Store the raw string as virStorageSource->externalDataStoreRaw > * Track that as its out virStorageSource in externalDataStore > * dac/selinux relabe

Re: [libvirt] [PATCH 2/3] tests: qemublock: Use bigger numbers as dummy capacity/physical

2019-08-30 Thread Christophe de Dinechin
uot;: 42 > + "size": 4294967296 > } Does any of these tests actually require that much space to run? If so, what is the impact on QE teams? -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v1 1/3] adding unplug_timeout QEMU conf

2019-08-30 Thread Christophe de Dinechin
nge.com :| > |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH trivial] qemu_conf.c: removing unused virQEMUDriverConfigPtr variable

2019-08-30 Thread Christophe de Dinechin
sec_managers); > virObjectUnref(caps); > -virObjectUnref(cfg); > return NULL; > } > > -- > 2.21.0 Reviewed-by: Christophe de Dinechin -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-30 Thread Christophe de Dinechin
John Snow writes: > On 8/29/19 12:45 PM, Christophe de Dinechin wrote: >> [...] >> Sorry for catching up late, this mail thread happened during my PTO. >> >> I remember bringing up at the time [1] that the correct solution needs >> to take into account usag

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Christophe de Dinechin
ort() alongside warn_report()? 2. Connect warn_report() and all the error_vprintf output to QAPI, e.g. using John's suggestion of adding the messages using some "warning" or "deprecated" tag? 3. Teach libvirt how to consume that new tag and pass it along? [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg06131.html -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-29 Thread Christophe de Dinechin
ich already at the BoF seemed like a really big hammer to kill a fly. CC'ing Andrea as well, because we discussed recently about how to deal with error checking in general, and if a new error checking framework is being put in place, adding deprecation to the thinking could be a good idea. -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 46/48] util: storage identity attrs as virTypedParameter internally

2019-07-31 Thread Christophe de Dinechin
t; +VIR_DEBUG("Unexpected SELinux context attribute '%s' != '%s'", >> + val, context); >> goto cleanup; >> } > > This change also doesn't belong in this patch. You can put it in the > same one a

Re: [libvirt] [PATCH v3 45/48] util: make generic identity accessors private

2019-07-30 Thread Christophe de Dinechin
tGroupID) < 0) { > +if (virIdentityGetOSGroupID(ident, > +&gotGroupID) < 0) { > fprintf(stderr, "Missing group ID in identity\n"); > goto cleanup; > } > -if (STRNEQ_NULLABLE("7337", gotG

Re: [libvirt] [PATCH v3 44/48] util: change identity class attribute names

2019-07-30 Thread Christophe de Dinechin
) < 0 || > +if (virIdentityGetOSGroupID(identity, &gid) < 0 || > virTypedParamsAddInt(&tmpparams, nparams, &maxparams, > VIR_CLIENT_INFO_UNIX_GROUP_ID, gid) < 0) > goto cleanup; > [...] > > if (virIdentityGet

Re: [libvirt] [PATCH v3 06/48] remote: stop trying to print help as giant blocks of text

2019-07-30 Thread Christophe de Dinechin
> On 30 Jul 2019, at 12:52, Andrea Bolognani wrote: > > On Mon, 2019-07-29 at 18:10 +0100, Daniel P. Berrangé wrote: >> The remote daemon tries to print out its help text in a couple of giant >> blocks of text. This has already lead to duplication of the text for the >> privileged vs unprivileg

Re: [libvirt] [PATCH v3 22/48] network: introduce virtnetworkd daemon

2019-07-30 Thread Christophe de Dinechin
> On 30 Jul 2019, at 13:20, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2019 at 01:08:53PM +0200, Christophe de Dinechin wrote: >> >> Daniel P. Berrangé writes: >> >>> The virtnetworkd daemon will be responsible for providing the network API >>>

Re: [libvirt] [PATCH v3 10/48] remote: conditionalize IP socket usage in libvirtd daemon

2019-07-30 Thread Christophe de Dinechin
> On 30 Jul 2019, at 13:15, Andrea Bolognani wrote: > > On Tue, 2019-07-30 at 12:00 +0100, Daniel P. Berrangé wrote: >> On Tue, Jul 30, 2019 at 12:46:31PM +0200, Christophe de Dinechin wrote: >>> Daniel P. Berrangé writes: >>>> @@ -381,11 +381,

Re: [libvirt] [PATCH v3 24/48] storage: introduce virtstoraged daemon

2019-07-30 Thread Christophe de Dinechin
storaged.service.in > @@ -0,0 +1,26 @@ > +[Unit] > +Description=Virtualization storage daemon > +Conflicts=libvirtd.service > +Requires=virtstoraged.socket > +Requires=virtstoraged-ro.socket > +Requires=virtstoraged-admin.socket > +After=network.target > +After=dbus.service &g

Re: [libvirt] [PATCH v3 23/48] interface: introduce virtinterfaced daemon

2019-07-30 Thread Christophe de Dinechin
t; +++ b/src/interface/virtinterfaced.service.in > @@ -0,0 +1,24 @@ > +[Unit] > +Description=Virtualization interface daemon > +Conflicts=libvirtd.service > +Requires=virtinterfaced.socket > +Requires=virtinterfaced-ro.socket > +Requires=virtinterfaced-admin.socket > +After=ne

Re: [libvirt] [PATCH v3 22/48] network: introduce virtnetworkd daemon

2019-07-30 Thread Christophe de Dinechin
+Requires=virtnetworkd-admin.socket > +After=network.target > +After=dbus.service > +After=apparmor.service > +After=local-fs.target > +Documentation=man:libvirtd(8) Maybe you need to create man page aliases for each of the new daemon names? > +Documentation=https://libvirt.org > + > +[Service] > +Type=notify > +ExecStart=@sbindir@/virtnetworkd --timeout 120 > +ExecReload=/bin/kill -HUP $MAINPID > +Restart=on-failure > +KillMode=process > + > +[Install] > +WantedBy=multi-user.target > +Also=virtnetworkd.socket > +Also=virtnetworkd-ro.socket > +Also=virtnetworkd-admin.socket > -- > 2.21.0 Reviewed-by: Christophe de Dinechin -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 21/48] secret: introduce virtsecretd daemon

2019-07-30 Thread Christophe de Dinechin
cret/virtsecretd.service.in > @@ -0,0 +1,24 @@ > +[Unit] > +Description=Virtualization secret daemon > +Conflicts=libvirtd.service > +Requires=virtsecretd.socket > +Requires=virtsecretd-ro.socket > +Requires=virtsecretd-admin.socket > +After=network.target > +After=dbus

Re: [libvirt] [PATCH v3 20/48] remote: introduce virtproxyd daemon to handle IP connectivity

2019-07-30 Thread Christophe de Dinechin
p;& defined(LIBVIRTD) > const char *optstr = "ldf:p:t:vVh"; > -#else /* ! ENABLE_IP */ > +#else /* ! ENABLE_IP && ! LIBVIRTD */ > const char *optstr = "df:p:t:vVh"; > -#endif /* ! ENABLE_IP */ > +#endif /* ! ENABLE_IP && ! LIBVIRTD */ > > c = getopt_long(argc, argv, optstr, opts, &optidx); > > @@ -1043,7 +1053,7 @@ int main(int argc, char **argv) { > godaemon = 1; > break; > > -#ifdef ENABLE_IP > +#if defined(ENABLE_IP) && defined(LIBVIRTD) > case 'l': > ipsock = 1; > break; > diff --git a/src/remote/remote_daemon_config.c > b/src/remote/remote_daemon_config.c > index 3c5ccd5ba8..f583442dc7 100644 > --- a/src/remote/remote_daemon_config.c > +++ b/src/remote/remote_daemon_config.c > @@ -108,7 +108,11 @@ daemonConfigNew(bool privileged ATTRIBUTE_UNUSED) > return NULL; > > #ifdef ENABLE_IP > -data->listen_tls = 1; > +# ifdef LIBVIRTD > +data->listen_tls = 1; /* Only honoured it --listen is set */ > +# else /* ! LIBVIRTD */ > +data->listen_tls = 0; /* Always honoured, --listen doesn't exist. */ > +# endif /* ! LIBVIRTD */ > data->listen_tcp = 0; > > if (VIR_STRDUP(data->tls_port, LIBVIRTD_TLS_PORT) < 0 || > diff --git a/src/remote/virtproxyd.service.in > b/src/remote/virtproxyd.service.in > new file mode 100644 > index 00..e99e2af19c > --- /dev/null > +++ b/src/remote/virtproxyd.service.in > @@ -0,0 +1,24 @@ > +[Unit] > +Description=Virtualization daemon > +Conflicts=libvirtd.service > +Requires=virtproxyd.socket > +Requires=virtproxyd-ro.socket > +Requires=virtproxyd-admin.socket > +After=network.target > +After=dbus.service > +After=apparmor.service > +After=local-fs.target > +Documentation=man:libvirtd(8) > +Documentation=https://libvirt.org > + > +[Service] > +Type=notify > +ExecStart=@sbindir@/virtproxyd --timeout 120 > +ExecReload=/bin/kill -HUP $MAINPID > +Restart=on-failure > + > +[Install] > +WantedBy=multi-user.target > +Also=virtproxyd.socket > +Also=virtproxyd-ro.socket > +Also=virtproxyd-admin.socket > -- > 2.21.0 Reviewed-by: Christophe de Dinechin -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 19/48] remote: in per-driver daemons ensure that state initialize succeeds

2019-07-30 Thread Christophe de Dinechin
age/storage_driver.c > @@ -255,12 +255,12 @@ storageStateInitialize(bool privileged, > VIR_AUTOFREE(char *) rundir = NULL; > > if (VIR_ALLOC(driver) < 0) > - return -1; > + return VIR_DRV_STATE_INIT_ERROR; > > driver->lockFD = -1; > if (virMutexIni

Re: [libvirt] [PATCH v3 16/48] remote: reduce duplication in systemd unit file make rules into one

2019-07-30 Thread Christophe de Dinechin
Reviewed-by: Christophe de Dinechin Daniel P. Berrangé writes: > The make rules for the systemd socket unit files are all essentially > identical and can be collapsed into a single generic rule. The service > unit file rule can be simplified too. > > Reviewed-by: Andrea Bolognan

Re: [libvirt] [PATCH v3 15/48] build: don't hardcode /etc in the config related files

2019-07-30 Thread Christophe de Dinechin
LGTM Reviewed-by: Christophe de Dinechin Daniel P. Berrangé writes: > Substitute in the @sysconfigdir@ value instead of /etc. > > Signed-off-by: Daniel P. Berrangé > --- > src/locking/Makefile.inc.am | 1 + > src/locking/virtlockd.service.in| 2

Re: [libvirt] [PATCH v3 12/48] remote: conditionalize IP socket config in libvirtd.conf

2019-07-30 Thread Christophe de Dinechin
still send them and the daemon will send responses. When > # keepalive_count is set to 0, connections will be automatically > # closed after keepalive_interval seconds of inactivity without > diff --git a/src/remote/test_libvirtd.aug.in b/src/remote/test_libvirtd.aug.in > index 6c51b7b9e7..d768b30b55 100644 > --- a/src/remote/test_libvirtd.aug.in > +++ b/src/remote/test_libvirtd.aug.in > @@ -29,11 +29,11 @@ module Test_libvirtd = > { "1" = "DN1"} > { "2" = "DN2"} > } > +{ "tls_priority" = "NORMAL" } I'm curious about this change? Is that because you changed the order in the source code? Does that depend on ENABLE_IP? > { "sasl_allowed_username_list" > { "1" = "j...@example.com" } > { "2" = "f...@example.com" } > } > -{ "tls_priority" = "NORMAL" } > { "max_clients" = "5000" } > { "max_queued_clients" = "1000" } > { "max_anonymous_clients" = "20" } > -- > 2.21.0 Reviewed-by: Christophe de Dinechin -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 10/48] remote: conditionalize IP socket usage in libvirtd daemon

2019-07-30 Thread Christophe de Dinechin
s_no_verify_certificate", > &data->tls_no_verify_certificate) < 0) > @@ -295,14 +311,14 @@ daemonConfigLoadOptions(struct daemonConfig *data, >&data->tls_allowed_dn_list) < 0) > goto error; > > +if (virConfG

Re: [libvirt] [PATCH v3 09/48] remote: conditionalize driver loading in libvirtd daemon

2019-07-30 Thread Christophe de Dinechin
> -#ifdef WITH_LXC > +# endif > +# ifdef WITH_LXC > if (virDriverLoadModule("lxc", "lxcRegister", false) < 0) > return -1; > -#endif > -#ifdef WITH_VBOX > +# endif > +# ifdef WITH_VBOX > if (virDriverLoadModule("vbox", &quo

Re: [libvirt] [PATCH v3 08/48] remote: conditionalize daemon name in libvirtd daemon

2019-07-30 Thread Christophe de Dinechin
if (!(srv = virNetServerNew(DAEMON_NAME, 1, > config->min_workers, > config->max_workers, > config->prio_workers, > diff --git a/src/remote/remote_daemon_config.c > b/src/remote

Re: [libvirt] [PATCH v3 07/48] remote: conditionalize socket names in libvirtd daemon

2019-07-30 Thread Christophe de Dinechin
derr, " %s\n", > -privileged ? LOCALSTATEDIR "/run/libvirt/libvirt-sock" : > -"$XDG_RUNTIME_DIR/libvirt/libvirt-sock"); > + fprintf(stderr, " %s/libvirt/%s-sock\n", > +privileged ? LOCALSTATEDIR "/

Re: [libvirt] [PATCH v3 07/48] remote: conditionalize socket names in libvirtd daemon

2019-07-30 Thread Christophe de Dinechin
"$XDG_RUNTIME_DIR/libvirt/libvirt-sock"); > +fprintf(stderr, " %s/libvirt/%s-sock\n", > +privileged ? LOCALSTATEDIR "/run" : "$XDG_RUNTIME_DIR", > +SOCK_PREFIX); > if (privileged) > -fprintf(stderr, " %s\n", > -LOCALSTATEDIR "/run/libvirt/libvirt-sock-ro"); > +fprintf(stderr, " %s/run/libvirt/%s-sock-ro\n", > +LOCALSTATEDIR, SOCK_PREFIX); > fprintf(stderr, "\n"); > > fprintf(stderr, "%s:\n", _("TLS")); > -- > 2.21.0 -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 00/48] Split the libvirtd daemon into per-driver daemons

2019-07-30 Thread Christophe de Dinechin
> On 30 Jul 2019, at 11:38, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2019 at 11:05:25AM +0200, Christophe de Dinechin wrote: >> >> Daniel P. Berrangé writes: >> >>> This is what all the driver refactoring I've done has been about >>&g

Re: [libvirt] [PATCH v3 06/48] remote: stop trying to print help as giant blocks of text

2019-07-30 Thread Christophe de Dinechin
> On 30 Jul 2019, at 12:04, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2019 at 11:56:45AM +0200, Christophe de Dinechin wrote: >> >> Daniel P. Berrangé writes: >> >>> The remote daemon tries to print out its help text in a couple of giant >>

Re: [libvirt] [PATCH v3 06/48] remote: stop trying to print help as giant blocks of text

2019-07-30 Thread Christophe de Dinechin
> On 30 Jul 2019, at 12:04, Daniel P. Berrangé wrote: > > On Tue, Jul 30, 2019 at 11:56:45AM +0200, Christophe de Dinechin wrote: >> >> Daniel P. Berrangé writes: >> >>> The remote daemon tries to print out its help text in a couple of giant >>

Re: [libvirt] [PATCH v3 07/48] remote: conditionalize socket names in libvirtd daemon

2019-07-30 Thread Christophe de Dinechin
EDIR "/run/libvirt/libvirt-sock" : > -"$XDG_RUNTIME_DIR/libvirt/libvirt-sock"); > +fprintf(stderr, " %s/libvirt/%s-sock\n", > +privileged ? LOCALSTATEDIR "/run" : "$XDG_RUNTIME_DIR", > +SOCK_PREFIX); > if (privileged) > -fprintf(stderr, " %s\n", > -LOCALSTATEDIR "/run/libvirt/libvirt-sock-ro"); > +fprintf(stderr, " %s/run/libvirt/%s-sock-ro\n", > +LOCALSTATEDIR, SOCK_PREFIX); > fprintf(stderr, "\n"); > > fprintf(stderr, "%s:\n", _("TLS")); fprintf(stderr, "%s\n", _("TLS:")); > -- > 2.21.0 Reviewed-by: Christophe de Dinechin -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 06/48] remote: stop trying to print help as giant blocks of text

2019-07-30 Thread Christophe de Dinechin
/run/libvirt/libvirt-sock-ro"); Add N_? > +fprintf(stderr, "\n"); > + > +fprintf(stderr, "%s:\n", _("TLS")); > +fprintf(stderr, " %s: %s\n", > + _("CA certificate"), > +privileged ?

Re: [libvirt] [PATCH v3 48/48] remote: pass identity across to newly opened daemons

2019-07-30 Thread Christophe de Dinechin
ROC_DOMAIN_CHECKPOINT_DELETE = 417, > +REMOTE_PROC_CONNECT_SET_IDENTITY = 418, > }; > diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c > index 1f020a5a04..2a278171f5 100644 > --- a/src/rpc/virnetserverclient.c > +++ b/src/rpc/virnetserverclient.c

Re: [libvirt] [PATCH v3 00/48] Split the libvirtd daemon into per-driver daemons

2019-07-30 Thread Christophe de Dinechin
|2 +- > 96 files changed, 3642 insertions(+), 1703 deletions(-) > create mode 100644 src/interface/virtinterfaced.service.in > create mode 100644 src/libxl/virtxend.service.in > create mode 100644 src/lxc/virtlxcd.service.in > create mode 100644 src/network/virtnetworkd.service.in > create mode 100644 src/node_device/virtnodedevd.service.in > create mode 100644 src/nwfilter/virtnwfilterd.service.in > create mode 100644 src/qemu/virtqemud.service.in > rename src/remote/{libvirtd.aug => libvirtd.aug.in} (89%) > rename src/remote/{libvirtd.conf => libvirtd.conf.in} (92%) > create mode 100644 src/remote/virtproxyd.service.in > create mode 100644 src/secret/virtsecretd.service.in > create mode 100644 src/storage/virtstoraged.service.in > create mode 100644 src/vbox/virtvboxd.service.in > create mode 100644 src/vz/virtvzd.service.in > > -- > 2.21.0 -- Cheers, Christophe de Dinechin (IRC c3d) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries

2019-06-20 Thread Christophe de Dinechin
> On 20 Jun 2019, at 12:25, Andrea Bolognani wrote: > > On Wed, 2019-06-19 at 17:00 +0200, Christophe de Dinechin wrote: >>> Andrea Bolognani (5): >>> docs: Update jQuery >>> docs: Update Moment.js >>> docs: Update jquery.rss >>> docs:

Re: [libvirt] [PATCH 2/3] docs: use case sensitive javascript

2019-06-19 Thread Christophe de Dinechin
advancedsearch) > + simpleSearch.addEventListener("submit", advancedsearch) Reviewed-by: Christophe de Dinechin > > docLoc = document.location; > if (docLoc.protocol != "file:" || > -- > 2.21.0 > > -- > libvir-list mailing list >

Re: [libvirt] [PATCH v3 0/5] docs: Update third-party JavaScript libraries

2019-06-19 Thread Christophe de Dinechin
> On 19 Jun 2019, at 14:41, Andrea Bolognani wrote: > > We're carrying around embedded copies of a few JavaScript libraries > for use in our homepage, and we've been unforgivably bad at keeping > them up to date. Address that. > > While doing so, replace the minified version of each library w

Re: [libvirt] [PATCH v3 4/5] docs: Perform JavaScript minimization at build time

2019-06-19 Thread Christophe de Dinechin
. > > Call uglifyjs at build time, if available, to achieve this. > Signed-off-by: Andrea Bolognani Reviewed-by: Christophe de Dinechin > --- > .gitignore | 1 + > docs/Makefile.am | 30 +++--- > docs/index.h

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-19 Thread Christophe de Dinechin
> On 19 Jun 2019, at 11:14, Daniel P. Berrangé wrote: > > On Wed, Jun 19, 2019 at 10:50:14AM +0200, Christophe de Dinechin wrote: > > So the first thing our Go code does is check the libvirt native library > version number and report an error > > eg > > func

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-19 Thread Christophe de Dinechin
> On 18 Jun 2019, at 19:01, Daniel P. Berrangé wrote: > > On Tue, Jun 18, 2019 at 06:33:01PM +0200, Christophe de Dinechin wrote: >> >> >>> On 18 Jun 2019, at 17:43, Daniel P. Berrangé wrote: >>> >>> Signed-off-by: Daniel P. Ber

Re: [libvirt] [go PATCH] Add support for virNetworkPort object and APIs

2019-06-18 Thread Christophe de Dinechin
> On 18 Jun 2019, at 17:43, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > network.go | 80 ++ > network_port.go | 233 > network_port_compat.h | 67 > network_port_wrapper.go | 197

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-14 Thread Christophe de Dinechin
> On 14 Jun 2019, at 16:23, Alex Williamson wrote: > > On Fri, 14 Jun 2019 11:54:42 +0200 > Christophe de Dinechin wrote: > >> That is true irrespective of the usage, isn’t it? In other words, when you >> invoke `mdevctl create-mdev`, you assert “I own that specifi

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-14 Thread Christophe de Dinechin
> On 24 May 2019, at 01:20, Alex Williamson wrote: > > Hi, > > Currently mediated device management, much like SR-IOV VF management, > is largely left as an exercise for the user. This is an attempt to > provide something and see where it goes. I doubt we'll solve > everyone's needs on the f

Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility

2019-06-14 Thread Christophe de Dinechin
> On 13 Jun 2019, at 18:35, Alex Williamson wrote: > > On Thu, 13 Jun 2019 18:17:53 +0200 > Christophe de Dinechin wrote: > >>> On 24 May 2019, at 01:20, Alex Williamson >>> wrote: >>> >>> Hi, >>> >>> Currently media

Re: [libvirt] [Qemu-devel] [PATCH 1/2] vfio/mdev: add version field as mandatory attribute for mdev device

2019-04-24 Thread Christophe de Dinechin
> On 23 Apr 2019, at 12:39, Daniel P. Berrangé wrote: > > On Fri, Apr 19, 2019 at 04:35:04AM -0400, Yan Zhao wrote: >> device version attribute in mdev sysfs is used by user space software >> (e.g. libvirt) to query device compatibility for live migration of VFIO >> mdev devices. This attribute

Re: [libvirt] [PATCH] Use port range 5901-5999 if not set in qemu.conf, avoid port 5900

2017-04-21 Thread Christophe de Dinechin
> On 21 Apr 2017, at 11:26, Daniel P. Berrange wrote: > > On Fri, Apr 21, 2017 at 11:20:11AM +0200, Peter Krempa wrote: >> On Fri, Apr 21, 2017 at 11:02:36 +0200, Christophe de Dinechin wrote: >>> In order to avoid conflict with the default port (5900) for host VNC ser

Re: [libvirt] [PATCH] Use port range 5901-5999 if not set in qemu.conf, avoid port 5900

2017-04-21 Thread Christophe de Dinechin
> On 21 Apr 2017, at 11:20, Peter Krempa wrote: > > On Fri, Apr 21, 2017 at 11:02:36 +0200, Christophe de Dinechin wrote: >> In order to avoid conflict with the default port (5900) for host VNC server >> (vino-server for example), or to conflict with X11 (starting at po

[libvirt] [PATCH] Use port range 5901-5999 if not set in qemu.conf, avoid port 5900

2017-04-21 Thread Christophe de Dinechin
qemu.conf, there is no reason not to allow ports 1024-5900 (system ports are below 1024). Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1442235 Signed-off-by: Christophe de Dinechin --- src/qemu/qemu_conf.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src