On 5/3/23 06:07, Andrea Bolognani wrote:
On Fri, Apr 28, 2023 at 02:15:04PM -0300, Daniel Henrique Barboza wrote:
On 4/28/23 12:40, Andrea Bolognani wrote:
On Thu, Apr 27, 2023 at 06:04:10PM -0300, Daniel Henrique Barboza wrote:
At this moment it is not possible to launch a 'riscv64
to the RISC-V driver to allow for CPU
definitions to be declared in RISC-V domains. This API was copied from
the ARM driver (virCPUarmUpdate()) since it's a good enough
implementation to get us going.
Signed-off-by: Daniel Henrique Barboza
---
po/POTFILES | 1 +
src/cpu/cpu_riscv64.c | 28
:
https://listman.redhat.com/archives/libvir-list/2023-April/239687.html
[1] https://listman.redhat.com/archives/libvir-list/2023-April/239687.html
Daniel Henrique Barboza (1):
cpu_riscv64.c: add update() implementation
po/POTFILES | 1 +
src/cpu/cpu_riscv64.c | 28
On 4/28/23 12:40, Andrea Bolognani wrote:
On Thu, Apr 27, 2023 at 06:04:10PM -0300, Daniel Henrique Barboza wrote:
At this moment it is not possible to launch a 'riscv64' domain of type
'qemu' (i.e. TCG) and machine 'virt' in a x86 host:
$ sudo ./run tools/virsh start riscv-virt1
error
Hi,
For some reason didn't notice this was broken until recently. We're
missing an API in the RISC-V CPU driver to allow QEMU TCG risc-v domains
to run in non-native hosts.
Daniel Henrique Barboza (1):
cpu_riscv64.c: add update() implementation
src/cpu/cpu_riscv64.c | 28
us started.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_riscv64.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/src/cpu/cpu_riscv64.c b/src/cpu/cpu_riscv64.c
index c44bdeb291..9796f8c967 100644
--- a/src/cpu/cpu_riscv64.c
+++ b/src/cpu
On 4/7/23 15:12, Andrea Bolognani wrote:
On Tue, Mar 28, 2023 at 04:46:45PM -0300, Daniel Henrique Barboza wrote:
On 3/22/23 13:37, Andrea Bolognani wrote:
On Wed, Mar 22, 2023 at 10:36:20AM -0300, Daniel Henrique Barboza wrote:
I'm not sure if the OS overwrites the firmware when running
On 3/22/23 13:37, Andrea Bolognani wrote:
On Wed, Mar 22, 2023 at 10:36:20AM -0300, Daniel Henrique Barboza wrote:
I'm not sure if the OS overwrites the firmware when running bare metal. Usually
they provide different OS images for QEMU/libvirt and bare metal systems,
probably
to account
On 3/22/23 10:05, Daniel P. Berrangé wrote:
On Wed, Mar 22, 2023 at 06:10:18AM -0300, Daniel Henrique Barboza wrote:
Today, trying to boot a RISC-V Fedora Rawhide image in a RISC-V QEMU domain
results in the following error:
error: Failed to start domain 'riscv-fedora'
error: internal
On 3/22/23 10:02, Andrea Bolognani wrote:
On Wed, Mar 22, 2023 at 09:32:21AM -0300, Daniel Henrique Barboza wrote:
On 3/22/23 06:42, Daniel Henrique Barboza wrote:
On 3/22/23 06:25, Daniel P. Berrangé wrote:
On Wed, Mar 22, 2023 at 06:10:18AM -0300, Daniel Henrique Barboza wrote
On 3/22/23 06:42, Daniel Henrique Barboza wrote:
On 3/22/23 06:25, Daniel P. Berrangé wrote:
On Wed, Mar 22, 2023 at 06:10:18AM -0300, Daniel Henrique Barboza wrote:
Today, trying to boot a RISC-V Fedora Rawhide image in a RISC-V QEMU domain
results in the following error:
error
On 3/22/23 06:25, Daniel P. Berrangé wrote:
On Wed, Mar 22, 2023 at 06:10:18AM -0300, Daniel Henrique Barboza wrote:
Today, trying to boot a RISC-V Fedora Rawhide image in a RISC-V QEMU domain
results in the following error:
error: Failed to start domain 'riscv-fedora'
error: internal
umption that we're
making in qemuFirmwareFillDomain(). Let's instead exit early in that
function if we're dealing with the loader type='none' scenario we're now
supporting: no firmware autoselection, loader->type == none,
loader->path == NULL.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_firmware.c | 10
dd a new loader type 'none' that, if no path is specified and we're not
use firmware autoselection, will tell QEMU that no default firmware
should be used:
(...)
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c| 5 +++--
src/conf/domain_validate.c
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 27f83e254d..3529c7a9c5 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -263,6 +263,13 @@ harddisk
Also add a qemuxml2argvtest to ensure that we're good.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 6
.../firmware-bios-none.riscv64-latest.args| 31 +++
tests/qemuxml2argvdata/firmware-bios-none.xml | 18
The pre-conditions of this format are (1) no loader->path and (2) only
manual autoselect. Everything else is already covered by libvirt as
corner cases of existing firmware features.
Daniel Henrique Barboza (4):
conf: add loader type 'none'
qemu: handle bios 'none' case in qemuFirmwareFillDo
On 1/24/23 11:03, Michal Prívozník wrote:
On 1/10/23 12:31, Daniel Henrique Barboza wrote:
Hi,
This series updates RISC-V QEMU caps that weren't being updated since
QEMU 5.0.0.
To do that I had to add a RISC-V stub driver in src/cpu to avoid test
failures after the caps update
Ping
On 1/10/23 08:31, Daniel Henrique Barboza wrote:
Hi,
This series updates RISC-V QEMU caps that weren't being updated since
QEMU 5.0.0.
To do that I had to add a RISC-V stub driver in src/cpu to avoid test
failures after the caps update. This is a very bare-bone driver that
is basically
'domaincapstest' are currently skipping RISC-V tests. Let's enable it.
The decision of enabling the "virt" machine is based on the idea that
this is the most used QEMU RISC-V machine in the community and it's the
most likely to be widely supported in the long run.
Signed-off-by: Danie
e a RISC-V driver yet.
Add a barebone RISC-V driver to allow tests to be executed. The only 2
callbacks implemented here are 'compare' and 'validateFeatures', both
acting as a no-op. More callbacks and features will be added in the
future.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu.c
'virt' machine type in
domaincapstest.c to increase the test coverage for the architecture.
Daniel Henrique Barboza (3):
src/cpu: add a basic RiscV64 cpu driver
tests: update RISC-V QEMU caps for QEMU 8.0.0
tests: add QEMU RISC-V "virt" machine in domaincapstest
src
On 10/13/22 08:02, Michal Prívozník wrote:
On 9/19/22 18:39, Daniel Henrique Barboza wrote:
Hi,
This series updates the remaining pseries tests in qemuxml2argvtest.c to
use CAPS_LATEST instead of using a capability list for each test.
First patch is the usual capability bump for the new
Ping
On 9/19/22 13:39, Daniel Henrique Barboza wrote:
Hi,
This series updates the remaining pseries tests in qemuxml2argvtest.c to
use CAPS_LATEST instead of using a capability list for each test.
First patch is the usual capability bump for the new QEMU release.
Second patch converts
support for it. The XML
being used for each test can be simplified to just declare a single
feature. In the end we'll end up with more XML lines, but less
complexity inside qemuxml2argvtest.c.
Signed-off-by: Daniel Henrique Barboza
---
.../qemuxml2argvdata/pseries-features-ccf.xml | 15
.
A notable expection were tests pseries-console-native,
pseries-serial-compat and pseries-serial+console-native. These are
aliases of the pseries-serial-native tests. In this case we needed to
re-create the symlink accordingly.
Signed-off-by: Daniel Henrique Barboza
---
...s.args => pser
Henrique Barboza (3):
tests: qemucapabilities: bump ppc64 caps with qemu 7.1.0
tests: change qemuxml2argv pseries tests to TEST_CAPS_LATEST
tests: refactor pseries features parse failure tests
tests/domaincapsdata/qemu_7.1.0.ppc64.xml | 147 +
.../caps_7.1.0.ppc64.replies
On 5/24/22 10:47, Andrea Bolognani wrote:
On Tue, May 24, 2022 at 10:02:41AM -0300, Daniel Henrique Barboza wrote:
+++ b/tests/qemuxml2argvdata/pseries-cpu-compat-power10.xml
+
+ /usr/bin/qemu-system-ppc64
+
+
+
spapr-vio is the default for pseries VMs, so you
Add POWER10 as a supported cpu model.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel Henrique Barboza
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build | 1 +
src/cpu_map/ppc64_POWER10.xml | 6 ++
tests
Update NEWS.rst with the now added Power10 processor support.
Signed-off-by: Daniel Henrique Barboza
---
NEWS.rst | 4
1 file changed, 4 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index de1b9ca407..b0d4297d53 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -22,6 +22,10 @@ v8.4.0 (unreleased
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 8 ++--
...eries-cpu-compat-power10.ppc64-latest.args | 34 +++
...series-cpu-compat-power10.ppc64-latest.err | 1 +
.../pseries-cpu-compat-power10.xml| 21 ++
tests
Changes from v2:
- rebased with current master
- patch 2:
- added qemuxml2xmltest
- all tests are now using DO_TEST_CAPS_ARCH_LATEST()
- new patch 3: added NEWS.rst update
- v2 link: https://listman.redhat.com/archives/libvir-list/2022-May/230746.html
Daniel Henrique Barboza (3):
cpu_map
On 5/24/22 06:21, Andrea Bolognani wrote:
On Fri, May 20, 2022 at 05:49:53PM -0300, Daniel Henrique Barboza wrote:
On 5/19/22 04:44, Andrea Bolognani wrote:
On Tue, May 17, 2022 at 05:32:56PM -0300, Daniel Henrique Barboza wrote:
On 5/12/22 04:52, Andrea Bolognani wrote:
Don't forget
On 5/23/22 07:39, Martin Kletzander wrote:
On Sat, May 21, 2022 at 01:59:05PM -0300, Daniel Henrique Barboza wrote:
qemuxml2xmltests that have "pseries" in the name now use the
DO_TEST_CAPS_LATEST_ARCH() macro.
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Martin
Pushed fixing the typo in patch 2. Thanks!
Daniel
On 5/20/22 17:47, Daniel Henrique Barboza wrote:
Hi,
This series attempts to fix a problem I found when converting the
"pseries-cpu-compat-power9" to use DO_TEST_CAPS_ARCH_LATEST* macros.
More information about the problem per se ca
qemuxml2xmltests that have "pseries" in the name now use the
DO_TEST_CAPS_LATEST_ARCH() macro.
Signed-off-by: Daniel Henrique Barboza
---
...ies.xml => panic-pseries.ppc64-latest.xml} | 5 +-
.../pseries-console-native.ppc64-latest.xml | 1 +
.../pseries-conso
On 5/19/22 04:44, Andrea Bolognani wrote:
On Tue, May 17, 2022 at 05:32:56PM -0300, Daniel Henrique Barboza wrote:
On 5/12/22 04:52, Andrea Bolognani wrote:
Don't forget to add the new test case to qemuxml2xmltest too.
It would be great if, as a follow-up, you could look into converting
quot;pseries-cpu-compat-power9".
Signed-off-by: Daniel Henrique Barboza
---
tests/qemuxml2argvtest.c | 18 ++
tests/testutilsqemu.c| 4
tests/testutilsqemu.h| 18 +-
3 files changed, 27 insertions(+), 13 deletions(-)
diff --git a/tests/qe
for the Power10 chip.
Signed-off-by: Daniel Henrique Barboza
---
...eries-cpu-compat-power9.ppc64-latest.args} | 12 ++
...series-cpu-compat-power9.ppc64-latest.err} | 0
tests/qemuxml2argvtest.c | 23 +++
3 files changed, 20 insertions(+), 15 deletions
Fix identation of virQEMUCapsUpdateHostCPUModel() params.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capspriv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_capspriv.h b/src/qemu/qemu_capspriv.h
index f4f4a99d32..26bf2d3571 100644
--- a/src
ix I found out when reading code.
Daniel Henrique Barboza (3):
qemu_capspriv.h: fix identation
testutilsqemu: introduce ARG_CAPS_HOST_CPU_MODEL
qemuxml2argvtest.c: use CAPS_ARCH_LATEST() with
pseries-cpu-compat-power9
src/qemu/qemu_capspriv.h | 4 +-
...eries-
On 5/12/22 04:52, Andrea Bolognani wrote:
On Thu, May 05, 2022 at 05:26:14PM -0300, Daniel Henrique Barboza wrote:
+++ b/tests/qemuxml2argvtest.c
@@ -2209,6 +2209,17 @@ mymain(void)
QEMU_CAPS_DEVICE_SPAPR_VTY);
qemuTestSetHostCPU(, driver.hostarch, NULL
On 5/9/22 10:30, Andrea Bolognani wrote:
On Mon, May 09, 2022 at 07:27:57AM -0300, Daniel Henrique Barboza wrote:
On 5/9/22 07:00, Andrea Bolognani wrote:
Would you be okay with something like
There are no major changes since 7.0.0-rc2, but a few additional
features are enabled
On 5/9/22 07:00, Andrea Bolognani wrote:
On Fri, May 06, 2022 at 04:54:22PM -0300, Daniel Henrique Barboza wrote:
No relevant changes since the last update from 7.0.0-rc2. Sending it so
we're sure that we don't need to worry about ppc64 caps for the 7.0.0
release anymore
Hi,
Sending this patch per Andrea's suggestion in the v1 review.
Changes in v2:
- create the caps using a P9 host with lots and lots of extra libraries
and QEMU features enabled
- v1 link: https://listman.redhat.com/archives/libvir-list/2022-May/230686.html
Daniel Henrique Barboza (1):
tests
On 5/6/22 04:51, Andrea Bolognani wrote:
On Thu, May 05, 2022 at 05:17:42PM -0300, Daniel Henrique Barboza wrote:
On 5/5/22 03:59, Peter Krempa wrote:
On Wed, May 04, 2022 at 14:27:16 -0300, Daniel Henrique Barboza wrote:
Most significant changes happened in the ppc64-latest.args files
Add POWER10 as a supported cpu model.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build | 1 +
src/cpu_map/ppc64_POWER10.xml | 6 ++
tests/domaincapsdata/qemu_5.0.0.ppc64.xml
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 8 ++---
.../pseries-cpu-compat-power10.args | 32 +++
.../pseries-cpu-compat-power10.err| 1 +
.../pseries-cpu-compat-power10.xml| 21
Changes in v2:
- dropped former patch 01 since qemu ppc64 caps are up to date for 7.0.0
- v1 link: https://listman.redhat.com/archives/libvir-list/2022-May/230686.html
Daniel Henrique Barboza (2):
cpu_map: add POWER10 cpu model
cpu_ppc64: add support for host-model on POWER10
src/cpu
On 5/5/22 03:59, Peter Krempa wrote:
On Wed, May 04, 2022 at 14:27:16 -0300, Daniel Henrique Barboza wrote:
Most significant changes happened in the ppc64-latest.args files with
the removal of the '-sandbox' option.
That's because you probably built qemu without seccomp support
On 5/5/22 03:59, Peter Krempa wrote:
On Wed, May 04, 2022 at 14:27:16 -0300, Daniel Henrique Barboza wrote:
Most significant changes happened in the ppc64-latest.args files with
the removal of the '-sandbox' option.
That's because you probably built qemu without seccomp support
Signed-off-by: Daniel Henrique Barboza
---
src/cpu/cpu_ppc64.c | 8 ++---
.../pseries-cpu-compat-power10.args | 32 +++
.../pseries-cpu-compat-power10.err| 1 +
.../pseries-cpu-compat-power10.xml| 21
Hi,
Small series to update ppc64 caps after the 7.0.0 release and to add
support for the recently released IBM POWER10 chip.
Daniel Henrique Barboza (3):
tests: qemucapabilities: update ppc64 qemu caps for 7.0.0 release
cpu_map: add POWER10 cpu model
cpu_ppc64: add support for host-model
Add POWER10 as a supported cpu model.
Signed-off-by: Daniel Henrique Barboza
---
src/cpu_map/index.xml | 1 +
src/cpu_map/meson.build | 1 +
src/cpu_map/ppc64_POWER10.xml | 6 ++
tests/domaincapsdata/qemu_5.0.0.ppc64.xml
that are pending review/acks are patches 14,
17, 19, 20, 22, 23 and 24.
v2 link:
https://listman.redhat.com/archives/libvir-list/2022-January/msg01149.html
Daniel Henrique Barboza (29):
qemu_domain.c: add PowerNV machine helpers
qemu_capabilities.c: use 'MachineIsPowerPC' in DeviceDiskCaps
qemu_domain
This device is an implementation of pcie-root-port, similar to its
sibling pnv-phb3-root-port. Since it's a new model name that Libvirt
automatically sets, we refrain from documenting it to users.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
docs/schemas/domaincommon.rng
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
.../powernv8-root-port.ppc64-latest.args | 35 +
tests/qemuxml2argvdata/powernv8-root-port.xml | 17
tests/qemuxml2argvtest.c | 1 +
.../powernv8-root-port.ppc64-latest.xml
that will allow for an
element to always be formatted regardless of
virPCIDeviceAddressIsEmpty() mechanics/semantics. Then we use this flag
when formatting pnv-phb3-root-port devices.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 25 -
src/conf/domain_conf.h | 2
If ommited from the controller definition, chip-id defaults to zero.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain_address.c | 16 +++-
src/qemu/qemu_validate.c | 5 +
.../powernv8-basic.ppc64
We're going to use the 'targetIndex' element for PowerNV PHBs. Clarify
that the same attribute will have a different meaning in this context.
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.rst | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs
The 'chip-id' attribute indicates which chip/socket that owns the
PowerNV pcie-root controller.
Reviewed-by: Ján Tomko
Reviewed-by: Peter Krempa
Signed-off-by: Daniel Henrique Barboza
---
docs/formatdomain.rst | 6 ++
docs/schemas/domaincommon.rng | 5 +
src/conf
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 19 +++
src/conf/domain_conf.h | 1 +
src/libvirt_private.syms | 1 +
3 files changed, 21 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 44327e2abb
.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_domain_address.c | 5 +
src/qemu/qemu_validate.c | 12 +++-
5 files changed, 19
wed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 56 +-
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 06d1294797..955bb36d9f 100644
--- a/src/c
Similar to the existing pnv-phb3 device, pnv-phb4 is also an
implementation of pcie-root. No user doc is needed in this case since
the user doesn't ideally set PCI model names manually.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
docs/schemas/domaincommon.rng | 1 +
src
Add support for the pcie-root implementation that PowerNV8 domains uses,
pnv-phb3.
It consists of a PCI model name that isn't supposed to be changed by
users, so no doc changes in formatdomain.rst were made.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
docs/schemas
Both PowerNV and pSeries machines don't support parallel ports.
Reviewed-by: Ján Tomko
Reviewed-by: Peter Krempa
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_validate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu
Update the virDomainControllerIsPowerNVPHB() helper to make the pnv-phb4
device receive the same handling as the existing pnv-phb3.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src
Since the nuances of PowerNV PHBs and root ports were already handled
when adding support for pnv-phb3* devices, we're already set to support
PowerNV9 PHBs and root ports as well.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
.../powernv9-dupPHBs.ppc64-latest.err
Make the virDomainControllerIsPowerNVRootPort() helper recognize
pnv-phb4-root-port as a PowerNV root port. This will spare us from
duplicating checks where the constraints of pnv-phb3-root-port also
applies for the pnv-phb4-root-port device.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique
Add 'virt type' to allow for an easier time debugging.
Reviewed-by: Ján Tomko
Reviewed-by: Peter Krempa
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_validate.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu
driver wasn't really tested with the PowerNV kernel.
Reviewed-by: Ján Tomko
Reviewed-by: Peter Krempa
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c81c63369c
The PowerNV machines uses ISA as the default serial type.
Reviewed-by: Ján Tomko
Reviewed-by: Peter Krempa
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 0352cad985
These devices must have unique targetIndex/chip-id pairs.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c| 35 +++
tests/qemuxml2argvdata/powernv8-dupPHBs.err | 1 +
.../powernv8-dupPHBs.ppc64-latest.err | 1 +
tests
ate(). This is
enough to allow for a root port to be added in slot 0 of a pnv-phb3
bus while not being intrusive with existing devices.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain_address.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/q
are patches 14,
17, 19, 20, 22, 23 and 24.
v2 link:
https://listman.redhat.com/archives/libvir-list/2022-January/msg01149.html
Daniel Henrique Barboza (29):
qemu_domain.c: add PowerNV machine helpers
qemu_capabilities.c: use 'MachineIsPowerPC' in DeviceDiskCaps
qemu_domain: turn
is available since 5.0.0, meaning that we
need to check QEMU version and arch manually before setting it.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c| 6 +-
src/qemu/qemu_capabilities.h| 1 +
tests/qemucapabilitiesdata/caps_5.0.0
.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_validate.c| 5 ++-
src/qemu/qemu_domain.c| 2 +-
src/qemu/qemu_validate.c | 5 +++
.../powernv8-two-sockets.ppc64-latest.args| 35 +
.../qemuxml2argvdata
The command line for the pnv-phb3 device is similar to the
spapr-pci-host-bridge command line but adding the extra 'chip-id'
attribute.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_command.c | 21 +--
.../powernv8
As done with the 'chip-id' attribute, use zero as a default
targetIndex value for pnv-phb3 devices in case it's absent
from the controller definition.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain_address.c| 2 ++
src/qemu/qemu_validate.c
. This means that probing it as
default will be misleading for users. Instead, let's use
virQEMUCapsInitQMPVersionCaps() to check for the adequate QEMU version
and arch, clearing the capability if necessary.
Suggested-by: Peter Krempa
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
The function is now unused outside of qemu_domain.c.
Reviewed-by: Ján Tomko
Reviewed-by: Peter Krempa
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c b
Both pSeries and PowerNV machines don't have floppy device support.
Reviewed-by: Ján Tomko
Reviewed-by: Peter Krempa
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_capabilities.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b
a 'qemuDomainIsPowerPC' helper that will be used in those
instances.
[1] https://open-power.github.io/skiboot/doc/overview.html
Reviewed-by: Ján Tomko
Reviewed-by: Peter Krempa
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 36
src/qemu/qemu_domain.h
We're now able to boot a simple PowerNV8 domain in libvirt.
Reviewed-by: Ján Tomko
Signed-off-by: Daniel Henrique Barboza
---
.../powernv8-basic.ppc64-latest.args | 33 +++
tests/qemuxml2argvdata/powernv8-basic.xml | 16 +
tests/qemuxml2argvtest.c
On 2/21/22 10:21, Ján Tomko wrote:
On a Tuesday in 2022, Daniel Henrique Barboza wrote:
We're going to use the 'targetIndex' element for PowerNV PHBs. Clarify
that the same attribute will have a different meaning in this context.
Signed-off-by: Daniel Henrique Barboza
---
docs
On 2/21/22 10:36, Ján Tomko wrote:
On a Tuesday in 2022, Daniel Henrique Barboza wrote:
Hiding the empty (:00:0.0) PCI address in the case of devices that
will connect to slot 0x0 can be counterintuitive to the user, which will
see something like this:
Even
On 2/21/22 10:07, Ján Tomko wrote:
On a Tuesday in 2022, Daniel Henrique Barboza wrote:
QEMU_CAPS_DEVICE_PNV_PHB3 indicates binary support for the pnv-phb3
device, the pcie-root controller for PowerNV8 domains, and also
the pnv-phb3-root-port device, its pcie-root-port device
On 2/21/22 09:47, Ján Tomko wrote:
On a Tuesday in 2022, Daniel Henrique Barboza wrote:
The PowerNV (Power Non-Virtualized) QEMU ppc64 machine is the emulation
of a bare-metal IBM Power host. It follows the OPAL (OpenPower
Abstration Layer) API/ABI, most specifically Skiboot [1]. For now
Ping
On 1/25/22 17:48, Daniel Henrique Barboza wrote:
Hi,
This v2 has changes proposed by Peter and Daniel on the v1
review. Peter's reviewed-by tags were kept when applicable.
The usability change made is that, now, we'll fail to launch powernv
domains that has a pnv-phb* device and it's
is
not. In fact, it's wrong from conceptual POV. We still want
threads working on the object tu mutually exclude each other.
Signed-off-by: Michal Privoznik
---
Reviewed-by: Daniel Henrique Barboza
v2 of:
https://listman.redhat.com/archives/libvir-list/2022-February/msg00036.html
diff to v1
14 (new):
* added documentation of the different semantics 'targetIndex' will have
for PowerNV PHBs
- several other minor changes suggested by Peter
- v1 link:
https://listman.redhat.com/archives/libvir-list/2022-January/msg00902.html
Daniel Henrique Barboza (29):
qemu_domain.c: add
On 1/27/22 11:05, Michal Prívozník wrote:
On 1/27/22 14:57, Daniel Henrique Barboza wrote:
On 1/26/22 06:29, Michal Privoznik wrote:
v2 of:
https://listman.redhat.com/archives/libvir-list/2022-January/msg0.html
Patches 1/3 and 2/3 were ACKed but I'm sending them for completeness
On 1/26/22 06:29, Michal Privoznik wrote:
v2 of:
https://listman.redhat.com/archives/libvir-list/2022-January/msg0.html
Patches 1/3 and 2/3 were ACKed but I'm sending them for completeness.
Back when I've added this UNASSIGNED address type I was also pursuing a PCI
multifunction
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 21 +
src/conf/domain_conf.h | 1 +
src/libvirt_private.syms | 1 +
3 files changed, 23 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 803c51d63a..13d5eb5b9d 100644
ate(). This is
enough to allow for a root port to be added in slot 0 of a pnv-phb3
bus while not being intrusive with existing devices.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain_address.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/q
Make the virDomainControllerIsPowerNVRootPort() helper recognize
pnv-phb4-root-port as a PowerNV root port. This will spare us from
duplicating checks where the constraints of pnv-phb3-root-port also
applies for the pnv-phb4-root-port device.
Signed-off-by: Daniel Henrique Barboza
---
src/conf
Since the nuances of PowerNV PHBs and root ports were already handled
when adding support for pnv-phb3* devices, we're already set to support
PowerNV9 PHBs and root ports as well.
Signed-off-by: Daniel Henrique Barboza
---
.../powernv9-dupPHBs.ppc64-latest.err | 1 +
tests
Similar to the existing pnv-phb3 device, pnv-phb4 is also an
implementation of pcie-root. No user doc is needed in this case since
the user doesn't ideally set PCI model names manually.
Signed-off-by: Daniel Henrique Barboza
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c
Signed-off-by: Daniel Henrique Barboza
---
.../powernv8-root-port.ppc64-latest.args | 35 +
tests/qemuxml2argvdata/powernv8-root-port.xml | 17
tests/qemuxml2argvtest.c | 1 +
.../powernv8-root-port.ppc64-latest.xml | 39
1 - 100 of 1918 matches
Mail list logo
