Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

On Wed, Jan 24, 2018 at 04:14:54PM +0100, Jiri Denemark wrote: > pushed. In other words, having Reviewed-by in the commit message is nice > for generating statistics for KVM Forum keynotes, once the patch gets > out of our git repository (i.e., is backported to a downstream), or when BTW, when

Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

On Wed, Jan 24, 2018 at 02:59:17PM +0100, Ján Tomko wrote: > > > + a "Signed-off-by" line to every commit message. The presence > > "line containing the contributor's name and e-mail" maybe? > I presume just 'Signed-off-by' is not enough for the "legal snake oil", > even though it's all

[libvirt] [PATCH] libxl: add explicit linkage to xenstore library

The libxl driver calls a couple of xenstorage APIs, so it must explicitly link to this library rather than rely on indirect linkage via libxl or other xen libraries. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- m4/virt-driver-libxl.m4 | 4 ++-- 1 file changed, 2 insertions

[libvirt] [PATCH v2 10/11] logd: add support for admin protocol in virtlogd

Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd daemon and define a virtlogd:///{system,session} URI scheme for connecting to it. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/Makefile.am | 1 + src/libvirt-a

[libvirt] [PATCH v2 09/11] rpc: refactor virNetServer setup for post-exec restarts

int he JSON state doc. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/libvirt_remote.syms | 1 - src/locking/lock_daemon.c | 41 + src/logging/log_daemon.c | 41 + src/rpc/virnetdaemon.c| 151 -

[libvirt] [PATCH v2 03/11] admin: add support for post-exec restart callbacks

We don't have any per-client private data we need to persist, but the RPC infrastructure requires that we provide the callbacks and serialize an empty JSON object. This makes us future proof going forwards. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src

[libvirt] [PATCH v2 04/11] util: add virGetUNIXSocketPath helper

When receiving multiple socket FDs from systemd, it is critical to know what socket address each corresponds to so we can setup the right protocols on each. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/libvirt_private.syms | 1 + src/util/virutil.c

[libvirt] [PATCH v2 02/11] libvirtd: rename virNetServerClient callback impls to match type names

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- daemon/libvirtd.c | 8 daemon/remote.c | 6 +++--- daemon/remote.h | 6 +++--- src/admin/admin_server_dispatch.c | 6 +++--- src/admin/admin_server_dispatch.h | 4 ++-- 5

[libvirt] [PATCH v2 01/11] admin: move admins server impl/dispatch into src/admin directory

The admin server functionality is a generic concept that should be wired up into all libvirt daemons, but is currently integrated with the libvirtd code. Move it all into the src/admin directory to prepare for broader reuse. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .git

[libvirt] [PATCH v2 00/11] Add admin protocol support for virtlogd/virtlockd

The initial admin protocol support was only integrated into libvirtd. This series extracts that code so that it is reusable with all the daemons we have (and more than we'll get). In v2: - Fixed completely broken post-exec restart support for admin servers - Misc fixes from v1 review Daniel P

[libvirt] [PATCH v2 11/11] lockd: add support for admin protocol in virtlockd

Add a virtlockd-admin-sock can serves the admin protocol for the virtlockd daemon and define a virtlockd:///{system,session} URI scheme for connecting to it. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- cfg.mk| 1 - src/Makef

[libvirt] [PATCH v2 06/11] rpc: pass virNetServer to post-exec restart callback in typesafe manner

, removing the confusion of passing two distinct 'void *' pointers to one method. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/rpc/virnetserver.c| 6 +++--- src/rpc/virnetserverclient.c | 14 +++--- src/rpc/virnetserverclient.h | 9 ++--- s

[libvirt] [PATCH v2 07/11] rpc: annotate various parameters as being required to be non-NULL

The server name and client data callbacks need to be non-NULL or the system will crash at various times. This is particularly bad when some of the crashes only occur post-exec restart. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/rpc/virnetserver.h | 7 +-- s

[libvirt] [PATCH v2 08/11] rpc: add method for checking if a named server exists

It is not possible to blindly call virNetDaemonGetServer() because in a post-exec restart scenario, some servers may not exist and this method will pollute the error logs. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/libvirt_remote.syms | 1 + src/rpc/virnetdaemon.c

[libvirt] [PATCH v2 05/11] rpc: clarify "void *" values passed to client callbacks

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/rpc/virnetserverclient.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/rpc/virnetserverclient.h b/src/rpc/virnetserverclient.h index 0fa8745191..14ace9e522 100644 --- a/src/rpc/virnetserverclient.h +++ b/s

Re: [libvirt] [dbus PATCH v2] main: add support for all usable libvirt drivers

> +{ "openvz:///system", "/org/libvirt/OpenVZ" }, > +{ "qemu:///system", "/org/libvirt/QEMU" }, > +{ "test:///default","/org/libvirt/Test" }, > +{ "uml:///system", "

Re: [libvirt] [dbus RFC 11/11] main: add support for all libvirt drivers

On Tue, Jan 23, 2018 at 12:37:53PM +0100, Pavel Hrdina wrote: > On Tue, Jan 23, 2018 at 10:12:26AM +0000, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > >

Re: [libvirt] [dbus RFC 00/11] improve libvirt connections handling

On Mon, Jan 22, 2018 at 06:15:58PM +0100, Pavel Hrdina wrote: > This patch series is a proposal to how to implement libvirt connections > in the libvirt D-Bus binding. The design is based on a discussion with > Daniel and it should follow D-Bus convention. > > Each connection is represented as

Re: [libvirt] [dbus RFC 11/11] main: add support for all libvirt drivers

On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/main.c | 26 ++ > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/src/main.c b/src/main.c > index 14c7c18..6421919 100644 > ---

Re: [libvirt] [dbus RFC 10/11] main: implement multiple connection within one daemon

a <phrd...@redhat.com> > --- > src/connect.c | 17 +++-- > src/connect.h | 4 +++- > src/main.c | 55 > ++--- > test/libvirttest.py | 4 ++-- > 4 files changed, 55 insertions(+), 25 delet

Re: [libvirt] [dbus RFC 09/11] domain: derive domain path from connect path

til.h| 6 -- > 6 files changed, 68 insertions(+), 35 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop1

Re: [libvirt] [dbus RFC 07/11] connect: move domain related code to domain.c

On Mon, Jan 22, 2018 at 06:16:05PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/connect.c | 7 ++- > src/connect.h | 2 ++ > src/domain.c | 7 +++ > 3 files changed, 11 insertions(+), 5 deletions(-) Reviewed-by: D

Re: [libvirt] [dbus RFC 08/11] connect: store connect path in connect structure

src/connect.h | 1 + > src/events.c | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] [dbus RFC 05/11] connect: don't use default libvirt authentication callback

to virConnectOpen(), so people only need to use OpenAuth() when they have a genuine callback to provide > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/connect.c | 32 +++- > 1 file changed, 31 insertions(+), 1 deletion(-) Revi

Re: [libvirt] [dbus RFC 06/11] connect: implement reconnect functionality to libvirt

virConnectDomainEventDeregisterAny(connect->connection, > connect->callback_ids[i]); > -} > - > -virConnectClose(connect->connection); > -} > +if (connect->connection) > +virtDBusConnectClose(connect, true); > > free(connect

Re: [libvirt] [dbus RFC 04/11] connect: implement lazy connection

+ > 2 files changed, 36 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |:

Re: [libvirt] [dbus RFC 03/11] src: rename manager to connect

> connect.c} (64%) > rename src/{manager.h => connect.h} (53%) > rename test/{test_manager.py => test_connect.py} (79%) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https:

Re: [libvirt] [dbus RFC 01/11] util: introduce VIRT_ARRAY_CARDINALITY macro

sageAppendTypedParameters(sd_bus_message *message, Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Though if I was naming this again in libvirt I would follow glib and call it VIR_N_ELEMENTS as it way shorter & easier to spell than the word CARDINALITY :-) Your call ! Regards, Daniel

Re: [libvirt] [dbus RFC 02/11] util: introduce virtDBusUtilSetError helper

On Mon, Jan 22, 2018 at 06:16:00PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/util.c | 7 +++ > src/util.h | 4 > 2 files changed, 11 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> R

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

Of course, I could also just > say ACK, but the R-b seems so much more authoritative. FWIW, in emacs I have some macros that make it quick to type the long statements, since it is so commonly needed in QEMU (define-abbrev-table 'global-abbrev-table '( ("8rev" "Reviewed

Re: [libvirt] [PATCH] apparmor: allow libvirt to send term signal to unconfined

On Mon, Jan 22, 2018 at 10:25:38AM -0700, Jim Fehlig wrote: > On 01/17/2018 08:34 AM, Guido Günther wrote: > > Otherwise stopping domains with qemu://session fails like > > > > [164012.338157] audit: type=1400 audit(1516202208.784:99): > > apparmor="DENIED" operation="signal"

Re: [libvirt] [PATCH 0/4] Add admin protocol support for virtlogd/virtlockd

On Mon, Jan 22, 2018 at 04:44:10PM +0100, Michal Privoznik wrote: > On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > > The initial admin protocol support was only integrated into libvirtd. > > This series extracts that code so that it is reusable with all the > > daemons w

Re: [libvirt] [PATCH 3/4] logd: add support for admin protocol in virtlogd

On Mon, Jan 22, 2018 at 04:44:13PM +0100, Michal Privoznik wrote: > On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > > Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd > > daemon and define a virtlogd:///{system,session} URI scheme for

Re: [libvirt] [PATCH] qemu: Don't initialize struct utsname

On Mon, Jan 22, 2018 at 03:12:46PM +0100, Jiri Denemark wrote: > On Mon, Jan 22, 2018 at 14:01:26 +0000, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote: > > > It breaks the build and it is not really useful for anything. > >

Re: [libvirt] [PATCH] qemu: Don't initialize struct utsname

On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote: > It breaks the build and it is not really useful for anything. Why does that break the build ? "{ 0 }" is a valid initializer for any struct according to the C standards. > > Signed-off-by: Jiri Denemark >

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

; This extends the update hook so that it enforces a requirement to have a > > > > Signed-off-by line in every commit message. This can be optionally > > > > turned off in individual repos by setting the "hooks.allowmissingsob" > > > > git config varia

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 02:24:40PM +0100, Ján Tomko wrote: > On Mon, Jan 22, 2018 at 12:42:47PM +0000, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote: > > > On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: > > >

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 02:28:42PM +0100, Martin Kletzander wrote: > On Mon, Jan 22, 2018 at 12:57:31PM +0000, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 01:54:28PM +0100, Martin Kletzander wrote: > > > On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

> > turned off in individual repos by setting the "hooks.allowmissingsob" > > git config variable. > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > update | 16 +++- > > 1 file changed, 15 insertions(+)

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 01:54:28PM +0100, Martin Kletzander wrote: > On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote: > > On 01/22/2018 01:22 PM, Daniel P. Berrange wrote: > > > On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote: > > > &

[libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

the contribution. This puts the project in a stronger position should any questions around contributions be raised going forward in the future. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/hacking.html.in | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

Re: [libvirt] [PATCH] qemu: Refresh caps cache after booting a different kernel

On Mon, Jan 22, 2018 at 01:31:21PM +0100, Jiri Denemark wrote: > On Mon, Jan 22, 2018 at 10:57:57 +0000, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 11:46:14AM +0100, Jiri Denemark wrote: > > > Whenever a different kernel is booted, some capabilities related to KVM &g

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote: > On Mon, Jan 22, 2018 at 12:05:19PM +0000, Daniel P. Berrange wrote: > > This extends the update hook so that it enforces a requirement to have a > > Signed-off-by line in every commit message. This can be optionally

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote: > On Thu, Jan 18, 2018 at 10:16:55AM +0100, Ján Tomko wrote: > > After the latest CPU additions, the build fails with clang: > > cputest.c:905:1: error: stack frame size of 26136 bytes > > in function 'mymain'

[libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

This extends the update hook so that it enforces a requirement to have a Signed-off-by line in every commit message. This can be optionally turned off in individual repos by setting the "hooks.allowmissingsob" git config variable. Signed-off-by: Daniel P. Berrange <berra.

[libvirt] [PATCH hooks 0/1] Enforce requirement for Signed-off-by line

repository that contains the original git repository update hook Eric provided years back. This commit then augments that hook to add the Signed-off-by check. The updated hook gets automatically installed on the server when we push to this repo. Daniel P. Berrange (1): Add check for Signed-off

Re: [libvirt] [PATCH] qemu: Refresh caps cache after booting a different kernel

gt; @@ -37,6 +37,7 @@ virQEMUCapsNewForBinaryInternal(virArch hostArch, > uid_t runUid, > gid_t runGid, > unsigned int microcodeVersion, > +const char *kernelVers

[libvirt] [PATCH 1/4] admin: move admins server impl/dispatch into src/admin directory

The admin server functionality is a generic concept that should be wired up into all libvirt daemons, but is currently integrated with the libvirtd code. Move it all into the src/admin directory to prepare for broader reuse. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .git

[libvirt] [PATCH 4/4] lockd: add support for admin protocol in virtlockd

Add a virtlockd-admin-sock can serves the admin protocol for the virtlockd daemon and define a virtlockd:///{system,session} URI scheme for connecting to it. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- cfg.mk| 1 - src/Makef

[libvirt] [PATCH 3/4] logd: add support for admin protocol in virtlogd

Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd daemon and define a virtlogd:///{system,session} URI scheme for connecting to it. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/Makefile.am | 1 + src/libvirt-a

[libvirt] [PATCH 0/4] Add admin protocol support for virtlogd/virtlockd

The initial admin protocol support was only integrated into libvirtd. This series extracts that code so that it is reusable with all the daemons we have (and more than we'll get). Daniel P. Berrange (4): admin: move admins server impl/dispatch into src/admin directory util: add

Re: [libvirt] [PATCH] Add Eduardo Otubo to Planet Virt-Tools

updater/virt-tools/images/otubo.png | Bin 0 -> 10597 bytes > 2 files changed, 6 insertions(+) > create mode 100644 updater/virt-tools/images/otubo.png Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > diff --git a/updater/virt-tools/config.ini b/updater/virt-too

[libvirt] [PATCH v2 2/2] qemu: add support for generating SMBIOS OEM strings command line

This wires up the previously added OEM strings XML schema to be able to generate comamnd line args for QEMU. This requires QEMU >= 2.12 release containing this patch: commit 2d6dcbf93fb01b4a7f45a93d276d4d74b16392dd Author: Daniel P. Berrange <berra...@redhat.com> Date: Sat Oct 28

[libvirt] [PATCH v2 0/2] Support SMBIOS OEM strings

A followup to https://www.redhat.com/archives/libvir-list/2017-November/msg00720.html The QEMU patch is now merged (for next 2.12 release). Since v2: - Remove redundant error message report - Split QEMU from XML parts of patch Daniel P. Berrange (2): conf: add support for setting OEM

[libvirt] [PATCH v2 1/2] conf: add support for setting OEM strings SMBIOS data fields

of a application specific prefix as illustrated above is recommended, but not mandated, so that an app can reliably identify which of the many OEM strings are targetted at it. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- docs/formatdomain.html.in | 13 docs/s

Re: [libvirt] [PATCH] qemu: avoid denial of service reading from QEMU monitor (CVE-2018-xxxx)

On Wed, Jan 17, 2018 at 05:13:06PM +0100, Michal Privoznik wrote: > On 01/16/2018 06:01 PM, Daniel P. Berrange wrote: > > We read from QEMU until seeing a \r\n pair to indicate a completed reply > > or event. To avoid memory denial-of-service though, we must have a size > > li

Re: [libvirt] [PATCH] remove bogus casts of arg to g_object_ref

On Wed, Jan 17, 2018 at 02:43:17PM +, Daniel P. Berrange wrote: > Latest version of glib uses typeof() magic to cast the > return value of g_object_ref to match its argument, > instead of returning a 'void *'. A few places in the > code were casting the arg to G_OB

[libvirt] [PATCH] remove bogus casts of arg to g_object_ref

always redundant so just remove them. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-gconfig/libvirt-gconfig-object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-ob

[libvirt] New GIT repos for libvirt wiki & virt tools planet

Hi Folks, Just let you all know that I've moved various libvirt related websites over to hosting on Red Hat's OpenShift v3 infrastructure. With the new v3 that is based on Kubernetes, I'm able to publish the GIT repos containing the core content & software setup. For wiki.libvirt.org:

Re: [libvirt] [PATCH] spec: enable bash completion only on new enough distros

10 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-ht

Re: [libvirt] [jenkins-ci PATCH] guests: install bash-completion when building libvirt

| 4 > guests/vars/projects/libvirt.yml | 1 + > 2 files changed, 5 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

[libvirt] [PATCH] qemu: avoid denial of service reading from QEMU monitor (CVE-2018-xxxx)

unreasonable mem. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- src/qemu/qemu_monitor.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 046caf001c..85c7d68a13 100644 --- a/src/qemu/qemu_monitor.c +++ b/sr

Re: [libvirt] [PATCH perl] block_stats: Fix rd_req and wr_req compat hash keys

On Mon, Jan 15, 2018 at 07:50:10PM +0200, Ville Skyttä wrote: > When virDomainBlockStatsFlags with NULL params fails, the returned > read and write requests hash keys are said to be backwards compatible > with the key names success case. However, they were rd_reqs and > wr_reqs (in plural) as

Re: [libvirt] [PATCH perl] Spelling fixes

On Mon, Jan 15, 2018 at 07:29:59PM +0200, Ville Skyttä wrote: > --- > Changes | 4 ++-- > HACKING | 4 ++-- > lib/Sys/Virt.pm | 6 +++--- > lib/Sys/Virt/Domain.pm | 14 +++--- > lib/Sys/Virt/Interface.pm | 2 +- >

Re: [libvirt] [RFC PATCH 04/10] qemu: Introduce virTheadPoolDrain

On Mon, Jan 15, 2018 at 05:51:28PM +0100, Erik Skultety wrote: > On Wed, Jan 10, 2018 at 12:23:29PM -0500, John Ferlan wrote: > > Split up virThreadPoolFree to create a Drain function which will > > be called from virNetServerClose in order to ensure the various > > worker threads are removed

Re: [libvirt] [PATCH 3/3] m4: Check for rl_completion_quote_character

On Mon, Jan 15, 2018 at 02:20:01PM +0100, Andrea Bolognani wrote: > On Mon, 2018-01-15 at 13:31 +0100, Michal Privoznik wrote: > > > So, one way to solve this once and for all would be to: > > > > > > * try looking up readline through pkg-config. If that works, > > > then we already know

Re: [libvirt] [jenkins-ci PATCH] guests: Install libtirpc when building libvirt

> --- > guests/vars/mappings.yml | 4 > guests/vars/projects/libvirt.yml | 1 + > 2 files changed, 5 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberran

Re: [libvirt] [PATCH python 3/7] Add checks for min supported distros

On Fri, Jan 12, 2018 at 05:32:32PM +0100, Pavel Hrdina wrote: > On Fri, Jan 12, 2018 at 03:43:55PM +0000, Daniel P. Berrange wrote: > > On Fri, Jan 12, 2018 at 12:36:23PM +0100, Pavel Hrdina wrote: > > > On Thu, Jan 11, 2018 at 04:43:35PM +, Daniel P. Berrange wrote: >

[libvirt] [PATCH python v2 9/9] Use python*_sitearch macros instead of manually defining the dir

Note we use python_sitearch not python2_sitearch, since the former is more portable. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libvirt-python.spe

[libvirt] [PATCH python v2 7/9] Require libvirt native version matching py version by default

hon binding, since the generator may incorrectly handle new APIs. So use == instead of >= too. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 2 +- setup.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --g

[libvirt] [PATCH python v2 8/9] Fix filtering of RPM provides for .so files

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 5 + 1 file changed, 5 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 2dfc84a..f658496 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -54,7

[libvirt] [PATCH python v2 6/9] Turn on python3 sub-RPMs for RHEL > 7

It is expected that future RHEL-8 will have python3 by default, so enable that. It is unclear whether python2 will still be available, so leave that enabled for now. Reviewed-by: Pavel Hrdina <phrd...@redhat.com> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-py

[libvirt] [PATCH python v2 5/9] Adapt to rename of py2 RPMs from python- to python2- prefix

Reviewed-by: Pavel Hrdina <phrd...@redhat.com> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 12 1 file changed, 12 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index b667ebe..b13e961 100644 -

[libvirt] [PATCH python v2 3/9] Add checks for min supported distros

Be clear about which distros we aim to support with the specfile, so we know what we can cleanup in the spec later. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 16 1 file changed, 16 insertions(+) diff --git a/libvirt-python.spe

[libvirt] [PATCH python v2 2/9] Allow override of which sub-RPMs to build

Allow using rpmbuild --define "with_python2 0" to override the default logic about which python sub-RPMs to build Reviewed-by: Pavel Hrdina <phrd...@redhat.com> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 9 ++--- 1 file

[libvirt] [PATCH python v2 1/9] Allow disabling of python2 RPM build

. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 13 + 1 file changed, 13 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 4d0262d..5bbebeb 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -1,

[libvirt] [PATCH python v2 0/9] Various improvements to RPM spec

Daniel P. Berrange (9): Allow disabling of python2 RPM build Allow override of which sub-RPMs to build Add checks for min supported distros Add emacs mode marker to activate rpm-spec highlighting Adapt to rename of py2 RPMs from python- to python2- prefix Turn on python3 sub-RPMs

[libvirt] [PATCH python v2 4/9] Add emacs mode marker to activate rpm-spec highlighting

Reviewed-by: Pavel Hrdina <phrd...@redhat.com> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index a98b902..b667ebe 100644 --- a/libvirt-python.s

Re: [libvirt] [PATCH python 5/7] Adapt to rename of py2 RPMs from python- to python2- prefix

On Fri, Jan 12, 2018 at 12:31:46PM +0100, Pavel Hrdina wrote: > On Thu, Jan 11, 2018 at 04:43:37PM +0000, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > libvirt-python.spec.in | 12 > > 1 file change

Re: [libvirt] [PATCH python 1/7] Allow disabling of python2 RPM build

On Fri, Jan 12, 2018 at 03:42:57PM +, Daniel P. Berrange wrote: > On Fri, Jan 12, 2018 at 12:15:19PM +0100, Pavel Hrdina wrote: > > On Thu, Jan 11, 2018 at 04:43:33PM +0000, Daniel P. Berrange wrote: > > > With Fedora modularity, it is possible to have add-on repos for multi

Re: [libvirt] [PATCH python 3/7] Add checks for min supported distros

On Fri, Jan 12, 2018 at 12:36:23PM +0100, Pavel Hrdina wrote: > On Thu, Jan 11, 2018 at 04:43:35PM +0000, Daniel P. Berrange wrote: > > Be clear about which distros we aim to support with the specfile, so we know > > what we can cleanup in the spec later. > > Do w

Re: [libvirt] [PATCH python 1/7] Allow disabling of python2 RPM build

On Fri, Jan 12, 2018 at 12:15:19PM +0100, Pavel Hrdina wrote: > On Thu, Jan 11, 2018 at 04:43:33PM +0000, Daniel P. Berrange wrote: > > With Fedora modularity, it is possible to have add-on repos for multiple > > versions of python3. It is thus desirable to be able to build

Re: [libvirt] [jenkins-ci PATCH v2 0/2] guests: Make rpcgen mapping more future-proof

; > Andrea Bolognani (2): > guests: Fix package name for rpcgen > guests: Make rpcgen mapping more future-proof > > guests/vars/mappings.yml | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Seeing la

Re: [libvirt] [jenkins-ci PATCH] guests: Make rpcgen mapping more future-proof

On Fri, Jan 12, 2018 at 01:31:22PM +0100, Andrea Bolognani wrote: > Since whatever is in Fedora Rawhide will end up in future Fedora > releases, it makes sense to use the newer package as default and > override it for existing releases (as well as CentOS), so that > no tweaking will be needed when

Re: [libvirt] [PATCH 0/2] travis: Fix build failure

On Fri, Jan 12, 2018 at 12:43:58PM +0100, Andrea Bolognani wrote: > It would be nice to have all greens before the release :) > > Andrea Bolognani (2): > travis: Sync packages with libvirt-jenkins-ci > travis: Skip nfs-common installation Reviewed-by: Daniel P. Berrange <b

Re: [libvirt] [PATCH python 7/7] Require libvirt native version matching py version by default

On Thu, Jan 11, 2018 at 06:00:34PM +0100, Jiri Denemark wrote: > On Thu, Jan 11, 2018 at 16:43:39 +0000, Daniel P. Berrange wrote: > > Although we're capable of building against any libvirt >= 0.9.11, 99% of the > > time we want RPM builds to be done against matchi

Re: [libvirt] [PATCH python 5/7] Adapt to rename of py2 RPMs from python- to python2- prefix

On Thu, Jan 11, 2018 at 04:43:37PM +, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > libvirt-python.spec.in | 12 > 1 file changed, 12 insertions(+) > > diff --git a/libvirt-python.spec.in b/libvirt-python

[libvirt] [PATCH python 5/7] Adapt to rename of py2 RPMs from python- to python2- prefix

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 12 1 file changed, 12 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index b667ebe..cc5a5a5 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@

[libvirt] [PATCH python 7/7] Require libvirt native version matching py version by default

Although we're capable of building against any libvirt >= 0.9.11, 99% of the time we want RPM builds to be done against matching libvirt version, otherwise we might silently build against an unexpected/wrong version. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> ---

[libvirt] [PATCH python 6/7] Turn on python3 sub-RPMs for RHEL > 7

It is expected that future RHEL-8 will have python3 by default, so enable that. It is unclear whether python2 will still be available, so leave that enabled for now. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 2 +- 1 file changed, 1 insertion

[libvirt] [PATCH python 4/7] Add emacs mode marker to activate rpm-spec highlighting

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index a98b902..b667ebe 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -1,

[libvirt] [PATCH python 1/7] Allow disabling of python2 RPM build

. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 13 + 1 file changed, 13 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 4d0262d..5bbebeb 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -1,

[libvirt] [PATCH python 3/7] Add checks for min supported distros

Be clear about which distros we aim to support with the specfile, so we know what we can cleanup in the spec later. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 16 1 file changed, 16 insertions(+) diff --git a/libvirt-python.spe

[libvirt] [PATCH python 2/7] Allow override of which sub-RPMs to build

Allow using rpmbuild --define "with_python2 0" to override the default logic about which python sub-RPMs to build Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- libvirt-python.spec.in | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

[libvirt] [PATCH python 0/7] Misc improvements to RPM spec

Various improvements to the RPM spec to help future Fedora/RHEL maint Daniel P. Berrange (7): Allow disabling of python2 RPM build Allow override of which sub-RPMs to build Add checks for min supported distros Add emacs mode marker to activate rpm-spec highlighting Adapt to rename

[libvirt] [PATCH] rpm: updates wrt min required fedora version

Update the min fedora to 25. Use a macro to record the min versions so that the later error message is always in sync with the earlier version check. Clarify the comment that refers to guessing of dist which does not actually happen. Signed-off-by: Daniel P. Berrange <berra...@redhat.

Re: [libvirt] [PATCH] qemuDomainRemoveMemoryDevice: unlink() memory backing file

On Thu, Jan 11, 2018 at 01:24:57PM +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1461214 > > Since fec8f9c49af we try to use predictable file names for > 'memory-backend-file' objects. But that made us provide full path > to qemu when hot plugging the object while

Re: [libvirt] [PATCH 5/5] qemu: implement the 'libvirt_qemu' shim for launching guests externally

On Tue, Jan 09, 2018 at 03:13:41PM +0100, Martin Kletzander wrote: > On Wed, Dec 20, 2017 at 04:47:50PM +0000, Daniel P. Berrange wrote: > > This introduces a new binary 'libvirt_qemu' which can be used to launch > > guests externally from libvirtd. eg > > > > lib

Re: [libvirt] [PATCH 1/5] conf: allow different resource registration modes

On Thu, Jan 11, 2018 at 12:14:21PM +, Daniel P. Berrange wrote: > On Tue, Jan 09, 2018 at 01:43:39PM +0100, Martin Kletzander wrote: > > I'm so sorry for not getting to this earlier. I though I'll get to this > > over > > the holidays, but they were very busy wit

Re: [libvirt] [PATCH 1/5] conf: allow different resource registration modes

On Tue, Jan 09, 2018 at 01:43:39PM +0100, Martin Kletzander wrote: > I'm so sorry for not getting to this earlier. I though I'll get to this over > the holidays, but they were very busy with no free time for me. > > On Wed, Dec 20, 2017 at 04:47:46PM +0000, Daniel P. Be

  1   2   3   4   5   6   7   8   9   10   >