Re: [libvirt] [PATCH v5 6/7] Implement qemuSetupGlobalCpuCgroup

On Mon, 2016-01-18 at 13:08 +0300, Alexander Burluka wrote: > This functions setups per-domain cpu bandwidth parameters > > Signed-off-by: Alexander Burluka > --- >  src/qemu/qemu_cgroup.c  | 54 > + >  

Re: [libvirt] [PATCH v5 0/7] Per domain bandwidth settings

On Mon, 2016-01-18 at 13:08 +0300, Alexander Burluka wrote: > We decide to make a global per domain bandwidth setting > as were discussed in mailing list earlier. > This patchset implements hierarchy top level cpu.cfs_period_us > and cpu.cfs_quota_us control knob. I've named this parameters > as

Re: [libvirt] [PATCH v3 7/7] Implement handling of per-domain bandwidth settings

On Thu, 2016-01-14 at 18:08 +0300, Alexander Burluka wrote: > Signed-off-by: Alexander Burluka > --- >  src/qemu/qemu_cgroup.c | 12 +-- >  src/qemu/qemu_driver.c | 97 > -- >  2 files changed, 96 insertions(+), 13

Re: [libvirt] [PATCH 4/7] Add new cgroup thread type

On Tue, 2016-01-12 at 19:42 +0300, Alexander Burluka wrote: > Signed-off-by: Alexander Burluka > --- >  src/util/vircgroup.c | 4 >  src/util/vircgroup.h | 1 + >  2 files changed, 5 insertions(+) > > diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c > index

Re: [libvirt] [PATCH 6/7] Implement qemuSetupGlobalCpuCgroup

On Thu, 2016-01-14 at 14:28 +0300, Dmitry Guryanov wrote: > On Tue, 2016-01-12 at 19:42 +0300, Alexander Burluka wrote: > > This functions setups per-domain cpu bandwidth parameters > > > > Signed-off-by: Alexander Burluka <aburl...@virtuozzo.com> > > ---

Re: [libvirt] [PATCH 6/7] Implement qemuSetupGlobalCpuCgroup

On Tue, 2016-01-12 at 19:42 +0300, Alexander Burluka wrote: > This functions setups per-domain cpu bandwidth parameters > > Signed-off-by: Alexander Burluka > --- >  src/qemu/qemu_cgroup.c  | 64 > + >  

Re: [libvirt] [PATCH v2 8/8] Implement handling of per-domain bandwidth settings

On Thu, 2016-01-14 at 13:28 +0300, Alexander Burluka wrote: > Signed-off-by: Alexander Burluka > --- >  src/qemu/qemu_driver.c | 120 > - >  1 file changed, 118 insertions(+), 2 deletions(-) > > diff --git

Re: [libvirt] [PATCH] vz: BUG: fix connecting hang in case of init failure

On Thu, 2015-12-24 at 15:58 +0300, Maxim Nestratov wrote: > In case of prlsdkLoadDomains fails, vzOpenDefault should > clear connection privateData pointer every time its > memory is actually freed. > Also it is not necessary to call vzConnectClose if a call > to vzOpenDefault fails, because they

Re: [libvirt] [PATCH 3/3] vz: support additional flags in domain undefine

On Tue, 2015-12-22 at 18:29 +0300, Maxim Nestratov wrote: > Implement VIR_DOMAIN_UNDEFINE_MANAGED_SAVE and > VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA flags support. > ACKed and pushed, thanks! > Signed-off-by: Maxim Nestratov > --- >  src/vz/vz_driver.c |  5 ++-- >  

Re: [libvirt] [PATCH 2/3] vz: move prlsdkCleanupBridgedNet after domain deletion

On Tue, 2015-12-22 at 18:29 +0300, Maxim Nestratov wrote: > prlsdkCleanupBridgedNet call should be made strongly after > any actual domain deletion accurs. By doing this we avoid > any potential problems connected with second undefine call > when it is made after first one fails by some reason,

Re: [libvirt] [PATCH 1/3] vz: delete domains when undefine is called

On Tue, 2015-12-22 at 18:29 +0300, Maxim Nestratov wrote: > Currently vz driver unregisters domains when undefine is called, > which is wrong because it contradicts with expected behavior. > All vz domains are persistent, which means that when one is > defined a new bundle directory containing

Re: [libvirt] [PATCH 1/3 v3] vz: allow to create container based on template

On Tue, 2015-12-15 at 14:43 +0300, Mikhail Feoktistov wrote: > We shouldn't delete disk from default config if we create container > based on template, > because we don't have the new disk from XML, only template name. > And don't add template section from XML as new filesystem, > we use

Re: [libvirt] [PATCH 2/3 v2] vz: allow to boot VM from cdrom

On Tue, 2015-12-15 at 14:43 +0300, Mikhail Feoktistov wrote: > If user creates virtual machine via virt-manager and select "boot from ISO" > then in libvirt we can see the following devices section > >     >   >   >     >     >  

Re: [libvirt] [PATCH 3/3 v2] vz: implementation of boot device order

On Tue, 2015-12-15 at 14:43 +0300, Mikhail Feoktistov wrote: > This patch implements functionality of boot device order > based on boot element from os section in XML. > Now we support boot from CDROM and HDD. > If we have several devices of the same type (for example hdd0 and hdd1), > than we

Re: [libvirt] [PATCH] vz: Allow to create container based on template

nn, virDomainDefPtr def) >  if (ret) >  goto cleanup; >   > -job = PrlVm_RegEx(sdkdom, "", > -  PACF_NON_INTERACTIVE_MODE | PRNVM_PRESERVE_DISK); > +flags = PACF_NON_INTERACTIVE_MODE; > +if (!useTemplate) > +flags

Re: [libvirt] [PATCH] vz: allow to boot VM from cdrom

->path); > -prlsdkCheckRetGoto(pret, cleanup); > +pret = PrlVmDev_SetFriendlyName(sdkdisk, disk->src->path); > +    prlsdkCheckRetGoto(pret, cleanup); > +} Could you, please, also add some comment about this code. I I thought we can only add disks with existing images. But here you allow to add disk without source path, how will it work? >   >  drive = >info.addr.drive; >  if (drive->controller > 0) { -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] vz: implementation of domainCreateXML callback

boot = vzDomainReboot, /* 1.2.22 */ >  .domainDefineXML = vzDomainDefineXML,  /* 0.10.0 */ >  .domainDefineXMLFlags = vzDomainDefineXMLFlags, /* 1.2.12 */ -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] vz: allow only en-us keymap for VNC

IR_ERR_CONFIG_UNSUPPORTED, "%s", > -   _("vz driver doesn't support " > - "keymap setting for VNC graphics.")); > +   _("vz driver supports only " > + "\"en-us\" keymap for V

Re: [libvirt] [PATCH v2] vz: implementation of domainReboot callback

sdkdom); >  PRL_RESULT prlsdkSuspend(PRL_HANDLE sdkdom); > +PRL_RESULT prlsdkRestart(PRL_HANDLE sdkdom); >   >  typedef PRL_RESULT (*prlsdkChangeStateFunc)(PRL_HANDLE sdkdom); >  int -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] NOT only vz!: add func to set shared drivers after libvirtd init

ernal.h > @@ -289,4 +289,5 @@ virTypedParameterValidateSet(virConnectPtr conn, >   virTypedParameterPtr params, >   int nparams); >   > +int virAssignSharedDrivers(const char *name); >  #endif > diff --git a/src/libvir

Re: [libvirt] [RFC] memory settings interface for containers

API and xml > model documentation accordingly. > > I'd be happy to hear core developers opinions on this topic. -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/2] vz: add memory setting functions to driver

NVALID_HANDLE; > +PRL_RESULT pret; > + > +job = PrlVm_BeginEdit(privdom->sdkdom); > +if (PRL_FAILED(waitJob(job))) > +goto out; > + > +pret = PrlVmCfg_SetRamSize(privdom->sdkdom, memsize); > +prlsdkCheckRetGoto(pret, out); > + > +job = PrlVm_CommitEx(privdom->sdkdom, PVCF_DETACH_HDD_BUNDLE); > +if (PRL_FAILED(waitJob(job))) > +goto out; > + > +ret = 0; > + out: > +return ret; > +} > diff --git a/src/vz/vz_sdk.h b/src/vz/vz_sdk.h > index ebe4591..88fef4a 100644 > --- a/src/vz/vz_sdk.h > +++ b/src/vz/vz_sdk.h > @@ -76,3 +76,4 @@ int >  prlsdkGetVcpuStats(virDomainObjPtr dom, int idx, unsigned long long *time); >  int >  prlsdkGetMemoryStats(virDomainObjPtr dom, virDomainMemoryStatPtr stats, > unsigned int nr_stats); > +int prlsdkSetMemsize(virDomainObjPtr dom, unsigned int memsize); -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/2] vz: factor out config update flags checks

DomObjFromDomain(domain))) >  return -1; >   > -if (!(flags & VIR_DOMAIN_AFFECT_CONFIG)) { > -virReportError(VIR_ERR_OPERATION_INVALID, "%s", > -   _("domain config update needs VIR_DOMAIN_AFFECT_CONFIG > " > - &qu

Re: [libvirt] [PATCH] vz: implement memory setting functions in driver

On Thu, 2015-11-05 at 13:13 +0300, Nikolay Shirokovskiy wrote: > Implement functions for vz containers only. vz VMs memory > managment thru libvirt yet to be designed. > > vz memory management for containers is rather different from other > drivers. > > 1. Whole bunch of memory settings

Re: [libvirt] [PATCH] vz: implement memory setting functions in driver

On Thu, 2015-11-05 at 13:13 +0300, Nikolay Shirokovskiy wrote: > Implement functions for vz containers only. vz VMs memory > managment thru libvirt yet to be designed. > > vz memory management for containers is rather different from other > drivers. > > 1. Whole bunch of memory settings

Re: [libvirt] [PATCH] vz: support cpu time in driver's domainGetInfo

d cputime for domain")); +goto cleanup; +} +info->cpuTime += vtime; +} +} ret = 0; cleanup: -if (privdom) -virObjectUnlock(privdom); +virDomainObjEndAPI(); return ret; } ACK. Looks good. -- Dmitry Gury

Re: [libvirt] [PATCH 1/2] conf: add crash to hyperv features

On 10/26/2015 01:23 PM, Dmitry Andreev wrote: Add crash CPU feature for Hyper-V. Hyper-V crash MSR's can be used by Hyper-V based guests to notify about occurred guest crash. XML: Looks good to me, ACK. By the way, which commit has added this feature to qemu? Is it this one

Re: [libvirt] [PATCH 2/2] qemu: add hv_crash support

On 10/26/2015 01:23 PM, Dmitry Andreev wrote: XML: QEMU command line: qemu -cpu ,hv_crash ACK from me, but I think someone else should look at these patches. --- src/qemu/qemu_command.c| 2 ++ tests/qemuxml2argvdata/qemuxml2argv-hyperv-off.xml

Re: [libvirt] [PATCH v2 0/3] vz: implement some API calls

On 10/19/2015 10:02 PM, Maxim Nestratov wrote: v1-v2 change: - removed vzConnectGetType - addressed comments on vzConnectGetMaxVcpus Maxim Nestratov (3): vz: implement connectGetMaxVcpus API calls vz: implement API calls of nodeGetxxx family vz: implement some domain API calls

Re: [libvirt] [PATCHv3 0/2] Added waiting for DAD to finish for bridge address.

On 09/29/2015 01:16 PM, Maxim Perevedentsev wrote: This is a fix for commit db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process which is relied on when waiting for DAD to complete exits without actually waiting for DAD. This is dnsmasq daemon's task. It seems to be a race that DAD

Re: [libvirt] [PATCH 1/3] vz: implement connectGetType and connectGetMaxVcpus API calls

On 10/14/2015 12:50 PM, Maxim Nestratov wrote: From: Maxim Nestratov As a connection type we report 'vz'. And because we have no limitation for maximal number of vcpus in containers we report as maximum 1028 just for the sake of common sence. Signed-off-by: Maxim

Re: [libvirt] [PATCH 2/3] vz: implement API calls of nodeGetxxx family

On 10/14/2015 12:50 PM, Maxim Nestratov wrote: From: Maxim Nestratov The following functions were implemented: vzNodeGetCPUStats, vzNodeGetMemoryStats, vzNodeGetCellsFreeMemory and vzNodeGetFreeMemory. Looks good to me, ACK. Signed-off-by: Maxim Nestratov

Re: [libvirt] [PATCH 3/3] vz: implement some domain API calls

On 10/14/2015 12:50 PM, Maxim Nestratov wrote: From: Maxim Nestratov The following functions are implemented: vzDomainIsUpdated, vzDomainGetVcpusFlags and vzDomainGetMaxVcpus. Signed-off-by: Maxim Nestratov ACK --- src/vz/vz_driver.c

Re: [libvirt] [PATCH] vz: cleanup

On 10/07/2015 01:05 PM, Maxim Nestratov wrote: From: Maxim Nestratov Remove unused definitions, functions and structure fields. ACKed and pushed, thanks! Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c |1 -

Re: [libvirt] [PATCH 0/2] vz: remove unused network and storage drivers

On 09/22/2015 01:33 PM, Maxim Nestratov wrote: From: Maxim Nestratov Maxim Nestratov (2): vz: remove network driver as never used vz: remove storage driver as never used You forgot to remove these files from po/POTFILES.in. I've fixed it, ACKed and pushed,

Re: [libvirt] [PATCH 1/2] vz: remove network driver as never used

On 09/22/2015 01:33 PM, Maxim Nestratov wrote: From: Maxim Nestratov At the time this code was added we had intentions to support libvirt interface to manage vz networks. In fact, it was never implemented completely to work correctly that makes me think that there

Re: [libvirt] [PATCH 2/2] vz: remove storage driver as never used

On 09/22/2015 01:33 PM, Maxim Nestratov wrote: From: Maxim Nestratov In fact, it was never used as far as vz has no features supporting it. That is why there will be no harm to anyone if we just remove this code to prevent further misunderstanding and efforts to

Re: [libvirt] [PATCH] vz: remove error logging from prlsdkUUIDParse

On 09/21/2015 02:08 PM, Maxim Nestratov wrote: From: Maxim Nestratov As far as not every call of prlsdkUUIDParse assume correct UUID supplied, there is no use to complain about wrong format in it. Otherwise our log is flooded with false error messages. For instance,

Re: [libvirt] [PATCH v3 5/5] vz: cleanup: define vz format of uuids

On 08/25/2015 12:04 PM, nshirokovs...@virtuozzo.com wrote: From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com ACK vz puts uuids into curly braces. Simply introduce new contstant to reflect this and get rid of magic +2 in code. Signed-off-by: Nikolay Shirokovskiy

Re: [libvirt] [PATCH v3 2/5] vz: add migration backbone code

On 08/25/2015 07:18 PM, Daniel P. Berrange wrote: On Tue, Aug 25, 2015 at 12:04:14PM +0300, nshirokovs...@virtuozzo.com wrote: From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com This patch makes basic vz migration possible. For example by virsh: virsh -c vz:///system migrate --direct

Re: [libvirt] [PATCH v3 3/5] vz: support domain rename on migrate

On 08/25/2015 12:04 PM, nshirokovs...@virtuozzo.com wrote: From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com ACK Signed-off-by: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com --- src/vz/vz_driver.c |6 ++ src/vz/vz_sdk.c| 16 +--- src/vz/vz_sdk.h|

Re: [libvirt] [PATCH v3 2/5] vz: add migration backbone code

On 08/25/2015 12:04 PM, nshirokovs...@virtuozzo.com wrote: From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com This patch makes basic vz migration possible. For example by virsh: virsh -c vz:///system migrate --direct $NAME $STUB vz+ssh://$DST/system $STUB could be anything as it is

Re: [libvirt] [PATCH v3 1/5] vz: save session uuid on login

On 08/25/2015 12:04 PM, nshirokovs...@virtuozzo.com wrote: From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com This session uuid acts as authN token for different multihost vz operations one of which is migration. Unfortunately we can't get it from server at any time thus we need to save it

Re: [libvirt] [PATCH v3 0/5] vz: add migration support

On 08/25/2015 12:04 PM, nshirokovs...@virtuozzo.com wrote: NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate --direct 200 shiny0 --migrateuri vz+ssh://shiny0/system --live --persistent --compressed It seems there is something wrong with virsh

Re: [libvirt] [PATCH v3 4/5] vz: support misc migration options

On 08/25/2015 12:04 PM, nshirokovs...@virtuozzo.com wrote: From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com Migration API has a lot of options. This patch intention is to provide support for those options that can be trivially supported and give estimation for other options support in

Re: [libvirt] [PATCH v3 0/5] vz: add migration support

On 08/25/2015 04:56 PM, Dmitry Guryanov wrote: On 08/25/2015 12:04 PM, nshirokovs...@virtuozzo.com wrote: NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate --direct 200 shiny0 --migrateuri vz+ssh://shiny0/system --live --persistent --compressed

Re: [libvirt] Fwd: Guidelines for implementing a hypervisor driver

On 08/21/2015 05:28 PM, Christian Loehle wrote: Hey, I couldn't find any documentation about how to implement a driver for an unsupported hypervisor, does something like that exist? I think the best way to understand, how to implement a driver, is learning test driver code (src/test in

Re: [libvirt] [PATCH 1/2] network: added waiting for DAD to finish for bridge address.

On 07/31/2015 07:35 PM, Maxim Perevedentsev wrote: This is a fix for commit db488c79173b240459c7754f38c3c6af9b432970 dnsmasq main process exits without waiting for DAD, this is dnsmasq daemon's task. So we periodically poll the kernel using netlink and check whether there are any IPv6 addresses

Re: [libvirt] [PATCH 2/2] netlink: add support for multi-part netlink messages.

On 07/31/2015 07:35 PM, Maxim Perevedentsev wrote: Such messages do not have NLMSG_ERROR or NLMSG_DONE type but they are valid responses. We test 'multi-partness' by looking for NLM_F_MULTI flag. This patch looks OK to me except for comment style. --- src/util/virnetlink.c | 4 +++- 1

Re: [libvirt] [PATCH v2 0/7] vz: add migration support

On 07/17/2015 03:55 PM, nshirokovs...@virtuozzo.com wrote: NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate 200 vz+ssh://shiny0/system -p2p --live --persistent --compressed Difference from v1: 1. Patch is quite different. First patchset implements

Re: [libvirt] [PATCH v2 1/7] vz: save session uuid on login

On 07/17/2015 03:55 PM, nshirokovs...@virtuozzo.com wrote: From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com This session uuid acts as authN token for different multihost vz operations one of which is migration. Unfortunately we can't get it from server at any time thus we need to save it

Re: [libvirt] [PATCH 1/2] configure: Move Virtuozzo checks to a specific module

On 07/10/2015 05:32 PM, Michal Privoznik wrote: Eventually, every driver will be moved to a special module. But for today the winner is Virtuozzo driver. Thanks, Michal, ACKed and pushed. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- configure.ac | 24

Re: [libvirt] [PATCH] vz: fix cleanup of nets of bridged type

On 07/09/2015 08:26 PM, Maxim Nestratov wrote: 09.07.2015 19:20, Dmitry Guryanov пишет: We create a virtual network of special type, which has the same name as bridge name to create bridged network adapter in vz. So when we delete such an adapter we have to remove corresponding virtual network

[libvirt] [PATCH] vz: fix cleanup of nets of bridged type

. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/vz/vz_sdk.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index a312990..d1bc312 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2986,20

Re: [libvirt] [PATCH] vz: use PRL_USE_VNET_NAME_FOR_BRIDGE_NAME

On 07/07/2015 04:49 AM, Maxim Nestratov wrote: It is better not to assume that newly created network should be connected to a bridge with same name, but specify it explicitly by PRL_USE_VNET_NAME_FOR_BRIDGE_NAME flag. Signed-off-by: Maxim Nestratov mnestra...@virtuozzo.com --- src/vz/vz_sdk.c

Re: [libvirt] [PATCH] vz: use PRL_USE_VNET_NAME_FOR_BRIDGE_NAME

On 07/07/2015 04:49 AM, Maxim Nestratov wrote: It is better not to assume that newly created network should be connected to a bridge with same name, but specify it explicitly by PRL_USE_VNET_NAME_FOR_BRIDGE_NAME flag. Signed-off-by: Maxim Nestratov mnestra...@virtuozzo.com There is a typo in

Re: [libvirt] [PATCH v2 1/1] vz: assign static IPs and default gateways for network adapter

On 07/07/2015 04:38 PM, Mikhail Feoktistov wrote: We support only one IPv4 and one IPv6 default gateway. If static IPs are not present in instance config, then we switch on DHCP for this adapter. PrlVmDevNet_SetAutoApply to makes necessary settings within guest OS In linux case it creates

Re: [libvirt] [PATCH v2] vz: fix building capabilities

On 07/06/2015 03:45 PM, Maxim Nestratov wrote: 03.07.2015 20:26, Dmitry Guryanov пишет: There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM

Re: [libvirt] [PATCH] vz: assign static IPs and default gateways for network adapter

On 07/01/2015 01:15 PM, Mikhail Feoktistov wrote: We support only one IPv4 and one IPv6 default gateway. If static IPs are not present in instance config, then we switch on DHCP for this adapter. PrlVmDevNet_SetAutoApply to makes necessary settings within guest OS In linux case it creates

[libvirt] [PATCH v2] vz: fix building capabilities

, vz, NULL, 0, NULL)) == NULL) Anyway, with two virt types it looks a litte messy, so let's move adding guest and domain to a separate function. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/vz/vz_driver.c | 92

Re: [libvirt] [PATCH] vz: fix building capabilities

On 07/03/2015 08:22 PM, Maxim Nestratov wrote: 03.07.2015 19:00, Dmitry Guryanov пишет: There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM

[libvirt] [PATCH] vz: fix building capabilities

There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, VIR_ARCH_X86_64,

[libvirt] [PATCH] docs: set more permissive patterns for paths in rng schemas

There is no obvious reason to limit paths, used in libvirt to a subset of what is allowed in linux. So let's allow any symbols in paths. --- docs/schemas/basictypes.rng | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/schemas/basictypes.rng

Re: [libvirt] Which symbols can be used in file paths in libvirt's XMLs?

On 07/01/2015 07:36 PM, Daniel P. Berrange wrote: On Wed, Jul 01, 2015 at 07:22:33PM +0300, Dmitry Guryanov wrote: Hello, There is an absFilePatch type in docs/schemas/basictypes.rng rng schema: define name=absFilePath data type=string param name=pattern/[a-zA-Z0-9_\.\+\-\\amp

[libvirt] Which symbols can be used in file paths in libvirt's XMLs?

The domain was successfully defined and virsh dumpxml shows this path in output. So the question is, where did this path pattern come from? Is it possible to use file paths with another symbols or there will be some problems? -- Dmitry Guryanov -- libvir-list mailing list libvir-list

Re: [libvirt] [PATCH] vz: fix SDK event dispatching

: @@ -1781,7 +1756,6 @@ prlsdkEventsHandler(PRL_HANDLE prlEvent, PRL_VOID_PTR opaque) return PRL_ERR_SUCCESS; } - int prlsdkSubscribeToPCSEvents(vzConnPtr privconn) { PRL_RESULT pret = PRL_ERR_UNINITIALIZED; -- Dmitry Guryanov -- libvir-list mailing list libvir-list

Re: [libvirt] [PATCH] vz: fix SDK event dispatching

); } cleanup: @@ -1781,7 +1756,6 @@ prlsdkEventsHandler(PRL_HANDLE prlEvent, PRL_VOID_PTR opaque) return PRL_ERR_SUCCESS; } - int prlsdkSubscribeToPCSEvents(vzConnPtr privconn) { PRL_RESULT pret = PRL_ERR_UNINITIALIZED; -- Dmitry Guryanov -- libvir-list mailing

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

the whole series. src/vz/vz_driver.c | 43 +- src/vz/vz_sdk.c| 248 +-- src/vz/vz_sdk.h|6 ++ -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

On 06/26/2015 04:59 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics for network, cpu and memory. CHANGES from v1. subject prefix changed from 'parallels' to 'vz' CHANGES from v2. 1

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

On 06/26/2015 05:04 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 17:01:25 +0300, Dmitry Guryanov wrote: On 06/26/2015 04:59 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics

Re: [libvirt] [PATCH v3 0/4] vz: add statistics

On 06/26/2015 05:04 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 17:01:25 +0300, Dmitry Guryanov wrote: On 06/26/2015 04:59 PM, Peter Krempa wrote: On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: Add vz statistics

Re: [libvirt] [PATCH v2 1/3] vz: add net dev statistiscs

prlsdkGetBlockStats(virDomainObjPtr dom, virDomainDiskDefPtr disk, virDomainBlockStatsPtr stats); +int +prlsdkGetAdapterIndex(virDomainObjPtr dom, const char *path); +int +prlsdkGetStatsParam(virDomainObjPtr dom, const char *name, long long *val); -- Dmitry Guryanov -- libvir-list mailing list libvir-list

Re: [libvirt] [PATCH v2 1/3] vz: add net dev statistiscs

); -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/3] vz: add vcpu statistics

); +virDomainObjEndAPI(privdom); +VIR_FREE(name); return ret; } -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 3/3] vz: add memory statistics

= vzDomainInterfaceStats, /* 1.3.0 */ +.domainMemoryStats = vzDomainMemoryStats, /* 1.3.0 */ }; static virConnectDriver vzConnectDriver = { -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] vz: Adapt to driver rename

net); -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] vz: implementation of attach/detach network devices

, parallelsConnPtr privconn, virDomainNetDefPtr net); -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] vz: fix syntax-check errors

Remove braces around single-statement blocks in vz_sdk.c Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/vz/vz_sdk.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index dea6e37..1a3aa87 100644 --- a/src/vz/vz_sdk.c

Re: [libvirt] [PATCH] vz: fix syntax-check errors

On 06/24/2015 10:37 PM, Dmitry Guryanov wrote: Remove braces around single-statement blocks in vz_sdk.c Pushed as trivial and build-breaker. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/vz/vz_sdk.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [libvirt] [PATCH 4/4] parallels: implementation of attach/detach network devices

, parallelsConnPtr privconn, virDomainNetDefPtr net); +int +prlsdkDetachNet(virDomainObjPtr dom, parallelsConnPtr privconn, virDomainNetDefPtr net); -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/4] parallels: Fix false error messages in libvirt log

; -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/4] parallels: Fix initialization of buflen variable in each loop iteration

, cleanup); +buflen = 0; pret = PrlVmDev_GetFriendlyName(hdd, 0, buflen); prlsdkCheckRetGoto(pret, cleanup); -- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] parallels: Implementation of attach/detach network devices and small network fixes

-- Dmitry Guryanov -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] parallels: rename parallels to vz

On 06/10/2015 10:50 AM, Maxim Nestratov wrote: This change is made in the scope of 'Parallel Cloud Server' pruduct renaming to 'Virtuozzo' to prevent future confusion and make things actual. Previously we introduced a new driver name 'vz' as a synonym to 'parallels'. This patch set finalizes

Re: [libvirt] [PATCH] parallels: fix formatting errors in parallels driver

On 06/09/2015 05:13 PM, Dmitry Guryanov wrote: This patch fixes several formatting errors, which I missed before pushing previous patches. Mostly because of missing cppi package. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 8 src

Re: [libvirt] Build failed in Jenkins: libvirt-syntax-check #3577

: incorrect preprocessor indentation make: *** [sc_preprocessor_indentation] Error 1 Build step 'Execute shell' marked build as failure -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- Dmitry Guryanov -- libvir-list mailing list libvir-list

[libvirt] [PATCH] parallels: fix formatting errors in parallels driver

This patch fixes several formatting errors, which I missed before pushing previous patches. Mostly because of missing cppi package. Signed-off-by: Dmitry Guryanov dgurya...@parallels.com --- src/parallels/parallels_driver.c | 8 src/parallels/parallels_sdk.c| 4 ++-- src/parallels

Re: [libvirt] [PATCH 0/4 v2] parallels: better support of volume based disks in containers

On 06/04/2015 12:10 AM, Maxim Nestratov wrote: v1-v2 change: * Single patch was split into smaller pieces * Corrected conflict of / mount point in case both filesystem and block device disks are being added. It is possible to attach volumes to containers but since they are added they

Re: [libvirt] [PATCH v5] parallels: add block device statistics to driver

On 06/09/2015 10:35 AM, Nikolay Shirokovskiy wrote: Statistics provided through PCS SDK. As we have only async interface in SDK we need to be subscribed to statistics in order to get it. Trivial solution on every stat request to subscribe, wait event and then unsubscribe will lead to significant

Re: [libvirt] [PATCH v4] parallels: add block device statistics to driver

On 06/05/2015 05:17 PM, Nikolay Shirokovskiy wrote: static int parallelsDoCmdRun(char **outbuf, const char *binary, va_list list) diff --git a/src/parallels/parallels_utils.h b/src/parallels/parallels_utils.h index 2d1d405..cdf6082 100644 --- a/src/parallels/parallels_utils.h +++

Re: [libvirt] [PATCH] parallels: return only success from PCS event handler

On 06/05/2015 04:47 PM, Nikolay Shirokovskiy wrote: 2 reasons to to this. 1. PCS SDK really don't care of handler return value. 2. It hard to imagine how notifier can handle subscriber failures. Even if there are some situations we probably will use some special error codes and not just throw

Re: [libvirt] [PATCH v2] parallels: simplify event types discrimination

On 06/04/2015 02:45 PM, Nikolay Shirokovskiy wrote: Use issuer type instead of event type to group vm related events. This saves us from explicit enumeration of all vm event types in prlsdkHandleVmEvent. Thanks, ACKed and pushed. --- src/parallels/parallels_sdk.c | 15 +-- 1

Re: [libvirt] [PATCH 0/8 v3] parallels: add vz driver

On 05/28/2015 11:05 AM, Dmitry Guryanov wrote: On 05/26/2015 08:12 PM, Maxim Nestratov wrote: v2-v3 change: * Patch parallels: set virtType depending on driver name reworked. Implemented ability to set virtType depending on driver name. v1-v2 change: * Only parallels: accept vz

Re: [libvirt] [PATCH] parallels: add block device statistics to driver

On 05/22/2015 10:42 AM, Nikolay Shirokovskiy wrote: Statistics provided through PCS SDK. As we have only async interface in SDK we need to be subscribed to statistics in order to get it. Trivial solution on every stat request to subscribe, wait event and then unsubscribe will lead to significant

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK

On 05/26/2015 08:05 PM, Daniel P. Berrange wrote: On Tue, May 26, 2015 at 08:04:25PM +0300, Maxim Nestratov wrote: 26.05.2015 18:01, Daniel P. Berrange пишет: On Tue, May 26, 2015 at 05:57:41PM +0300, Maxim Nestratov wrote: It is necessary to have unpolluted screen when connecting to

Re: [libvirt] [PATCH 0/8 v3] parallels: add vz driver

On 05/26/2015 08:12 PM, Maxim Nestratov wrote: v2-v3 change: * Patch parallels: set virtType depending on driver name reworked. Implemented ability to set virtType depending on driver name. v1-v2 change: * Only parallels: accept vz as a driver uri and name patch is changed. Fixed

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK

On 05/28/2015 12:01 PM, Daniel P. Berrange wrote: On Thu, May 28, 2015 at 11:12:38AM +0300, Dmitry Guryanov wrote: On 05/26/2015 08:05 PM, Daniel P. Berrange wrote: On Tue, May 26, 2015 at 08:04:25PM +0300, Maxim Nestratov wrote: 26.05.2015 18:01, Daniel P. Berrange пишет: On Tue, May 26

Re: [libvirt] [PATCH 0/8] parallels: add vz driver

On 05/22/2015 09:18 PM, Maxim Nestratov wrote: This new driver 'vz' will be used as a substitution for parallels driver. New domains will be created with 'vz' domain type. Old 'parallels' domains remain supported. Connection to the driver can be made either way: vz:///system or

Re: [libvirt] [PATCH 2/2] parallels: fix possible crash in case of errors in prlsdkLoadDomain

On 05/21/2015 04:49 PM, Maxim Nestratov wrote: Cleanup code in prlsdkLoadDomain doesn't take into account the fact if private domain structure along with freeing function is assigned or not. In case it is, we shouldn't call it manually because virDomainObjListRemove calls it and frees pdom.

Re: [libvirt] [PATCH 1/2] parallels: move up updating parameter in prlsdkLoadDomain

On 05/21/2015 04:49 PM, Maxim Nestratov wrote: It is better to get all necessary parameters and check them on newly created configuration before actually creating a domain with them or applying them to an existing domain. Signed-off-by: Maxim Nestratov mnestra...@parallels.com Thanks, ACKED

  1   2   3   4   5   6   >