Re: [libvirt] [PATCH] libxl: libxl_domain_create_restore has an extra argument

2016-04-06 Thread Doug Goldstein
; params.checkpointed_stream = 0; > ret = libxl_domain_create_restore(cfg->ctx, _config, , >restore_fd, , NULL, > ACK This fixes integration testing that Xen Project does with libvirt and Xen so it would be nice to get in for 1.3.3. -- Doug Golds

[libvirt] Fwd: libvirt-php: 0.4.8 tag is missing

2014-04-20 Thread Doug Goldstein
Hi Michal, I sent the below message to the libvirt mailing list back on June 11th 2013 but never received a response from anyone. I just checked and the tag is still missing. Can you possibly push this tag as it looks like you are maintaining this project now. Thank you. -- Doug Goldstein

Re: [libvirt] [PATCH] Drop dependency on pm-is-supported

2014-03-28 Thread Doug Goldstein
On Mar 28, 2014, at 11:32 AM, Cédric Bosdonnat cbosdon...@suse.com wrote: From: Cédric Bosdonnat cedric.bosdon...@free.fr pm-is-supported is the only thing needed in pm-utils, better get rid of it since systemd is heavily used for libvirt. --- src/util/virnodesuspend.c | 34

Re: [libvirt] [PATCH 2/2] spice: expose the QEMU disable file transfer option

2014-01-15 Thread Doug Goldstein
On Jan 15, 2014, at 10:33 AM, Francesco Romani from...@redhat.com wrote: spice-server offers an API to disable file transfer messages on the agent channel between the client and the guest. This is supported in qemu through the disable-agent-file-xfer option. This patch exposes this option

Re: [libvirt] [PATCH v2] Add helper program to create custom leases

2014-01-15 Thread Doug Goldstein
On Jan 14, 2014, at 2:09 PM, Nehal J Wani nehaljw.k...@gmail.com wrote: Introduce helper program to catch events from dnsmasq and maintain a custom lease file per network. It supports DHCPv4 and DHCPv6. The file is saved as interface-name.status. The format of each lease is: expiry-time

[libvirt] [PATCH python] virStream.sendAll() fix raising an undeclared var

2014-01-10 Thread Doug Goldstein
The exception is raised from the variable 'e', which was undeclared in this context. Used code that is compatible with old and new Python versions. --- libvirt-override-virStream.py | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-override-virStream.py b/libvirt-override-virStream.py

Re: [libvirt] [PATCH] vmware: os x support is broken

2014-01-03 Thread Doug Goldstein
at the moment have anyone to test them. So if you're interested in testing them I can provide you with an alternate brew install command and we can maybe land some other fixes. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python] define __GNUC_PREREQ macro before using it

2014-01-02 Thread Doug Goldstein
On Tue, Dec 31, 2013 at 8:26 AM, Eric Blake ebl...@redhat.com wrote: On 12/29/2013 03:52 PM, Doug Goldstein wrote: We brought over use of the __GNUC_PREREQ macro from libvirt but didn't bring over the definition of it. This brings over the macro from libvirt sources. --- libvirt-utils.h | 9

Re: [libvirt] [PATCH] rbd: Use rbd_create3 to create RBD format 2 images by default

2014-01-02 Thread Doug Goldstein
something similar with the compat attribute added for qcow2 for the versioning that way things are explicitly stated rather than implicitly switching versions on us. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] can't build python bindings on FreeBSD

2013-12-29 Thread Doug Goldstein
://people.freebsd.org/~jgh | The Power to Serve -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH python] define __GNUC_PREREQ macro before using it

2013-12-29 Thread Doug Goldstein
We brought over use of the __GNUC_PREREQ macro from libvirt but didn't bring over the definition of it. This brings over the macro from libvirt sources. --- libvirt-utils.h | 9 + 1 file changed, 9 insertions(+) diff --git a/libvirt-utils.h b/libvirt-utils.h index f55be7b..add7553 100644

Re: [libvirt] [RFC/PATCH python] expose the bindings version to Python

2013-12-29 Thread Doug Goldstein
On Thu, Dec 12, 2013 at 4:29 PM, Eric Blake ebl...@redhat.com wrote: On 12/11/2013 08:43 PM, Doug Goldstein wrote: The method getVersion() retrieves the version of the libvirt library that the binaries are linked against but there is no way to retrieve the version of the bindings you are using

Re: [libvirt] [PATCH] libxl: avoid crashing if calling `virsh numatune' on inactive domain

2013-12-28 Thread Doug Goldstein
be in 2014). I'll help you out and get started on this. Family is in town around the holidays so no promises I'll get them all done if its not too trivial. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] libxl: avoid crashing if calling `virsh numatune' on inactive domain

2013-12-28 Thread Doug Goldstein
On Sat, Dec 28, 2013 at 3:18 PM, Doug Goldstein car...@gentoo.org wrote: On Tue, Dec 24, 2013 at 12:02 AM, Eric Blake ebl...@redhat.com wrote: On 12/20/2013 11:36 AM, Jim Fehlig wrote: Dario Faggioli wrote: by, in libxlDomainGetNumaParameters(), calling libxl_bitmap_init() as soon

Re: [libvirt] python setMetadata issue

2013-12-24 Thread Doug Goldstein
On Dec 24, 2013, at 2:13 AM, Umar Draz unix...@gmail.com wrote: Hi I am trying to set Metada of running virtual machine, but its giving me an error. Thanks for taking the time to report a potential issue. When you report potential issues please make sure to include the version of libvirt

Re: [libvirt] [PATCH] storage: show compile options in virsh --version=long

2013-12-11 Thread Doug Goldstein
there already and just Gluster was missing. Wouldn't be better to say storage: show gluster option in virsh --version=long? I realize I'm nitpicking the commit message/subject, the code is fine so ACK from that stand point. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [RFC/PATCH python] expose the bindings version to Python

2013-12-11 Thread Doug Goldstein
The method getVersion() retrieves the version of the libvirt library that the binaries are linked against but there is no way to retrieve the version of the bindings you are using. In the future if we support new APIs in Python that don't rely on features in the library there needs to be a way for

Re: [libvirt] [PATCH python 01/14] examples: Invoke print(...) instead of print ...

2013-12-09 Thread Doug Goldstein
://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 02/14] examples: Ensure we write bytes to the self-pipe

2013-12-09 Thread Doug Goldstein
for 'events' (libvirt -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 03/14] override: Fix native module registration to work with Python3

2013-12-09 Thread Doug Goldstein
+ cygvirtmod_qemu, +# endif + libvirtQemuMethods); } +#endif /* ! PY_MAJOR_VERSION 2 */ -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir

Re: [libvirt] [PATCH python 04/14] sanitytest: Fix libvirtError class handling for Python 2.4

2013-12-09 Thread Doug Goldstein
-list Don't have a setup to test, but in principle the code makes sense. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 05/14] override: Replace PyString_FromString with libvirt_constcharPtrWrap

2013-12-09 Thread Doug Goldstein
py_retval; } -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 06/14] override: Replace PyString_AsString with libvirt_charPtrUnwrap

2013-12-09 Thread Doug Goldstein
/libvir-list Some minor nits but overall looks ok. I'll double check it for any leaks with more context after I review the rest of the series. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 07/14] override: Replace Py{Int, Long}_FromLong with helpers

2013-12-09 Thread Doug Goldstein
); PyObject * libvirt_ulongWrap(unsigned long val); PyObject * libvirt_longlongWrap(long long val); -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH python 08/14] override: Replace PyInt_AsLong with helper

2013-12-09 Thread Doug Goldstein
)PyInt_AsLong(PyList_GetItem(pyobj_list, i)); +libvirt_uintUnwrap(PyList_GetItem(pyobj_list, i), (keycodes[i])); } LIBVIRT_BEGIN_ALLOW_THREADS; -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug

Re: [libvirt] [PATCH python 09/14] typewrappers: Replace use of PyString class

2013-12-09 Thread Doug Goldstein
. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 10/14] typewrappers: PyInt/PyLong merge for Python3

2013-12-09 Thread Doug Goldstein
list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 11/14] override: Conditionalize use of PyString_Check and PyInt_Check

2013-12-09 Thread Doug Goldstein
} else if (PyFloat_Check(value)) { type = VIR_TYPED_PARAM_DOUBLE; } -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH python 13/14] sanitytest: Fix broken comparison between int and string

2013-12-09 Thread Doug Goldstein
map to a class goes into the -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 14/14] sanitytest: remove use of string.lower()

2013-12-09 Thread Doug Goldstein
https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 12/14] override: Switch virStreamSend wrapper to use libvirt_charPtrSizeUnwrap

2013-12-09 Thread Doug Goldstein
libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list I don't really know the format specifier but it seems reasonably correct that O is object and then you're unwrapping it which makes sense so ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [libvirt-python 1/2] override: Fix exception handling syntax

2013-12-06 Thread Doug Goldstein
Python 3 no longer accepts 'except Exception, e:' as valid while Python 2.4 does not accept the new syntax 'except Exception as e:' so this uses a fall back method that is compatible with both. --- libvirt-override-virStream.py | 3 ++- libvirt-override.py | 8 ++-- 2 files changed,

[libvirt] [libvirt-python 2/2] test: Invoke print(...) instead of print ...

2013-12-06 Thread Doug Goldstein
The 'print' statement no longer exists in Python 3 and now must be called as a function. This is compatible down to Python 2.4 as we are not using any special syntax of the function. --- sanitytest.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sanitytest.py

Re: [libvirt] [PATCH RFC] spec: move hypvisor-specific files to hypervisor driver subpackages

2013-12-05 Thread Doug Goldstein
On Thu, Dec 5, 2013 at 9:03 AM, Jim Fehlig jfeh...@suse.com wrote: Jim Fehlig wrote: The libvirt-daemon package contains several hypervisor-specific files, directories, and script, which can be problematic when building the package with multiple hypervisor support, e.g. both QEMU and Xen.

Re: [libvirt] [PATCH python v2] generator: Remove use of 'has_key' function

2013-12-05 Thread Doug Goldstein
% (function_post[name])) -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

[libvirt] [libvirt-python 0/3] Python 3 support mixed with Dan's patches

2013-12-04 Thread Doug Goldstein
Turns out Dan and I both started working on Python 3 support and we talked about some changes to his patchset and these are the result of that conversation. This really belongs in the middle of his patchset but he's pushed the first part already so this is on top of master. Doug Goldstein (3

[libvirt] [libvirt-python 3/3] Update exception catching in generated code

2013-12-04 Thread Doug Goldstein
Use a syntax for exception handling that works in both Python 2 and Python 3. The new syntax is 'except Exception as e:' but this does not work in older Pythons so we use the most compatible way by just catching the exception and getting the type and the exception value after the fact. ---

[libvirt] [libvirt-python 2/3] generator: Support exceptions in Python 2 and 3

2013-12-04 Thread Doug Goldstein
Use a syntax for exception handling that works in both Python 2 and Python 3 --- generator.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/generator.py b/generator.py index 0717624..009d3e1 100755 --- a/generator.py +++ b/generator.py @@ -818,7 +818,8 @@ def

[libvirt] [libvirt-python 1/3] setup: Drop unused exception variable

2013-12-04 Thread Doug Goldstein
Drop the unused exception variable in setup.py. This has the benefit of dropping syntax that is not valid with Python 3. --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 561157c..24d4cf2 100755 --- a/setup.py +++ b/setup.py @@ -40,7 +40,7

Re: [libvirt] [PATCH python 02/15] generator: Remove string.lower(XXX) with XXX.lower()

2013-12-03 Thread Doug Goldstein
libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 01/15] generator: Don't use 'list' as a variable name

2013-12-03 Thread Doug Goldstein
]) -- 1.8.3.1 ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 04/15] generator: Cast iterators to a list() explicitly

2013-12-03 Thread Doug Goldstein
)) fd.write(\n) -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 05/15] generator: Remove use of 'has_key' function

2013-12-03 Thread Doug Goldstein
in function_post: classes.write(%s\n % (function_post[name])) -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list ACK. -- Doug Goldstein -- libvir

Re: [libvirt] [PATCH python 09/15] setup: Fix exception catching syntax

2013-12-03 Thread Doug Goldstein
, libvirt]) -except DistutilsExecError,e: +except DistutilsExecError: have_libvirt_lxc=False def get_pkgconfig_data(args, mod, required=True): -- 1.8.3.1 ACK. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 10/15] examples: Invoke print(...) instead of print ...

2013-12-03 Thread Doug Goldstein
the examples, which you may want to do as well. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 03/15] generator: Invoke print(...) instead of print ...

2013-12-03 Thread Doug Goldstein
://www.redhat.com/mailman/listinfo/libvir-list My patch actually uses myprint and provides that function which just calls the built in function when possible but provides one when not possible. Would we want to go with that approach instead? -- Doug Goldstein -- libvir-list mailing list libvir-list

Re: [libvirt] [PATCH python 03/15] generator: Invoke print(...) instead of print ...

2013-12-03 Thread Doug Goldstein
On Tue, Dec 3, 2013 at 10:53 AM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 03, 2013 at 10:44:07AM -0600, Doug Goldstein wrote: On Tue, Dec 3, 2013 at 10:36 AM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com The 'print' method

Re: [libvirt] [PATCH python 08/15] generator: Sort enums and functions when generating code

2013-12-03 Thread Doug Goldstein
()) +if enumvals is not None: +enumvals.sort(key=lambda x: x[0]) +for type,enum in enumvals: classes.write(# %s\n % type) items = list(enum.items()) items.sort(key=lambda i: int(i[1])) -- 1.8.3.1 ACK. -- Doug Goldstein -- libvir-list mailing list

[libvirt] [libvirt-python] Use user requested python binary for setup.py

2013-12-03 Thread Doug Goldstein
When setup.py is kicked off with a python interpreter other than the system 'python', (e.g. python2.7 setup.py build) the build process would switch to 'python' and not use python2.7 as requested by the user. We should always respect the user requested python interpreter and use it. --- setup.py

Re: [libvirt] [PATCH python 13/15] generator: Fix exception catching syntax in generated code

2013-12-03 Thread Doug Goldstein
(\No module named\):\n) fd.write(raise lib_e\n\n) -- 1.8.3.1 We'll want to use sys.exc_info() for the exceptions here so older Python compat. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python 06/15] generator: Update to use sort() 'key' param

2013-12-03 Thread Doug Goldstein
: cmp(int(i1[1]),int(i2[1]))) +items.sort(key=lambda i: int(i[1])) for name,value in items: fd.write(%s = %s\n % (name,value)) fd.write(\n) -- 1.8.3.1 Visually makes sense. Have not run it locally but ACK from a visual stand point. -- Doug Goldstein

Re: [libvirt] [libvirt-python] Use user requested python binary for setup.py

2013-12-03 Thread Doug Goldstein
On Tue, Dec 3, 2013 at 11:23 AM, Eric Blake ebl...@redhat.com wrote: On 12/03/2013 10:11 AM, Doug Goldstein wrote: When setup.py is kicked off with a python interpreter other than the system 'python', (e.g. python2.7 setup.py build) the build process would switch to 'python' and not use

Re: [libvirt] [PATCH] Fix VMware support for Fusion 6 / Workstation 10

2013-12-02 Thread Doug Goldstein
. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH python] Deal with old filenames for events/error functions

2013-11-27 Thread Doug Goldstein
On Nov 27, 2013, at 6:14 AM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com Older libvirt has files named 'events' and 'virterror' rather than 'virevent' and 'virerror'. This is visible in the API XML files. We must look for both names to

Re: [libvirt] [PATCH python] Improve quality of sanitytest check

2013-11-27 Thread Doug Goldstein
On Nov 27, 2013, at 6:19 AM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Nov 26, 2013 at 01:16:24PM -0600, Doug Goldstein wrote: On Tue, Nov 26, 2013 at 12:32 PM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com Validate that every

[libvirt] [libvirt-python] Call virGetLastError from mod rather than py wrapper

2013-11-26 Thread Doug Goldstein
All other code always calls the methods from the mod rather than using the python wrapper so this matches the state of all other callers. --- libvirt-override.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-override.py b/libvirt-override.py index ccfec48..87996f8

Re: [libvirt] [PATCH python] Improve quality of sanitytest check

2013-11-26 Thread Doug Goldstein
are a bit cleaner. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-24 Thread Doug Goldstein
as is as note that its broken or fix it). -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-python PATCHv2 43/44] virConnectGetCPUModelNames API appeared in 1.1.3

2013-11-21 Thread Doug Goldstein
On Tue, Nov 19, 2013 at 1:36 PM, Doug Goldstein car...@cardoe.com wrote: --- libvirt-override.c | 4 1 file changed, 4 insertions(+) This change must be dropped with latest libvirt.git master. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [libvirt-python PATCHv2 43/44] virConnectGetCPUModelNames API appeared in 1.1.3

2013-11-21 Thread Doug Goldstein
On Thu, Nov 21, 2013 at 8:14 AM, Doug Goldstein car...@cardoe.com wrote: On Tue, Nov 19, 2013 at 1:36 PM, Doug Goldstein car...@cardoe.com wrote: --- libvirt-override.c | 4 1 file changed, 4 insertions(+) This change must be dropped with latest libvirt.git master. Nvm. Ignore

Re: [libvirt] [PATCH] python: add virConnectGetCPUModelNames to skip_impl

2013-11-20 Thread Doug Goldstein
On Tue, Nov 19, 2013 at 4:17 PM, Doug Goldstein car...@cardoe.com wrote: In commit de51dc9c9, we removed virConnectGetCPUModelNames from skip_impl but without this the module will always generate a symbol for libvirt_virConnectGetCPUModelNames which we don't always want. CC: Giuseppe

[libvirt] [PATCH] python: Move examples to python/ for repo breakout

2013-11-20 Thread Doug Goldstein
In anticipation of the python bindings moving to their own repo and in an effort to preserve history, move the examples within the python/ directory. --- Makefile.am| 3 +-- configure.ac

Re: [libvirt] [libvirt-python 09/18] virNodeGetCPUMap API not added until 1.0.0

2013-11-19 Thread Doug Goldstein
On Tue, Nov 19, 2013 at 9:19 AM, Eric Blake ebl...@redhat.com wrote: On 11/18/2013 03:44 PM, Doug Goldstein wrote: --- libvirt-override.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) ACK. +#if LIBVIR_CHECK_VERSION(1,0,0) Style-wise, I would have written

Re: [libvirt] [libvirt-python 10/18] virDomainMigrate3 and virDomainMigrateToURI3 not added until 1.1.0

2013-11-19 Thread Doug Goldstein
On Tue, Nov 19, 2013 at 9:35 AM, Eric Blake ebl...@redhat.com wrote: On 11/18/2013 03:44 PM, Doug Goldstein wrote: The functions virDomainMigrate3 and virDomainMigrateToURI3 were not added to libvirt until v1.1.0. Is there a method to how you picked which functions to work around? It would

[libvirt] [PATCH] Add missing break to switch-case block

2013-11-19 Thread Doug Goldstein
The case label for VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED did not have its own break statement but relied on falling through which we probably don't want. --- python/libvirt-override.c | 1 + 1 file changed, 1 insertion(+) diff --git a/python/libvirt-override.c b/python/libvirt-override.c index

Re: [libvirt] [PATCH] Add missing break to switch-case block

2013-11-19 Thread Doug Goldstein
On Tue, Nov 19, 2013 at 10:39 AM, Martin Kletzander mklet...@redhat.com wrote: On Tue, Nov 19, 2013 at 10:32:01AM -0600, Doug Goldstein wrote: The case label for VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED did not have its own break statement but relied on falling through which we probably don't want

[libvirt] [libvirt-python PATCHv2 05/44] Add decl of MIN macro

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-utils.h | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-utils.h b/libvirt-utils.h index bec7346..aed64e6 100644 --- a/libvirt-utils.h +++ b/libvirt-utils.h @@ -24,4

[libvirt] [libvirt-python PATCHv2 13/44] Import some virTypedParams* APIs from libvirt

2013-11-19 Thread Doug Goldstein
virTypedParamsClear() and virTypedParamsFree() were introduced in libvirt 1.0.2. In an effort to keep the code clean bring these two functions to libvirt-python if we're building against a version of libvirt that's older than 1.0.2 --- libvirt-utils.c | 45

[libvirt] [libvirt-python PATCHv2 08/44] Import code annotation macros from libvirt

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com Import ATTRIBUTE_RETURN_CHECK, ATTRIBUTE_UNUSED ATTRIBUTE_NONNULL macros Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-utils.h | 52 1 file changed, 52 insertions(+) diff

[libvirt] [libvirt-python PATCHv2 02/44] Update generator for new code layout

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com Change the generator.py to - Take XML API file names on command line - Generate data in build/ directory instead of cwd --- generator.py | 69 ++-- 1 file changed, 25 insertions(+), 44

[libvirt] [libvirt-python PATCHv2 11/44] Import VIR_FORCE_CLOSE macro from libvirt

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com Import the macro for safely closing file descriptors Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-utils.c | 19 +++ libvirt-utils.h | 7 +++ 2 files changed, 26 insertions(+) diff --git a/libvirt-utils.c

[libvirt] [libvirt-python PATCHv2 14/44] Add build/ to python module path for sanitytest.py

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com The generated libvirt.py modules will be in the build/ directory, so santitytest.py must use that directory. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- sanitytest.py | 4 1 file changed, 4 insertions(+) diff --git a/sanitytest.py

[libvirt] [libvirt-python PATCHv2 09/44] Import VIR_ALLOC / VIR_ALLOC_N / VIR_REALLOC_N functions

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com Import the libvirt memory allocation functions, stripping the OOM testing and error reporting pieces. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-lxc-override.c | 1 + libvirt-override.c | 106

[libvirt] [libvirt-python PATCHv2 19/44] Create array of modules to be built

2013-11-19 Thread Doug Goldstein
Create an array of modules to be built to allow for flexibility to enable or disable some modules in the future and allow for additional modules to be added easily --- setup.py | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index

[libvirt] [libvirt-python PATCHv2 12/44] Import LIBVIR_CHECK_VERSION macro from libvirt

2013-11-19 Thread Doug Goldstein
Add LIBVIR_CHECK_VERSION from libvirt upstream so that we can check the version of the library we are compiling against and support a range of libvirt versions. The macro was added to libvirt in 1.2.0 so we must provide it if its not defined. --- libvirt-utils.h | 10 ++ 1 file changed,

[libvirt] [libvirt-python PATCHv2 18/44] Break generator.py to be called per module

2013-11-19 Thread Doug Goldstein
Since we don't always want to build all the modules, and there might be more modules added in the future but we want to retain backwards compatibility with older libvirts, change generator.py to be called once per module instead of with all modules at once. --- generator.py | 24

[libvirt] [libvirt-python PATCHv2 03/44] Update header file includes

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com We're no longer using automake, so config.h files are not required. Also remove of all libvirt internal util header files. Reference generated header files in build/ subdir. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

[libvirt] [libvirt-python PATCHv2 20/44] Don't build LXC module when building less than 1.0.2

2013-11-19 Thread Doug Goldstein
The functions that the LXC module wraps did not appear until 1.0.2 so we can't build the module unless we're building against 1.0.2 or newer. --- setup.py | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/setup.py b/setup.py index

[libvirt] [libvirt-python PATCHv2 15/44] Add execute permission for sanitytest.py

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- sanitytest.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 = 100755 sanitytest.py diff --git a/sanitytest.py b/sanitytest.py old mode 100644 new mode 100755 --

[libvirt] [libvirt-python PATCHv2 32/44] virConnectListAll* APIs appeared in 0.10.2

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 24 1 file changed, 24 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 3cc6f22..3602cd9 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -3032,6 +3032,7 @@ libvirt_virConnectListDefinedNetworks(PyObject *self

[libvirt] [libvirt-python PATCHv2 41/44] virDomainCreateXMLWithFiles and virDomainCreateWithFiles APIs appeared in 1.1.1

2013-11-19 Thread Doug Goldstein
virDomainCreateXMLWithFiles() and virDomainCreateWithFiles() were not added to libvirt until 1.1.1 --- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 6bd5138..32d1a4a 100644 --- a/libvirt-override.c +++ b/libvirt-override.c

[libvirt] [libvirt-python PATCHv2 40/44] virDomainMigrate3 and virDomainMigrateToURI3 appeared in 1.1.0

2013-11-19 Thread Doug Goldstein
The functions virDomainMigrate3 and virDomainMigrateToURI3 were not added to libvirt until v1.1.0. --- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 6c5d55f..6bd5138 100644 --- a/libvirt-override.c +++ b/libvirt-override.c

[libvirt] [libvirt-python PATCHv2 29/44] virDomainSnapshotListAllChildren API appeared in 0.9.13

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index dc1297e..90e6451 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -2656,6 +2656,7 @@ cleanup: } #endif /* LIBVIR_CHECK_VERSION(0, 9, 7) */ +#if

[libvirt] [libvirt-python PATCHv2 26/44] virDomainGetDiskErrors API appeared in 0.9.10

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index dbf45cc..cccfac5 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -4766,6 +4766,7 @@ cleanup: } #endif /* LIBVIR_CHECK_VERSION(0, 9, 8) */ +#if

[libvirt] [libvirt-python PATCHv2 36/44] virNodeGetCPUMap API appeared in 1.0.0

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libvirt-override.c b/libvirt-override.c index 7e167ee..951ad29 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -419,12 +419,14 @@ cleanup: */ static int

[libvirt] [libvirt-python PATCHv2 33/44] virNode{Get, Set}MemoryParameters API appeared in 0.10.2

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 3602cd9..4237cb7 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6967,6 +6967,7 @@ cleanup: return py_retval; } +#if LIBVIR_CHECK_VERSION(0, 10, 2)

[libvirt] [libvirt-python PATCHv2 43/44] virConnectGetCPUModelNames API appeared in 1.1.3

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index bcc2499..0464f49 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -2283,6 +2283,7 @@ libvirt_virConnectGetVersion(PyObject *self ATTRIBUTE_UNUSED, return

[libvirt] [libvirt-python PATCHv2 39/44] virDomainMigrateGetCompressionCache API appeared in 1.0.3

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index ad1ff4a..6c5d55f 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6789,6 +6789,7 @@ libvirt_virDomainSendKey(PyObject *self ATTRIBUTE_UNUSED, return

[libvirt] [libvirt-python PATCHv2 25/44] virDomainGetCPUStats API appeared in 0.9.10

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 7ab9013..dbf45cc 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -526,6 +526,7 @@ cleanup: return ret; } +#if LIBVIR_CHECK_VERSION(0, 9, 10) static

[libvirt] [libvirt-python PATCHv2 44/44] Simplify out of memory error case

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 0464f49..570918c 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -167,8 +167,7 @@ setPyVirTypedParameter(PyObject *info, } if

[libvirt] [libvirt-python PATCHv2 00/44] Split Python bindings into its own repo

2013-11-19 Thread Doug Goldstein
build system Doug Goldstein (30): Import LIBVIR_CHECK_VERSION macro from libvirt Import some virTypedParams* APIs from libvirt Add missing attributes to setup.py Break generator.py to be called per module Create array of modules to be built Don't build LXC module when building less than

[libvirt] [libvirt-python PATCHv2 24/44] virDomain{Get, Set}NumaParameters APIs appeared in 0.9.9

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 051b7cd..7ab9013 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -1264,6 +1264,7 @@ cleanup: return ret; } +#if LIBVIR_CHECK_VERSION(0, 9, 9) static

[libvirt] [libvirt-python PATCHv2 28/44] virConnectListAllDomains API appeared in 0.9.13

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 4bbb499..dc1297e 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -2400,6 +2400,7 @@ libvirt_virConnectListDomainsID(PyObject *self ATTRIBUTE_UNUSED,

[libvirt] [libvirt-python PATCHv2 35/44] VIR_DOMAIN_EVENT_ID_PMSUSPEND_DISK appeared in 1.0.0

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index aff1131..7e167ee 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6260,6 +6260,7 @@ libvirt_virConnectDomainEventBalloonChangeCallback(virConnectPtr conn

[libvirt] [libvirt-python PATCHv2 10/44] Remove use of virStrcpyStatic

2013-11-19 Thread Doug Goldstein
From: Daniel P. Berrange berra...@redhat.com Signed-off-by: Daniel P. Berrange berra...@redhat.com --- libvirt-override.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libvirt-override.c b/libvirt-override.c index d8bbbab..816ef01 100644 --- a/libvirt-override.c +++

[libvirt] [libvirt-python PATCHv2 42/44] VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED appeared in 1.1.1

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 32d1a4a..bcc2499 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6314,6 +6314,7 @@ libvirt_virConnectDomainEventPMSuspendDiskCallback(virConnectPtr conn

[libvirt] [libvirt-python PATCHv2 22/44] virDomain{Get, Set}BlockIoTune APIs appeared in 0.9.8

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 9740d1f..4aaef4e 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -4637,6 +4637,7 @@ error: return NULL; } +#if LIBVIR_CHECK_VERSION(0, 9, 8) static

[libvirt] [libvirt-python PATCHv2 38/44] virDomainGetJobStats API appeared in 1.0.3

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 06956f4..ad1ff4a 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -4564,6 +4564,7 @@ libvirt_virDomainGetJobInfo(PyObject *self ATTRIBUTE_UNUSED, PyObject

[libvirt] [libvirt-python PATCHv2 17/44] Add missing attributes to setup.py

2013-11-19 Thread Doug Goldstein
setup.py needs a URL attribute that contains the project's website which is set to http://libvirt.org as well as information about a maintainer which is set to 'Libvirt Maintainers' and points to the libvirt mailing list. --- setup.py | 3 +++ 1 file changed, 3 insertions(+) diff --git

[libvirt] [libvirt-python PATCHv2 30/44] virConnect{Unr, R}egisterCloseCallback API appeared in 0.10.0

2013-11-19 Thread Doug Goldstein
--- libvirt-override.c | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 90e6451..82bbd84 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6504,6 +6504,7 @@ libvirt_virConnectCloseCallbackDispatch(virConnectPtr conn

  1   2   3   4   5   6   >