On Sun, 2021-10-03 at 15:52 -0400, Laine Stump wrote:
> On 10/3/21 3:43 PM, Laine Stump wrote:
> > cleanup:
> > + if (mon)
> > + virCHMonitorClose(mon);
>
> Oops, I also meant to point out that the "if (mon)" is unnecessary
> here,
> because (as with all similar functions in
On Wed, 2021-09-22 at 22:55 +0200, Ján Tomko wrote:
> While cleaning up the tests, I noticed that the 'ch' driver is
> not using g_auto up to its full potential.
>
> Use automatic cleanup where possible and remove redundant labels.
>
> Ján Tomko (9):
> ch: use g_auto in
On Fri, 2021-08-27 at 17:38 +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 26, 2021 at 02:59:19PM -0700, William Douglas wrote:
> > Add function to build the the json structure to configure a PTY in
> > cloud-hypervisor. The configuration only supports a single serial
> > or
> > console device.
>
On Fri, 2021-08-27 at 17:30 +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 26, 2021 at 02:59:17PM -0700, William Douglas wrote:
> > The virCHMonitorGet function needed to be able to return data from
> > the
> > hypervisor. This functionality is needed in order for the driver to
> > support PTY
On Mon, 2021-07-12 at 14:05 +0200, Michal Prívozník wrote:
> On 6/30/21 1:05 AM, William Douglas wrote:
>
> > + memcpy(data->content, contents, content_size);
> > + data->content[content_size] = 0;
> > + data->size = content_size;
> > +
> > + return content_size;
>
> .. are we sure
On Mon, 2021-07-12 at 14:05 +0200, Michal Prívozník wrote:
> On 6/30/21 1:05 AM, William Douglas wrote:
>
>
> Hey, we require that the code is able to compile and test suite
> passes
> after each individual commit (because it's more cherry-pick
> friendly).
> Basically 'ninja -C build/ test'
Ick sorry for the malformed mail...
On 6/17/21 10:33 AM, Michal Prívozník wrote:
> On 6/17/21 9:00 AM, Peter Krempa wrote:
>> On Wed, Jun 16, 2021 at 21:16:01 -0700, William Douglas wrote:
>>> Instead of trying to match devices passed in based on the monitor
>>> detecting the number of devices
load. Then if a new libvirt is loaded
after restart with new hardware support (but cloud-hypervisor doesn't support
it) existing configurations wouldn't be impacted.
This is definitely validation but the validation call's type signature doesn't
seem to align very closely to the use case I was t
> On Wed, May 12, 2021 at 04:01:26PM +0000, Douglas, William wrote:
>> On Tue, May 11, 2021 at 02:05AM, Daniel P. Berrangé wrote:
>> > On Tue, Apr 27, 2021 at 02:39:46PM -0700, William Douglas wrote:
>> >> diff --git a/meson.build b/meson.build
>> &g
On Tue, May 11, 2021 at 02:05AM, Daniel P. Berrangé wrote:
> On Tue, Apr 27, 2021 at 02:39:46PM -0700, William Douglas wrote:
>> * On a 64-bit host Cloud-Hypervisor needs to support PVH and so can
>> emulate 32-bit mode but it isn't fully tested (a 64-bit kernel and
>> 32-bit userspace is fine,
On Tue, Sep 22, 2020 at 12:07 PM Ján Tomko wrote:
>
> On a Tuesday in 2020, Douglas, William wrote:
> >On Tue, Sep 22, 2020 at 1:11 AM Daniel P. Berrangé
> >wrote:
> >>
> >> On Mon, Sep 21, 2020 at 12:05:48PM -0700, Douglas, William wrote:
> >&g
On Tue, Sep 22, 2020 at 1:11 AM Daniel P. Berrangé wrote:
>
> On Mon, Sep 21, 2020 at 12:05:48PM -0700, Douglas, William wrote:
> > On Tue, Sep 15, 2020 at 5:53 AM Daniel P. Berrangé
> > wrote:
> > >
> > > On Thu, Aug 27, 2020 at 11:
On Tue, Sep 15, 2020 at 5:53 AM Daniel P. Berrangé wrote:
>
> On Thu, Aug 27, 2020 at 11:24:32AM -0700, William Douglas wrote:
> > +virCHMonitorPtr
> > +virCHMonitorNew(virDomainObjPtr vm, const char *socketdir)
> > +{
> > +virCHMonitorPtr ret = NULL;
> > +virCHMonitorPtr mon = NULL;
>
13 matches
Mail list logo
