Re: [libvirt] [PATCH 0/9] Yet another version of CAT stuff (no idea about the version number)

hi Martin, Thanks for reaching me, sure, I will try to testing your patch. BTW, do you have a github repo/branch for these which I can directly pull? Best regards - Eli a leaf duckweed belongs to the sea, where not to meet in life 2017-12-13 23:39 GMT+08:00 Martin Kletzander

Re: [libvirt] Yet another RFC for CAT

> > > > We didn't want to exec external python programs because that certainly > *does* have bad scalability, terrible error reporting facilities and > need to parse ill defined data formats from stdout, etc. It doesn't > magically solve the complexity, just moves it elsewhere where we have > less

Re: [libvirt] Yet another RFC for CAT

2017-09-04 23:57 GMT+08:00 Daniel P. Berrange : > On Mon, Sep 04, 2017 at 04:14:00PM +0200, Martin Kletzander wrote: > > * The current design (finally something libvirt-related, right?) > > > > The discussion ended with a conclusion of the following (with my best > >

Re: [libvirt] [PATCH RESEND RFC V2 0/2] Implement l3 CAT

ping On Wednesday, 5 July 2017 at 10:39 AM, Eli Qiao wrote: > Allow user to define cachetune in domain xml. > > RESEND: > * Fix stupid complile problem pointed out by Martin, check and syntax-check > passed. > > V2 -> V1 changes: > * Redefine cachetune xml in doma

[libvirt] [PATCH RESEND RFC V2 1/2] Resctrl: Add new xml element to support cache tune

to minimum. vcpus: cache allocation on vcpu set, if empty, will apply the allocation on all vcpus. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- docs/schemas/domaincommon.rng | 29 +++ src/conf/domain_conf.c| 112 +

[libvirt] [PATCH RESEND RFC V2 0/2] Implement l3 CAT

Allow user to define cachetune in domain xml. RESEND: * Fix stupid complile problem pointed out by Martin, check and syntax-check passed. V2 -> V1 changes: * Redefine cachetune xml in domain xml. * Create a struct for driver to talk with util/virresctrl.* * Nit fixes Eli Qiao

[libvirt] [PATCH RESEND RFC V2 2/2] Resctrl: Do cache allocation while boot a qemu VM

. virResctrlRemoveCachetunes: remove cache allocation group from the host. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- include/libvirt/virterror.h | 1 + src/Makefile.am | 1 + src/libvirt_privat

Re: [libvirt] [PATCH RFC V2 1/2] Resctrl: Add new xml element to support cache tune

On Friday, 30 June 2017 at 7:06 PM, Martin Kletzander wrote: > On Mon, Jun 26, 2017 at 06:33:39PM +0800, Eli Qiao wrote: > > This patch adds new xml element to support cache tune as: > > > > > > ... > > > > ... > > > > > > c

[libvirt] [PATCH RFC V2 0/2] Implement l3 CAT

Allow user to define cachetune in domain xml. V2 -> V1 changes: * Redefine cachetune xml in domain xml. * Create a struct for driver to talk with util/virresctrl.* * Nit fixes Eli Qiao (2): Resctrl: Add new xml element to support cache tune Resctrl: Do cache allocation while b

[libvirt] [PATCH RFC V2 2/2] Resctrl: Do cache allocation while boot a qemu VM

. virResctrlRemoveCachetunes: remove cache allocation group from the host. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- include/libvirt/virterror.h | 1 + src/Makefile.am | 1 + src/libvirt_privat

[libvirt] [PATCH RFC V2 1/2] Resctrl: Add new xml element to support cache tune

to minimum. vcpus: cache allocation on vcpu set, if empty, will apply the allocation on all vcpus. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- docs/schemas/domaincommon.rng | 29 +++ src/conf/domain_conf.c| 113 +

Re: [libvirt] [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

On Thursday, 22 June 2017 at 8:41 PM, Martin Kletzander wrote: > I missed this. Ye, you're right, thanks for showing that with a use > case. We could then require only the cache_id and automatically fill > in level and type. Migration (or rather any start) should then fail if > that cache_id

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

On Wednesday, 21 June 2017 at 10:44 PM, Martin Kletzander wrote: > n 21, 2017 at 02:07:15PM +0800, Eli Qiao wrote: > > You don't need to pass the whole structure of all the data. Can't the > qemu function just do something like: > > virResctrlLock() > foreac

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

On Wednesday, 21 June 2017 at 10:44 PM, Martin Kletzander wrote: > You don't need to pass the whole structure of all the data. Can't the > qemu function just do something like: > > virResctrlLock() > foreach cachetune: > region = virResctrlGetFreeRegion(size, type) > foreach cachetune.vcpu: >

Re: [libvirt] [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

hi Martin It’s really nice of you to help reviewing the mass code. Thanks. I don’t find a better way to split patch. On Wednesday, 21 June 2017 at 9:53 PM, Martin Kletzander wrote: > On Mon, Jun 12, 2017 at 05:48:40PM +0800, Eli Qiao wrote: > > This patch adds new xml element t

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

On Tuesday, 20 June 2017 at 8:39 PM, Martin Kletzander wrote: > On Mon, Jun 12, 2017 at 05:48:41PM +0800, Eli Qiao wrote: > > This patch adds 3 major private interface. > > > > virResctrlGetFreeCache: return free cache, default cache substract cache > > allocated.

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

hello, ping On Monday, 12 June 2017 at 5:48 PM, Eli Qiao wrote: > This patch adds 3 major private interface. > > virResctrlGetFreeCache: return free cache, default cache substract cache > allocated. > virResctrlSetCachetunes: set cache banks which defi

[libvirt] [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

allocation on vcpu set, if empty, will apply the allocation on all vcpus Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- docs/schemas/domaincommon.rng | 54 + src/conf/domain_conf.c| 131 ++ src/conf/domain_conf.h

[libvirt] [PATCH RFC 0/2] Implement l3 CAT

://www.kernel.org/doc/Documentation/x86/intel_rdt_ui.txt [4] https://github.com/taget/libvirt/commits/cache Eli Qiao (2): Resctrl: Add new xml element to support cache tune Resctrl: Add uitls functions to operate sysfs resctrl docs/schemas/domaincommon.rng | 54 ++ include/libvirt

[libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

+ * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this

Re: [libvirt] [PATCH v2] Report more correct information for cache control

Thanks martin, Looks good to me. On Friday, 9 June 2017 at 4:52 PM, Martin Kletzander wrote: > On some platforms the number of bits in the cbm_mask might not be > divisible by 4 (and not even by 2), so we need to properly count the > bits. Similar file, min_cbm_bits, is properly parsed and

Re: [libvirt] [V4 RESEND PATCH] Expose resource control capabilites on cache bank

> > > > This could be wrong on new platform in Intel’s SKX CPU after check with > > platform guys. > > > > The cbm_mask is “7ff” (11 bits) on SKX. I will refine this by counting the > > bits. > > > > We can virFileReadValueString() then convert it to unsigned int, then count > > the bits

Re: [libvirt] [PATCH] Report more correct information for cache control

hi Martin The code looks good to me, I have 1 comment for the granularity’s comment, and another one for the test data. Otherwise, looks perfect, good to learn how to deal with hex On Monday, 5 June 2017 at 9:14 PM, Martin Kletzander wrote: > On some platforms the number of bits in the

[libvirt] [PATCH] Capabilities: add step to cache control

updated. Signed-off-by: Eli Qiao <qiaoliy...@gmail.com> --- docs/schemas/capability.rng | 3 +++ src/conf/capabilities.c | 19 --- src/conf/capabilities.h | 1 + .../linux-resctrl/resctr

Re: [libvirt] [V4 RESEND PATCH] Expose resource control capabilites on cache bank

Martin: Please hold on merge this first. I found we still need some modification. > > > > Again, wrong indentation and unnecessary parentheses. > > > > Otherwise it looks good, so ACK with those differences and reworded > > commit message. Let me know if you agree and I can push it

Re: [libvirt] [V4 RESEND PATCH] Expose resource control capabilites on cache bank

hi Martin Thanks for you reviewing and I am okay with the diff as you suggested. Please help to push this patch. Eli. On Sunday, 4 June 2017 at 5:39 PM, Martin Kletzander wrote: > On Wed, May 17, 2017 at 05:08:33PM +0800, taget wrote: > > From: Eli Qiao <liyong.q.

[libvirt] [V3 PATCH] RFC: Reimplement cache allocation for a VM

From: Eli Qiao <liyong.q...@intel.com> This is a RFC patch for the reimplement of `support cache tune(CAT) in libvirt`[1]. This patch defines some structs to represent data struct in linux resctrl fs which will be used later to do cache allocation. The patch expose a private int

Re: [libvirt] [V4 RESEND PATCH] Expose resource control capabilites on cache bank

ping On Wednesday, 17 May 2017 at 5:08 PM, taget wrote: > From: Eli Qiao <liyong.q...@intel.com (mailto:liyong.q...@intel.com)> > > * This patch amends the cache bank capability as follow: > > > > > > > > > >

[libvirt] [V4 RESEND PATCH] Expose resource control capabilites on cache bank

* This patch amends the cache bank capability as follow: For CDP enabled on x86 arch, we will have: ... * Added a new testdata directory `linux-resctrl-cdp` to test CDP enabled case. * Along with vircaps2xmltest case updated. Signed-off-by: Eli Qiao

Re: [libvirt] Libvirt CAT support plan

On Wednesday, 3 May 2017 at 4:34 PM, Daniel P. Berrange wrote: > On Wed, May 03, 2017 at 08:30:31AM +0800, Eli Qiao wrote: > > hi all, > > > > Thanks for helping reviewing for CAT support in the past days. > > > > I writing this email to ask for the pla

[libvirt] Libvirt CAT support plan

hi all, Thanks for helping reviewing for CAT support in the past days. I writing this email to ask for the plan in libvirt support. I think we’v discussed this early this year, and I’v proposed a patch set [1]. But don’t get merged because of some performance reason ? Then I proposed a

Re: [libvirt] [PATCH RFC V2] RFC: Reimplement cache allocation for a VM

/sys/fs/resctrl ? On Friday, 28 April 2017 at 8:16 PM, Martin Kletzander wrote: > On Fri, Apr 14, 2017 at 06:01:46PM +0800, Eli Qiao wrote: > > This is a RFC patch for the reimplement of `support cache tune(CAT) in > > libvirt`[1]. > > > > > I searched for

Re: [libvirt] [PATCH RFC V2] RFC: Reimplement cache allocation for a VM

Ping Please let me know which is the direction. Thx. On Friday, 14 April 2017 at 6:01 PM, Eli Qiao wrote: > This is a RFC patch for the reimplement of `support cache tune(CAT) in > libvirt`[1]. > > This patch defines some structs to represent data struct in linux > r

[libvirt] [PATCH RFC V2] RFC: Reimplement cache allocation for a VM

* <http://www.gnu.org/licenses/>. + * + * Authors: + * Eli Qiao <liyong.q...@intel.com> + */ + +#include +#include +#include +#include +#include + +#include "virresctrl.h" +#include "virerror.h" +#include "virlog.h" +#include "viralloc.h

[libvirt] [RFC] RFC: Reimplement cache allocation for a VM

General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: + * Eli Qiao <liyong.q...@intel.com> + */ + +#include +#include +#include +#include +#include + +#include "virresctrl.h" +#include "viralloc.h"

[libvirt] [PATCH V5] Expose resource control capabilites on cache bank

with vircaps2xmltest case updated. P.S. here the scope is from /sys/fs/resctrl/info/L3{"" "code" "data"}, I keep it capital upper as I need to use a macro to convert from enum to string easily. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- docs/schemas/capability.rng

Re: [libvirt] [PATCH V4] Expose resource control capabilites on cache bank

On Tuesday, 11 April 2017 at 4:10 PM, Martin Kletzander wrote: > This should just be: > > + if (virAsprintf(, "%s/vircaps2xmldata/linux-%s/resctrl", > + abs_srcdir, data->filename) < 0) > yep, stupid me. I get it now. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH V4] Expose resource control capabilites on cache bank

On Tuesday, 11 April 2017 at 3:48 PM, Peter Krempa wrote: > On Tue, Apr 11, 2017 at 13:44:26 +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > * This patch amends the cache bank

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

> > > > > > > > > > > > @Daniel, > > > > the enum values are same with `type` > > > > unified: 0 > > instruction: 1 > > data: 2 > > > > but scope should be both(0)/code(1)/data(2), so the attribute name will be > > 'both' and 'unified' mean the same thing. > > 'instruction'

[libvirt] [PATCH V4] Expose resource control capabilites on cache bank

with vircaps2xmltest case updated. P.S. here the scope is from /sys/fs/resctrl/info/L3{"" "CODE" "DATA"}, I keep it capital upper as I need to use a macro to convert from enum to string easily. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- docs/schemas/capability.rng

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Friday, 7 April 2017 at 7:06 PM, Daniel P. Berrange wrote: > On Fri, Apr 07, 2017 at 01:04:57PM +0200, Martin Kletzander wrote: > > On Fri, Apr 07, 2017 at 05:47:54PM +0800, Eli Qiao wrote: > > > > > > > > The name doesn't really matter that much, 'scop

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

> > The name doesn't really matter that much, 'scope' makes a bit more > sense, 'type' is consistent with the cache bank specification, I'm fine > with any. The big question here was if it is possible to have: > > > > > > > And from what you say, the simple answer is "yes". So we need to

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thursday, 6 April 2017 at 9:04 PM, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 01:25:35PM +0100, Daniel P. Berrange wrote: > > On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > > > This patch is based on Martin's cache branch. > > > > > &

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thursday, 6 April 2017 at 8:46 PM, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > This patch amends the cache bank capability as follow: > > It helps a lot i

[libvirt] [PATCH V3] Expose resource control capabilites on cache bank

This patch is based on Martin's cache branch. This patch amends the cache bank capability as follow: Along with vircaps2xmltest case updated. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/conf/capabilities.c

Re: [libvirt] [PATCH V2] Expose resource control capabilites on cache bank

On Thursday, 6 April 2017 at 7:56 PM, Daniel P. Berrange wrote: > On Thu, Apr 06, 2017 at 07:32:59PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > This patch amends the cache bank

[libvirt] [PATCH V2] Expose resource control capabilites on cache bank

This patch is based on Martin's cache branch. This patch amends the cache bank capability as follow: Along with vircaps2xmltest case updated. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/conf/capabilities.c

Re: [libvirt] [PATCH] Expose resource control capabilites on cache bank

On Thursday, 6 April 2017 at 5:51 PM, Daniel P. Berrange wrote: > On Thu, Apr 06, 2017 at 11:49:14AM +0200, Martin Kletzander wrote: > > On Thu, Apr 06, 2017 at 04:20:06PM +0800, Eli Qiao wrote: > > > This patch is based on Martin's cache branch. > > > > > &

Re: [libvirt] [PATCH] Expose resource control capabilites on cache bank

On Thursday, 6 April 2017 at 5:49 PM, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 04:20:06PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > This patch amends the cache bank capability as follow: > > > > >

Re: [libvirt] [PATCH] Expose resource control capabilites on cache bank

On Thursday, 6 April 2017 at 5:49 PM, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 04:20:06PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > This patch amends the cache bank capability as follow: > > > > >

Re: [libvirt] [PATCH] Expose resource control capabilites on cache bank

te: > > > > On Thu, Apr 06, 2017 at 04:20:06PM +0800, Eli Qiao wrote: > > > > > This patch is based on Martin's cache branch. > > > > > > > > > > This patch amends the cache bank capability as follow: > >

[libvirt] [PATCH] Expose resource control capabilites on cache bank

This patch is based on Martin's cache branch. This patch amends the cache bank capability as follow: Along with vircaps2xmltest case updated. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/conf/capabilities.c | 112 +-- sr

Re: [libvirt] [PATCH v2 09/12] Add host cache information into capabilities

> + > +VIR_ENUM_IMPL(virCache, VIR_CACHE_TYPE_LAST, > + "unified", > + "instruction", > + "data") > + > }; > > +typedef enum { > + VIR_CACHE_TYPE_DATA, > + VIR_CACHE_TYPE_INSTRUCTION, > + VIR_CACHE_TYPE_UNIFIED, > + > + VIR_CACHE_TYPE_LAST > +} virCacheType; > + The sequence is wrong, it

Re: [libvirt] [PATCH v2 12/12] tests: Add resctrl test for vircaps2xmltest

On Wednesday, 5 April 2017 at 10:36 PM, Martin Kletzander wrote: > Add info from yet another machine, this time with resctrl data so that > we can extend tests easily in a test-driven way. > > Signed-off-by: Martin Kletzander (mailto:mklet...@redhat.com)> > --- >

Re: [libvirt] [PATCH 15/16] tests: Add tests for caches into vircaps2xmltest

> > > > How about for l3: > > > reserved=“2816"/> > > > > > Well, yes, kind of what you had in your patches. Wasn't it without the > 'cbm_len' and 'avail'? The 'cbm_len' is avail/min, so it's redundant > and avail is the same as the size of the whole cache, right? Also > 'reserved'

Re: [libvirt] [PATCH 10/16] util: Add virSysfsGetCPUCache* functions

On Friday, 31 March 2017 at 7:39 PM, Martin Kletzander wrote: > On Fri, Mar 31, 2017 at 05:32:16PM +0800, Eli Qiao wrote: > > > > > > On Thursday, 30 March 2017 at 10:03 PM, Martin Kletzander wrote: > > > > > Signed-off-by: Martin Kletzander <m

Re: [libvirt] [PATCH 15/16] tests: Add tests for caches into vircaps2xmltest

On Friday, 31 March 2017 at 7:19 PM, Martin Kletzander wrote: > On Fri, Mar 31, 2017 at 09:56:32AM +0800, Eli Qiao wrote: > > > > > > > Okay, cool, this comes better than my patches and have some differences. > > I am open with this as long as that it can

[libvirt] [PATCH V3] util: Add more virsysfs functions for handling resctrl sysfs

Extended /sys/fs/resctrl sysfs handling such as: Read string/uint. Write string. Create/remove directory. All these operations will be while we are enabled CAT feature later. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/libvirt_private.syms | 9 +++ src/util/virs

Re: [libvirt] [PATCH 10/16] util: Add virSysfsGetCPUCache* functions

On Thursday, 30 March 2017 at 10:03 PM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander (mailto:mklet...@redhat.com)> > --- > src/libvirt_private.syms | 5 +++ > src/util/virsysfs.c | 102 +++ > src/util/virsysfs.h |

Re: [libvirt] [PATCH 15/16] tests: Add tests for caches into vircaps2xmltest

> Okay, cool, this comes better than my patches and have some differences. I am open with this as long as that it can meet cache allocation requires and everyone will be happy. I am ++ for this. But I am not sure expose all of cache information in the capabilities XML. > > + > + > >

Re: [libvirt] [PATCH 06/16] util: Add virSysfsDirOpen

On Thursday, 30 March 2017 at 10:03 PM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander (mailto:mklet...@redhat.com)> > --- > src/libvirt_private.syms | 1 + > src/util/virsysfs.c | 17 - > src/util/virsysfs.h | 6 ++ > 3 files changed, 23

Re: [libvirt] [PATCH V2 1/2] util: Add more virsysfs functions for handling resctrl sysfs

> > +# util/virresctrl.h > > +virResCtrlAvailable; > > +virResCtrlInit; > > + > > > > > This has nothing to do in the patch > Okay, this should be involved by mistake while rebasing. > > > # util/virrotatingfile.h > > virRotatingFileReaderConsume; > > virRotatingFileReaderFree; > > @@

[libvirt] [PATCH V2 2/2] test: Add fake cpu id file

Added fake cpu cache id and resctrl file Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/

[libvirt] [PATCH V2 1/2] util: Add more virsysfs functions for handling resctrl sysfs

Extended /sys/fs/resctrl sysfs handling. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/libvirt_private.syms | 11 - src/util/virsysfs.c | 102 ++- src/util/virsysfs.h | 16 src/util/virsysfspriv.h | 1 + 4

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

On Wednesday, 29 March 2017 at 5:47 PM, Martin Kletzander wrote: > On Wed, Mar 29, 2017 at 05:31:42PM +0800, Eli Qiao wrote: > > > > > > -- > > Best regards > > Eli > > > > 天涯无处不重逢 > > a leaf duckweed belongs to the sea, where no

[libvirt] [PATCH] test: Add fake cpu id file

Added fake cpu cache id and resctrl file Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/

[libvirt] [PATCH] util: Add more virsysfs functions for handling resctrl sysfs

Extended /sys/fs/resctrl sysfs handling. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/libvirt_private.syms | 4 ++ src/util/virsysfs.c | 98 +++- src/util/virsysfs.h | 15 3 files changed, 116 insertions(+), 1 de

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 29 March 2017 at 5:19 PM, Martin Kletzander wrote: > On Wed, Mar 29, 2017 at 04:22:16PM +0800, Eli Qiao wr

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 29 March 2017 at 3:45 PM, Martin Kletzander wrote: > On Tue, Mar 28, 2017 at 03:22:34PM +0800, Eli Qiao wrote: > >

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

with Sparrow (http://www.sparrowmailapp.com/?sig) On Friday, 24 March 2017 at 3:42 PM, Martin Kletzander wrote: > On Fri, Mar 24, 2017 at 09:35:33AM +0800, Eli Qiao wrote: > > > > > > -- > > Best regards > > Eli > > > > 天涯无处不重逢 > > a

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Thursday, 16 March 2017 at 3:52 PM, Eli Qiao wrote: > > > -- > Best regards > Eli > > 天涯无处不重逢 >

Re: [libvirt] [PATCH resend V10 02/12] Resctrl: expose cache information to capabilities

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 15 March 2017 at 8:53 PM, Martin Kletzander wrote: > On Mon, Mar 06, 2017 at 06:06:31PM +0800, Eli Qiao wrote: > > T

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 15 March 2017 at 7:57 PM, Martin Kletzander wrote: > On Mon, Mar 06, 2017 at 06:06:30PM +0800, Eli Qiao wrote: > > T

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 15 March 2017 at 8:20 PM, Martin Kletzander wrote: > On Mon, Mar 06, 2017 at 06:06:30PM +0800, Eli Qiao wrote: > > T

Re: [libvirt] [PATH V10 12/12] Resctrl: Add nodecachestats

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Tuesday, 7 March 2017 at 5:33 AM, Marcelo Tosatti wrote: > On Mon, Mar 06, 2017 at 05:50:43PM +0800, Eli Qiao wrote: > > Add

[libvirt] [PATH V10 08/12] Resctrl: Compatible mode for cdp enabled

This patch support l3 cache allocation compatible mode if cdp enabled on host. In this case l3code/l3data has same schemata. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/conf/domain_conf.c | 15 +-- src/util/virresctrl.c | 10 ++ 2 files changed, 23 inse

[libvirt] [PATCH resend V10 06/12] Resctrl: enable l3code/l3data

resctrl -o cdp /sys/fs/resctrl Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- docs/schemas/domaincommon.rng | 2 +- src/util/virresctrl.c | 27 +-- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/s

[libvirt] [PATCH resend V10 04/12] Resctrl: Add private interfaces to operate cache bank

directory, and update the schemata after libvirt domain destroy. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/libvirt_private.syms | 6 +- src/util/virresctrl.c| 677 +++ src/util/virresctrl.h| 5 +- 3

[libvirt] [PATCH resend V10 08/12] Resctrl: Compatible mode for cdp enabled

This patch support l3 cache allocation compatible mode if cdp enabled on host. In this case l3code/l3data has same schemata. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/conf/domain_conf.c | 15 +-- src/util/virresctrl.c | 10 ++ 2 files changed, 23 inse

[libvirt] [PATCH resend V10 07/12] Resctrl: Make sure l3data/l3code are pairs

l3data and l3code type of cache banks should be configured pairs. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/conf/domain_conf.c | 19 +++ src/util/virresctrl.c | 1 - src/util/virresctrl.h | 2 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATCH resend V10 11/12] Resctrl: Add Public API for nodecachestats

This patch expose a public API virNodeCacheStats to query cache stats on a host. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- daemon/remote.c| 67 ++ include/libvirt/libvirt-host.h | 32 src/driver-hyperv

[libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

to maintain resource control information. Some of host cpu related information methods was added in virhostcpu.c Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- include/libvirt/virterror.h | 1 + po/POTFILES.in | 1 + src/Makefile.am | 1 + src/libvirt_privat

[libvirt] [PATCH resend V10 02/12] Resctrl: expose cache information to capabilities

Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/conf/capabilities.c | 56 ++ src/conf/capabilities.h | 23 src/libvirt_private.syms | 3 +++ src/nodeinfo.c

[libvirt] [PATCH resend V10 12/12] Resctrl: Add nodecachestats

Add new virsh command line `nodecachestats` to expose the cache usage on a node. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/libvirt_private.syms | 3 ++- src/qemu/qemu_driver.c | 12 ++ src/util/virresctrl.c| 62 +++

[libvirt] [PATCH resend V10 00/12] Support cache tune in libvirt

em fs. There are still one TODO left: 2. Expose a new public interface to set cachetune lively. Some discussion about this feature support can be found from: https://www.redhat.com/archives/libvir-list/2017-January/msg00644.html *** BLURB HERE *** Eli Qiao (12): Resctrl: Add some utils f

[libvirt] [PATCH resend V10 03/12] Resctrl: Add new xml element to support cache tune

This patch adds new xml element to support cache tune as: ... ... id: any non-minus number host_id: reference of the host's cache banks id, it's from capabilities type: cache bank type size: should be multiples of the min_size of the bank on host. vcpus: cache allocation on vcpu set, if

[libvirt] [PATCH resend V10 09/12] Resctrl: concurrence support

bank. We need also to add lock to access /sys/fs/resctrl, use flock. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/util/virresctrl.c | 93 --- src/util/virresctrl.h | 3 ++ 2 files changed, 83 insertions(+), 13 deletions(-) diff

[libvirt] [PATCH resend V10 05/12] Qemu: Set cache tune while booting a new domain.

While user can assign some specific vcpus list in , adds the vcpus' pids to cache bank, else vm->pid will be added to cache bank. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/qemu/qemu_driver.c | 6 -- src/qemu/qemu_proce

[libvirt] [PATCH resend V10 10/12] Resctrl: Scan resctrl before doing cache allocation

Other application may touch resctrl while libvirt's running, scan resctrl again before allocating cache information to the newly created VM. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/util/virresctrl.c | 40 1 file changed, 40 inse

[libvirt] [PATH V10 05/12] Qemu: Set cache tune while booting a new domain.

While user can assign some specific vcpus list in , adds the vcpus' pids to cache bank, else vm->pid will be added to cache bank. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/qemu/qemu_driver.c | 6 -- src/qemu/qemu_proce

[libvirt] [PATH V10 04/12] Resctrl: Add private interfaces to operate cache bank

directory, and update the schemata after libvirt domain destroy. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/libvirt_private.syms | 6 +- src/util/virresctrl.c| 677 +++ src/util/virresctrl.h| 5 +- 3

Re: [libvirt] [PATH v9 12/12] Resctrl: Add nodecachestats

Best regards - Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life 2017-03-03 10:24 GMT+08:00 Marcelo Tosatti <mtosa...@redhat.com (mailto:mtosa...@redhat.com)>: > On Mon, Feb 27, 2017 at 03:22:56PM +0800, Eli Qiao wrote: > > Add new vir

[libvirt] [PATH V10 11/12] Resctrl: Add Public API for nodecachestats

This patch expose a public API virNodeCacheStats to query cache stats on a host. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- daemon/remote.c| 67 ++ include/libvirt/libvirt-host.h | 32 src/driver-hyperv

[libvirt] [PATH V10 07/12] Resctrl: Make sure l3data/l3code are pairs

l3data and l3code type of cache banks should be configured pairs. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/conf/domain_conf.c | 19 +++ src/util/virresctrl.c | 1 - src/util/virresctrl.h | 2 ++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git

[libvirt] [PATH V10 06/12] Resctrl: enable l3code/l3data

resctrl -o cdp /sys/fs/resctrl Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- docs/schemas/domaincommon.rng | 2 +- src/util/virresctrl.c | 27 +-- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/s

[libvirt] [PATH V10 12/12] Resctrl: Add nodecachestats

Add new virsh command line `nodecachestats` to expose the cache usage on a node. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/libvirt_private.syms | 3 ++- src/qemu/qemu_driver.c | 12 ++ src/util/virresctrl.c| 62 +++

[libvirt] [PATH V10 01/12] Resctrl: Add some utils functions

to maintain resource control information. Some of host cpu related information methods was added in virhostcpu.c Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- include/libvirt/virterror.h | 1 + po/POTFILES.in | 1 + src/Makefile.am | 1 + src/libvirt_privat

[libvirt] [PATH V10 09/12] Resctrl: concurrence support

bank. We need also to add lock to access /sys/fs/resctrl, use flock. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/util/virresctrl.c | 93 --- src/util/virresctrl.h | 3 ++ 2 files changed, 83 insertions(+), 13 deletions(-) diff

[libvirt] [PATH V10 10/12] Resctrl: Scan resctrl before doing cache allocation

Other application may touch resctrl while libvirt's running, scan resctrl again before allocating cache information to the newly created VM. Signed-off-by: Eli Qiao <liyong.q...@intel.com> --- src/util/virresctrl.c | 40 1 file changed, 40 inse

[libvirt] [PATH V10 00/12] Support cache tune in libvirt

em fs. There are still one TODO left: 1. Expose a new public interface to get free cache information. 2. Expose a new public interface to set cachetune lively. Some discussion about this feature support can be found from: https://www.redhat.com/archives/libvir-list/2017-January/msg00644

  1   2   3   >