On Tue, Oct 03, 2023 at 02:56:37PM +0200, Erik Skultety wrote:
> On Wed, Sep 27, 2023 at 08:53:41PM +0200, Erik Skultety wrote:
> > While we have already descriptive articles on our GitLab CI, there's
> > recently
> > been some work on the CI front where a few sec
On Wed, Sep 27, 2023 at 08:53:41PM +0200, Erik Skultety wrote:
> While we have already descriptive articles on our GitLab CI, there's recently
> been some work on the CI front where a few sections deserve some updates.
>
> Erik Skultety (7):
> docs: ci-runners: Add a
While we have already descriptive articles on our GitLab CI, there's recently
been some work on the CI front where a few sections deserve some updates.
Erik Skultety (7):
docs: ci-runners: Add a note on a new runner registration process
docs: ci: Update the description on the integrati
While we may have needed to run TCK through Avocado by explicitly using
the '--tap' option (still possible), we can get a nice output from
Avocado by default leaving the option out which is exactly what we do
inside GitLab CI environment.
Signed-off-by: Erik Skultety
---
docs/testt
onment the same way
as we do in GitLab CI or execute everything manually.
This patch takes the opportunity to also link to the virtiofs kbase
article to give users a different option to get the local libvirt
repositories to be used in testing inside a VM.
Signed-off-by: Erik Skultety
---
docs/t
This patch mainly fixes an unfinished sentence that was supposed to
describe the LIBVIRT_CI_INTEGRATION_RUNNER_TAG variable, but took the
opportunity to update the description of the other variable too.
Signed-off-by: Erik Skultety
---
docs/ci.rst | 8 ++--
1 file changed, 6 insertions
arget from Fedora 36 -> 38.
Signed-off-by: Erik Skultety
---
docs/testtck.rst | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/docs/testtck.rst b/docs/testtck.rst
index d7f5483b5f..89760e3f63 100644
--- a/docs/testtck.rst
+++ b/docs/testtck.rst
@
The documented process should be updated to reflect the new process
once GitLab transitions to it completely and drops the old process
involving registration tokens as hinted by the note.
Signed-off-by: Erik Skultety
---
docs/ci-runners.rst | 10 ++
1 file changed, 10 insertions
functionality which only allowed builds, tests and
shell (although important to say it could be adjusted with the right
meson/ninja args).
lcitool also became mandatory as it enables the container execution
which replaced a Makefile we used to have for this purpose.
Signed-off-by: Erik Skultety
sers don't feel like building everything on their own.
Signed-off-by: Erik Skultety
---
docs/testtck.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/testtck.rst b/docs/testtck.rst
index 89760e3f63..f57af61aa8 100644
--- a/docs/testtck.rst
+++ b/docs/testtck.rst
@@ -73,6
On Tue, Sep 19, 2023 at 11:34:19AM +0200, Erik Skultety wrote:
> send-email scans the commit messages to figure out the default set of
> addresses to put into CC, Acked-by/Reviewed-by, etc-by being among
> them. We're quite strict about CC-ing people on libvirt-list, since
> mo
eople solely based on the fact that they've done review
of any of previous revisions.
Signed-off-by: Erik Skultety
---
I noticed this issue when sending
https://listman.redhat.com/archives/libvir-list/2023-September/242173.html
and publish automatically included Dan. I guess I could have
suite sequentially leading to test
stability issues, so abandoning the v98.0 in commit 91774931 was a good
thing in the end.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/jobs.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index adb798d127
rint some important values for debugging
purposes.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 8ae3b87228..861e561039 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -87,
All supported versions of Fedora and CentOS Stream 9 default to modular
setup, it's probably better if we cosmetically adjust the CentOS Stream
version check to make it explicit that monolithic daemon services ought
to be started only on Stream 8.
Signed-off-by: Erik Skultety
Reviewed-by: D
Neither '&>' nor 'source' are defined in POSIX.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/jobs.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 37bca452fa..b52e45cc8c 100644
--- a/
nvironment for the job every time run_integration function is
run. For repeated interactive use case, it is imperative that the
developer takes care of their environment.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/jobs.sh | 7 +++
1 file changed, 7 insertions(+)
diff
We've not been interested in any extra output from the command at all
since we always redirected both stdout and stderr to /dev/null. Future
patch will change that slightly, so --quiet will start making sense.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/jobs.s
applied at parameter passing to run_cmd it's going to be
applied to the debug print as well. Let's introduce another helper,
run_cmd_quiet which takes care of the I/O redirection and executes the
command completely silently.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 5 +
1 file c
Since the section now only consists of a single command, we can happily
move the command to the main integration template job body.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/integration-template.yml | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
EMONS variable that we set depending on the distro we
execute the tests on.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/jobs.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 861e561039..2e6888232f 100644
--- a/ci/jobs.sh
+++ b/ci/jo
es to the vendor locking of Avocado to v98.0 in the past
Erik Skultety (12):
syntax-check: Drop the shell's 'check for minus' rule
ci: integration: Extract the integration CI main recipe to jobs.sh
ci: integration: Adjust the check for CentOS Stream version
ci: integration: Dr
f-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/jobs.sh | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 75ea638580..37bca452fa 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -84,10 +84,14 @@ run_website_b
SI Applications shall not use obsolescent
features."
It is however unlikely that the shell implementations would drop
support for -[ao] despite POSIX potentially removing them.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
build-aux/syntax-check.mk | 9 -
1 file
Follow what's been done to other jobs in .gitlab-ci.yml and extract the
shell logic from YAML to a function in ci/jobs.sh
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/integration-template.yml | 36 ++--
ci/jobs.sh
On Mon, Sep 18, 2023 at 11:31:53AM +0100, Daniel P. Berrangé wrote:
> On Mon, Sep 18, 2023 at 12:22:45PM +0200, Erik Skultety wrote:
> > We tried to evade usage of eval in commit 6214ae55f6a, but trying to
> > use I/O redirections with a command doesn't have the desired effe
All supported versions of Fedora and CentOS Stream 9 default to modular
setup, it's probably better if we cosmetically adjust the CentOS Stream
version check to make it explicit that monolithic daemon services ought
to be started only on Stream 8.
Signed-off-by: Erik Skultety
---
ci/jobs.s
Follow what's been done to other jobs in .gitlab-ci.yml and extract the
shell logic from YAML to a function in ci/jobs.sh
Signed-off-by: Erik Skultety
---
ci/integration-template.yml | 36 ++--
ci/jobs.sh | 32 ++
er to print all commands and use the
redirection only on the actual execution of a given command, let's
adopt eval on "$@" and allow passing redirections as strings later on.
Future patches will demonstrate this.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 4 ++--
1 file changed
EMONS variable that we set depending on the distro we
execute the tests on.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 27add3d105..e10769527a 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -98,6 +98,8 @@ run_integr
f-by: Erik Skultety
---
ci/jobs.sh | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 75ea638580..37bca452fa 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -84,10 +84,14 @@ run_website_build() {
run_integration() {
sudo pip3 ins
nvironment for the job every time run_integration function is
run. For repeated interactive use case, it is imperative that the
developer takes care of their environment.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 7 +++
1 file changed, 7 insertions(+)
diff --git a/ci/jobs.sh b/ci/job
Neither '&>' nor 'source' are defined in POSIX.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 37bca452fa..f4e83dda2e 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -91
We've not been interested in any extra output from the command at all
since we always redirected both stdout and stderr to /dev/null. Future
patch will change that slightly, so --quiet will start making sense.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 2 +-
1 file changed, 1 insertion(
r debugging
purposes.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 3a89cb1a69..27add3d105 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -82,16 +82,16
abandoning the v98.0 was a good thing in the end.
Signed-off-by: Erik Skultety
---
ci/jobs.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index adb798d127..04e776e9be 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
@@ -82,7 +82,6 @@ run_website_build
anged, so I'm proposing this as a
new thing.
Here are test pipelines (both integration as well as normal one) after the
change:
https://gitlab.com/eskultety/libvirt/-/pipelines/1008044353
https://gitlab.com/eskultety/libvirt/-/pipelines/1008098378
Erik Skultety (12):
syntax-check: Drop t
Since the section now only consists of a single command, we can happily
move the command to the main integration template job body.
Signed-off-by: Erik Skultety
---
ci/integration-template.yml | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/ci/integration-template.yml b
it already. Therefore, drop the
rule.
Signed-off-by: Erik Skultety
---
build-aux/syntax-check.mk | 9 -
1 file changed, 9 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index d7cf109fbd..5718768193 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/synta
On Wed, Sep 13, 2023 at 12:57:09PM +0200, Erik Skultety wrote:
> On Wed, Sep 13, 2023 at 08:56:35AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote:
> > > On 9/12/23 7:00 AM, Peter Krempa wrote:
> > > > On Mon,
egression. This patch adds
them back.
Fixes: 8e660c5286d7e2d07dd61681074bf155592d
Signed-off-by: Erik Skultety
---
Technically this is a build breaker fix, but sending for review anyway to see
if there's an agreement on this approach.
ci/jobs.sh | 3 +++
1 file changed, 3 insertions
On Wed, Sep 13, 2023 at 08:56:35AM +0100, Daniel P. Berrangé wrote:
> On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote:
> > On 9/12/23 7:00 AM, Peter Krempa wrote:
> > > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote:
> > > > see https://bugzilla.redhat.com/show_bug.
On Mon, Sep 11, 2023 at 03:02:15PM +0100, Daniel P. Berrangé wrote:
> On Mon, Sep 11, 2023 at 03:43:02PM +0200, Erik Skultety wrote:
> > These are common variables we wish to use in containerized environments
> > both in GitLab and locally. Having these defined in a single place
: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helper | 15 ---
1 file changed, 15 deletions(-)
diff --git a/ci/helper b/ci/helper
index b90dc56ede..c734629731 100755
--- a/ci/helper
+++ b/ci/helper
@@ -75,21 +75,6 @@ class Parser:
help="pa
tical helper for this purpose.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helper | 22 ++
1 file changed, 22 insertions(+)
diff --git a/ci/helper b/ci/helper
index 75552774f6..4727145b28 100755
--- a/ci/helper
+++ b/ci/helper
@@ -14,6 +
Individual shell command executions are replaced by respective
functions in the ci/build.sh base script. This will make sure we use
the same recipes in GitLab jobs as well as in local executions.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
.gitlab-ci.yml
that will source ci/build.sh and run whatever was
specified as --job essentially to simulate the exact steps a GitLab
pipeline job would go through.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helper | 55 +++
This method unused anywhere, so drop it.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helper | 4
1 file changed, 4 deletions(-)
diff --git a/ci/helper b/ci/helper
index fb562d55e1..8986772153 100755
--- a/ci/helper
+++ b/ci/helper
@@ -163,10 +163,6
This helper is a shell function transcript of its original GitLab CI
counterpart.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/ci/build.sh b/ci/build.sh
index 477ccbc7d1..f908bbc5d4 100644
--- a/ci/build.sh
+++ b/ci
ocal build inspection in an interactive container shell session
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
.gitlab-ci.yml | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 944a7b7817..1c6af8f
7; and 'libvirt-pot' targets
in a serial manner.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 11 +++
1 file changed, 11 insertions(+)
diff --git a/ci/build.sh b/ci/build.sh
index e6c3225691..d6361f3ade 100644
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -65,3 +65,14
tions which rely on a shallow
copy of the libvirt repo created as:
$ git clone --local
Even if all changes have been committed, git often complained
otherwise. Updating the index in a GitLab environment is a NOP.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 10 ++
1
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/build.sh | 10 --
1 file changed, 10 deletions(-)
diff --git a/ci/build.sh b/ci/build.sh
index ac649ed9a9..96ee289c4f 100644
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -13,16 +13,6 @@ if ! [ -t 1 ]; then
The idea behind this subcommand is to follow whatever build job we have
defined in the GitLab CI pipeline, so that we only have a single source
of truth for the recipes. Adds 'shell' as an extra option for
interactive container build debugging.
Signed-off-by: Erik Skultety
Reviewed-by
All the functionality this script provided has been incorporated either
in the Python ci/helper tool or lcitool directly.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/Makefile | 245
1 file changed, 245
We've successfully migrated over to lcitool to take care of the
container workload execution, so dropping this 'make' prep code is a
prerequisite of finally getting rid of the ci/Makefile script.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
Previous patches added a single 'run' command parametrized with GitLab
job specs via '--job' that cover all of these original actions, adding
some more in the process. Drop the original actions as we don't need
them anymore.
Signed-off-by: Erik Skultety
Reviewed-by:
':' is just a connecting character, we can add it to the appropriate
place later in the Python script later, but it doesn't make sense to be
part of the image 'tag' string.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helper
Just like with the other CLI sub-commands, add an action to run a
GitLab spec job in a local container via lcitool.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helper | 4
1 file changed, 4 insertions(+)
diff --git a/ci/helper b/ci/helper
index
This helper is a shell function transcript of its original GitLab CI
counterpart.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/ci/build.sh b/ci/build.sh
index ab56c5e5eb..29b6a3306d 100644
--- a/ci/build.sh
+++ b/ci
Individual shell command executions are replaced by respective
functions in the ci/build.sh base script. This will make sure we use
the same recipes in GitLab jobs as well as in local executions.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
.gitlab-ci.yml
A proper Python equivalent of 'git clone --local'.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helper | 4
1 file changed, 4 insertions(+)
diff --git a/ci/helper b/ci/helper
index 6aca089db4..392702ae41 100755
--- a/ci/helper
+++ b
definitions.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/ci/build.sh b/ci/build.sh
index fd326dad8d..ac649ed9a9 100644
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -21,10 +21,7 @@ GIT_ROOT="$(git rev-parse --
This helper will be utilized by a future patch which will add the
lcitool container execution logic. The reason why the required_deps
decorator isn't being used here is because this is a property.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helpe
We'll soon be relying solely on lcitool so we need to be able to run it
from a user-provided location if it's not installed in a known
location.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/helper | 6 ++
1 file changed, 6 insertions(+)
di
Individual shell command executions are replaced by respective
functions in the ci/build.sh base script. This will make sure we use
the same recipes in GitLab jobs as well as in local executions.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
.gitlab-ci.yml
that
in a transitive manner.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/ci/build.sh b/ci/build.sh
index 5883542b45..477ccbc7d1 100644
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -32,3 +32,8 @@ run_cmd() {
printf "\e[32
Individual shell command executions are replaced by respective
functions in the ci/build.sh base script. This will make sure we use
the same recipes in GitLab jobs as well as in local executions.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
.gitlab-ci.yml
This helper is a shell function transcript of its original GitLab CI
counterpart.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 7 +++
1 file changed, 7 insertions(+)
diff --git a/ci/build.sh b/ci/build.sh
index c558b4c9ca..8e1619d483 100644
--- a/ci/build.sh
+++ b/ci
This helper is a shell function transcript of its original GitLab CI
counterpart.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 8
1 file changed, 8 insertions(+)
diff --git a/ci/build.sh b/ci/build.sh
index 29b6a3306d..e6c3225691 100644
--- a/ci/build.sh
+++ b/ci
he job ran in a GitLab environment.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 2 --
1 file changed, 2 deletions(-)
diff --git a/ci/build.sh b/ci/build.sh
index 8e1619d483..fd326dad8d 100644
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -1,7 +1,5 @@
#!/bin/sh
-cd "$CI_CO
Individual shell command executions are replaced by respective
functions in the ci/build.sh base script. This will make sure we use
the same recipes in GitLab jobs as well as in local executions.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
.gitlab-ci.yml
;t lose track of the *actual* shell commands being run as
part of the GitLab job pipelines. An example of what the output then
might look like:
[RUN COMMAND]: 'meson compile -C build install-web'
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 5 +
1 file changed,
This helper is a shell function transcript of its original GitLab CI
counterpart.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 9 +
1 file changed, 9 insertions(+)
diff --git a/ci/build.sh b/ci/build.sh
index d6361f3ade..c558b4c9ca 100644
--- a/ci/build.sh
+++ b/ci
o
longer descriptive enough and 'jobs.sh' feels more suitable and less
misleading.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/{build.sh => jobs.sh} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename ci/{build.sh => jobs.sh} (100%)
diff --git a/ci/build.sh b/ci/
Previous patches have removed the code that allowed injecting arbitrary
meson arguments, same for ninja args.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/build.sh | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/ci/build.sh b/ci
These are common variables we wish to use in containerized environments
both in GitLab and locally. Having these defined in a single place
rather than twice is highly preferable.
Signed-off-by: Erik Skultety
Erik Skultety :
---
ci/build.sh | 12 +++-
1 file changed, 11 insertions(+), 1
.html
[2] https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/431
Erik Skultety (35):
ci: build.sh: Add variables from .gitlab-ci.yml
ci: build.sh: Add GIT_ROOT env helper variable
ci: build.sh: Don't mention that MESON_ARGS are available via CLI
ci: build.sh: Add a wrapper function
We'll use this one in many of the job functions future patches will
introduce, it's a neat shortcut to avoid using relative paths.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
Erik Skultety :
---
ci/build.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ci/bui
On Thu, Aug 31, 2023 at 05:45:05PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:09PM +0200, Erik Skultety wrote:
> > These are common variables we wish to use in containerized environments
> > both in GitLab and locally. Having these defined in a single place
On Fri, Sep 01, 2023 at 10:46:06AM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 31, 2023 at 03:30:23PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Aug 25, 2023 at 07:55:13PM +0200, Erik Skultety wrote:
> > > This would normally be not needed at all, but the problem here is
On Fri, Sep 01, 2023 at 10:41:26AM +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 01, 2023 at 11:39:34AM +0200, Erik Skultety wrote:
> > On Fri, Sep 01, 2023 at 02:15:59AM -0700, Andrea Bolognani wrote:
> > > On Thu, Aug 31, 2023 at 04:53:47PM +0100, Daniel P. Berrangé wrote
On Fri, Sep 01, 2023 at 02:15:59AM -0700, Andrea Bolognani wrote:
> On Thu, Aug 31, 2023 at 04:53:47PM +0100, Daniel P. Berrangé wrote:
> > I'm also strongly inclined to archive the following:
> >
> > * libvirt-cim
> > * libvirt-appdev-guide-python
> > * libvirt-publican
> > * libvirt-sandb
On Thu, Aug 31, 2023 at 05:17:13PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:08PM +0200, Erik Skultety wrote:
> > Technically a v2 of:
> > https://listman.redhat.com/archives/libvir-list/2023-February/237552.html
> >
> > However, the approach her
On Fri, Sep 01, 2023 at 10:10:55AM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:13PM +0200, Erik Skultety wrote:
> > This would normally be not needed at all, but the problem here is the
> > Shell-in-YAML which GitLab interprets. It outputs every command that
&
On Fri, Aug 25, 2023 at 07:55:19PM +0200, Erik Skultety wrote:
> This helper is a shell function transcript of its original GitLab CI
> counterpart.
>
> Signed-off-by: Erik Skultety
> ---
> ci/build.sh | 11 +++
> 1 file changed, 11 insertions(+)
>
> di
On Thu, Aug 31, 2023 at 06:28:16PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:08PM +0200, Erik Skultety wrote:
> > Technically a v2 of:
> > https://listman.redhat.com/archives/libvir-list/2023-February/237552.html
> >
> > However, the approach her
On Thu, Aug 31, 2023 at 05:59:26PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:22PM +0200, Erik Skultety wrote:
> > We've moved all invocations to the respective helper function which
> > we'll execute both from gitlab CI jobs and local environment
On Thu, Aug 31, 2023 at 05:55:54PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:19PM +0200, Erik Skultety wrote:
> > This helper is a shell function transcript of its original GitLab CI
> > counterpart.
> >
> > Signed-off-by: Erik Skultety
&g
On Thu, Aug 31, 2023 at 05:55:21PM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 25, 2023 at 07:55:18PM +0200, Erik Skultety wrote:
> > This helper is a shell function transcript of its original GitLab CI
> > counterpart. There's one notable difference such that we pass &#
On Thu, Aug 31, 2023 at 09:50:07AM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 31, 2023 at 01:43:44AM -0700, Andrea Bolognani wrote:
> > On Wed, Aug 30, 2023 at 07:25:23PM +0200, Erik Skultety wrote:
> > > On Wed, Aug 30, 2023 at 06:22:33PM +0200, Andrea Bolognani wrote:
ing
'--setopt=install_weak_deps=False'. Footprint aside, I don't see a practical
problem having both installed even if unused since it allows users switching
between the deployment modes seamlessly without having to go and install an
extra package.
FWIW:
Reviewed-by: Erik Skultety
gt; to parse the firmware that has not been loaded yet. We must delay
> building the VMSA in that scenario.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Erik Skultety
'host-passthrough' is used")
> +
> sig = capsdoc.xpath("/capabilities/host/cpu/signature")
> if len(sig) != 1:
> raise UnsupportedUsageException(
> --
> 2.41.0
>
Reviewed-by: Erik Skultety
On Mon, Aug 28, 2023 at 04:44:35PM -0500, Jonathon Jongsma wrote:
> This is the seventh version of this patch series. See
> https://bugzilla.redhat.com/show_bug.cgi?id=2016527 for more information.
>
> Note that testing this requires selinux policy changes which are not fully
> done, but there is
This change was supposed to be part of commit 120a674f , but was
proposed against the libvirt TCK project instead. Since we're running
the TCK test suite as part of this project, this is the right place for
the TCK runtime deps list config.
Signed-off-by: Erik Skultety
---
ci/lcitool/pro
tions which rely on a shallow
copy of the libvirt repo created as:
$ git clone --local
Even if all changes have been committed, git often complained
otherwise. Updating the index in a GitLab environment is a NOP.
Signed-off-by: Erik Skultety
---
ci/build.sh | 12
1 file change
Individual shell command executions are replaced by respective
functions in the ci/build.sh base script. This will make sure we use
the same recipes in GitLab jobs as well as in local executions.
Signed-off-by: Erik Skultety
---
.gitlab-ci.yml | 5 ++---
1 file changed, 2 insertions(+), 3
This helper will be utilized by a future patch which will add the
lcitool container execution logic. The reason why the required_deps
decorator isn't being used here is because this is a property.
Signed-off-by: Erik Skultety
---
ci/helper | 9 +
1 file changed, 9 insertions(+)
Just like with the other CLI sub-commands, add an action to run a
GitLab spec job in a local container via lcitool.
Signed-off-by: Erik Skultety
---
ci/helper | 4
1 file changed, 4 insertions(+)
diff --git a/ci/helper b/ci/helper
index 887e64ece1..7385d3b95c 100755
--- a/ci/helper
+++ b
1 - 100 of 3810 matches
Mail list logo
