Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-17 Thread Erik Skultety
... > > FWIW, when I'm writing Go code I have used emacs 'go-mode' and > this runs 'go fmt' to automatically fix your style problems > every time you save the file. So your code is basically always > correct, and you don't need a separate job to check it later. Since you mentioned ^this, we

Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-10 Thread Erik Skultety
On Wed, Oct 09, 2019 at 02:01:37PM +0200, Peter Krempa wrote: > On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote: > > [...] > > > - src/rpc/gendispatch.pl > > - src/rpc/genprotocol.pl > > - tools/wireshark/util/genxdrstub.pl > > [...] > > > Note that the check-spacing.py script is

Re: [libvirt] [PATCH] qemu: capabilities: Fill in bochs-display info

2019-10-04 Thread Erik Skultety
t in, but since we're already one release late, I think it can way 1 more :). Nevertheless: Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/1] admin_server: use VIR_AUTOFREE() in adminClientGetInfo string

2019-10-01 Thread Erik Skultety
On Tue, Oct 01, 2019 at 03:54:02PM +0100, Daniel P. Berrangé wrote: > On Tue, Oct 01, 2019 at 11:49:25AM -0300, Daniel Henrique Barboza wrote: > > > > > > On 10/1/19 11:25 AM, Ján Tomko wrote: > > > On Tue, Oct 01, 2019 at 03:59:07PM +0200, Erik Skultety wrote: >

Re: [libvirt] [PATCH 1/1] admin_server: use VIR_AUTOFREE() in adminClientGetInfo string

2019-10-01 Thread Erik Skultety
On Tue, Oct 01, 2019 at 03:28:27PM +0100, Daniel P. Berrangé wrote: > On Tue, Oct 01, 2019 at 04:25:42PM +0200, Ján Tomko wrote: > > On Tue, Oct 01, 2019 at 03:59:07PM +0200, Erik Skultety wrote: > > > On Tue, Oct 01, 2019 at 09:12:58AM -0300, Daniel Henrique Barboza wrote:

Re: [libvirt] [PATCH 1/1] admin_server: use VIR_AUTOFREE() in adminClientGetInfo string

2019-10-01 Thread Erik Skultety
On Tue, Oct 01, 2019 at 09:12:58AM -0300, Daniel Henrique Barboza wrote: > Signed-off-by: Daniel Henrique Barboza > --- Reviewed-by: Erik Skultety and safe for freeze -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: document that C & Python are the preferred languages

2019-10-01 Thread Erik Skultety
On Tue, Oct 01, 2019 at 10:27:33AM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 30, 2019 at 08:50:51PM +, Jim Fehlig wrote: > > On 9/23/19 7:52 AM, Daniel P. Berrangé wrote: > > > On Thu, Sep 05, 2019 at 06:15:04PM +0100, Daniel P. Berrangé wrote: > > >> On Thu, Sep 05, 2019 at 12:30:27PM

Re: [libvirt] [PATCH 5/5] tools: Record NSS dependency on symbols file

2019-09-30 Thread Erik Skultety
t dependency into the Makefile then. Unfortunately, > setting _DEPENDENCIES makes us lose automake's generated > dependencies (see src/Makefile.am:592 for details). But > fortunately, the only dependency we had was _LIBADD variable. > > Signed-off-by: Michal Privoznik > --- Reviewed-by:

Re: [libvirt] [PATCH 3/5] nss: Don't leak @addr in gethostbyname4()

2019-09-30 Thread Erik Skultety
On Sat, Sep 28, 2019 at 10:05:31PM +0200, Michal Privoznik wrote: > Similarly to gethostbyname3(), the @addr must be freed on return > from the function. > > Signed-off-by: Michal Privoznik > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@r

Re: [libvirt] [PATCH 4/5] libvirt_nss.h: Separate function declarations with an empty line

2019-09-30 Thread Erik Skultety
On Sat, Sep 28, 2019 at 10:05:32PM +0200, Michal Privoznik wrote: > I find it more readable that way. > > Signed-off-by: Michal Privoznik > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/5] nss: Drop needless free() in gethostbyname3()

2019-09-30 Thread Erik Skultety
ords as addr == NULL. > > Signed-off-by: Michal Privoznik > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/5] nss: Compare addresses iff their family matches

2019-09-30 Thread Erik Skultety
ress family of each item of the array > must be considered. > > Signed-off-by: Michal Privoznik > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] remote: fix systemd IP socket activation with virtproxyd

2019-09-27 Thread Erik Skultety
On Fri, Sep 27, 2019 at 01:20:51PM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 27, 2019 at 02:15:45PM +0200, Erik Skultety wrote: > > On Fri, Sep 27, 2019 at 01:09:31PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 25, 2019 at 09:42:57AM +0200, Erik Skultety wrote: >

Re: [libvirt] [PATCH] remote: fix systemd IP socket activation with virtproxyd

2019-09-27 Thread Erik Skultety
On Fri, Sep 27, 2019 at 01:09:31PM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 25, 2019 at 09:42:57AM +0200, Erik Skultety wrote: > > On Tue, Sep 24, 2019 at 04:07:17PM +0100, Daniel P. Berrangé wrote: > > > We recently forbid the use of --listen with socket activation: &g

Re: [libvirt] [PATCH 3/6] qemu_driver: use VIR_AUTOUNREF() with virQEMUDriverConfigPtr 3/3

2019-09-27 Thread Erik Skultety
On Thu, Sep 26, 2019 at 01:15:16PM -0300, Daniel Henrique Barboza wrote: > > > On 9/26/19 6:18 AM, Erik Skultety wrote: > > On Wed, Sep 18, 2019 at 11:56:55AM -0300, Daniel Henrique Barboza wrote: > > > virQEMUDriverConfigPtr can be auto-unref for the great majorit

Re: [libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-27 Thread Erik Skultety
On Thu, Sep 26, 2019 at 04:38:49PM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 26, 2019 at 05:34:49PM +0200, Ján Tomko wrote: > > On Thu, Sep 26, 2019 at 02:16:04PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Sep 26, 2019 at 12:39:39PM +0200, Erik Skultety wrote: > >

Re: [libvirt] [PATCH] tests: qemucapabilities: Update caps of qemu-4.1 to released version

2019-09-27 Thread Erik Skultety
On Fri, Sep 27, 2019 at 07:35:37AM +0200, Peter Krempa wrote: > Now that qemu 4.1 was released we can update the capabilities to the > final form. > > Signed-off-by: Peter Krempa > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.red

Re: [libvirt] [PATCH] domain_conf: Unref video private data in virDomainVideoDefClear()

2019-09-26 Thread Erik Skultety
On Thu, Sep 26, 2019 at 05:01:24PM +0200, Michal Privoznik wrote: > On 9/26/19 4:42 PM, Erik Skultety wrote: > > On Thu, Sep 26, 2019 at 04:25:05PM +0200, Michal Privoznik wrote: > > > The private data for video definition is created in > > > virDomainVideoDefN

Re: [libvirt] [PATCH] domain_conf: Unref video private data in virDomainVideoDefClear()

2019-09-26 Thread Erik Skultety
seXML (domain_conf.c:21158) >by 0x51C5973: virDomainDefParseNode (domain_conf.c:21708) >by 0x51C583A: virDomainDefParse (domain_conf.c:21663) >by 0x51C58AE: virDomainDefParseFile (domain_conf.c:21688) Impressive that we haven't uncovered it sooner. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH v3 04/22] build-aux: rewrite duplicate header checker in Python

2019-09-26 Thread Erik Skultety
> +errs = True > +else: > +includes[inc] = True > + > +return errs > + > + > +ret = 0 > + > +for filename in sys.argv[1:]: > +if check_file(filename): > +ret = 1 so, how about instead of using @re

Re: [libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-26 Thread Erik Skultety
On Tue, Sep 24, 2019 at 03:58:44PM +0100, Daniel P. Berrangé wrote: > As part of an goal to eliminate Perl from libvirt build tools, > rewrite the minimize-po.pl tool in Python. > > This was a straight conversion, manually going line-by-line to > change the syntax from Perl to Python. Thus the

Re: [libvirt] [PATCH 6/6] qemu_driver: use VIR_AUTOFREE() with strings 3/3

2019-09-26 Thread Erik Skultety
On Wed, Sep 18, 2019 at 11:56:58AM -0300, Daniel Henrique Barboza wrote: > VIR_AUTOFREE is a beautiful macro. Let's use it across the board > inside qemu_driver.c to make the code a bit tidier and smaller, > sparing VIR_FREE() calls and sometimes a whole 'cleanup' > label. > > This is the last

Re: [libvirt] [PATCH 4/6] qemu_driver: use VIR_AUTOFREE() with strings 1/3

2019-09-26 Thread Erik Skultety
On Wed, Sep 18, 2019 at 11:56:56AM -0300, Daniel Henrique Barboza wrote: > VIR_AUTOFREE is a beautiful macro. Let's use it across the board > inside qemu_driver.c to make the code a bit tidier and smaller, > sparing VIR_FREE() calls and sometimes a whole 'cleanup' > label. > > This is a huge

Re: [libvirt] [PATCH 3/6] qemu_driver: use VIR_AUTOUNREF() with virQEMUDriverConfigPtr 3/3

2019-09-26 Thread Erik Skultety
On Wed, Sep 18, 2019 at 11:56:55AM -0300, Daniel Henrique Barboza wrote: > virQEMUDriverConfigPtr can be auto-unref for the great majority > of the uses made in qemu_driver, sparing us a virObjectUnref() > call and sometimes a whole 'cleanup' label. > > This patch changes virQEMUDriverConfigPtr

Re: [libvirt] [PATCH 2/6] qemu_driver: use VIR_AUTOUNREF() with virQEMUDriverConfigPtr 2/3

2019-09-26 Thread Erik Skultety
On Wed, Sep 18, 2019 at 11:56:54AM -0300, Daniel Henrique Barboza wrote: > virQEMUDriverConfigPtr can be auto-unref for the great majority > of the uses made in qemu_driver, sparing us a virObjectUnref() > call and sometimes a whole 'cleanup' label. > > This patch changes virQEMUDriverConfigPtr

Re: [libvirt] [PATCH] remote: fix systemd IP socket activation with virtproxyd

2019-09-25 Thread Erik Skultety
On Tue, Sep 24, 2019 at 04:07:17PM +0100, Daniel P. Berrangé wrote: > We recently forbid the use of --listen with socket activation: > > commit 3a6a725b8f575890ee6c151ad1f46ea0ceea1f3b > Author: Daniel P. Berrangé > Date: Thu Aug 22 14:52:16 2019 +0100 > > remote: forbid the

Re: [libvirt] [PATCH] spec: Drop unittest overrides

2019-09-25 Thread Erik Skultety
off-by: Cole Robinson > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [libvirt-tck PATCH] conf: Drop UML from the suite

2019-09-24 Thread Erik Skultety
Libvirt dropped UML in v5.0.0 so there's no reason for us not to follow along. Signed-off-by: Erik Skultety --- conf/default.cfg| 26 -- lib/Sys/Virt/TCK.pm | 2 -- 2 files changed, 28 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index d9fd0cb

[libvirt] [libvirt-tck PATCH] domain: Relax the checks matching disk sizes

2019-09-24 Thread Erik Skultety
-by: Erik Skultety --- scripts/domain/121-block-info.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/domain/121-block-info.t b/scripts/domain/121-block-info.t index bfff48c..d9d644e 100644 --- a/scripts/domain/121-block-info.t +++ b/scripts/domain/121-block-info.t

Re: [libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-24 Thread Erik Skultety
On Tue, Sep 24, 2019 at 12:02:44PM +0200, Andrea Bolognani wrote: > On Tue, 2019-09-24 at 08:27 +0200, Erik Skultety wrote: > > On Mon, Sep 23, 2019 at 04:47:06PM -0400, Laine Stump wrote: > > > On 9/23/19 1:27 PM, Erik Skultety wrote: > > > > The nwfilter 22

Re: [libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-24 Thread Erik Skultety
On Tue, Sep 24, 2019 at 05:41:30AM -0400, Laine Stump wrote: > On Tue, Sep 24, 2019, 2:25 AM Erik Skultety wrote: > > > On Mon, Sep 23, 2019 at 04:47:06PM -0400, Laine Stump wrote: > > > On 9/23/19 1:27 PM, Erik Skultety wrote: > > > > > > From m

Re: [libvirt] [libvirt-tck PATCH] conf: Upgrade the used version of fedora to 30

2019-09-24 Thread Erik Skultety
On Tue, Sep 24, 2019 at 09:19:19AM +0200, Fabiano Fidêncio wrote: > On Tue, Sep 24, 2019 at 9:01 AM Erik Skultety wrote: > > > > Fedora 28 is already EOL and the URLs don't work anymore either because > > EOL resources eventually move to > > http://archives.fedorapro

[libvirt] [libvirt-tck PATCH] conf: Upgrade the used version of fedora to 30

2019-09-24 Thread Erik Skultety
Fedora 28 is already EOL and the URLs don't work anymore either because EOL resources eventually move to http://archives.fedoraproject.org/pub/archive/fedora/ from https://dl.fedoraproject.org/pub/fedora/linux/releases/. --- Notes: I'm wondering whether we shouldn't drop the secondary i686

Re: [libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-24 Thread Erik Skultety
On Mon, Sep 23, 2019 at 04:47:06PM -0400, Laine Stump wrote: > On 9/23/19 1:27 PM, Erik Skultety wrote: > > The nwfilter 220-no-ip-spoofing.t test relies on an SSH connection to > > the test VM. However, because the domain definition passed to libvirt > > lacks an RNG device,

Re: [libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-24 Thread Erik Skultety
On Mon, Sep 23, 2019 at 04:47:06PM -0400, Laine Stump wrote: > On 9/23/19 1:27 PM, Erik Skultety wrote: > > The nwfilter 220-no-ip-spoofing.t test relies on an SSH connection to > > the test VM. However, because the domain definition passed to libvirt > > lacks an RNG device,

[libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-23 Thread Erik Skultety
The nwfilter 220-no-ip-spoofing.t test relies on an SSH connection to the test VM. However, because the domain definition passed to libvirt lacks an RNG device, the SSH server isn't started inside the guest (even though that is the default on virt-builder images) and therefore: "ssh: connect to

Re: [libvirt] [PATCH] docs: kbase: Add a section explaining how to verify SEV from the guest

2019-09-23 Thread Erik Skultety
On Mon, Sep 23, 2019 at 11:06:34AM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 20, 2019 at 01:47:09PM +0200, Erik Skultety wrote: > > Commit 50dfabbb59 forgot to add this important bit on how to check that > > all the changes to the XML actually worked. > >

Re: [libvirt] [PATCH] docs: kbase: Add a section explaining how to verify SEV from the guest

2019-09-23 Thread Erik Skultety
On Mon, Sep 23, 2019 at 10:11:47AM +0200, Ján Tomko wrote: > On Fri, Sep 20, 2019 at 01:47:09PM +0200, Erik Skultety wrote: > > Commit 50dfabbb59 forgot to add this important bit on how to check that > > all the changes to the XML actually worked. > > --- > > docs/kbase/

Re: [libvirt] [PATCH 3/3] qemu_hotplug.c: use VIR_AUTOFREE() in strings 3/3

2019-09-23 Thread Erik Skultety
sage and push. Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/3] qemu_hotplug.c: use VIR_AUTOFREE() in strings 2/3

2019-09-23 Thread Erik Skultety
On Wed, Sep 18, 2019 at 04:53:07PM -0300, Daniel Henrique Barboza wrote: > Using VIR_AUTOFREE() spare us from calling VIR_VREE() and > sometimes a whole 'cleanup' label can be erased as well. > > There are quite a few strings in qemu_hotplug.c to be > auto-freed. This is the second part of this

Re: [libvirt] [PATCH 1/3] qemu_hotplug.c: use VIR_AUTOFREE() in strings 1/3

2019-09-23 Thread Erik Skultety
On Wed, Sep 18, 2019 at 04:53:06PM -0300, Daniel Henrique Barboza wrote: > Using VIR_AUTOFREE() spare us from calling VIR_VREE() and > sometimes a whole 'cleanup' label can be erased as well. > > There are quite a few strings in qemu_hotplug.c to be > auto-freed. This is the first part of this

Re: [libvirt] [PATCH v2 2/2] qemu_domain_address: use virPCIDeviceAddressEqual() in conditionals

2019-09-23 Thread Erik Skultety
t;info.addr, if we settled beforehand that @cont->info.addr > is not present or bogus. > > Suggested-by: Erik Skultety > Signed-off-by: Daniel Henrique Barboza > --- > src/qemu/qemu_domain_address.c | 56 +++--- > 1 file changed, 25 insertions(+), 31

Re: [libvirt] [PATCH v2 0/2] a few cleanups in qemu_domain_address.c

2019-09-23 Thread Erik Skultety
als > > src/qemu/qemu_domain_address.c | 125 +++-- > 1 file changed, 55 insertions(+), 70 deletions(-) Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] docs: kbase: Add a section explaining how to verify SEV from the guest

2019-09-20 Thread Erik Skultety
Commit 50dfabbb59 forgot to add this important bit on how to check that all the changes to the XML actually worked. --- docs/kbase/launch_security_sev.html.in | 12 1 file changed, 12 insertions(+) diff --git a/docs/kbase/launch_security_sev.html.in

Re: [libvirt] [PATCH 2/2] virpci, qemu_domain_address: adding virPCIDeviceSetAddress

2019-09-20 Thread Erik Skultety
On Thu, Sep 19, 2019 at 05:04:47PM -0300, Daniel Henrique Barboza wrote: > A common operation in qemu_domain_address is comparing a > virPCIDeviceAddress and assigning domain, bus, slot and function > to a specific value. The former can be done with the existing > virPCIDeviceAddressEqual()

Re: [libvirt] [PATCH 1/2] qemu_domain_address.c: use VIR_AUTOFREE() in strings

2019-09-20 Thread Erik Skultety
On Thu, Sep 19, 2019 at 05:04:46PM -0300, Daniel Henrique Barboza wrote: > A few 'cleanup' labels gone after using VIR_AUTOFREE() in the > strings. s/in the strings/on the @addrStr variable Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redh

Re: [libvirt] [PATCH] qemu: maintain user alias for video type 'none'

2019-09-06 Thread Erik Skultety
eo(virDomainDefPtr def, > return 0; > > if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_NONE) { > +char *alias; I'd put a blank line here to separate the declaration from everything else. Reviewed-by: Erik Skultety > /* we don't want to fo

Re: [libvirt] [PATCH] vircgroupv2: fix setting cpu.max period

2019-09-06 Thread Erik Skultety
t; @@ -1508,7 +1508,7 @@ virCgroupV2SetCpuCfsPeriod(virCgroupPtr group, > _("Invalid 'cpu.max' data.")); > return -1; > } > -*tmp = '\n'; > +*tmp = '\0'; > > if (virAsprintf(, "%s %llu", str, cfs_period) &l

Re: [libvirt] [PATCH] qemu: domain: Fix potential NULL deref when parsing job private data

2019-09-02 Thread Erik Skultety
; just treat it as a wrong job XML. Found by Coverity. > > Reported-by: John Ferlan > Signed-off-by: Peter Krempa > --- Reviewed-by: Erik Skultety safe for freeze -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH trivial] qemu_conf.c: removing unused virQEMUDriverConfigPtr variable

2019-08-30 Thread Erik Skultety
On Fri, Aug 30, 2019 at 07:03:55AM -0300, Daniel Henrique Barboza wrote: > 'virQEMUDriverConfigPtr cfg' is declared, initiated, but never > used in virQEMUDriverCreateCapabilities(). > > Signed-off-by: Daniel Henrique Barboza > --- Reviewed-by: Erik Skultety and safe for freeze

Re: [libvirt] [PATCH v2] qemu: agent: fix potential leak in qemuAgentGetFSInfo()

2019-08-29 Thread Erik Skultety
On Thu, Aug 29, 2019 at 08:56:29AM -0500, Jonathon Jongsma wrote: > On error paths, info_ret could potentially leak. Make sure it's freed. > > Signed-off-by: Jonathon Jongsma Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

Re: [libvirt] [PATCH] qemu: agent: fix potential leak in qemuAgentGetFSInfo()

2019-08-29 Thread Erik Skultety
On Wed, Aug 28, 2019 at 01:48:14PM -0500, Jonathon Jongsma wrote: > On error paths, info_ret could potentially leak. Make sure it's freed. The patch is missing your "Developer Certificate of Origin" aka Signed-off-by, I can't merge it without it. Otherwise: Reviewed-by: Erik Skultet

Re: [libvirt] [PATCH 0/4] remote: Enforce RPC limits when encoding typed params

2019-08-27 Thread Erik Skultety
On Tue, Aug 27, 2019 at 02:05:05PM +0200, Michal Privoznik wrote: > Couple of bug fixes here. Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [jenkins-ci PATCH v2] guests: Introduce a var to enable shallow git clones for projects

2019-08-27 Thread Erik Skultety
First of all, we don't need the full history for builds and we can save some time during the prepare phase. The disk footprint is about 5x smaller, but the most important thing is the repo clone duration difference e.g. in libvirt's case is quite significant: full history: real 3m45.236s user

Re: [libvirt] [jenkins-ci PATCH] Use shallow git clones for projects

2019-08-27 Thread Erik Skultety
On Tue, Aug 27, 2019 at 02:12:12PM +0100, Daniel P. Berrangé wrote: > On Tue, Aug 27, 2019 at 02:56:02PM +0200, Erik Skultety wrote: > > First of all, we don't need the full history for builds and we can save > > some time during the prepare phase. The disk footprint is about

[libvirt] [jenkins-ci PATCH] Use shallow git clones for projects

2019-08-27 Thread Erik Skultety
First of all, we don't need the full history for builds and we can save some time during the prepare phase. The disk footprint is about 5x smaller, but the most important thing is the repo clone duration difference e.g. in libvirt's case is quite significant: full history: real 3m45.236s user

Re: [libvirt] [PATCH] mdev: point user to mdevctl for missing devices

2019-08-20 Thread Erik Skultety
On Mon, Aug 19, 2019 at 02:30:05PM -0500, Jonathon Jongsma wrote: > When a host is rebooted, any mediated devices that were previously > configured will disappear. There have been requests for libvirt to > handle persisting these mediated devices across reboots, but the > decision was made that

Re: [libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-16 Thread Erik Skultety
On Fri, Aug 16, 2019 at 05:57:36PM +0300, Ilias Stamatis wrote: > On Fri, Aug 16, 2019 at 5:39 PM Erik Skultety wrote: > > > > ... > > > > > + > > > +if (operation == TEST_DEVICE_DETACH) > > > +parse_flags |= VIR_DOMAIN_DEF_PARSE_SKIP_VA

Re: [libvirt] [PATCH v2 6/6] test_driver: implement virDomainUpdateDeviceFlags

2019-08-16 Thread Erik Skultety
ef->nets[idx] = net; > +dev->data.net = NULL; > +ret = 0; > +break; > + > +default: > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > + _("neither persistent nor live update of device > is supported")); > +goto cleanup; return -1; > +} > + > +ret = 0; > + cleanup: drop the cleanup label Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 5/6] test_driver: implement virDomainDetachDeviceAlias

2019-08-16 Thread Erik Skultety
On Wed, Aug 14, 2019 at 07:47:09PM +0300, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 3/6] test_driver: implement virDomainDetachDeviceFlags

2019-08-16 Thread Erik Skultety
> + > +virDomainShmemDefFree(virDomainShmemDefRemove(vmdef, idx)); > +break; > + ^Extra line Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-16 Thread Erik Skultety
E_UPDATE: > +break; > +} > + > +ret = 0; > + cleanup: > +if (xml) > +virDomainDeviceDefFree(dev); > + else > +VIR_FREE(dev); virDomainDeviceDefFree() can handle both cases. Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 4/6] test_driver: implement virDomainDetachDevice

2019-08-16 Thread Erik Skultety
/* 5.7.0 */ > .domainDetachDeviceFlags = testDomainDetachDeviceFlags, /* 5.7.0 */ > .domainGetAutostart = testDomainGetAutostart, /* 0.3.2 */ > .domainSetAutostart = testDomainSetAutostart, /* 0.3.2 */ Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/6] test_driver: implement virDomainAttachDevice

2019-08-16 Thread Erik Skultety
tachDeviceFlags, /* 5.7.0 */ > .domainGetAutostart = testDomainGetAutostart, /* 0.3.2 */ > .domainSetAutostart = testDomainSetAutostart, /* 0.3.2 */ Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] tests: virpcimock: Always declare __open_2

2019-08-16 Thread Erik Skultety
t; '__open_2' [-Werror,-Wmissing-prototypes] > __open_2(const char *path, int flags) > > Add a separate declaration to appease the compiler. > > Signed-off-by: Peter Krempa > --- I guess you could have simply pushed this as a build breaker, anyway: Reviewed-by: Erik Skultety

Re: [libvirt] [PATCH 1/2] ci: Allow gdb in containers

2019-08-15 Thread Erik Skultety
ou my: Reviewed-by: Erik Skultety ...but I'd wait and let others to comment. > Makefile.ci | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile.ci b/Makefile.ci > index 8857c953b2..977e0445c6 100644 > --- a/Makefile.ci > +++ b/Makefile.ci > @@ -167,6 +167,7

Re: [libvirt] [PATCH 2/2] virpcimock: Mock __open_2()

2019-08-15 Thread Erik Skultety
path from host's /sys. > This of course fails with variety of errors. > > Signed-off-by: Michal Privoznik > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 5/5] util: default to read-only in virPCIDeviceConfigOpen

2019-08-15 Thread Erik Skultety
On Tue, Aug 13, 2019 at 03:45:19PM +0200, Ján Tomko wrote: > All the callers left require virPCIDeviceConfigOpen to be fatal > and only use read-only access to the config file. > > Signed-off-by: Ján Tomko > --- FYI this patch broke make check, both virpcitest and virhostdevtest. Erik --

Re: [libvirt] [PATCH v2 1/2] test_driver: handle different lifecycle actions in testDomainShutdownFlags

2019-08-14 Thread Erik Skultety
On Tue, Aug 13, 2019 at 03:28:09PM +0300, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis I'll rephrase the commit subject to: Introduce testDomainActionSetState helper Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetLifecycleAction

2019-08-14 Thread Erik Skultety
est_driver.c | 135 +++-- > 1 file changed, 103 insertions(+), 32 deletions(-) > Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/2] test_driver: handle different lifecycle actions in testDomainShutdownFlags

2019-08-14 Thread Erik Skultety
On Tue, Aug 13, 2019 at 03:34:02PM +0300, Ilias Stamatis wrote: > On Tue, Aug 13, 2019 at 3:28 PM Ilias Stamatis > wrote: > > > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 77 -- > > 1 file changed, 45 insertions(+), 32

Re: [libvirt] [PATCH] qemu: Fix crash on incoming migration

2019-08-13 Thread Erik Skultety
mmit v5.6.0-109-gbf15b145ec. > > Signed-off-by: Jiri Denemark > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] test_driver: implement virDomainSetLifecycleAction

2019-08-13 Thread Erik Skultety
On Tue, Aug 13, 2019 at 03:07:50PM +0300, Ilias Stamatis wrote: > On Fri, Aug 9, 2019 at 3:55 PM Erik Skultety wrote: > > > > On Fri, Aug 02, 2019 at 11:51:05AM +0200, Ilias Stamatis wrote: > > > Signed-off-by: Ilias Stamatis > > > --- &

Re: [libvirt] [PATCH v2 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-12 Thread Erik Skultety
c_max); +TEST_BLOCK_IOTUNE_MAX_CHECK(read_iops_sec, read_iops_sec_max); +TEST_BLOCK_IOTUNE_MAX_CHECK(write_iops_sec, write_iops_sec_max); -if (info.total_iops_sec > info.total_iops_sec_max) { -virReportError(VIR_ERR_INVALID_ARG, "%s", - _("total_iops_sec " - "cannot be set higher than its corresponding max value")); -goto cleanup; -} - -if (info.read_iops_sec > info.read_iops_sec_max) { -virReportError(VIR_ERR_INVALID_ARG, "%s", - _("read_iops_sec " - "cannot be set higher than its corresponding max value")); -goto cleanup; -} - -if (info.write_iops_sec > info.write_iops_sec_max) { -virReportError(VIR_ERR_INVALID_ARG, "%s", - _("write_iops_sec " - "cannot be set higher than its corresponding max value")); -goto cleanup; -} +#undef TEST_BLOCK_IOTUNE_MAX_CHECK if (virDomainDiskSetBlockIOTune(conf_disk, ) < 0) goto cleanup; Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 1/2] test_driver: implement testDomainGetBlockIoTune

2019-08-12 Thread Erik Skultety
No need to CC me explicitly (especially for just a single patch of the series), all libvirt devs are subscribed to the list. Regards, Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] nwfilter: move standard XML configs out of examples dir

2019-08-12 Thread Erik Skultety
2xmlout", "../src/nwfilter"); DO_TEST_DIR("nwfilterbinding.rng", "virnwfilterbindingxml2xmldata"); DO_TEST_DIR("secret.rng", "secretxml2xmlin"); DO_TEST_DIR("storagepoolcaps.rng", "storagepoolcapsschemadata"); otherwise distcheck fails. With that: Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] test_driver: implement virDomainSetLifecycleAction

2019-08-09 Thread Erik Skultety
On Fri, Aug 02, 2019 at 11:51:05AM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 58 ++ > 1 file changed, 58 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index

Re: [libvirt] [PATCH] conf: code comment fix for TPM version

2019-08-09 Thread Erik Skultety
-André Lureau > --- The html docs agrees with that: Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainManagedSaveGetXMLDesc

2019-08-09 Thread Erik Skultety
On Wed, Aug 07, 2019 at 06:56:35PM +0200, Ilias Stamatis wrote: > The managedSave APIs according to the documentation are supposed to > operate on a disk file. However, this might not be appropriate in the > case of the test driver since: > > * It's better if the test driver keeps all its state in

Re: [libvirt] [PATCH] test_driver: implement virDomainGetBlockInfo

2019-08-09 Thread Erik Skultety
On Thu, Aug 08, 2019 at 12:30:24PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 40 > 1 file changed, 40 insertions(+) Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redh

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-08 Thread Erik Skultety
On Wed, Aug 07, 2019 at 12:52:17PM +0200, Ilias Stamatis wrote: > On Sun, Aug 4, 2019 at 6:32 PM Erik Skultety wrote: > > > > On Sat, Jul 27, 2019 at 05:04:38PM +0200, Ilias Stamatis wrote: > > > Signed-off-by: Ilias Stamatis > > > --- > > > &

Re: [libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetTime and update virDomainGetTime

2019-08-07 Thread Erik Skultety
1 file changed, 41 insertions(+), 2 deletions(-) Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] src: security: Replace bitwise OR with logical OR

2019-08-07 Thread Erik Skultety
Typo introduced by commit d73f3f58360. https://bugzilla.redhat.com/show_bug.cgi?id=1738483 Signed-off-by: Erik Skultety --- Pushed as trivial. src/security/security_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_util.c b/src/security

Re: [libvirt] [PATCH] test_driver: implement virDomainReset

2019-08-07 Thread Erik Skultety
On Tue, Aug 06, 2019 at 05:56:23PM +0200, Ilias Stamatis wrote: > The qemu and vz implementations don't emit any signals when this API is > called, so we can do the same here for now and succeed by doing nothing. > > Signed-off-by: Ilias Stamatis > --- Reviewed-by: Erik Skultety

Re: [libvirt] [PATCH] test_driver: implement virDomainSetTime and update virDomainGetTime

2019-08-07 Thread Erik Skultety
On Tue, Aug 06, 2019 at 06:20:07PM +0200, Ilias Stamatis wrote: > Until now, testDomainGetTime would always return the same fixed value > everytime it was called. By using domain-private data we can make this > API return the values previously set with testDomainSetTime, or use the > same old

Re: [libvirt] [PATCH v2 4/4] test_driver: implement virDomainFSTrim

2019-08-06 Thread Erik Skultety
On Sun, Aug 04, 2019 at 03:27:18PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 3/4] test_driver: implement virDomainFSThaw

2019-08-06 Thread Erik Skultety
On Sun, Aug 04, 2019 at 03:27:17PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 2/4] test_driver: implement virDomainFSFreeze

2019-08-06 Thread Erik Skultety
6,15 +4096,8 @@ testDomainFSFreeze(virDomainPtr dom, priv = vm->privateData; if (nmountpoints == 0) { -ret = 0; -if (priv->frozen[0] == false) { -priv->frozen[0] = true; -ret++; -} -if (priv->frozen[1] == false) { -priv->

Re: [libvirt] [PATCH 3/4] qemu: Generate 'xres' and 'yres' for qxl device.

2019-08-05 Thread Erik Skultety
On Mon, Aug 05, 2019 at 12:30:48PM +0200, Ján Tomko wrote: > On Mon, Aug 05, 2019 at 08:43:14AM +0200, Erik Skultety wrote: > > On Sun, Aug 04, 2019 at 10:21:20PM -0300, jcfara...@gmail.com wrote: > > > From: Julio Faracco > > > > > > Now, QEMU command line

Re: [libvirt] [PATCH 0/4] Adding resolution properties for QXL device

2019-08-05 Thread Erik Skultety
On Mon, Aug 05, 2019 at 09:12:26AM +0200, Gerd Hoffmann wrote: > On Sun, Aug 04, 2019 at 10:21:17PM -0300, jcfara...@gmail.com wrote: > > From: Julio Faracco > > > > This serie adds 'xres' and 'yres' properties into XML definition for QXL > > video device to specify a default resolution. This

Re: [libvirt] [PATCH 0/2] test_driver: implement the remaining virDomainCreate APIs

2019-08-05 Thread Erik Skultety
tions(+) Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] libxl: Implement domain metadata getter/setter

2019-08-05 Thread Erik Skultety
om/show_bug.cgi?id=1732306 > > Signed-off-by: Michal Privoznik Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/4] qemu: Generate 'xres' and 'yres' for qxl device.

2019-08-05 Thread Erik Skultety
On Sun, Aug 04, 2019 at 10:21:20PM -0300, jcfara...@gmail.com wrote: > From: Julio Faracco > > Now, QEMU command line can define 'xres' and 'yres' if XML contains both > properties from qxl model. > > Signed-off-by: Julio Faracco > --- > src/qemu/qemu_command.c | 4 > 1 file changed, 4

Re: [libvirt] [PATCH 1/4] docs: Adding 'xres' and 'yres' into qxl XML definition

2019-08-05 Thread Erik Skultety
On Sun, Aug 04, 2019 at 10:21:18PM -0300, jcfara...@gmail.com wrote: > From: Julio Faracco > > This commit adds 'xres' and 'yres' into qxl XML Domain group definition. > Both, properties were added into properties group inside qxl model and > they are set as optional. > > Signed-off-by: Julio

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-04 Thread Erik Skultety
On Sat, Jul 27, 2019 at 05:04:38PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- > > I deliberately omitted the logic from qemuDomainSetBlockIoTuneDefaults > in order to leave the function simpler. I think that in the case of the > test driver it is ok. > > After all, how we

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainGetBlockIoTune

2019-08-04 Thread Erik Skultety
On Sun, Aug 04, 2019 at 03:46:03PM +0200, Ilias Stamatis wrote: > On Sun, Aug 4, 2019 at 11:12 AM Erik Skultety wrote: > > > > On Sat, Jul 27, 2019 at 05:04:37PM +0200, Ilias Stamatis wrote: > > > Signed-off-by: Ilias Stamatis > > > --- &

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainGetBlockIoTune

2019-08-04 Thread Erik Skultety
ret = 0; > + cleanup: > +VIR_FREE(reply.group_name); > +virDomainObjEndAPI(); > +return ret; > +} > #undef TEST_SET_PARAM > > > @@ -8512,6 +8601,7 @@ static virHypervisorDriver testHypervisorDriver = { > .domainGetNumaParameters = testDomainGetNumaPara

Re: [libvirt] [PATCH 4/4] test_driver: implement virDomainFSTrim

2019-08-02 Thread Erik Skultety
On Tue, Jul 09, 2019 at 09:23:24PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/4] test_driver: implement virDomainFSThaw

2019-08-02 Thread Erik Skultety
On Tue, Jul 09, 2019 at 09:23:23PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 66 ++ > 1 file changed, 66 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index

Re: [libvirt] [PATCH 2/4] test_driver: implement virDomainFSFreeze

2019-08-02 Thread Erik Skultety
On Tue, Jul 09, 2019 at 09:23:22PM +0200, Ilias Stamatis wrote: > On success update the domain-private data. Consider / and /boot to be > the only mountpoints avaiable in order to be consistent with the other > FS-related calls. > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c |

  1   2   3   4   5   6   7   8   9   10   >