Re: [libvirt PATCH v4 0/4] Ask qemu about migration blockers

2022-07-20 Thread Eugenio Perez Martin
On Thu, Jul 21, 2022 at 7:02 AM Laine Stump wrote: > > This all looks good except a couple small nits that I've noted in > separate messages for the individual patches. > > I've already made these minor changes locally and pushed them here: > >

Re: [libvirt PATCH v3 3/4] qemu_migration: get migration blockers before hardcoded checks

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 4:48 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 16:29:45 +0200, Eugenio Perez Martin wrote: > > On Wed, Jul 20, 2022 at 4:01 PM Jiri Denemark wrote: > > > > > > On Wed, Jul 20, 2022 at 14:15:57 +0200, Eugenio Pérez wrote: > &

Re: [libvirt PATCH v3 3/4] qemu_migration: get migration blockers before hardcoded checks

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 4:01 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 14:15:57 +0200, Eugenio Pérez wrote: > > since qemu 6.0, if migration is blocked for some reason, 'query-migrate' > > will return an array of error strings describing the migration blockers. > > This can be used to

Re: [libvirt PATCH v3 2/4] qemu_monitor: add support for get qemu migration blockers

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 3:58 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 14:15:56 +0200, Eugenio Pérez wrote: > > since qemu 6.0, if migration is blocked for some reason, 'query-migrate' > > will return an array of error strings describing the migration blockers. > > This can be used to

Re: [libvirt PATCH v3 4/4] qemu_migration: Do not forbid vDPA devices if can query blockers

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 4:02 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 14:15:58 +0200, Eugenio Pérez wrote: > > vDPA devices will be migratable soon. Since they are not migratable > > before qemu 6.0, and qemu pre-6.0 didn't have the capability of asking > > for migration blockers, let

Re: [libvirt PATCH v2 4/5] qemu_migration: get migration blockers before hardcoded checks

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 12:31 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 11:11:53 +0200, Eugenio Pérez wrote: > > since qemu 6.0, if migration is blocked for some reason, 'query-migrate' > > will return an array of error strings describing the migration blockers. > > This can be used to

Re: [libvirt PATCH v2 5/5] qemu_migrate: Do not forbif vDPA devices if can query blockers

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 1:13 PM Peter Krempa wrote: > > On Wed, Jul 20, 2022 at 13:11:57 +0200, Eugenio Perez Martin wrote: > > On Wed, Jul 20, 2022 at 12:36 PM Jiri Denemark wrote: > > > > > > On Wed, Jul 20, 2022 at 11:11:54 +0200, Eugenio Pérez wrote: > >

Re: [libvirt PATCH v2 2/5] qemu_monitor_json: Add qemuMonitorJSONGetMigrationBlockers

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 1:13 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 12:43:44 +0200, Eugenio Perez Martin wrote: > > On Wed, Jul 20, 2022 at 12:14 PM Jiri Denemark wrote: > > > > > > On Wed, Jul 20, 2022 at 11:11:51 +0200, Eugenio Pérez

Re: [libvirt PATCH v2 5/5] qemu_migrate: Do not forbif vDPA devices if can query blockers

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 12:36 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 11:11:54 +0200, Eugenio Pérez wrote: > > vDPA devices will be migratable soon. Since they are not migratable > > before qemu 6.0, and qemu pre-6.0 didn't have the capability of asking > > for migration blockers, let

Re: [libvirt PATCH v2 5/5] qemu_migrate: Do not forbif vDPA devices if can query blockers

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 12:37 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 12:36:16 +0200, Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 11:11:54 +0200, Eugenio Pérez wrote: > > > vDPA devices will be migratable soon. Since they are not migratable > > > before qemu 6.0, and qemu pre-6.0

Re: [libvirt PATCH v2 2/5] qemu_monitor_json: Add qemuMonitorJSONGetMigrationBlockers

2022-07-20 Thread Eugenio Perez Martin
On Wed, Jul 20, 2022 at 12:14 PM Jiri Denemark wrote: > > On Wed, Jul 20, 2022 at 11:11:51 +0200, Eugenio Pérez wrote: > > This will allow qemuMigrationSrcIsAllowed to dynamically ask for > > migration blockers, reducing duplication. > > > > Signed-off-by: Eugenio Pérez > > --- > >

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 6:43 PM Laine Stump wrote: > > On 7/19/22 12:01 PM, Laine Stump wrote: > > On 7/19/22 11:09 AM, Eugenio Perez Martin wrote: > >> On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: > >>> > >>> On 7/18/22 11:15 AM, Jiri Denemar

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 5:24 PM Jiri Denemark wrote: > > On Tue, Jul 19, 2022 at 17:09:29 +0200, Eugenio Perez Martin wrote: > > On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: > > > Actually that's been on my todo list for a long time - for any qemu that > >

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 4:02 PM Laine Stump wrote: > > On 7/18/22 11:15 AM, Jiri Denemark wrote: > > On Mon, Jul 18, 2022 at 10:40:56 +0200, Eugenio Perez Martin wrote: > >> On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote: > >>> Which in ideal c

Re: [libvirt PATCH] qemu_migration: Delete vDPA check

2022-07-18 Thread Eugenio Perez Martin
On Mon, Jul 18, 2022 at 10:25 AM Jiri Denemark wrote: > > On Fri, Jul 15, 2022 at 11:14:58 +0200, Eugenio Pérez wrote: > > Currently, the migration code denies migration as long as the VM has a > > vhost-vDPA device. > > > > While it's true that vhost-vDPA devices cannot be migrated at the