Re: [PATCH v5 1/7] migration: Print block status when needed

Juan Quintela writes: > The new line was only printed when command options were used. When we > used migration parameters and capabilities, it wasn't. > > Signed-off-by: Juan Quintela Reviewed-by: Fabiano Rosas

Re: [PATCH 02/26] migration/multifd: Protect accesses to migration_threads

Juan Quintela writes: > From: Fabiano Rosas > > This doubly linked list is common for all the multifd and migration > threads so we need to avoid concurrent access. > > Add a mutex to protect the data from concurrent access. This fixes a > crash when removing two Migrati

Re: [PATCH v2 3/3] ui: remove deprecated 'password' option for SPICE

Daniel P. Berrangé writes: > This has been replaced by the 'password-secret' option, > which references a 'secret' object instance. > > Reviewed-by: Markus Armbruster > Signed-off-by: Daniel P. Berrangé Reviewed-by: Fabiano Rosas Just a small detail below. >

Re: [PATCH v2 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret'

via QCryptoSecret API > > The existing 'password' option is overdue for deprecation and > subsequent removal. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Fabiano Rosas

Re: [PATCH v2 1/3] block: mention 'password-secret' option for -iscsi

via QCryptoSecret API > > but was not mentioned in the command line docs > > Reviewed-by: Markus Armbruster > Signed-off-by: Daniel P. Berrangé Reviewed-by: Fabiano Rosas

Re: [PATCH 1/3] block: mention 'password-secret' option for -iscsi

Daniel P. Berrangé writes: > The 'password-secret' option was added > > commit b189346eb1784df95ed6fed610411dbf23d19e1f > Author: Daniel P. Berrangé > Date: Thu Jan 21 14:19:21 2016 + > > iscsi: add support for getting CHAP password via QCryptoSecret API > > but was not

Re: [libvirt] [PATCH 0/2] qemu: Add support for host-model pseries machine option

Daniel P. Berrangé writes: > What userspace tool is broken, and in what way ? The major use case, as far as I know, is from software license managers which use this to determine how much to charge for software. I would have to ask around to know exactly which ones and how they operate. >

Re: [libvirt] [PATCH 2/2] qemu: Add support for pseries 'host-model' machine parameter

Daniel P. Berrangé writes: > On Tue, Oct 08, 2019 at 01:46:57PM -0300, Fabiano Rosas wrote: >> Since QEMU v4.0.0, the host's model is no longer automatically exposed >> to the guest via /proc/device-tree/host-model. There is now a machine >> option 'host-model' that allow

[libvirt] [PATCH 2/2] qemu: Add support for pseries 'host-model' machine parameter

Signed-off-by: Fabiano Rosas --- docs/formatdomain.html.in | 9 ++ docs/schemas/domaincommon.rng | 5 src/conf/domain_conf.c| 4 +++ src/conf/domain_conf.h| 1 + src/qemu/qemu_command.c

[libvirt] [PATCH 1/2] qemu: Add capability for pseries machine 'host-model' parameter

As of QEMU v4.0.0, the pseries machine has a new parameter 'host-model' which receives an arbitrary string to be exposed inside the guest at /proc/device-tree/host-model. Signed-off-by: Fabiano Rosas --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h

[libvirt] [PATCH 0/2] qemu: Add support for host-model pseries machine option

', such as 'cpuinfo' and 'device-tree'. So to keep the two discussions separated I took advantage of the fact that the host model happens to also be present at /proc/cpuinfo and used the smbios structures for now. Fabiano Rosas (2): qemu: Add capability for pseries machine 'host-model' parameter qemu