Re: [libvirt] [PATCH 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-09-17 Thread Ilias Stamatis
On Tue, Sep 17, 2019 at 5:51 PM Daniel Henrique Barboza wrote: > > > > On 8/1/19 9:54 AM, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 290 + > > 1 file changed, 290 in

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainPMSuspendForDuration

2019-09-06 Thread Ilias Stamatis
On Tue, Sep 3, 2019 at 8:17 PM Daniel Henrique Barboza wrote: > > > > On 9/3/19 2:00 PM, Daniel Henrique Barboza wrote: > > > > > > On 8/13/19 1:19 PM, Ilias Stamatis wrote: > >> Signed-off-by: Ilias Stamatis >

[libvirt] [PATCH] test_driver: implement virDomainSetBlockThreshold

2019-08-17 Thread Ilias Stamatis
Store disk name - threshold pairs in vm-private data so they can be retrieved by virConnectGetAllDomainStats later. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 91 +- src/test/test_driver.h | 9 + 2 files changed, 98 insertions(+), 2

Re: [libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-16 Thread Ilias Stamatis
On Fri, Aug 16, 2019 at 5:39 PM Erik Skultety wrote: > > ... > > > + > > +if (operation == TEST_DEVICE_DETACH) > > +parse_flags |= VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE; > > ^This should be added by patch 3/5 > > > + > > +if (xml) { > > +if (!(dev =

[libvirt] [PATCH] test_driver: implement virConnectCompareCPU

2019-08-15 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- Probably we need to extend the host CPU's capabilities as well along with this patch. Currently virCPUx86Compare reports "unknown host CPU". src/test/test_driver.c | 21 + 1 file changed, 21 insertions(+) diff --git

[libvirt] [PATCH v2 6/6] test_driver: implement virDomainUpdateDeviceFlags

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 72 ++ 1 file changed, 72 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e271bc58f8..9bf3728654 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 5/6] test_driver: implement virDomainDetachDeviceAlias

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 12 1 file changed, 12 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 1152ca5bed..e271bc58f8 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5119,6 +5119,17

[libvirt] [PATCH v2 4/6] test_driver: implement virDomainDetachDevice

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 8 1 file changed, 8 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ff9693ccb7..1152ca5bed 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5119,6 +5119,13

[libvirt] [PATCH v2 3/6] test_driver: implement virDomainDetachDeviceFlags

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 178 + 1 file changed, 178 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index abf80b97cf..ff9693ccb7 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 2/6] test_driver: implement virDomainAttachDevice

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5f28e9017f..abf80b97cf 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4935,6 +4935,14

[libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 290 + 1 file changed, 290 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c39eef2d4b..5f28e9017f 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 0/6] test_driver: implement device attach/detach APIs

2019-08-14 Thread Ilias Stamatis
This series needed a respin since there were conflicts when trying to apply on the current master. Ilias Stamatis (6): test_driver: implement virDomainAttachDeviceFlags test_driver: implement virDomainAttachDevice test_driver: implement virDomainDetachDeviceFlags test_driver: implement

[libvirt] [PATCH 2/2] test_driver: implement virDomainPMWakeup

2019-08-13 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 37 + 1 file changed, 37 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index d21a69c7ed..b2a9baf361 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/2] test_driver: implement PM suspend/wakeup APIs

2019-08-13 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainPMSuspendForDuration test_driver: implement virDomainPMWakeup src/test/test_driver.c | 116 + 1 file changed, 116 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH 1/2] test_driver: implement virDomainPMSuspendForDuration

2019-08-13 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5f5c512571..d21a69c7ed 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [PATCH v2 1/2] test_driver: handle different lifecycle actions in testDomainShutdownFlags

2019-08-13 Thread Ilias Stamatis
On Tue, Aug 13, 2019 at 3:28 PM Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 77 -- > 1 file changed, 45 insertions(+), 32 deletions(-) > > diff --git a/src/test/test_driver.c b/src/test/

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainSetLifecycleAction

2019-08-13 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 58 ++ 1 file changed, 58 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5a3ed45008..2008e7e43a 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 1/2] test_driver: handle different lifecycle actions in testDomainShutdownFlags

2019-08-13 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 77 -- 1 file changed, 45 insertions(+), 32 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5f5c512571..5a3ed45008 100755 --- a/src/test/test_driver.c +++ b/src

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetLifecycleAction

2019-08-13 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: handle different lifecycle actions in testDomainShutdownFlags test_driver: implement virDomainSetLifecycleAction src/test/test_driver.c | 135 +++-- 1 file changed, 103 insertions(+), 32 deletions(-) -- 2.22.0

Re: [libvirt] [PATCH] test_driver: implement virDomainSetLifecycleAction

2019-08-13 Thread Ilias Stamatis
On Fri, Aug 9, 2019 at 3:55 PM Erik Skultety wrote: > > On Fri, Aug 02, 2019 at 11:51:05AM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 58 ++ > > 1 file changed, 58 in

[libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlkioParameters

2019-08-13 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a2a8599dac..e961e696eb 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 1/2] test_driver: implement virDomainGetBlkioParameters

2019-08-13 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 47 ++ 1 file changed, 47 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5f5c512571..a2a8599dac 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/2] test_driver: implement Get/Set Blkio parameters APIs

2019-08-13 Thread Ilias Stamatis
This series depends on another series that haven't been merged yet: https://www.redhat.com/archives/libvir-list/2019-July/msg00520.html Ilias Stamatis (2): test_driver: implement virDomainGetBlkioParameters test_driver: implement virDomainSetBlkioParameters src/test/test_driver.c | 123

[libvirt] [PATCH v2 5/5] test_driver: implement virDomainSetIOThreadParams

2019-08-12 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7eef54bb05..6274d5bf0f 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 4/5] test_driver: implement virDomainGetIOThreadInfo

2019-08-12 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 60d611245d..7eef54bb05 100755 --- a/src/test/test_driver.c

[libvirt] [PATCH v2 3/5] test_driver: implement virDomainPinIOThread

2019-08-12 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index b4a883cb54..60d611245d 100755 --- a/src/test/test_driver.c

[libvirt] [PATCH v2 2/5] test_driver: implement virDomainDelIOThread

2019-08-12 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 85 ++ 1 file changed, 85 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7acde811ef..b4a883cb54 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 1/5] test_driver: implement virDomainAddIOThread

2019-08-12 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 67 ++ src/test/test_driver.h | 11 +++ 2 files changed, 78 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5f5c512571..7acde811ef 100755 --- a/src/test

[libvirt] [PATCH v2 0/5] test_driver: implement IOThread related APIs

2019-08-12 Thread Ilias Stamatis
Changes since v1: - Use vm-private data for storing iothread parameters and implement virDomainSetIOThreadParams Ilias Stamatis (5): test_driver: implement virDomainAddIOThread test_driver: implement virDomainDelIOThread test_driver: implement virDomainPinIOThread test_driver: implement

Re: [libvirt] [PATCH v2 1/2] test_driver: implement testDomainGetBlockIoTune

2019-08-12 Thread Ilias Stamatis
On Mon, Aug 12, 2019 at 11:33 AM Erik Skultety wrote: > > No need to CC me explicitly (especially for just a single patch of the > series), > all libvirt devs are subscribed to the list. > > Regards, > Erik I didn't do that intentionally. I think git send-email added you in the CC list because

[libvirt] [PATCH v2 1/2] test_driver: implement testDomainGetBlockIoTune

2019-08-09 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 102 + 1 file changed, 102 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2b5376ec28..14b7d683e1 100755 --- a/src/test/test_driver.c

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-09 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 259 + 1 file changed, 259 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 14b7d683e1..009bc18a73 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 0/2] test_driver: implement get/set BlockIoTune APIs

2019-08-09 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement testDomainGetBlockIoTune test_driver: implement virDomainSetBlockIoTune src/test/test_driver.c | 361 + 1 file changed, 361 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH v2 2/3] test_driver: implement virDomainManagedSaveGetXMLDesc

2019-08-09 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 8bd5a5296b..211c0d737a 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -7624,6

[libvirt] [PATCH v2 3/3] test_driver: implement virDomainManagedSaveDefineXML

2019-08-09 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 40 1 file changed, 40 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 211c0d737a..a127dc69c1 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 1/3] test_driver: use domain-private data to store managed image

2019-08-09 Thread Ilias Stamatis
ay we also make sure that we don't touch the real host's filesystem. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2b5376ec28..8bd5a5296b 1

[libvirt] [PATCH v2 0/3] test_driver: implement the remaining ManagedSave APIs

2019-08-09 Thread Ilias Stamatis
Ilias Stamatis (3): test_driver: use domain-private data to store managed image test_driver: implement virDomainManagedSaveGetXMLDesc test_driver: implement virDomainManagedSaveDefineXML src/test/test_driver.c | 93 +- 1 file changed, 92 insertions

[libvirt] [PATCH 3/4] test_driver: implement virDomainSetVcpu

2019-08-08 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 99cba7db42..d6f1adf6e9 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 4/4] test_driver: implement virDomainSetGuestVcpus

2019-08-08 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 12 1 file changed, 12 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index d6f1adf6e9..6698fb7cf6 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3070,6 +3070,17

[libvirt] [PATCH 2/4] test_driver: implement virDomainGetGuestVcpus

2019-08-08 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 70 ++ 1 file changed, 70 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a6f239b9f1..99cba7db42 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 1/4] test_driver: make testDomainGetVcpus report all vcpus

2019-08-08 Thread Ilias Stamatis
The current implementation of testDomainGetVcpus is erroneous. When offline vcpus are encountered in the vm definition, the corresponding fields in the output array are left empty. Additionally some vcpus are not reported at all due to the wrong invariant checking done in the loop. Make

[libvirt] [PATCH 0/4] test_driver: implement the remaining VCPUs-related APIs

2019-08-08 Thread Ilias Stamatis
Ilias Stamatis (4): test_driver: make testDomainGetVcpus report all vcpus test_driver: implement virDomainGetGuestVcpus test_driver: implement virDomainSetVcpu test_driver: implement virDomainSetGuestVcpus src/test/test_driver.c | 167 +++-- 1 file

[libvirt] [PATCH] test_driver: implement virDomainGetBlockInfo

2019-08-08 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 40 1 file changed, 40 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6f18baa265..106e8f027e 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 1/2] test_driver: implement virDomainManagedSaveGetXMLDesc

2019-08-07 Thread Ilias Stamatis
ay we also make sure that we don't touch the real host's filesystem. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 28 1 file changed, 28 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6f18baa265..8715d6c0d6 1

[libvirt] [PATCH 0/2] test_driver: implement the remaining ManagedSave APIs

2019-08-07 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainManagedSaveGetXMLDesc test_driver: implement virDomainManagedSaveDefineXML src/test/test_driver.c | 66 ++ 1 file changed, 66 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list

[libvirt] [PATCH 2/2] test_driver: implement virDomainManagedSaveDefineXML

2019-08-07 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 8715d6c0d6..360bdef373 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-08-07 Thread Ilias Stamatis
On Sun, Aug 4, 2019 at 6:32 PM Erik Skultety wrote: > > On Sat, Jul 27, 2019 at 05:04:38PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > > > I deliberately omitted the logic from qemuDomainSetBlockIoTuneDefaults > > in order to

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainGetBlockIoTune

2019-08-07 Thread Ilias Stamatis
On Sun, Aug 4, 2019 at 5:32 PM Erik Skultety wrote: > > On Sun, Aug 04, 2019 at 03:46:03PM +0200, Ilias Stamatis wrote: > > On Sun, Aug 4, 2019 at 11:12 AM Erik Skultety wrote: > > > > > > On Sat, Jul 27, 2019 at 05:04:37PM +0200, Ilias Stamatis wrote: > &g

[libvirt] [PATCH v2 1/2] test_driver: make testDomainGetTime read time from vm-private data

2019-08-07 Thread Ilias Stamatis
-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6bca4e277f..3e2cd3a9a4 100755 --- a/src/test/test_driver.c +++ b/src/test

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainSetTime

2019-08-07 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 3e2cd3a9a4..6f18baa265 100755 --- a/src/test/test_driver.c +++ b/src/test

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetTime and update virDomainGetTime

2019-08-07 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: make testDomainGetTime read time from vm-private data test_driver: implement virDomainSetTime src/test/test_driver.c | 43 -- 1 file changed, 41 insertions(+), 2 deletions(-) -- 2.22.0 -- libvir-list mailing list

[libvirt] [PATCH] test_driver: implement virDomainSetTime and update virDomainGetTime

2019-08-06 Thread Ilias Stamatis
Until now, testDomainGetTime would always return the same fixed value everytime it was called. By using domain-private data we can make this API return the values previously set with testDomainSetTime, or use the same old fixed value in case testDomainSetTime hasn't been called at all. ---

[libvirt] [PATCH] test_driver: implement virDomainReset

2019-08-06 Thread Ilias Stamatis
The qemu and vz implementations don't emit any signals when this API is called, so we can do the same here for now and succeed by doing nothing. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/test

[libvirt] [PATCH 1/2] test_driver: implement virDomainCreateWithFiles

2019-08-05 Thread Ilias Stamatis
This should just forward the call to testDomainCreateWithFlags since we can't do anything with the provided file descriptors in the test driver. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/test/test_driver.c b/src

[libvirt] [PATCH 2/2] test_driver: implement virDomainCreateXMLWithFile

2019-08-05 Thread Ilias Stamatis
This should just forward the call to testDomainCreateXML since we can't do anything with the provided file descriptors in the test driver. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 12 1 file changed, 12 insertions(+) diff --git a/src/test/test_driver.c b/src/test

[libvirt] [PATCH 0/2] test_driver: implement the remaining virDomainCreate APIs

2019-08-05 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainCreateWithFiles test_driver: implement virDomainCreateXMLWithFile src/test/test_driver.c | 23 +++ 1 file changed, 23 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainGetBlockIoTune

2019-08-04 Thread Ilias Stamatis
On Sun, Aug 4, 2019 at 11:12 AM Erik Skultety wrote: > > On Sat, Jul 27, 2019 at 05:04:37PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 90 ++ > > 1 file changed, 90 in

[libvirt] [PATCH v2 4/4] test_driver: implement virDomainFSTrim

2019-08-04 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 32 1 file changed, 32 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2a9041d777..cb373f61d3 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4177,6

[libvirt] [PATCH v2 2/4] test_driver: implement virDomainFSFreeze

2019-08-04 Thread Ilias Stamatis
On success update the domain-private data. Consider / and /boot to be the only mountpoints avaiable in order to be consistent with the other FS-related calls. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 72 ++ 1 file changed, 72 insertions

[libvirt] [PATCH v2 0/4] test_driver: implement FS-related APIs

2019-08-04 Thread Ilias Stamatis
Ilias Stamatis (4): test_driver: introduce domain-private data test_driver: implement virDomainFSFreeze test_driver: implement virDomainFSThaw test_driver: implement virDomainFSTrim src/test/test_driver.c | 200 - 1 file changed, 199 insertions

[libvirt] [PATCH v2 3/4] test_driver: implement virDomainFSThaw

2019-08-04 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 61 ++ 1 file changed, 61 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a8b75b175a..2a9041d777 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 1/4] test_driver: introduce domain-private data

2019-08-04 Thread Ilias Stamatis
parameters - virDomainManagedSaveDefineXML for internally storing the VM definition Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src

Re: [libvirt] [PATCH 2/4] test_driver: implement virDomainFSFreeze

2019-08-04 Thread Ilias Stamatis
On Fri, Aug 2, 2019 at 4:39 PM Erik Skultety wrote: > > On Tue, Jul 09, 2019 at 09:23:22PM +0200, Ilias Stamatis wrote: > > On success update the domain-private data. Consider / and /boot to be > > the only mountpoints avaiable in order to be consistent with the other &g

Re: [libvirt] [PATCH 1/4] test_driver: introduce domain-private data

2019-08-02 Thread Ilias Stamatis
On Fri, Aug 2, 2019 at 1:23 PM Erik Skultety wrote: > > On Tue, Jul 09, 2019 at 09:23:21PM +0200, Ilias Stamatis wrote: > > --- > > Explaining that the private data will come handy to hold the information > whether filesystems have been frozen would be nice. Sure, just maybe

[libvirt] [PATCH v3 2/2] test_driver: implement virDomainMemoryStats

2019-08-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 83e2c0289f..2fbaf1c4ee 100755 --- a/src/test/test_driver.c

[libvirt] [PATCH v3 1/2] test_driver: add a memballoon device in the default config

2019-08-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index aae9875194..83e2c0289f 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -450,6 +450,9 @@ static const char

[libvirt] [PATCH v3 0/2] test_driver: implement virDomainMemoryStats

2019-08-02 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: add a memballoon device in the default config test_driver: implement virDomainMemoryStats src/test/test_driver.c | 57 ++ 1 file changed, 57 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] test_driver: implement virDomainSetLifecycleAction

2019-08-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 58 ++ 1 file changed, 58 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index aae9875194..71d6baa3da 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2] test_driver: implement virDomainMemoryStats

2019-08-01 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index aae9875194..0e0acf2baf 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 6/6] test_driver: implement virDomainUpdateDeviceFlags

2019-08-01 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 72 ++ 1 file changed, 72 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index cffd60c75c..228e24b0ae 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 5/6] test_driver: implement virDomainDetachDeviceAlias

2019-08-01 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 12 1 file changed, 12 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index de449d89fb..cffd60c75c 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4487,6 +4487,17

[libvirt] [PATCH 4/6] test_driver: implement virDomainDetachDevice

2019-08-01 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 8 1 file changed, 8 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 1d371a5832..de449d89fb 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4487,6 +4487,13

[libvirt] [PATCH 3/6] test_driver: implement virDomainDetachDeviceFlags

2019-08-01 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 178 + 1 file changed, 178 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 784622985c..1d371a5832 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 2/6] test_driver: implement virDomainAttachDevice

2019-08-01 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c8aad6a0bb..784622985c 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4302,6 +4302,15

[libvirt] [PATCH 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-01 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 290 + 1 file changed, 290 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index aae9875194..c8aad6a0bb 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/6] test_driver: implement device attach/detach APIs

2019-08-01 Thread Ilias Stamatis
Ilias Stamatis (6): test_driver: implement virDomainAttachDeviceFlags test_driver: implement virDomainAttachDevice test_driver: implement virDomainDetachDeviceFlags test_driver: implement virDomainDetachDevice test_driver: implement virDomainDetachDeviceAlias test_driver: implement

Re: [libvirt] [PATCH v2 2/2] test_driver: implement virDomainGetCPUStats

2019-07-29 Thread Ilias Stamatis
On Mon, Jul 29, 2019 at 3:28 PM Erik Skultety wrote: > > On Sun, Jul 28, 2019 at 12:02:21PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 132 + > > 1 file changed, 132 in

[libvirt] [PATCH v2 1/2] tests: virsh-optparse: remove no longer valid cpu-stats test cases

2019-07-28 Thread Ilias Stamatis
These test cases are no longer valid since this series provides an implementation of the virDomainGetCPUStats API for the test driver. Signed-off-by: Ilias Stamatis --- tests/virsh-optparse | 20 1 file changed, 20 deletions(-) diff --git a/tests/virsh-optparse b/tests

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainGetCPUStats

2019-07-28 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 132 + 1 file changed, 132 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ab0f8b06d6..56f08fc3d2 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainGetCPUStats

2019-07-28 Thread Ilias Stamatis
Changes since v1: * Removed failing test cases * Total CPUTIME now is the sum of the individual CPUs Ilias Stamatis (2): tests: virsh-optparse: remove no longer valid cpu-stats test cases test_driver: implement virDomainGetCPUStats src/test/test_driver.c | 132

[libvirt] [PATCH 2/2] test_driver: implement virDomainSetBlockIoTune

2019-07-27 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- I deliberately omitted the logic from qemuDomainSetBlockIoTuneDefaults in order to leave the function simpler. I think that in the case of the test driver it is ok. After all, how we handle the parameters it is supposed to be hypervisor-specific. src/test

[libvirt] [PATCH 1/2] test_driver: implement virDomainGetBlockIoTune

2019-07-27 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ab0f8b06d6..9f4e255e35 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/2] test_driver: implement get/set BlockIoTune APIs

2019-07-27 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainGetBlockIoTune test_driver: implement virDomainSetBlockIoTune src/test/test_driver.c | 286 + 1 file changed, 286 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH] test_driver: implement virDomainMemoryStats

2019-07-26 Thread Ilias Stamatis
On Wed, Jul 24, 2019 at 4:19 PM Erik Skultety wrote: > > On Tue, Jul 16, 2019 at 11:36:31PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 52 ++ > > 1 file changed, 52 in

Re: [libvirt] [PATCH] test_driver: implement virDomainGetCPUStats

2019-07-26 Thread Ilias Stamatis
On Thu, Jul 25, 2019 at 2:01 PM Erik Skultety wrote: > > On Thu, Jul 18, 2019 at 12:02:43PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 131 + > > 1 file changed, 131 in

Re: [libvirt] [PATCH 4/4] test_driver: implement virDomainGetIOThreadInfo

2019-07-26 Thread Ilias Stamatis
On Thu, Jul 25, 2019 at 5:43 PM Erik Skultety wrote: > > On Tue, Jul 23, 2019 at 12:17:57PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 74 ++ > > 1 file changed, 74 in

Re: [libvirt] [PATCH 2/4] test_driver: implement virDomainDelIOThread

2019-07-26 Thread Ilias Stamatis
On Thu, Jul 25, 2019 at 5:47 PM Erik Skultety wrote: > > On Tue, Jul 23, 2019 at 12:17:55PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 72 ++ > > 1 file changed, 72 in

[libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetNumaParameters

2019-07-24 Thread Ilias Stamatis
Change since v1: * virDomainObjGetOneDefState is used instead of virDomainObjGetOneDef I send these 2 patches together, since testConnectSupportsFeature needs to be implemented in order for testDomainSetNumaParameters to support string parameters. Ilias Stamatis (2): test_driver: implement

[libvirt] [PATCH v2 1/2] test_driver: implement virConnectSupportsFeature

2019-07-24 Thread Ilias Stamatis
Make the test driver only support the VIR_TYPED_PARAM_STRING flag for now. Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 29 + 1 file changed, 29 insertions(+) mode change 100644 => 100755 src/test/test_driver.c diff --git a/src/test/test_driver.

[libvirt] [PATCH v2 2/2] test_driver: implement virDomainSetNumaParameters

2019-07-24 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 82 ++ 1 file changed, 82 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6221f5b9ae..127403bc0c 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2] implement virDomainSetInterfaceParameters

2019-07-24 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 106 + 1 file changed, 106 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7cf92e78a7..fce38acc17 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

Re: [libvirt] [PATCH] implement virDomainSetInterfaceParameters

2019-07-24 Thread Ilias Stamatis
On Wed, Jul 24, 2019 at 1:04 PM Erik Skultety wrote: > > On Sat, Jul 06, 2019 at 01:24:22PM +0200, Ilias Stamatis wrote: > > Signed-off-by: Ilias Stamatis > > --- > ... > > > + > > +/* average or floor are mandatory, peak and burst are optional */

[libvirt] [PATCH 2/2] test_driver: implement virDomainPinEmulator

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 235d70f793..5411a97a5b 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/2] test_driver: implement emulator pinning APIs

2019-07-23 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: implement virDomainGetEmulatorPinInfo test_driver: implement virDomainPinEmulator src/test/test_driver.c | 92 ++ 1 file changed, 92 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH 1/2] test_driver: implement virDomainGetEmulatorPinInfo

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2e33a9dd55..235d70f793 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 3/4] test_driver: implement virDomainPinIOThread

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 29262e4d34..47e28a01ec 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 4/4] test_driver: implement virDomainGetIOThreadInfo

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 47e28a01ec..4c6f3db8de 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 2/4] test_driver: implement virDomainDelIOThread

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 72 ++ 1 file changed, 72 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 313cf5e7ef..29262e4d34 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH 0/4] test_driver: implement IOThread related APIs

2019-07-23 Thread Ilias Stamatis
Ilias Stamatis (4): test_driver: implement virDomainAddIOThread test_driver: implement virDomainDelIOThread test_driver: implement virDomainPinIOThread test_driver: implement virDomainGetIOThreadInfo src/test/test_driver.c | 248 + 1 file changed

[libvirt] [PATCH 1/4] test_driver: implement virDomainAddIOThread

2019-07-23 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2e33a9dd55..313cf5e7ef 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

  1   2   3   >