Re: [libvirt] [PATCH] Apparmor: Support Xen scripts in libexec

2019-10-18 Thread Jim Fehlig
On 10/18/19 8:31 AM, Andrea Bolognani wrote: > On Thu, 2019-10-17 at 03:41 +0000, Jim Fehlig wrote: >> Upstream Xen has traditionally installed various hotplug and >> utility scripts in /etc/xen/scripts/. openSUSE is slowly moving >> all distribution provided configuration f

[libvirt] [PATCH] Apparmor: Support Xen scripts in libexec

2019-10-16 Thread Jim Fehlig
/xen/scripts/. Adjust the libvirtd Apparmor profile to allow executing scripts from this location. Signed-off-by: Jim Fehlig --- If this is deemed too distro-specific I'm happy to maintain a downstream patch. src/security/apparmor/usr.sbin.libvirtd | 1 + 1 file changed, 1 insertion(+) diff

[libvirt] [PATCH] libxl: Fix lock manager lock ordering

2019-10-14 Thread Jim Fehlig
to the destination, which avoids reacquiring the lock if the send fails. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c| 14 +++--- src/libxl/libxl_migration.c | 14 +- 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl

Re: [libvirt] Question about migration confirm phase

2019-10-14 Thread Jim Fehlig
On 10/14/19 2:18 AM, Jiri Denemark wrote: > On Fri, Oct 11, 2019 at 23:18:29 +0000, Jim Fehlig wrote: >> I've been investigating a lockd lock ordering bug in a migration error >> handling >> path in the libxl driver. In the perform phase, the src calls >> virDomain

[libvirt] Question about migration confirm phase

2019-10-11 Thread Jim Fehlig
I've been investigating a lockd lock ordering bug in a migration error handling path in the libxl driver. In the perform phase, the src calls virDomainLockProcessPause to release the lock before sending the VM to dst. In this case the send fails for other reasons and an attempt is made to

Re: [libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test

2019-10-10 Thread Jim Fehlig
On 9/16/19 6:47 AM, Marek Marczykowski-Górecki wrote: > On Mon, Sep 16, 2019 at 12:23:35PM +0000, Jim Fehlig wrote: >> On 9/15/19 1:43 PM, Marek Marczykowski-Górecki wrote: >>> Signed-off-by: Marek Marczykowski-Górecki >>> --- >>>tests/libxlxml2domcon

Re: [libvirt] [PATCH] docs: document that C & Python are the preferred languages

2019-09-30 Thread Jim Fehlig
On 9/23/19 7:52 AM, Daniel P. Berrangé wrote: > On Thu, Sep 05, 2019 at 06:15:04PM +0100, Daniel P. Berrangé wrote: >> On Thu, Sep 05, 2019 at 12:30:27PM -0400, Laine Stump wrote: >>> (BTW, what does the removal of perl from libvirt say about continued >>> use of perl for libvirt-tck? There are a

Re: [libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test

2019-09-16 Thread Jim Fehlig
On 9/15/19 1:43 PM, Marek Marczykowski-Górecki wrote: > Signed-off-by: Marek Marczykowski-Górecki > --- > tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +- > tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml | 32 - > tests/libxlxml2domconfigtest.c

Re: [libvirt] [PATCH v2 00/24] scripts: convert most perl scripts to python

2019-09-13 Thread Jim Fehlig
On 9/13/19 9:28 AM, Andrea Bolognani wrote: > On Fri, 2019-09-13 at 13:58 +0000, Jim Fehlig wrote: >> On 9/13/19 2:56 AM, Andrea Bolognani wrote: >>> Jim, does SLES 12 have >>> Python 3? >> >> Yes, python 3.4.6. And python 2.7.13. > > That's *amazing*

Re: [libvirt] [PATCH v2 00/24] scripts: convert most perl scripts to python

2019-09-13 Thread Jim Fehlig
On 9/13/19 3:09 AM, Andrea Bolognani wrote: > If I understand the SLES / OpenSUSE situation correctly, then SLES > 12.3 should be comparable to OpenSUSE 42.3, Nice job! Even SUSE folks are known to get confused by the numbering :-). openSUSE 42.3 ~= SLES12 SP3 SLES12 SP4 and SP5 have no openSUSE

Re: [libvirt] [PATCH] apparmor: avoid copying empty profile name

2019-09-13 Thread Jim Fehlig
On 9/9/19 10:26 AM, Jim Fehlig wrote: > AppArmorGetSecurityProcessLabel copies the VM's profile name to the > label member of virSecurityLabel struct. If the profile is not loaded, > the name is set empty before calling virStrcpy to copy it. However, > virStrcpy will fail if src is emp

Re: [libvirt] [PATCH v2 00/24] scripts: convert most perl scripts to python

2019-09-13 Thread Jim Fehlig
On 9/13/19 2:56 AM, Andrea Bolognani wrote: > On Wed, 2019-09-11 at 17:23 +0100, Daniel P. Berrangé wrote: >> This series is an effort to reduce the number of different >> languages we use by eliminating most use of perl in favour >> of python. > > Just today I found out about > > >

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-11 Thread Jim Fehlig
On 9/11/19 10:33 AM, Marek Marczykowski-Górecki wrote: > On Wed, Sep 11, 2019 at 01:31:34PM +0000, Jim Fehlig wrote: >> On 9/11/19 5:43 AM, Marek Marczykowski-Górecki wrote: >>> On Wed, Sep 11, 2019 at 02:34:57AM +, Jim Fehlig wrote: >>>> On 9/10/19 5:24 PM, Mar

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-11 Thread Jim Fehlig
On 9/11/19 5:43 AM, Marek Marczykowski-Górecki wrote: > On Wed, Sep 11, 2019 at 02:34:57AM +0000, Jim Fehlig wrote: >> On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote: >>> On Tue, Sep 10, 2019 at 10:54:15PM +, Jim Fehlig wrote: >>>> On 9/6/19 8:31 PM, Mar

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-10 Thread Jim Fehlig
On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote: > On Tue, Sep 10, 2019 at 10:54:15PM +0000, Jim Fehlig wrote: >> On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote: >>> From: Ivan Kardykov >>> >>> Libxl driver did not support setup addit

Re: [libvirt] [PATCH 1/2] libxl: add acpi slic table support

2019-09-10 Thread Jim Fehlig
On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote: > From: Ivan Kardykov > > Libxl driver did not support setup additional acpi firmware to xen > guest. It is necessary to activate OEM Windows installs. This patch > allow to define in OS section acpi table param (which supported domain >

[libvirt] [PATCH] apparmor: avoid copying empty profile name

2019-09-09 Thread Jim Fehlig
the profile is not loaded. Signed-off-by: Jim Fehlig --- src/security/security_apparmor.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index 6d16b15c65..77eee9410c 100644 --- a/src/security

Re: [libvirt] [PATCH 4/7] util: make string functions abort on OOM

2019-09-05 Thread Jim Fehlig
On 8/29/19 12:02 PM, Daniel P. Berrangé wrote: > The functions are left returning an "int" to avoid an immediate > big-bang cleanup. They'll simply never return anything other > than 0. > > Signed-off-by: Daniel P. Berrangé > --- > src/util/virstring.c | 93

Re: [libvirt] [PATCH 0/7] util: abort when out of memory

2019-09-05 Thread Jim Fehlig
On 8/29/19 12:02 PM, Daniel P. Berrangé wrote: > See this previous thread: > >https://www.redhat.com/archives/libvir-list/2019-May/msg00273.html > > The executive summary is that catching & reporting ENOMEM is not worth > the maint cost because: > >- this code will almost never run on

[libvirt] [PATCH] maint: Post-release version bump to 5.8.0

2019-09-03 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- Pushed under trivial rule. Usually done by Michal but I need to push other changes to news for the 5.8.0 cycle. configure.ac | 2 +- docs/news.xml | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[libvirt] [PATCH 1/2] xenapi: remove driver

2019-09-02 Thread Jim Fehlig
The xenapi driver has not seen any development since its initial contribution 9 years ago. There have been no bug reports, no patches, and no queries about the driver on the developer or user mailing lists. Remove the driver from the libvirt sources. Signed-off-by: Jim Fehlig --- cfg.mk

[libvirt] [PATCH 2/2] news: Mention removal of xenapi driver

2019-09-02 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 92d566c2fe..303078036d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -63,6 +63,16 @@ KVM device assignment from libvirt too

[libvirt] [PATCH 0/2] Remove xenapi driver

2019-09-02 Thread Jim Fehlig
Remove the xenapi driver is unmaintained and has no known user base. We are stuck with references in include/libvirt/virterror.h and src/util/virerror.c but otherwise I think I've nuked xenapi everywhere. Jim Fehlig (2): xenapi: remove driver news: Mention removal of xenapi driver cfg.mk

Re: [libvirt] [PATCH for 5.7.0 0/2] virsh: Rename --precopy-bandwidth migration option

2019-09-02 Thread Jim Fehlig
4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) > I was a little uncertain about the name and mentioned that when submitting the patch. Agreed that "bandwidth" is more consistent and a better choice. Reviewed-by: Jim Fehlig Regards, Jim -- libvir-list mailing list libvir-

Re: [libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

2019-09-02 Thread Jim Fehlig
On 9/2/19 8:16 AM, Daniel P. Berrangé wrote: > On Mon, Sep 02, 2019 at 02:07:08PM +0000, Jim Fehlig wrote: >> On 8/31/19 2:11 AM, Michal Prívozník wrote: >>> On 8/26/19 1:49 PM, Ján Tomko wrote: >>>> The 'From:' field shows your e-mail in uppercase. >>>&g

Re: [libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

2019-09-02 Thread Jim Fehlig
On 8/31/19 2:11 AM, Michal Prívozník wrote: > On 8/26/19 1:49 PM, Ján Tomko wrote: >> The 'From:' field shows your e-mail in uppercase. >> >> On Fri, Aug 23, 2019 at 07:50:12PM +, Jim Fehlig wrote: >>> Signed-off-by: Jim Fehlig >>> --- >>&g

[libvirt] [PATCH] news: Mention new --precopy-bandwidth parameter for virsh migrate

2019-08-27 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index c6580e4e72..990c84274d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -65,6 +65,16 @@ + + + virsh: Support

[libvirt] [PATCH] virsh: Add support for setting bandwidth in migrate

2019-08-26 Thread Jim Fehlig
Commit f15789ec added support for setting postcopy migration bandwidth to the migrate subcommand. This change does the same for standard migration. Signed-off-by: Jim Fehlig --- I used the term 'standard migration' in the commit message but 'pre-copy' in the documentation. If one is preferred

Re: [libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

2019-08-26 Thread Jim Fehlig
On 8/26/19 5:49 AM, Ján Tomko wrote: > The 'From:' field shows your e-mail in uppercase. Thanks for pointing that out! Seems the O365 server is doing it on my behalf :-(. I've entered an internal ticket. > > On Fri, Aug 23, 2019 at 07:50:12PM +0000, Jim Fehlig wrote: >> Sig

[libvirt] [PATCH] xenconfig: move contents to libxl driver and remove directory

2019-08-23 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- cfg.mk | 2 +- configure.ac | 2 -- po/POTFILES | 6 ++--- src/Makefile.am | 1 - src/libvirt_xenconfig.syms | 12 -- src

Re: [libvirt] [PATCH v4 27/42] libxl: introduce virtxend daemon

2019-08-23 Thread Jim Fehlig
On 8/8/19 9:10 AM, Daniel P. Berrangé wrote: > Arguably we could rename the libxl driver to "xen" since it is the > only xen driver we have these days, and that matches how we expose it > to users in the URI naming. While thinking about this today I realized it is actually quite a rat hole. I

Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

2019-08-19 Thread Jim Fehlig
.0 so I guess > everybody > has it). Would be nice to kill the 'newid' handling. I thought it sounded familiar, and not in a good way: 70f83f9d526 (Jim Fehlig 2016-08-01 21:36:45 -0600 1265) * to the unpleasant new_id interface. Regards, Jim -- libvir-list mailing list libvir-list

Re: [libvirt] [PATCH] remote_daemon_dispatch.c: typecast ARRAY_CARDINALITY() in remoteDispatchProbeURI()

2019-08-15 Thread Jim Fehlig
longer than fixing it in the first place :-). Thanks for taking care of it! Reviewed-by: Jim Fehlig Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 0/2] libxl: suspend-related fixes

2019-08-13 Thread Jim Fehlig
er a successful call to the underlying libxl API. Jim Fehlig (2): Revert "libxl: send lifecycle event on suspend" libxl: send lifecycle event on PMSuspend src/libxl/libxl_domain.c | 19 --- src/libxl/libxl_driver.c | 6 ++ 2 files changed, 14 insertions(+

[libvirt] [PATCH 1/2] Revert "libxl: send lifecycle event on suspend"

2019-08-13 Thread Jim Fehlig
as before. This reverts commit d00c77ae45c7d9fd90384f01cd8b04c54f501e96. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index b60511a266..4073bf8

[libvirt] [PATCH 2/2] libxl: send lifecycle event on PMSuspend

2019-08-13 Thread Jim Fehlig
After a successful call to libxl_domain_suspend_only(), set domain state to VIR_DOMAIN_PMSUSPENDED and send lifecycle event. Signed-off-by: Jim Fehlig --- src/libxl/libxl_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index

Re: [libvirt] [PATCH v4 39/42] remote: handle autoprobing of driver within virtproxyd

2019-08-13 Thread Jim Fehlig
On 8/8/19 9:10 AM, Daniel P. Berrangé wrote: > The virtproxyd daemon is merely responsible for forwarding RPC calls to > one of the other per-driver daemons. As such, it does not have any > drivers loaded and so regular auto-probing logic will not work. We need > it to be able to handle NULL URIs

Re: [libvirt] [PATCH] daemon: improve Xen support in systemd service

2019-08-05 Thread Jim Fehlig
On 8/1/19 3:36 AM, Daniel P. Berrangé wrote: > On Wed, Jul 31, 2019 at 06:18:00PM +0000, Jim Fehlig wrote: >> The xencommons service provides all the essential services such as >> xenstored, xenconsoled, etc. needed by the libvirt Xen driver, so >> libvirtd should be sta

[libvirt] [PATCH] daemon: improve Xen support in systemd service

2019-07-31 Thread Jim Fehlig
. Add a conflicts on the xendomains service to ensure it is not enabled when libvirtd is enabled. Signed-off-by: Jim Fehlig --- src/remote/libvirtd.service.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in index 3ddf0e229b

[libvirt] [PATCH] news: add entry for new max_threads_per_process option in qemu.conf

2019-07-31 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 82a4ec9c84..3a20f95a0d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -74,6 +74,17 @@ which portions of a disk have changed since a point

Re: [libvirt] [PATCH 17/41] remote: refactor how list of systemd unit files is built

2019-07-29 Thread Jim Fehlig
On 7/29/19 8:18 AM, Andrea Bolognani wrote: > On Mon, 2019-07-29 at 13:17 +0100, Daniel P. Berrangé wrote: >> On Fri, Jul 26, 2019 at 08:01:52PM +0200, Andrea Bolognani wrote: >>> Again IIUC there's nothing really stopping us from generating >>> virtqemud*.service from libvirtd*.service.in, or at

Re: [libvirt] [PATCH 19/41] remote: introduce virtproxyd daemon to handle IP connectivity

2019-07-29 Thread Jim Fehlig
On 7/23/19 10:02 AM, Daniel P. Berrangé wrote: > The libvirtd daemon provides the traditional libvirt experience where > all the drivers are in a single daemon, and is accessible over both > local UNIX sockets and remote IP sockets. > > In the new world we're having a set of per-driver daemons

Re: [libvirt] [PATCH 26/41] libxl: introduce virtxend daemon

2019-07-26 Thread Jim Fehlig
On 7/23/19 10:03 AM, Daniel P. Berrangé wrote: > The virtxend daemon will be responsible for providing the libxl API Written that way, with the 'xen' and 'd' squashed together, revives nightmares of another thing with similar name :-). However I agree it is the correct name to use here and the

[libvirt] [PATCH] README: fix license typo

2019-07-25 Thread Jim Fehlig
The README contains a reference to GPL 2.1, which does not exist. COPYING contains 2.0 so change the README to follow. Signed-off-by: Jim Fehlig --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1271843cb1..4d1e86259d 100644

[libvirt] [PATCH RESEND] qemu: Add support for overriding max threads per process limit

2019-07-23 Thread Jim Fehlig
-by: Jim Fehlig --- Rebase and resend of https://www.redhat.com/archives/libvir-list/2019-June/msg00185.html src/lxc/lxc_cgroup.c | 1 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 10 ++ src/qemu/qemu_cgroup.c | 1 + src/qemu

Re: [libvirt] [PATCH] remote: increase daemon shutdown timer to 2 minutes

2019-07-18 Thread Jim Fehlig
e virsh in single-shot mode, and often get distracted, so 5 minutes is more to my taste :-). > > Signed-off-by: Daniel P. Berrangé > --- > src/remote/libvirtd.service.in | 2 +- > src/rpc/virnetsocket.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Revi

Re: [libvirt] [PATCH v2] logging: ensure virtlogd rollover takes priority over logrotate

2019-07-11 Thread Jim Fehlig
tate.in | 10 +- > 4 files changed, 17 insertions(+), 3 deletions(-) This patch looks good based on requirement of logrotate not interfering with virtlogd rotation, and for that Reviewed-by: Jim Fehlig But the problem of unpurged log files that Jan was attempting to solve remains. If I un

Re: [libvirt] [PATCH] logging: ensure virtlogd rollover takes priority over logrotate

2019-07-09 Thread Jim Fehlig
On 7/8/19 8:12 AM, Daniel P. Berrangé wrote: I should have read more libvirt mail yesterday before responding to the other thread. Sorry for missing this message. > The virtlogd config is set to rollover logs every 2 MB. > > Normally a logrotate config file is also installed to handle cases

Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-08 Thread Jim Fehlig
On 7/8/19 7:51 PM, Jan Zerebecki wrote: > > > On 08/07/2019 23.28, Jim Fehlig wrote: >> On 7/8/19 12:28 PM, Jan Zerebecki wrote: >>> With logrotates copytruncate when e.g. domain1 doesn't exist anymore >>> /var/log/libvirt/qemu/domain1.log will still exi

Re: [libvirt] [PATCH 00/14] xen: Remove sexpr parsing and formatting support

2019-07-08 Thread Jim Fehlig
On 7/3/19 6:37 AM, Peter Krempa wrote: > The formatter support was unused from the time we dropped xend support. > Let's drop the formatter too along with all the unused code. Nice! I see the series has already been reviewed and will only add that AFAICT the xen community has not supported the

Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-08 Thread Jim Fehlig
On 7/8/19 12:28 PM, Jan Zerebecki wrote: > With logrotates copytruncate when e.g. domain1 doesn't exist anymore > /var/log/libvirt/qemu/domain1.log will still exist after rotation even > though it will never be written to. When new domain names keep getting > used this leads to a lot of empty

Re: [libvirt] [PATCH] Do not keep empty log files for deleted domains

2019-07-03 Thread Jim Fehlig
On 7/3/19 2:42 AM, Daniel P. Berrangé wrote: > On Wed, Jul 03, 2019 at 08:55:15AM +0200, Peter Krempa wrote: >> On Wed, Jul 03, 2019 at 08:32:21 +0200, Jan Zerebecki wrote: >>> On 03/07/2019 08.03, Peter Krempa wrote: I'm not sure that this is the right thing to do. virtlogd has some

Re: [libvirt] [PATCH] qemu: Add support for overriding max threads per process limit

2019-06-12 Thread Jim Fehlig
On 6/6/19 11:40 AM, Jim Fehlig wrote: Some VM configurations may result in a large number of threads created by the associated qemu process which can exceed the system default limit. The maximum number of threads allowed per process is controlled by the pids cgroup controller and is set to 16k

Re: [libvirt] [PATCH 0/3] tests: Include LDADDS in qemu_LDADDS

2019-06-12 Thread Jim Fehlig
in qemu_LDADDS tests/Makefile.am | 44 +--- 1 file changed, 25 insertions(+), 19 deletions(-) In addition to reviewing these changes, I also tested them in my LTO build setup. Other than the commit message nit in patch 1, looks good! Reviewed-by: Jim Fehlig

Re: [libvirt] [PATCH 1/3] tests: Tweak cputest_LDADDS

2019-06-12 Thread Jim Fehlig
On 6/12/19 5:19 AM, Andrea Bolognani wrote: We want have all test programs using qemu_LDADDS also use LDADDS, This part of the sentence seems awkward. How about "We want all test programs using qemu_LDADDS to also use LDADDS," ? and cputest is the only existing exception. We can't just

[libvirt] [PATCH] qemu: Add support for overriding max threads per process limit

2019-06-06 Thread Jim Fehlig
-by: Jim Fehlig --- src/lxc/lxc_cgroup.c | 1 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 10 ++ src/qemu/qemu_cgroup.c | 1 + src/qemu/qemu_conf.c | 2 ++ src/qemu/qemu_conf.h | 1 + src/qemu

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-06-03 Thread Jim Fehlig
On 5/30/19 10:00 AM, Andrea Bolognani wrote: On Thu, 2019-05-30 at 16:56 +0200, Michal Privoznik wrote: On 5/30/19 4:44 PM, Jim Fehlig wrote: On 5/30/19 3:08 AM, Michal Privoznik wrote: On 5/29/19 7:44 PM, Jim Fehlig wrote: -libqemutestdriver_la_LIBADD = $(qemu_LDADDS

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-30 Thread Jim Fehlig
On 5/30/19 8:56 AM, Michal Privoznik wrote: On 5/30/19 4:44 PM, Jim Fehlig wrote: On 5/30/19 3:08 AM, Michal Privoznik wrote: On 5/29/19 7:44 PM, Jim Fehlig wrote: openSUSE Factory is in the process of enabling Link Time Optimization [0] and stumbled upon missing symbols when linking

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-30 Thread Jim Fehlig
On 5/30/19 3:08 AM, Michal Privoznik wrote: On 5/29/19 7:44 PM, Jim Fehlig wrote: openSUSE Factory is in the process of enabling Link Time Optimization [0] and stumbled upon missing symbols when linking libqemutestdriver libtool: link: gcc -shared  -fPIC -DPIC  ../src/libvirt_qemu_probes.o

[libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-29 Thread Jim Fehlig
-off-by: Jim Fehlig --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 46d94d2236..1d80647c9f 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -557,7 +557,7 @@ endif WITH_DTRACE_PROBES

Re: [libvirt] Increasing TasksMax when creating machines via systemd

2019-05-23 Thread Jim Fehlig
On 5/23/19 9:22 AM, Daniel P. Berrangé wrote: On Wed, May 22, 2019 at 05:16:38PM -0600, Jim Fehlig wrote: Hi All, I recently received an internal bug report of VM "crashing" due to hitting thread limits. Seems there was an assert in pthread_create within the VM when hitting the limi

[libvirt] Increasing TasksMax when creating machines via systemd

2019-05-22 Thread Jim Fehlig
preferred, suggestions on where to place it and what to call it would be much appreciated :-). Regards, Jim >From 0583ee3b26b2ee43efe8d25226eceb8547400d97 Mon Sep 17 00:00:00 2001 From: Jim Fehlig Date: Wed, 22 May 2019 17:12:14 -0600 Subject: [PATCH] systemd: set TasksMax when calling

Re: [libvirt] [PATCH 3/3] network: delay global firewall setup if no networks are running

2019-05-22 Thread Jim Fehlig
ting cleanup of legacy firewall rules"); Perhaps intended for the previous patch? I tested all the restart scenarios I could think of, including updating from "older" libvirt without private chains (with and without running networks). Looks good! Reviewed-by: Jim

Re: [libvirt] [PATCH 2/3] network: add more debugging of firewall chain creation

2019-05-22 Thread Jim Fehlig
On 5/22/19 6:29 AM, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- src/network/bridge_driver_linux.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) The additional debug messages proved helpful while testing the patches! Reviewed-by: Jim Fehlig

Re: [libvirt] [PATCH 1/3] network: pull global chain init into separate method

2019-05-22 Thread Jim Fehlig
+++ 1 file changed, 24 insertions(+), 15 deletions(-) Eric already mentioned the typo in the commit message. Otherwise Reviewed-by: Jim Fehlig Regards, Jim diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index f2827543ca

Re: [libvirt] [PATCH RFC] network: Delay creating private chains until starting network

2019-05-10 Thread Jim Fehlig
On 5/7/19 4:36 AM, Daniel P. Berrangé wrote: On Tue, Apr 30, 2019 at 02:34:44PM -0600, Jim Fehlig wrote: Automated performance tests found that network-centric workloads suffered a 20 percent decrease when the host libvirt was updated from 5.0.0 to 5.1.0. On the test hosts libvirtd is enabled

Re: [libvirt] [PATCHv2] build: restore support for libyajl 2.0.1

2019-05-09 Thread Jim Fehlig
On 5/9/19 9:18 AM, Andrea Bolognani wrote: On Thu, 2019-05-09 at 16:07 +0200, Ján Tomko wrote: Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did not consider SLE 12 which still has 2.0.1 that does not ship "SLE" is no longer a thing, so either s/SLE/SUSE Linux

[libvirt] [PATCH RFC] network: Delay creating private chains until starting network

2019-04-30 Thread Jim Fehlig
aded until starting a network, when libvirt added rules to the builtin chains. Restore the behavior of previous libvirt versions by delaying the creation of private chains until the first network is started. Signed-off-by: Jim Fehlig --- I briefly discussed this issue with Daniel on IRC and just n

Re: [libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses

2019-04-12 Thread Jim Fehlig
controller-live+disk-scsi-2.xml | 4 ++-- 7 files changed, 16 insertions(+), 14 deletions(-) Thanks. I reviewed and tested the series. Reviewed-by: Jim Fehlig Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses

2019-04-12 Thread Jim Fehlig
On 4/12/19 3:16 AM, Michal Privoznik wrote: On 4/11/19 8:36 PM, Daniel Henrique Barboza wrote: On 4/11/19 11:34 AM, Michal Privoznik wrote: This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg0.html which caused regression to which a proposed

Re: [libvirt] New libvirt-tck failure with libvirt 5.2.0

2019-04-10 Thread Jim Fehlig
On 4/10/19 1:17 PM, Daniel Henrique Barboza wrote: On 4/10/19 3:33 PM, Jim Fehlig wrote: On 4/10/19 12:25 PM, Daniel Henrique Barboza wrote: On 4/10/19 3:08 PM, Jim Fehlig wrote: I noticed libvirt-tck test domain/207-disk-media-change.t started failing after updating to libvirt 5.2.0

Re: [libvirt] New libvirt-tck failure with libvirt 5.2.0

2019-04-10 Thread Jim Fehlig
On 4/10/19 12:25 PM, Daniel Henrique Barboza wrote: On 4/10/19 3:08 PM, Jim Fehlig wrote: I noticed libvirt-tck test domain/207-disk-media-change.t started failing after updating to libvirt 5.2.0. A bisection fingered commit f1d65853 commit f1d658531c7b23b8796a0faa4411c3531996 Author

[libvirt] New libvirt-tck failure with libvirt 5.2.0

2019-04-10 Thread Jim Fehlig
I noticed libvirt-tck test domain/207-disk-media-change.t started failing after updating to libvirt 5.2.0. A bisection fingered commit f1d65853 commit f1d658531c7b23b8796a0faa4411c3531996 Author: Daniel Henrique Barboza Date: Fri Mar 15 18:06:45 2019 -0300 domain_conf: check device

Re: [libvirt] [PATCH 1/2] api: disallow virDomainGetHostname for read-only connections

2019-04-05 Thread Jim Fehlig
s and 2/2 were pushed already :-). Reviewed-by: Jim Fehlig Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] tests: fix mocking of stat() / lstat() functions

2019-04-05 Thread Jim Fehlig
On 4/2/19 3:42 AM, Michal Privoznik wrote: On 4/2/19 10:58 AM, Daniel P. Berrangé wrote: On Mon, Apr 01, 2019 at 06:03:29PM +0100, Daniel P. Berrangé wrote: Quite a few of the tests have a need to mock the stat() / lstat() functions and they are taking somewhat different & inconsistent

Re: [libvirt] [PATCH 2/2] remote: enforce ACL write permission for getting guest time & hostname

2019-04-05 Thread Jim Fehlig
in:read + * @acl: domain:write */ REMOTE_PROC_DOMAIN_GET_TIME = 337, Reviewed-by: Jim Fehlig Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/4] conf: Add a new 'xenbus' controller type

2019-03-14 Thread Jim Fehlig
On 3/13/19 7:17 PM, Eric Blake wrote: On 3/8/19 5:05 PM, Jim Fehlig wrote: xenbus is virtual controller (akin to virtio controllers) for Xen paravirtual devices. Although all Xen VMs have a xenbus, it has never been modeled in libvirt, or in Xen native VM config format for that matter

[libvirt] [PATCH] news: Add entry describing support for Xen's max grant frames

2019-03-13 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 896700fa97..f437a3f455 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -82,6 +82,16 @@ chooses

Re: [libvirt] [PATCH 3/4] libxl: Add support for max_grant_frames

2019-03-12 Thread Jim Fehlig
On 3/12/19 8:17 AM, Daniel P. Berrangé wrote: On Fri, Mar 08, 2019 at 04:05:57PM -0700, Jim Fehlig wrote: Add support for setting max_grant_frames in libxl domain config object and include a test to check that it is properly converted from XML to libxl domain config. Signed-off-by: Jim Fehlig

[libvirt] [PATCH 2/4] libxl: Add implicit xenbus controller

2019-03-08 Thread Jim Fehlig
All Xen domains have a xenbus device. Implicitly add one if not already explicitly specified in the domain config. Signed-off-by: Jim Fehlig --- Lot's of test churn!! src/libxl/libxl_domain.c | 5 + tests/sexpr2xmldata/sexpr2xml-boot-grub.xml

[libvirt] [PATCH 1/4] conf: Add a new 'xenbus' controller type

2019-03-08 Thread Jim Fehlig
in libvirt. max_grant_frames is best modeled as an attribute of xenbus. It describes the maximum IO buffer space (or DMA space) available in xenbus for use by connected paravirtual devices. This patch introduces a new xenbus controller type that includes a maxGrantFrames attribute. Signed-off-by: Jim Fehlig

[libvirt] [PATCH 3/4] libxl: Add support for max_grant_frames

2019-03-08 Thread Jim Fehlig
Add support for setting max_grant_frames in libxl domain config object and include a test to check that it is properly converted from XML to libxl domain config. Signed-off-by: Jim Fehlig --- src/libxl/libxl_conf.c| 9 ++ .../max-gntframes-hvm.json

[libvirt] [PATCH 4/4] xenconfig: Add support for max_grant_frames

2019-03-08 Thread Jim Fehlig
Add support in the domXML<->native config converter for max_grant_frames. Include a test for the conversion. Signed-off-by: Jim Fehlig --- src/xenconfig/xen_xl.c| 56 +++ tests/xlconfigdata/test-max-gntframes.cfg | 13 ++ tests/xlconfigdata/te

[libvirt] [PATCH 0/4] libxl: add support for max grant frames

2019-03-08 Thread Jim Fehlig
config generator. Patch4 adds support for the setting on the domXML<->native config converter and also includes a test. Jim Fehlig (4): conf: Add a new 'xenbus' controller type libxl: Add implicit xenbus controller libxl: Add support for max_grant_frames xenconfig: Add s

Re: [libvirt] [PATCH 2/2] apparmor: Add ptrace and signal rules for named profile

2019-03-05 Thread Jim Fehlig
On 3/2/19 7:20 AM, Jamie Strandboge wrote: On Fri, 01 Mar 2019, Jim Fehlig wrote: Commit a3ab6d42 changed the libvirtd profile to a named profile but neglected to accommodate the change in the qemu profile ptrace and signal rules. As a result, libvirtd is unable to signal confined qemu

Re: [libvirt] [PATCH] libxl: Add support for max_grant_frame setting

2019-03-05 Thread Jim Fehlig
On 3/5/19 3:17 AM, Daniel P. Berrangé wrote: On Mon, Mar 04, 2019 at 04:00:01PM -0700, Jim Fehlig wrote: Xen 4.10 introduced the max_grant_frames xl config setting, which can be set globally in xl.conf(5) or per-domain in xl.cfg(5). max_grant_frames specifies the maximum number of grant frames

Re: [libvirt] domXML modeling question

2019-03-04 Thread Jim Fehlig
Adding xen-devel to cc in case anyone there wants to comment on my latest proposal... On 2/20/19 5:20 PM, Jim Fehlig wrote: There have been a few requests [1][2] to support Xen's max_grant_frames setting in libvirt domXML, but I'm not quite sure how to model it. The documentation [3

[libvirt] [PATCH] libxl: Add support for max_grant_frame setting

2019-03-04 Thread Jim Fehlig
adds support for setting max_grant_frames on a global level in libxl.conf. Per-domain support via domXML can be provided in a future patch. Signed-off-by: Jim Fehlig --- src/libxl/libvirtd_libxl.aug | 2 ++ src/libxl/libxl.conf | 8 src/libxl/libxl_conf.c

[libvirt] [PATCH 2/2] apparmor: Add ptrace and signal rules for named profile

2019-03-01 Thread Jim Fehlig
that reference the libvirtd profile by name in addition to full binary path. Signed-off-by: Jim Fehlig --- src/security/apparmor/libvirt-qemu | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index 7d28faa163..474aaefdf8 100644

[libvirt] [PATCH 1/2] apparmor: Check libvirtd profile status by name

2019-03-01 Thread Jim Fehlig
. Signed-off-by: Jim Fehlig --- src/security/security_apparmor.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index 4afdef065a..6d16b15c65 100644 --- a/src/security/security_apparmor.c +++ b/src

[libvirt] [PATCH 0/2] Small apparmor fixes

2019-03-01 Thread Jim Fehlig
This series fixes a few things I broke when changing the libvirtd apparmor profile to a named profile. See patches for details. Too bad I didn't make it for 5.1.0 release Jim Fehlig (2): apparmor: Check libvirtd profile status by name apparmor: Add ptrace and signal rules for named

Re: [libvirt] [PATCH 0/1] update copyright notice

2019-02-25 Thread Jim Fehlig
On 2/22/19 2:06 AM, David Kiarie wrote: > i did this as part of GSoC. there was no contract. I'm not entirely sure, but we might want to ask the SuSE folks whether they agree. i guess you can do that. my mentor was jim, he's around libvirt a lot. David is correct. There was no

[libvirt] domXML modeling question

2019-02-20 Thread Jim Fehlig
There have been a few requests [1][2] to support Xen's max_grant_frames setting in libvirt domXML, but I'm not quite sure how to model it. The documentation [3] on this setting states: Specify the maximum number of grant frames the domain is allowed to have. This value controls how many pages

Re: [libvirt] [PATCH 2/2] apparmor: convert libvirtd profile to a named profile

2019-01-23 Thread Jim Fehlig
On 1/22/19 1:01 PM, Jamie Strandboge wrote: On Mon, 14 Jan 2019, Jim Fehlig wrote: Signed-off-by: Jim Fehlig --- Optional patch that may need a bit of coorindation with upstream apparmor since the dnsmasq profile currently has 'peer=/usr/sbin/libvirtd'. src/security/apparmor

[libvirt] [PATCH 0/2] apparmor: support named profiles

2019-01-14 Thread Jim Fehlig
with upstream apparmor since the dnsmasq profile currently has 'peer=/usr/sbin/libvirtd'. Jim Fehlig (2): apparmor: Add support for named profiles apparmor: convert libvirtd profile to a named profile src/security/apparmor/usr.sbin.libvirtd | 7 +-- 1 file changed, 5 insertions(+), 2 deletions

[libvirt] [PATCH 2/2] apparmor: convert libvirtd profile to a named profile

2019-01-14 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- Optional patch that may need a bit of coorindation with upstream apparmor since the dnsmasq profile currently has 'peer=/usr/sbin/libvirtd'. src/security/apparmor/usr.sbin.libvirtd | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src

[libvirt] [PATCH 1/2] apparmor: Add support for named profiles

2019-01-14 Thread Jim Fehlig
switched dnsmasq to a named profile. ATM it is the only named profile switch that has affected libvirt. Add rules to the libvirtd profile to reference dnsmasq in peer= conditions by profile name. Signed-off-by: Jim Fehlig --- src/security/apparmor/usr.sbin.libvirtd | 2 ++ 1 file changed, 2

[libvirt] [PATCH] libxl: Set current memory value after successful balloon

2019-01-10 Thread Jim Fehlig
the new memory value in active domain def after a successful call to libxl_set_memory_target(). Signed-off-by: Jim Fehlig --- src/libxl/libxl_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index e30c9891d2..f11597b0d7 100644 --- a/src

[libvirt] [PATCH] docs: Improve description of

2018-12-14 Thread Jim Fehlig
improves the text by clarifying it can be used to prevent "host crashing" when VM memory is locked. Signed-off-by: Jim Fehlig --- docs/formatdomain.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.htm

Re: [libvirt] [PATCH 2/2] libxl: handle external domain destroy

2018-12-10 Thread Jim Fehlig
virChrdevsPtr devs; libxl_evgen_domain_death *deathW; +/* the upcoming LIBXL_EVENT_TYPE_DOMAIN_DEATH is caused by libvirt and + * should not be handled separately */ I tweaked this comment a tiny bit by prefixing the sentence with "Flag to indicate ". + bool ignoreDea

  1   2   3   4   5   6   7   8   9   10   >