Re: [libvirt PATCH v3 0/8] Support for VFIO variant drivers, Part 1

On 21/08/2023 20:32, Laine Stump wrote: > A "VFIO variant" driver is a kernel driver for a device that supports > all the APIs of the basic vfio-pci driver (which enables assigning a > host PCI device to a QEMU guest) plus "some extra stuff" (e.g. to > enable things like saving/restoring device

Re: [PATCH v2] util: basic support for VFIO variant drivers

On 31/05/2023 15:31, Jason Gunthorpe wrote: > On Wed, May 31, 2023 at 03:18:17PM +0100, Joao Martins wrote: >> Hey Laine, >> >> On 23/08/2022 15:11, Laine Stump wrote: >>> ping. >>> >>> I have a different version of this patch where I do read

Re: [PATCH v2] util: basic support for VFIO variant drivers

Hey Laine, On 23/08/2022 15:11, Laine Stump wrote: > ping. > > I have a different version of this patch where I do read the modules.alias > file > rather than just checking the name of the driver, but that also requires > "double > mocking" open() in the unit test, which wasn't working

Re: [libvirt] [PATCH v3.1 3/6] libxl: add support for CPUID features policy

On 01/04/2018 12:43 AM, Marek Marczykowski-Górecki wrote: > On Wed, Jan 03, 2018 at 05:00:10PM -0700, Jim Fehlig wrote: >> On 12/19/2017 06:19 AM, Joao Martins wrote: >>> On 12/13/2017 07:09 PM, Marek Marczykowski-Górecki wrote: >>>> +/* >>>> + * Transl

Re: [libvirt] [PATCH v3.1 3/6] libxl: add support for CPUID features policy

On 01/04/2018 12:00 AM, Jim Fehlig wrote: > On 12/19/2017 06:19 AM, Joao Martins wrote: >> On 12/13/2017 07:09 PM, Marek Marczykowski-Górecki wrote: >>> Convert CPU features policy into libxl cpuid policy settings. Use new >>> ("libxl") syntax, which allow t

Re: [libvirt] [PATCH v3 2/6] libxl: do not enable nested HVM by mere presence of element

On 12/19/2017 01:13 PM, Daniel P. Berrange wrote: > On Tue, Dec 19, 2017 at 01:01:36PM +0000, Joao Martins wrote: >> [Sorry for double posting, but I mistakenly forgot to include libvirt list) >> >> +WimT +Daniel >> >> On 12/10/2017 02:10 AM, Marek Marczykowsk

Re: [libvirt] [PATCH v3.1 3/6] libxl: add support for CPUID features policy

On 12/13/2017 07:09 PM, Marek Marczykowski-Górecki wrote: > Convert CPU features policy into libxl cpuid policy settings. Use new > ("libxl") syntax, which allow to enable/disable specific bits, using > host CPU as a base. For this reason, only "host-passthrough" mode is > accepted. > Libxl do not

Re: [libvirt] [PATCH v3 2/6] libxl: do not enable nested HVM by mere presence of element

[Sorry for double posting, but I mistakenly forgot to include libvirt list) +WimT +Daniel On 12/10/2017 02:10 AM, Marek Marczykowski-Górecki wrote: > element may be used to configure other > features, like NUMA, or CPUID. Do not enable nested HVM (which is in > "preview" state after all) by

Re: [libvirt] [PATCH v3] libxl: Add a test suite for libxl_domain_config generator

the comments that Jim mentioned yesterday are ammended, and this looks good to me: Reviewed-by: Joao Martins <joao.m.mart...@oracle.com> It adds a really nice piece of testing infra for libxl_domain_configs. Maybe in the future more tests could be added in (in addition

Re: [libvirt] [PATCH 3/3] tests: check domain XML to libxl structures conversion

On 06/29/2017 11:08 PM, Marek Marczykowski-Górecki wrote: > On Thu, Jun 29, 2017 at 10:06:39AM +0100, Joao Martins wrote: >> On 06/29/2017 02:11 AM, Marek Marczykowski-Górecki wrote: >>> libxl contains a method to dump libxl_domain_config in json format, >>> which is

Re: [libvirt] [PATCH 2/3] libxl: add support for CPUID features policy

On 06/29/2017 09:39 AM, Marek Marczykowski-Górecki wrote: > On Thu, Jun 29, 2017 at 10:04:42AM +0200, Jiri Denemark wrote: >> On Thu, Jun 29, 2017 at 03:11:42 +0200, Marek Marczykowski-Górecki wrote: >>> Set CPU features in appropriate libxl structure. >>> Use old "xend" syntax, because it allow

Re: [libvirt] [PATCH 3/3] tests: check domain XML to libxl structures conversion

On 06/29/2017 02:11 AM, Marek Marczykowski-Górecki wrote: > libxl contains a method to dump libxl_domain_config in json format, > which is really convenient for tests. Unfortunately it require > libxl_ctx, which can be only created when running on Xen (wither in dom0 > or domU). Because of this,

Re: [libvirt] [RFC PATCH v1 4/4] xlconfigtest: add tests for numa cell sibling distances

On 06/12/2017 07:54 PM, Wim Ten Have wrote: > From: Wim ten Have > > Test a bidirectional xen-xl domxml to and from native for numa > support administration as brought under this patch series. > > Signed-off-by: Wim ten Have > --- >

Re: [libvirt] [PATCH V2 2/2] libxl: add default listen address for VNC and spice

ot specified, set the listen > address in virDomainGraphicsDef struct to the libxl default when > creating the frame buffer device. Additionally, set default spice > listen address to 127.0.0.1. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Reviewed-by: Joao M

Re: [libvirt] [PATCH V2 1/2] maint: define a macro for IPv4 loopback address

On 05/19/2017 11:33 PM, Jim Fehlig wrote: > Use a macro instead of hardcoding "127.0.0.1" throughout the > sources. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Reviewed-by: Joao Martins <joao.m.mart...@oracle.com> > --- > src/internal.h

Re: [libvirt] [PATCH] libxl: add default VNC listen address

, socketaddr.c) , maybe defining a macro in a well defined place would be better. Other than that, Reviewed-by: Joao Martins <joao.m.mart...@oracle.com> This fix should silence that message virt-viewer warnings. nice :) Joao > --- > src/libxl/libxl_conf.c | 16 ++-- > 1 f

Re: [libvirt] [PATCH v2] libxl: report numa sibling distances on host capabilities

gt; capabilities would like: > > > > > 263902380 > > > > > ... > > ... > > ... > > > Signed-off-by: Wim ten Have <wim

Re: [libvirt] [PATCH v1 0/3] libxl: nestedhvm support

On 03/08/2017 03:07 PM, Daniel P. Berrange wrote: > On Wed, Mar 08, 2017 at 03:09:11PM +0000, Joao Martins wrote: >> On 03/08/2017 02:13 PM, Daniel P. Berrange wrote: >>> On Wed, Mar 08, 2017 at 03:07:12PM +0100, Wim Ten Have wrote: >>>> From: Wim ten

Re: [libvirt] [PATCH v1 0/3] libxl: nestedhvm support

On 03/08/2017 02:13 PM, Daniel P. Berrange wrote: > On Wed, Mar 08, 2017 at 03:07:12PM +0100, Wim Ten Have wrote: >> From: Wim ten Have >> >> This patch enhances host-passthrough capability to advertise the >> required vendor CPU virtualization feature which will be used

Re: [libvirt] [PATCH RFC 3/4] libxl: implement qemu-agent-command

On 03/03/2017 12:15 AM, Jim Fehlig wrote: > On 03/02/2017 11:46 AM, Jim Fehlig wrote: >> On 02/08/2017 09:44 AM, Joao Martins wrote: >>> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> > > Opps, forgot to mention that it would be helpful if the commit messag

Re: [libvirt] [PATCH RFC 3/4] libxl: implement qemu-agent-command

On 03/02/2017 06:46 PM, Jim Fehlig wrote: > On 02/08/2017 09:44 AM, Joao Martins wrote: >> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> >> --- Sorry - being an RFC I let myself be a little too clumsy on the commit messages. This was meant to have at least the bits m

Re: [libvirt] [PATCH RFC 2/4] qemu_agent: ignore requests echoed back by guest

On 03/02/2017 06:16 PM, Daniel P. Berrange wrote: > On Thu, Mar 02, 2017 at 11:10:10AM -0700, Jim Fehlig wrote: >> On 02/08/2017 09:44 AM, Joao Martins wrote: >>> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> >> >> Since it wasn't needed before,

Re: [libvirt] [PATCH RFC 1/4] qemu_agent: move agent into util

On 03/03/2017 11:35 AM, Daniel P. Berrange wrote: > On Fri, Mar 03, 2017 at 11:36:25AM +0000, Joao Martins wrote: >> >> >> On 03/02/2017 05:58 PM, Jim Fehlig wrote: >>> Sorry for the review delay. >>> >>> On 02/08/2017 09:44 AM, Joao Martins wrote:

Re: [libvirt] [PATCH RFC 2/4] qemu_agent: ignore requests echoed back by guest

On 03/02/2017 06:10 PM, Jim Fehlig wrote: > On 02/08/2017 09:44 AM, Joao Martins wrote: >> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> > > Since it wasn't needed before, I think it is helpful for the commit message > to > describe why the change is need

Re: [libvirt] [PATCH RFC 1/4] qemu_agent: move agent into util

On 03/02/2017 05:58 PM, Jim Fehlig wrote: > Sorry for the review delay. > > On 02/08/2017 09:44 AM, Joao Martins wrote: >> As it could be shared with libxl which now allows channels to >> be created. Also changed filename to match others in the same >> directory

[libvirt] [PATCH] libxl: fix coverity issues introduced by 6a95edf

. [0] https://www.redhat.com/archives/libvir-list/2017-February/msg00791.html [1] https://www.redhat.com/archives/libvir-list/2017-February/msg00833.html Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- Cc: John Ferlan <jfer...@redhat.com> Cc: Jim Fehlig <jfeh...@suse.com&

Re: [libvirt] [PATCH v3 2/2] libxl: add tunnelled migration support

On 02/16/2017 02:57 PM, John Ferlan wrote: > On 02/16/2017 09:26 AM, Joao Martins wrote: >> On 02/16/2017 11:47 AM, John Ferlan wrote: >>> FYI: Couple of Coverity issues resulted from these patches. >>> >>>> int >>>> +lib

Re: [libvirt] [PATCH] news: document libxl tunnelled migration support

On 02/16/2017 01:24 AM, Jim Fehlig wrote: > On 02/15/2017 05:06 PM, Joao Martins wrote: >> On 02/15/2017 11:41 PM, Jim Fehlig wrote: >>> Joao Martins wrote: >>>> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> >>>> --- >>>> docs/

Re: [libvirt] [PATCH v3 2/2] libxl: add tunnelled migration support

On 02/16/2017 11:47 AM, John Ferlan wrote: > FYI: Couple of Coverity issues resulted from these patches. > >> int >> +libxlDomainMigrationPrepareTunnel3(virConnectPtr dconn, >> + virStreamPtr st, >> + virDomainDefPtr *def, >> +

Re: [libvirt] [PATCH] news: document libxl tunnelled migration support

On 02/15/2017 11:41 PM, Jim Fehlig wrote: > Joao Martins wrote: >> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> >> --- >> docs/news.xml | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/docs/news.xml b/docs/news.xml &

Re: [libvirt] [PATCH v3 0/2] libxl: tunnelled migration support

On 02/15/2017 10:14 PM, Joao Martins wrote: > On 02/15/2017 09:53 PM, Jim Fehlig wrote: >> Joao Martins wrote: >>> Hey! >>> >>> Presented herewith is take 4 from tunnelled migration addressing all >>> previous >>> comments. No function

[libvirt] [PATCH] news: document libxl tunnelled migration support

Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index b756a97..b0629b5 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -53,6 +53,16 @@ was virt

Re: [libvirt] [PATCH v3 0/2] libxl: tunnelled migration support

On 02/15/2017 09:53 PM, Jim Fehlig wrote: > Joao Martins wrote: >> Hey! >> >> Presented herewith is take 4 from tunnelled migration addressing all previous >> comments. No functional changes from v2, only revert to v1 on the top level >> migration functio

Re: [libvirt] [PATCH v3 2/2] libxl: add tunnelled migration support

On 02/15/2017 11:17 AM, Joao Martins wrote: > From: Bob Liu <bob@oracle.com> > > Tunnelled migration doesn't require any extra network connections > beside the libvirt daemon. It's capable of strong encryption and the > default option of openstack-nova. > > Th

[libvirt] [PATCH v3 2/2] libxl: add tunnelled migration support

ra '--tunnelled' to the libvirt p2p migration command. Signed-off-by: Bob Liu <bob@oracle.com> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- v3: * virStream{Send,Finish} and VIR_ALLOC_N already report errors, hence removing the virReportError calls from its error

[libvirt] [PATCH v3 0/2] libxl: tunnelled migration support

Joao Martins (1): libxl: refactor libxlDomainMigrationPrepare src/libxl/libxl_driver.c| 58 ++- src/libxl/libxl_migration.c | 367 +--- src/libxl/libxl_migration.h | 9 ++ 3 files changed, 381 insertions(+), 53 deletions(-) -- 2.1.4

[libvirt] [PATCH v3 1/2] libxl: refactor libxlDomainMigrationPrepare

The newly introduced function libxlDomainMigrationPrepareAny will be shared between P2P and tunnelled variations. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- src/libxl/libxl_migration.c | 92 +++-- 1 file changed, 56 insertions(

Re: [libvirt] [PATCH v2 3/3] libxl: add tunnelled migration support

On 02/14/2017 03:34 AM, Jim Fehlig wrote: > On 02/07/2017 05:35 PM, Joao Martins wrote: >> From: Bob Liu <bob@oracle.com> >> >> Tunnelled migration doesn't require any extra network connections beside >> the libvirt daemon. It's capable of strong enc

Re: [libvirt] [PATCH v2 2/3] libxl: streamline top-level migrate functions

On 02/14/2017 03:13 AM, Jim Fehlig wrote: > On 02/07/2017 05:35 PM, Joao Martins wrote: >> This allows us to reuse a single function for both tunnelled and >> non-tunnelled variants. >> >> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> >>

Re: [libvirt] [PATCH V2 2/2] libxl: fix dom0 maximum memory setting

On 02/09/2017 04:58 PM, Jim Fehlig wrote: > Joao Martins wrote: >> On 02/08/2017 10:24 PM, Jim Fehlig wrote: >>> When the libxl driver is initialized, it creates a virDomainDef >>> object for dom0 and adds it to the list of domains. Total memory >>> for d

Re: [libvirt] [PATCH V2 2/2] libxl: fix dom0 maximum memory setting

On 02/09/2017 12:39 PM, Joao Martins wrote: > On 02/08/2017 10:24 PM, Jim Fehlig wrote: >> When the libxl driver is initialized, it creates a virDomainDef >> object for dom0 and adds it to the list of domains. Total memory >> for dom0 was being set from the max_memkb f

Re: [libvirt] [PATCH V2 2/2] libxl: fix dom0 maximum memory setting

imum memory is effectively all physical > host memory. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Argh, sorry. Failed to mention one (non-blocking) observation in the patch about the parsing of "dom0_mem". Regardless, Acked-by: Joao Martins <joao.m.mart...@oracle.com

Re: [libvirt] [PATCH V2 1/2] libxl: fix reporting of maximum memory

efGetMemoryTotal() will produce > the same results as reading the static-max node in xenstore. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Acked-by: Joao Martins <joao.m.mart...@oracle.com> > --- > src/libxl/libxl_driver.c | 5 ++--- > 1 file changed, 2 insert

Re: [libvirt] [PATCH 2/2] libxl: fix dom0 maximum memory setting

On 02/08/2017 04:06 PM, Jim Fehlig wrote: > Joao Martins wrote: >> On 02/02/2017 10:31 PM, Jim Fehlig wrote: >>> When the libxl driver is initialized, it creates a virDomainDef >>> object for dom0 and adds it to the list of domains. Total memory >>> for dom0 wa

Re: [libvirt] [PATCH 2/2] libxl: use init and dispose functions with libxl_physinfo

On 02/08/2017 04:17 PM, Jim Fehlig wrote: > Joao Martins wrote: >> On 02/02/2017 10:39 PM, Jim Fehlig wrote: >>> The typical pattern when calling libxl functions that populate a >>> structure is >>> >>> libxl_foo foo; &g

[libvirt] [PATCH RFC 1/4] qemu_agent: move agent into util

As it could be shared with libxl which now allows channels to be created. Also changed filename to match others in the same directory namely to virqemuagent.{h,c} Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- po/POTFILES.in |2 +- src/Makef

[libvirt] [PATCH RFC 2/4] qemu_agent: ignore requests echoed back by guest

Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- src/util/virqemuagent.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virqemuagent.c b/src/util/virqemuagent.c index caabae0..ffb3489 100644 --- a/src/util/virqemuagent.c +++ b/src/util/virqemua

[libvirt] [PATCH RFC 0/4] libxl: qemu agent support

GuestVcpus * domainSetGuestVcpus * domainSetVcpusFlags (with VIR_DOMAIN_VCPU_GUEST) * domainGetVcpusFlags (with VIR_DOMAIN_VCPU_GUEST) Comments/Feedback is appreciated :) Cheers, Joao [0] https://www.spinics.net/linux/fedora/libvir/msg136685.html Joao Martins (4): qemu_agent: move agent into util qemu_age

[libvirt] [PATCH RFC 4/4] libxl: domainInterfaceAddresses agent support

Allow querying of guest interface address through agent through command `virsh domifaddr test --source agent` Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- src/libxl/libxl_driver.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/libxl/libxl_driv

[libvirt] [PATCH RFC 3/4] libxl: implement qemu-agent-command

Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- src/libxl/libxl_domain.c | 239 ++- src/libxl/libxl_domain.h | 16 src/libxl/libxl_driver.c | 51 ++ 3 files changed, 305 insertions(+), 1 deletion(-) diff --git a/src

Re: [libvirt] [PATCH 2/2] libxl: fix dom0 maximum memory setting

On 02/02/2017 10:31 PM, Jim Fehlig wrote: > When the libxl driver is initialized, it creates a virDomainDef > object for dom0 and adds it to the list of domains. Total memory > for dom0 was being set from the max_memkb field of libxl_dominfo > struct retrieved from libxl, but this field can be set

Re: [libvirt] [PATCH 2/2] libxl: use init and dispose functions with libxl_physinfo

ibxl_physinfo missing the init and > dispose calls. Indeed, > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Reviewed-by: Joao Martins <joao.m.mart...@oracle.com> See also one comment/nit below, perhaps one libxl_physinfo_init could be moved slightly up.. > [...] > diff --

Re: [libvirt] [PATCH 1/2] libxl: honor autoballoon setting in libxl.conf

g is present and > correct, accept it. Only fallback to checking Xen dom0_mem > command line parameter if user-specfied setting is not present. > > Signed-off-by: Jim Fehlig <jfeh...@suse.com> Nice catch! Reviewed-by: Joao Martins <joao.m.mart...@oracle.com> > --- >

[libvirt] [PATCH] xenconfig: fix xml conversion convert with no graphics

If no graphics element is in XML xenFormatXLSpice will access graphics without checking it has one in the first place, leading to a segmentation fault. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- src/xenconfig/xen_xl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [libvirt] [PATCH v2 0/3] libxl: tunnelled migration support

On 02/08/2017 12:35 AM, Joao Martins wrote: > Hey! > > Presented herewith is take 2 from tunnelled migration addressing all previous > comments. Changelog in individual patches (patch 1 and 2 are small > refactorings > suggested in v1) Despite being functional changes mostly I

[libvirt] [PATCH v2 3/3] libxl: add tunnelled migration support

ra '--tunnelled' to the libvirt p2p migration command. Signed-off-by: Bob Liu <bob@oracle.com> Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- v2 (comments from Jim): * Adjust common preparetunnel function reflecting v1 suggestions - Using common top-level Prepare f

[libvirt] [PATCH v2 1/3] libxl: refactor libxlDomainMigrationPrepare

The newly introduced function libxlDomainMigrationPrepareAny will be shared between P2P and tunnelled variations. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- New in v2 --- src/libxl/libxl_migration.c | 92 +++-- 1 file chang

[libvirt] [PATCH v2 2/3] libxl: streamline top-level migrate functions

This allows us to reuse a single function for both tunnelled and non-tunnelled variants. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- New in v2 --- src/libxl/libxl_driver.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff

[libvirt] [PATCH v2 0/3] libxl: tunnelled migration support

tunnelled migration support Joao Martins (2): libxl: refactor libxlDomainMigrationPrepare libxl: streamline top-level migrate functions src/libxl/libxl_driver.c| 79 -- src/libxl/libxl_migration.c | 372 +--- src/libxl/libxl_migration.h

Re: [libvirt] [PATCH 3/4] xenconfig: add support for more timers

On 01/20/2017 10:17 PM, Jim Fehlig wrote: > On 01/20/2017 05:00 AM, Joao Martins wrote: >> On 01/20/2017 01:59 AM, Jim Fehlig wrote: >>> Currently xenconfig only supports the hpet timer for HVM domains. >>> Include support for tsc timer for both PV and HVM domains.

Re: [libvirt] [PATCH 1/4] libxl: fix timer configuration

On 01/20/2017 09:55 PM, Jim Fehlig wrote: > On 01/20/2017 05:00 AM, Joao Martins wrote: >> On 01/20/2017 01:59 AM, Jim Fehlig wrote: >>> The current logic around configuring timers in libxl based on >>> virDomainDef object is a bit brain dead. Unsupported timers are &

Re: [libvirt] [PATCH 3/4] xenconfig: add support for more timers

On 01/20/2017 01:59 AM, Jim Fehlig wrote: > Currently xenconfig only supports the hpet timer for HVM domains. > Include support for tsc timer for both PV and HVM domains. > > Signed-off-by: Jim Fehlig > --- > src/xenconfig/xen_common.c | 87 >

Re: [libvirt] [PATCH 1/4] libxl: fix timer configuration

On 01/20/2017 01:59 AM, Jim Fehlig wrote: > The current logic around configuring timers in libxl based on > virDomainDef object is a bit brain dead. Unsupported timers are > silently ignored and tsc is only recognized if it is the first > timer specified. > > Change the logic to reject

Re: [libvirt] [PATCH] tests: fix QED disk test in xlconfigtest

sstest job doesn't run "make check" on the libvirt test case. FWIW: Acked-by: Joao Martins <joao.m.mart...@oracle.com> > --- > tests/xlconfigdata/test-disk-qed.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/xlconfigdata/test-dis

[libvirt] [PATCH] news: document libxl HVM network attach fix

Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 92e39f9..c19 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -204,6 +204,16 @@ domain defi

Re: [libvirt] [PATCH v4] libxl: define a per-domain logger.

Hey Cedric, On 01/10/2017 09:03 AM, Cédric Bosdonnat wrote: > libxl doesn't provide a way to write one log for each domain. Thus > we need to demux the messages. If our logger doesn't know to which > domain to attribute a message, then it will write it to the default > log file. > > Starting

Re: [libvirt] [PATCH v1] libxl: reverse defaults on HVM net device attach

On 12/14/2016 08:53 PM, Jim Fehlig wrote: > On 12/14/2016 03:53 AM, Joao Martins wrote: >> libvirt libxl picks its own default with respect to the default NIC >> to use. libxlMakeNic is the one responsible for this and on boot it >> picks LIBXL_NIC_TYPE_VIF_

[libvirt] [PATCH v1] libxl: reverse defaults on HVM net device attach

s above commit. Also to avoid ruling out the emulated one we set to LIBXL_NIC_TYPE_IOEMU when setting a model type that is not 'netfront'. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> Signed-off-by: Jim Fehlig <jfeh...@suse.com> --- Since RFC: - Joao: Add mention to HV

Re: [libvirt] [PATCH RFC] libxl: reverse defaults on HVM net device attach

On 12/13/2016 03:24 AM, Jim Fehlig wrote: > On 12/09/2016 04:35 AM, Joao Martins wrote: >> libvirt libxl picks its own default with respect to the default NIC >> to use. libxlMakeNic is the one responsible for this and on boot it >> picks LIBXL_NIC_TYPE_VIF_IOEMU such that i

Re: [libvirt] [PATCH RFC] libxl: reverse defaults on HVM net device attach

On 12/09/2016 11:35 AM, Joao Martins wrote: > libvirt libxl picks its own default with respect to the default NIC > to use. libxlMakeNic is the one responsible for this and on boot it > picks LIBXL_NIC_TYPE_VIF_IOEMU such that it accomodates both PV and > emulated one. The good be

[libvirt] [PATCH RFC] libxl: reverse defaults on HVM net device attach

Also to avoid ruling out the emulated one we set to LIBXL_NIC_TYPE_IOEMU when setting a model type that is not 'netfront'. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- This allows Openstack to attach network interfaces, which currently is broken on libxl if it doesn't

Re: [libvirt] [RFC PATCH] libxl: add tunnelled migration support

On 10/26/2016 07:33 AM, Bob Liu wrote: > Tunnelled migration doesn't require any extra network connections beside the > libvirt daemon. > It's capable of strong encryption and is the default option in openstack-nova. > > This patch add the tunnelled migration(Tunnel3params) support to libxl. >

Re: [libvirt] [PATCH v3 1/4] conf: add xen type for channels

On 09/27/2016 05:05 AM, Jim Fehlig wrote: > On 09/26/2016 11:33 AM, Joao Martins wrote: >> So far only guestfwd and virtio were supported. Add an additional >> for Xen as libxl channels create Xen console visible to the guest. >> >> Signed-off-by: Joao Martins

Re: [libvirt] [PATCH v3 2/4] libxl: channels support

On 09/26/2016 10:44 PM, Jim Fehlig wrote: > On 09/26/2016 11:33 AM, Joao Martins wrote: >> And allow libxl to handle channel element which creates a Xen >> console visible to the guest as a low-bandwitdh communication >> channel. If type is PTY we also fetch the

[libvirt] [PATCH v3 4/4] xlconfigtest: add test for channel conversion

Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> Acked-by: Jim Fehlig <jfeh...@suse.com> --- tests/xlconfigdata/test-channel-pty.cfg | 13 tests/xlconfigdata/test-channel-pty.xml | 33 +++ tests/xlconfigdata/test-channel-u

[libvirt] [PATCH v3 1/4] conf: add xen type for channels

So far only guestfwd and virtio were supported. Add an additional for Xen as libxl channels create Xen console visible to the guest. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- Changes since v2: * Add relevant documentation about target type xen. --- docs/formatdomain.h

[libvirt] [PATCH v3 0/4] libxl: channels support

: 8}, {"ip-address-type": "ipv6", "ip-address": "::1", "prefix": 128}], "hardware-address": "00:00:00:00:00:00"}, {"name": "eth0", "ip-addresses": [{"ip-address-type": "ipv4&quo

[libvirt] [PATCH v3 3/4] xenconfig: channels conversion support

Add support for formating/parsing libxl channels. Syntax on xen libxl goes as following: channel=["connection=pty|socket,path=/path/to/socket,name=XXX",...] Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> Acked-by: Jim Fehlig <jfeh...@suse.com> --- Changes since v

[libvirt] [PATCH v3 2/4] libxl: channels support

27.0.0.1", "prefix": 8}, {"ip-address-type": "ipv6", "ip-address": "::1", "prefix": 128}], "hardware-address": "00:00:00:00:00:00"}, {"name": "eth0", "ip-addresses": [{"

Re: [libvirt] [PATCH v2 2/4] libxl: channels support

On 09/26/2016 05:27 PM, Jim Fehlig wrote: > On 09/26/2016 09:30 AM, Joao Martins wrote: >> On 09/26/2016 03:21 PM, Jim Fehlig wrote: >>> On 09/25/2016 01:13 PM, Joao Martins wrote: >>>> On 09/25/2016 07:55 PM, Joao Martins wrote: >>>>&g

Re: [libvirt] [PATCH v2 2/4] libxl: channels support

On 09/26/2016 03:21 PM, Jim Fehlig wrote: > On 09/25/2016 01:13 PM, Joao Martins wrote: >> On 09/25/2016 07:55 PM, Joao Martins wrote: >>> On 09/24/2016 12:15 AM, Joao Martins wrote: >>>> On September 23, 2016 11:12:00 PM GMT+01:00, Jim Fehlig <jfeh...@suse.com&

Re: [libvirt] [PATCH v2 2/4] libxl: channels support

On 09/25/2016 07:55 PM, Joao Martins wrote: > On 09/24/2016 12:15 AM, Joao Martins wrote: >> On September 23, 2016 11:12:00 PM GMT+01:00, Jim Fehlig <jfeh...@suse.com> >> wrote: >>> On 09/22/2016 01:53 PM, Joao Martins wrote: >>>> [snip] >>>>

Re: [libvirt] [PATCH v2 2/4] libxl: channels support

On 09/24/2016 12:15 AM, Joao Martins wrote: > On September 23, 2016 11:12:00 PM GMT+01:00, Jim Fehlig <jfeh...@suse.com> > wrote: >> On 09/22/2016 01:53 PM, Joao Martins wrote: >>> Allow libxl to handle channel element which creates a Xen >>> console vis

Re: [libvirt] [PATCH v2 1/4] conf: add xen type for channels

On 09/24/2016 12:04 AM, Joao Martins wrote: > On September 23, 2016 11:05:57 PM GMT+01:00, Jim Fehlig <jfeh...@suse.com> > wrote: >> On 09/22/2016 01:53 PM, Joao Martins wrote: >>> So far only guestfwd and virtio were supported. Add an additional >>> for Xen

Re: [libvirt] [PATCH v2 2/4] libxl: channels support

On September 23, 2016 11:12:00 PM GMT+01:00, Jim Fehlig <jfeh...@suse.com> wrote: >On 09/22/2016 01:53 PM, Joao Martins wrote: >> Allow libxl to handle channel element which creates a Xen >> console visible to the guest as a low-bandwitdh communication >> channel. I

Re: [libvirt] [PATCH v2 1/4] conf: add xen type for channels

On September 23, 2016 11:05:57 PM GMT+01:00, Jim Fehlig <jfeh...@suse.com> wrote: >On 09/22/2016 01:53 PM, Joao Martins wrote: >> So far only guestfwd and virtio were supported. Add an additional >> for Xen as libxl channels create Xen console visible to the guest. >

[libvirt] [PATCH v2 0/4] libxl: channels support

;ip-addresses": [{"ip-address-type": "ipv4", "ip-address": "10.100.0.6", "prefix": 24}, {"ip-address-type": "ipv6", "ip-address": "fe80::216:3eff:fe40:88eb", "prefix": 64}], "hardware

[libvirt] [PATCH v2 1/4] conf: add xen type for channels

So far only guestfwd and virtio were supported. Add an additional for Xen as libxl channels create Xen console visible to the guest. Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- docs/schemas/domaincommon.rng | 11 +++ src/conf/domain_conf.c

[libvirt] [PATCH v2 3/4] xenconfig: channels conversion support

Add support for formating/parsing libxl channels. Syntax on xen libxl goes as following: channel=["connection=pty|socket,path=/path/to/socket,name=XXX",...] Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- Changes since v1: * Move path to UNIX case. --- src/xenconfi

[libvirt] [PATCH v2 4/4] xlconfigtest: add test for channel conversion

Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- tests/xlconfigdata/test-channel-pty.cfg | 13 tests/xlconfigdata/test-channel-pty.xml | 33 +++ tests/xlconfigdata/test-channel-unix.cfg | 13 tests/xlconfigdata/test-c

[libvirt] [PATCH v2 2/4] libxl: channels support

0.0.1", "prefix": 8}, {"ip-address-type": "ipv6", "ip-address": "::1", "prefix": 128}], "hardware-address": "00:00:00:00:00:00"}, {"name": "eth0", "ip-addresses": [{"ip-address-t

Re: [libvirt] [PATCH v1 1/4] conf: add xen type for channels

On 09/19/2016 11:29 PM, Jim Fehlig wrote: > On 09/16/2016 05:43 PM, Joao Martins wrote: >> So far only guestfwd and virtio were supported. Add an additional >> for Xen as libxl channels create Xen console visible to the guest. >> >> Signed-off-by: Joao Martins

Re: [libvirt] [PATCH v1 3/4] xenconfig: channels conversion support

On 09/20/2016 04:04 AM, Jim Fehlig wrote: > On 09/16/2016 05:43 PM, Joao Martins wrote: >> Add support for formating/parsing libxl channels. >> >> Syntax on xen libxl goes as following: >> channel=["connection=pty|socket,path=/path/to/socket,name=XXX",.

Re: [libvirt] [PATCH v1 0/4] libxl: channels support

On 09/20/2016 01:14 PM, Michal Privoznik wrote: > On 20.09.2016 13:57, Joao Martins wrote: >> On 09/20/2016 11:54 AM, Michal Privoznik wrote: >>> On 20.09.2016 12:43, Joao Martins wrote: >>>> On 09/20/2016 05:14 AM, Michal Privoznik wrote: >>>>> On 20.

Re: [libvirt] [PATCH v1 0/4] libxl: channels support

On 09/20/2016 11:54 AM, Michal Privoznik wrote: > On 20.09.2016 12:43, Joao Martins wrote: >> On 09/20/2016 05:14 AM, Michal Privoznik wrote: >>> On 20.09.2016 00:04, Jim Fehlig wrote: >>>> On 09/16/2016 05:43 PM, Joao Martins wrote: >>>>> He

Re: [libvirt] [PATCH v1 2/4] libxl: channels support

On 09/19/2016 11:57 PM, Jim Fehlig wrote: > On 09/16/2016 05:43 PM, Joao Martins wrote: >> And allow libxl to handle channel element which creates a Xen >> console visible to the guest as a low-bandwitdh communication >> channel. If type is PTY we also fetch the

Re: [libvirt] [PATCH v1 0/4] libxl: channels support

On 09/20/2016 05:14 AM, Michal Privoznik wrote: > On 20.09.2016 00:04, Jim Fehlig wrote: >> On 09/16/2016 05:43 PM, Joao Martins wrote: >>> Hey, >>> >>> Channels have been on xen toolstack since Xen 4.5 and this small series >>> adds support for it, i

[libvirt] [PATCH v1 4/4] xlconfigtest: add test for channel conversion

Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- tests/xlconfigdata/test-channel-pty.cfg | 13 tests/xlconfigdata/test-channel-pty.xml | 33 +++ tests/xlconfigdata/test-channel-unix.cfg | 13 tests/xlconfigdata/test-c

[libvirt] [PATCH v1 0/4] libxl: channels support

? Additionally what does "state" signify for virtio case: is it that the guest agent is connected, or that the virtio serial is connected? Looking at the qemu driver on processSerialChangedEvent it sounds to me like it's about the serial state. I also have one other series that let

[libvirt] [PATCH v1 3/4] xenconfig: channels conversion support

Add support for formating/parsing libxl channels. Syntax on xen libxl goes as following: channel=["connection=pty|socket,path=/path/to/socket,name=XXX",...] Signed-off-by: Joao Martins <joao.m.mart...@oracle.com> --- src/xenconfi

  1   2   3   >