Re: [libvirt] [PATCH] util: set bridge device MAC address explicitly during virNetDevBridgeCreate

2019-10-17 Thread Laine Stump
Sorry - disregard this patch by itself. There is a small prerequisite patch that is needed along with it. I've resent this patch in a 2 patch series that includes both. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCHv2 0/2] util: set bridge device MAC address explicitly

2019-10-17 Thread Laine Stump
From: Laine Stump I just sent a single patch for this, then realized there was a small prerequisite patch also needed. So 1/2 is the prerequisite patch, and 2/2 is identical to the single patch I sent previously. Laine Stump (2): util: allow sending mac addr to virNetNewLink without ifindex

[libvirt] [PATCHv2 1/2] util: allow sending mac addr to virNetNewLink without ifindex

2019-10-17 Thread Laine Stump
From: Laine Stump Although until now, any use of the extra_args argument (a pointer to a struct containing extra attributes to add the the RTM_NEWLINK message) would always have the ifindex and mac set, so the code could assume it was safe to add both to the message if extra_args != NULL

[libvirt] [PATCHv2 2/2] util: set bridge device MAC address explicitly during virNetDevBridgeCreate

2019-10-17 Thread Laine Stump
From: Laine Stump Remember when the MAC address of libvirt-created bridges weren't stable, and changed as guests were started and stopped? Pepperidge Farms remembers. (No, I would never actually push a comment like that! Just wanted to get your attention). When libvirt first implemented

[libvirt] [PATCH] util: set bridge device MAC address explicitly during virNetDevBridgeCreate

2019-10-17 Thread Laine Stump
Remember when the MAC address of libvirt-created bridges weren't stable, and changed as guests were started and stopped? Pepperidge Farms remembers. (No, I would never actually push a comment like that! Just wanted to get your attention). When libvirt first implemented a stable and configurable

[libvirt] [PATCH] conf: remove parse code for long-extinct "

2019-10-09 Thread Laine Stump
XML. Since the only way a current libvirt would ever encounter this element would be if someone was upgrading directly from libvirt <=v0.7.5 with running guests, it seems safe to finally remove the code that parses it. Signed-off-by: Laine Stump --- The git commit ID's etc are probably not essentia

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-10-01 Thread Laine Stump
On 9/30/19 1:35 PM, Andrea Bolognani wrote: On Mon, 2019-09-30 at 13:13 -0400, Laine Stump wrote: On 9/30/19 10:05 AM, Andrea Bolognani wrote: I see your point about backports being more painful when you have a bunch of unrelated changes mixed in, but I would still prefer if we converted

Re: [libvirt] [PATCH 06/11] util: use glib base64 encoding/decoding APIs

2019-09-30 Thread Laine Stump
On 9/30/19 10:05 AM, Andrea Bolognani wrote: On Mon, 2019-09-30 at 13:41 +0100, Daniel P. Berrangé wrote: On Mon, Sep 30, 2019 at 02:18:17PM +0200, Andrea Bolognani wrote: On Mon, 2019-09-30 at 13:56 +0200, Pavel Hrdina wrote: Agreed, for now let's keep all the wrappers but eventually we can

Re: [libvirt] [PATCH] conf: utility function to update entry in def->nets array

2019-09-26 Thread Laine Stump
On 9/26/19 11:51 AM, Laine Stump wrote: On 9/26/19 3:28 AM, Michal Privoznik wrote: On 9/25/19 6:57 PM, Laine Stump wrote: diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0753904472..5f63c4f51e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8786,8

Re: [libvirt] [PATCH] conf: utility function to update entry in def->nets array

2019-09-26 Thread Laine Stump
On 9/26/19 3:28 AM, Michal Privoznik wrote: On 9/25/19 6:57 PM, Laine Stump wrote: diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0753904472..5f63c4f51e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8786,8 +8786,10 @@ qemuDomainUpdateDeviceConfig

Re: [libvirt] [PATCH 1.5/3] conf: use VIR_AUTOPTR as much as possible for virNetworkPortDefPtr

2019-09-26 Thread Laine Stump
On 9/26/19 2:52 AM, Michal Privoznik wrote: On 9/23/19 3:08 AM, Laine Stump wrote: Since the VIR_DEFINE_AUTOPTR_FUNC() was added for virNetworkPortDefPtr, I decided to convert all uses of virNetworkPortDefPtr that were appropriate to use VIR_AUTOPTR. This could be squashed into patch 1/2

Re: [libvirt] [PATCH 0/2] conf: refresh network ports missing from network driver

2019-09-25 Thread Laine Stump
ping On 9/21/19 7:59 PM, Laine Stump wrote: Patch 2/2 is the actual fix. 1/2 is just to make the fix simpler. NB: these two patches should also be included with the other patches for https://bugzilla.redhat.com/1745815 Laine Stump (2): conf: take advantage of VIR_AUTO

[libvirt] [PATCH] conf: utility function to update entry in def->nets array

2019-09-25 Thread Laine Stump
-by: Laine Stump --- (I actually think that it was a bad idea to have this "reach over" pointer in the hostdevs array (I can say that, since it was my idea :-), and want to eliminate it in favor of using an iterator function for all operations that need to do something to all hostdevs, bu

Re: [libvirt] [libvirt-tck PATCH] conf: Upgrade the used version of fedora to 30

2019-09-24 Thread Laine Stump
On 9/24/19 2:59 AM, Erik Skultety wrote: Fedora 28 is already EOL and the URLs don't work anymore either because EOL resources eventually move to http://archives.fedoraproject.org/pub/archive/fedora/ from https://dl.fedoraproject.org/pub/fedora/linux/releases/. Hah! I made this same patch

Re: [libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-24 Thread Laine Stump
On Tue, Sep 24, 2019, 6:02 AM Andrea Bolognani wrote: > On Tue, 2019-09-24 at 08:27 +0200, Erik Skultety wrote: > > On Mon, Sep 23, 2019 at 04:47:06PM -0400, Laine Stump wrote: > > > On 9/23/19 1:27 PM, Erik Skultety wrote: > > > > The nwfilter 220-no-ip-sp

Re: [libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-24 Thread Laine Stump
On Tue, Sep 24, 2019, 2:25 AM Erik Skultety wrote: > On Mon, Sep 23, 2019 at 04:47:06PM -0400, Laine Stump wrote: > > On 9/23/19 1:27 PM, Erik Skultety wrote: > > > > From my POV, if you apply the diff at the end of this message, then: > > > > > > Review

Re: [libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-23 Thread Laine Stump
test to explicitly add an element, but I think we still should put it in conditionally, in case someone needs to *not* have it (e.g., there are xen tests run with libvirt-tck, and they might not like it if the domain had an element; I can't say that for sure, because I'm not setup to test Xen

Re: [libvirt] [PATCH] rpm: stop compressing the ChangeLog file

2019-09-23 Thread Laine Stump
to compress it anymore. Signed-off-by: Daniel P. Berrangé (I've never liked ChangeLog files anyway...) Reviewed-by: Laine Stump --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index e2f2a40238..c7448ed6a6 100644

[libvirt] [PATCH 1.5/3] conf: use VIR_AUTOPTR as much as possible for virNetworkPortDefPtr

2019-09-22 Thread Laine Stump
Since the VIR_DEFINE_AUTOPTR_FUNC() was added for virNetworkPortDefPtr, I decided to convert all uses of virNetworkPortDefPtr that were appropriate to use VIR_AUTOPTR. This could be squashed into patch 1/2, or left separate, or just completely dropped. Signed-off-by: Laine Stump --- src/conf

[libvirt] [PATCH 2/2] conf: refresh network ports missing from network driver on restart

2019-09-21 Thread Laine Stump
rtid for these cases, it makes for less churn in portids (and thus may make troubleshooting simpler) if we make the small fix to virDomainNetDefActualToNetworkPort() that preserves existing valid portids rather than unconditionally generating a new one.) Signed-off-by: Laine Stump --- src/con

[libvirt] [PATCH 1/2] conf: take advantage of VIR_AUTO* in virDomainNetCreatePort()

2019-09-21 Thread Laine Stump
Before adding new code to this function that will be made easier by using auto-cleaning pointers, update it to use auto-cleaning pointers (and the more modern virErrorPreserveLast()). Signed-off-by: Laine Stump --- src/conf/domain_conf.c | 53 ++-- src/conf

[libvirt] [PATCH 0/2] conf: refresh network ports missing from network driver

2019-09-21 Thread Laine Stump
Patch 2/2 is the actual fix. 1/2 is just to make the fix simpler. NB: these two patches should also be included with the other patches for https://bugzilla.redhat.com/1745815 Laine Stump (2): conf: take advantage of VIR_AUTO* in virDomainNetCreatePort() conf: refresh network ports missing

[libvirt] [PATCH] conf: reattach interface taps to correct bridge on restart

2019-09-20 Thread Laine Stump
needs to check for type='network' as well. (at the time we thought that type='network' and type='bridge' could be conflated for interface actual type, but this turned out to be too problematic to do). Signed-off-by: Laine Stump --- (NB: I thought I remembered seeing a bugzilla report go by about

Re: [libvirt] [RFC] quirks of interface target device name

2019-09-17 Thread Laine Stump
On 9/16/19 3:44 PM, Laine Stump wrote: I vote for putting a check in virDomainNetDefValidate() that errors out if it finds target dev present but empty. There may be some who would say "it's existing behavior and has been like this for a long time, so we have to preserve it",

Re: [libvirt] [RFC] quirks of interface target device name

2019-09-16 Thread Laine Stump
On 9/16/19 10:44 AM, Nikolay Shirokovskiy wrote: Hi, all I recently discovered that input is allowed[*] So you're saying this previously failed? Catastrophically (SEGV)? Or did it log an error and refuse to start the domain? by qemu driver's defineXML for element. On start it will

Re: [libvirt] [PATCH 2/3] qemu: move runtime netdev validation into a separate function

2019-09-15 Thread Laine Stump
On 9/13/19 4:02 PM, Michal Prívozník wrote: On 9/13/19 4:52 PM, Laine Stump wrote: +qemuCaps && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VHOSTUSER_MULTIQUEUE)) { NULL is never passed to qemuCaps, so no need to check it. I had put that in so I could also call

Re: [libvirt] [PATCH 2/3] qemu: move runtime netdev validation into a separate function

2019-09-15 Thread Laine Stump
On 9/13/19 4:02 PM, Michal Prívozník wrote: On 9/13/19 4:52 PM, Laine Stump wrote: --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5300,6 +5300,86 @@ qemuDomainWatchdogDefValidate(const virDomainWatchdogDef *dev, } + 3 empty lines instead of 2. :-O +int

Re: [libvirt] [PATCH 0/3] qemu: make runtime validation of NetDefs more consistent

2019-09-15 Thread Laine Stump
On 9/13/19 4:02 PM, Michal Prívozník wrote: On 9/13/19 4:52 PM, Laine Stump wrote: There is some validation of NetDefs () that can't be done until runtime, due to not knowing the exact configuration until that time. This needs to happen in 3 places: 1) in the qemu commandline when a new guest

Re: [libvirt] [PATCH] network: fix connection usage counts after restart

2019-09-13 Thread Laine Stump
On 9/13/19 12:38 PM, Daniel P. Berrangé wrote: On Fri, Sep 13, 2019 at 12:10:34PM -0400, Laine Stump wrote: On 9/13/19 10:59 AM, Daniel P. Berrangé wrote: Since the introduction of the virNetworkPort object, the network driver has a persistent record of ports that have been created against

Re: [libvirt] [PATCH] network: apply bandwidth settings for forward mode=bridge

2019-09-13 Thread Laine Stump
. Berrangé Unfortunately the wrong version of this patch was posted and reviewed and thus it lacked the code to actually apply the bandwidth settings to the bridge itself. Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH] network: add debug when bandwidth settings are not applied

2019-09-13 Thread Laine Stump
On 9/13/19 12:05 PM, Daniel P. Berrangé wrote: To aid in troubleshooting add some debug messages wrt bandwidth settings and networks. Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump (although it sounds like you already found the problem you were looking for :-) --- src

Re: [libvirt] [PATCH] network: fix connection usage counts after restart

2019-09-13 Thread Laine Stump
Reviewed-by: Laine Stump (also tested for direct/bridge, direct/passthrough, hostdev, and normal tap-based virtual networks) There is one issue with this though - it only re-adds connections that were in the port list, while previously (before introduction of virNetworkPortDef) we had

[libvirt] [PATCH 2/3] qemu: move runtime netdev validation into a separate function

2019-09-13 Thread Laine Stump
-off-by: Laine Stump --- src/qemu/qemu_command.c | 52 +-- src/qemu/qemu_domain.c | 80 + src/qemu/qemu_domain.h | 4 +++ 3 files changed, 85 insertions(+), 51 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu

[libvirt] [PATCH 3/3] qemu: call common NetDef validation for hotplug and device update

2019-09-13 Thread Laine Stump
to https://bugzilla.redhat.com/1502754 Signed-off-by: Laine Stump --- src/qemu/qemu_hotplug.c | 32 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index bd8868b0f7..0530bdd990 100644 --- a/src/qemu

[libvirt] [PATCH 0/3] qemu: make runtime validation of NetDefs more consistent

2019-09-13 Thread Laine Stump
that added the warning). This seems to me to be going a bit too far - I think that (at least upstream) we should turn this into an error, and let the regression testing of said management apps catch the behavior change so they can fix their code. (insert Kermit-drinking-coffee meme here) Laine Stump

[libvirt] [PATCH 1/3] conf: make arg to virDomainNetGetActualVirtPortProfile() a const

2019-09-13 Thread Laine Stump
It needs to be used by a function that only has a const pointer to virDomainNetDef. Signed-off-by: Laine Stump --- src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

Re: [libvirt] [PATCH 8/9] qemu: explicitly delete standard tap devices only on platforms that require it

2019-09-06 Thread Laine Stump
On 9/6/19 11:46 AM, Daniel P. Berrangé wrote: On Fri, Sep 06, 2019 at 11:37:12AM -0400, Laine Stump wrote: On 9/6/19 5:16 AM, Daniel P. Berrangé wrote: On Tue, Aug 27, 2019 at 09:46:38PM -0400, Laine Stump wrote: libvirt creates its tap devices without the IFF_PERSIST flag, so

Re: [libvirt] [PATCH 8/9] qemu: explicitly delete standard tap devices only on platforms that require it

2019-09-06 Thread Laine Stump
On 9/6/19 5:16 AM, Daniel P. Berrangé wrote: On Tue, Aug 27, 2019 at 09:46:38PM -0400, Laine Stump wrote: libvirt creates its tap devices without the IFF_PERSIST flag, so they will be automatically deleted when qemu is finished with them. In the case of tap devices created outside of libvirt

Re: [libvirt] [PATCH] docs: document that C & Python are the preferred languages

2019-09-05 Thread Laine Stump
On 9/5/19 1:57 PM, Andrea Bolognani wrote: How about we add a paragraph at the end of the section that says something along the lines of Both the lists above are subject to change: code written in a new programming language might be accepted if it's generally agreed that the advantages

Re: [libvirt] [PATCH] docs: document that C & Python are the preferred languages

2019-09-05 Thread Laine Stump
On 9/5/19 10:51 AM, Andrea Bolognani wrote: On Thu, 2019-09-05 at 15:42 +0100, Daniel P. Berrangé wrote: On Thu, Sep 05, 2019 at 04:22:17PM +0200, Andrea Bolognani wrote: On Thu, 2019-09-05 at 12:42 +0100, Daniel P. Berrangé wrote: + The libvirt repository makes use of a large number of

Re: [libvirt] [PATCH 0/9] support use of precreated tap devices from unprivileged libvirtd

2019-09-05 Thread Laine Stump
hat's used as a gazinta/gazouta for packets). On 8/27/19 9:46 PM, Laine Stump wrote: This resolves https://bugzilla.redhat.com/1723367 It has become more popular to run libvirtd in an unprivileged environment (e.g. inside a container), but until now the only possible types of network connection

Re: [libvirt] [PATCH] news: rewording wrt NSS, virt-login-shell & split daemons

2019-09-03 Thread Laine Stump
On 9/3/19 11:12 AM, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- docs/news.xml | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) Reviewed-by: Laine Stump (but unfortunately too late to be in the release tarball :-/) -- libvir-list

Re: [libvirt] [PATCH] virsh: Fix help for net-port-delete

2019-09-03 Thread Laine Stump
L dump to stdout.") + .data = N_("Delete the specified network port.") }, {.name = NULL} }; Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 6/9] qemu: support unmanaged target tap dev for

2019-08-27 Thread Laine Stump
() is the correct function to call in the case of an existing device, because the same ioctl() that creates a new tap device will also open an existing tap device. Resolves: https://bugzilla.redhat.com/1723367 (partially) Signed-off-by: Laine Stump --- src/qemu/qemu_interface.c | 77

[libvirt] [PATCH 8/9] qemu: explicitly delete standard tap devices only on platforms that require it

2019-08-27 Thread Laine Stump
on platforms that have VIR_NETDEV_TAP_REQUIRE_MANUAL_CLEANUP #defined (which is only FreeBSD). This mistake has been corrected, along with the unnecessary check for non-null net->ifname (it must always be non-null), and erroneous VIR_FREE of net->ifname. Signed-off-by: Laine Stump --- sr

[libvirt] [PATCH 5/9] conf: new "managed" attribute for target dev of

2019-08-27 Thread Laine Stump
hen it automatically creates the tap devices.) Signed-off-by: Laine Stump --- docs/formatdomain.html.in | 48 + docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c| 51 +++ sr

[libvirt] [PATCH 7/9] qemu: support unmanaged macvtap devices with

2019-08-27 Thread Laine Stump
='no'. Resolves: https://bugzilla.redhat.com/1723367 (partially) Signed-off-by: Laine Stump --- src/qemu/qemu_interface.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c index 446f43c364..83580b1a82 100644 --- a/src

[libvirt] [PATCH 4/9] conf: use virXMLFormatElement for interface

2019-08-27 Thread Laine Stump
This will simplify addition of another attribute to the element Signed-off-by: Laine Stump --- src/conf/domain_conf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b7a342bb91..f21731b5f6 100644 --- a/src/conf

[libvirt] [PATCH 9/9] docs: update news file

2019-08-27 Thread Laine Stump
with info about support for using precreated tap/macvtap devices in unprivileged libvirtd. Signed-off-by: Laine Stump --- docs/news.xml | 13 + 1 file changed, 13 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index c6580e4e72..be51d6c953 100644 --- a/docs/news.xml +++ b

[libvirt] [PATCH 3/9] qemu: reorganize qemuInterfaceEthernetConnect()

2019-08-27 Thread Laine Stump
tap/macvtap devices will be more easily reviewable. Signed-off-by: Laine Stump --- src/qemu/qemu_interface.c | 69 --- 1 file changed, 35 insertions(+), 34 deletions(-) diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c index 72ed51cb1f..1e3b7f0

[libvirt] [PATCH 0/9] support use of precreated tap devices from unprivileged libvirtd

2019-08-27 Thread Laine Stump
libvirtd is given a precreated device, that device will *not* be explicitly deleted when qemu is finished with it - the caller must take care of that. Laine Stump (9): util: new function virNetDevMacVLanIsMacvtap() util: make a couple virNetDevMacVlan*() functions public qemu: reorganize qemuInterfaceEthernetConne

[libvirt] [PATCH 2/9] util: make a couple virNetDevMacVlan*() functions public

2019-08-27 Thread Laine Stump
In virNetDevMacVLanOpen(), The "retries" arg has been removed and the value hardcoded as 10, since previously the function was only called from one place, so it was always 10. Signed-off-by: Laine Stump --- src/util/virnetdevmacvlan.c | 12 +--- src/util/virnetdevmacv

[libvirt] [PATCH 1/9] util: new function virNetDevMacVLanIsMacvtap()

2019-08-27 Thread Laine Stump
a netlink dump of the interface and parsing through it to look for some attributes, but that is complicated to figure out, takes longer to execute, and I'm lazy. Signed-off-by: Laine Stump --- src/libvirt_private.syms| 3 +++ src/util/virnetdevmacvlan.c | 23 +++

Re: [libvirt] [PATCH] virpci:fix Secondary Bus Reset bug

2019-08-16 Thread Laine Stump
The fact that you are modifying this code implies that you are using it, and that implies that you are still using legacy KVM device assignment (i.e. the pcistub driver) instead of VFIO device assignment. (I say this because the function that calls this function you've patched,

[libvirt] [PATCH 2/2] network: replace virSaveLastError() with virErrorPreserveLast()

2019-08-15 Thread Laine Stump
virErrorPreserveLast()/virErrorRestore() (added in commit 8333e7455 back in 2017), do a better better job of saving and restoring the last libvirt error than virSaveLastError()/virErrorRestore() (they're simpler, and they also save/restore the system errno). Signed-off-by: Laine Stump --- src

[libvirt] [PATCH 1/2] network: fix crash during cleanup from failure to allocate port

2019-08-15 Thread Laine Stump
ateXML() that happens after networkAllocatePort() has succeeded, so the code to call networkReleasePort() was just moved down to there. Resolves: https://bugzilla.redhat.com/1741390 Signed-off-by: Laine Stump --- src/network/bridge_driver.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[libvirt] [PATCH 0/2] network: fix crash during cleanup from failure to allocate port

2019-08-15 Thread Laine Stump
The first patch fixes the bug. The 2nd patch just updates some code that I noticed while fixing the bug (because I figured someone would whine that I was just moving around calls to outdated APIs). Laine Stump (2): network: fix crash during cleanup from failure to allocate port network

[libvirt] [PATCH] access: fix incorrect addition to virAccessPermNetwork

2019-08-15 Thread Laine Stump
e of the list, while the string was added to the end of the VIR_ENUM_IMPL(). This patch corrects that error by moving the new value to the end of the enum definition, so that the order matches that of the string list. Resolves: https://bugzilla.redhat.com/1741428 Signed-off-by: Laine St

[libvirt] [PATCH] util: allow tap-based guest interfaces to have MAC address prefix 0xFE

2019-08-11 Thread Laine Stump
ticast MAC (lowest bit of first byte set to 1) was chosen), but that's a different issue). Signed-off-by: Laine Stump --- Yes, I find it slightly problematic that the same setting is in two different places in the code, but 1) that is pre-existing, and 2) if I moved the MAC address setting down

Re: [libvirt] [RFC] handling hostdev save/load net config for non SR-IOV devices

2019-07-18 Thread Laine Stump
On 7/18/19 2:58 PM, Daniel Henrique Barboza wrote: On 7/18/19 2:18 PM, Laine Stump wrote: But to back up a bit - what is it about managed='yes' that makes you want to do it that way instead of managed='no'? Do you really ever need the devices to be binded to the host driver? Or are you just

Re: [libvirt] [RFC] handling hostdev save/load net config for non SR-IOV devices

2019-07-18 Thread Laine Stump
On 7/18/19 11:56 AM, Daniel Henrique Barboza wrote: On 7/18/19 12:29 PM, Laine Stump wrote: On 7/18/19 10:29 AM, Daniel Henrique Barboza wrote: Hi, I have a PoC that enables partial coldplug assignment of multifunction PCI devices with managed mode. At this moment, Libvirt can't handle

Re: [libvirt] [RFC] handling hostdev save/load net config for non SR-IOV devices

2019-07-18 Thread Laine Stump
On 7/18/19 10:29 AM, Daniel Henrique Barboza wrote: Hi, I have a PoC that enables partial coldplug assignment of multifunction PCI devices with managed mode. At this moment, Libvirt can't handle this scenario - the code will detach only the hostdevs from the XML, when in fact the whole IOMMU

Re: [libvirt] [PATCH 0/5] network: xmlns dnsmasq option passthrough

2019-07-18 Thread Laine Stump
On 7/18/19 4:59 AM, Daniel P. Berrangé wrote: On Wed, Jul 17, 2019 at 05:38:51PM -0400, Cole Robinson wrote: On 7/17/19 12:49 PM, Laine Stump wrote: On 7/14/19 8:03 PM, Cole Robinson wrote: There's several unresolved RFEs for the bridge driver that are essentially requests to add XML

Re: [libvirt] [PATCH 0/5] network: xmlns dnsmasq option passthrough

2019-07-17 Thread Laine Stump
be straightforward to do, and should still be done, but that shouldn't stop this patch series from going in). This is for the entire series: Reviewed-by: Laine Stump Cole Robinson (5): conf: Add virNetworkXMLOption conf: Add network xmlopt argument conf: Add virNetworkXMLNamespace

Re: [libvirt] [PATCH]daemon: Fix a crash during virNetlinkEventServiceStopAll

2019-06-10 Thread Laine Stump
On 6/10/19 2:15 AM, Liu Haitao wrote: The virNetlinkEventServiceStopAll() should be executed behind virStateCleanup(), for some important resources like(static virNetlinkEventSrvPrivatePtr server) are freed unexpected. However virStateCleanup() need to use this variable(server). The call trace

Re: [libvirt] [PATCH v6 23/23] conf: switch over to use network port APIs for virt drivers

2019-06-07 Thread Laine Stump
, the better! Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 20/23] lxc, libxl: notify network driver of NICs during reconnect

2019-06-07 Thread Laine Stump
as important in the past (since mostly all it did was update the use counter for the network, unless the guest was using macvtap passthrough mode). Reviewed-by: Laine Stump Signed-off-by: Daniel P. Berrangé --- src/libxl/libxl_driver.c | 30 ++ src/lxc

Re: [libvirt] [PATCH v6 19/23] network: add implementation of network port APIs

2019-06-07 Thread Laine Stump
pidey sense tingled for nothing :-) Reviewed-by: Laine Stump /* @def replaced in virNetworkObjUnsetDefTransient*/ def = virNetworkObjGetDef(obj); @@ -5538,6 +5543,394 @@ networkBandwidthUpdate(virDomainNetDefPtr iface, } +static virNetworkPortPtr +networkPo

Re: [libvirt] [PATCH v6 22/23] conf: record a portid against the domain conf

2019-06-07 Thread Laine Stump
On 5/23/19 11:33 AM, Daniel P. Berrangé wrote: The portid will be the UUID of the virNetworkPort object associated with the network interface when a guest is running. Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https

Re: [libvirt] [PATCH v6 21/23] lxc, libxl: save domain status after reconnect

2019-06-07 Thread Laine Stump
On 5/23/19 11:33 AM, Daniel P. Berrangé wrote: The various steps involved in reconnecting to a domain may cause updates to the virDomainObj struct that need to be reflected in the saved status file. Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump --- src/libxl

Re: [libvirt] [PATCH v6 18/23] conf: support recording ports against virNetworkObjPtr

2019-06-06 Thread Laine Stump
ObjEndAPI(); +goto cleanup; +} Why do you do this here instead of adding it to virNetworkLoadState()? ACK as-is if there's a reason for it. Otherwise, ACK with that chunk moved into virNetworkLoadState() Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com h

Re: [libvirt] [PATCH v6 17/23] virsh: add support for network port APIs

2019-06-06 Thread Laine Stump
On 5/23/19 11:32 AM, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé These all worked when I tried them (including the uuid completer. Yay!) Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 03/23] network: make networkLogAllocation independent of domain conf

2019-06-06 Thread Laine Stump
tworkRunHook(obj, dom, iface, VIR_HOOK_NETWORK_OP_IFACE_UNPLUGGED, VIR_HOOK_SUBOP_BEGIN); -networkLogAllocation(netdef, actualType, dev, iface, false); +networkLogAllocation(netdef, dev, >mac, false); } ret = 0; cleanup: Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 04/23] conf: add APIs to convert virDomainNetDef to virNetworkPortDef

2019-06-06 Thread Laine Stump
Reviewed-by: Laine Stump (just so you don't have to go back and search through the v5 patches for the ACK I gave minutes before you sent v6 :-) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 01/23] conf: allow bandwidth parsing / formatting to include class ID

2019-06-05 Thread Laine Stump
the new network port XML to users though, we should get the design right. Signed-off-by: Daniel P. Berrangé I had done this in v5, but for completeness: Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 02/23] conf: introduce virNetworkPortDefPtr struct and XML support

2019-05-24 Thread Laine Stump
On 5/23/19 11:32 AM, Daniel P. Berrangé wrote: Introduce a virNetworkPortDefPtr struct to represent the data associated with a virtual network port. Add APIs for parsing/formatting XML docs with the data. Signed-off-by: Daniel P. Berrangé [...] + +networkport +

Re: [libvirt] [PATCH v6 16/23] remote: add support for new network port APIs

2019-05-23 Thread Laine Stump
On 5/23/19 11:32 AM, Daniel P. Berrangé wrote: Define the wire protocol for the virNetworkPort APIs and enable the client/server RPC dispatch. Signed-off-by: Daniel P. Berrangé ...and so much more boilerplate! :-P Reviewed-by: Laine Stump (Truthfully, I didn't try to visually verify

Re: [libvirt] [PATCH v6 15/23] access: add permissions for network port objects

2019-05-23 Thread Laine Stump
On 5/23/19 11:32 AM, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé Similar to patch 13 - ACK carries over from v5 Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v6 14/23] network: add public APIs for network port object

2019-05-23 Thread Laine Stump
: Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 15/24] access: add permissions for network port objects

2019-05-23 Thread Laine Stump
d I've always been bothered by mixing of - and _ - too bad they don't all use _, that would allow the same name to be used as a C identifier, and make searching easier). Anyway, pointless rant, sorry :-) I can't claim to have deep knowledge of the access driver, but this addition follows the pattern of what's already there, so: Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 14/24] network: add public APIs for network port object

2019-05-23 Thread Laine Stump
0644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -819,4 +819,19 @@ LIBVIRT_5.2.0 { virConnectGetStoragePoolCapabilities; } LIBVIRT_4.10.0; +LIBVIRT_5.3.0 { This needs to be 5.4.0, right? Reviewed-by: Laine Stump (NB: Patches 05/24 - 13/24 already had my ack, and that stands (I'm assuming that if

Re: [libvirt] [PATCH v5 02/24] conf: introduce virNetworkPortDefPtr struct and XML support

2019-05-22 Thread Laine Stump
On 5/22/19 6:29 AM, Daniel P. Berrangé wrote: On Mon, May 20, 2019 at 09:44:04PM -0400, Laine Stump wrote: On 5/14/19 11:48 AM, Daniel P. Berrangé wrote: Introduce a virNetworkPortDefPtr struct to represent the data associated with a virtual network port. Add APIs for parsing/formatting XML

Re: [libvirt] [PATCH v5 04/24] conf: add APIs to convert virDomainNetDef to virNetworkPortDef

2019-05-21 Thread Laine Stump
Reviewed-by: Laine Stump --- src/conf/domain_conf.c | 290 +++ src/conf/domain_conf.h | 17 +++ src/libvirt_private.syms | 3 + 3 files changed, 310 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 011d789feb..7569b1b580

Re: [libvirt] [PATCH v5 02/24] conf: introduce virNetworkPortDefPtr struct and XML support

2019-05-21 Thread Laine Stump
On 5/20/19 9:44 PM, Laine Stump wrote: On 5/14/19 11:48 AM, Daniel P. Berrangé wrote: Introduce a virNetworkPortDefPtr struct to represent the data associated with a virtual network port. Add APIs for parsing/formatting XML docs with the data. Oops. This fails virschematest #1974: 1974

Re: [libvirt] [PATCH v5 03/24] network: make networkLogAllocation independent of domain conf

2019-05-20 Thread Laine Stump
tworkRunHook(obj, dom, iface, VIR_HOOK_NETWORK_OP_IFACE_UNPLUGGED, VIR_HOOK_SUBOP_BEGIN); -networkLogAllocation(netdef, actualType, dev, iface, false); +networkLogAllocation(netdef, dev, >mac, false); } ret = 0; cleanup: Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 02/24] conf: introduce virNetworkPortDefPtr struct and XML support

2019-05-20 Thread Laine Stump
On 5/14/19 11:48 AM, Daniel P. Berrangé wrote: Introduce a virNetworkPortDefPtr struct to represent the data associated with a virtual network port. Add APIs for parsing/formatting XML docs with the data. Signed-off-by: Daniel P. Berrangé --- docs/docs.html.in |

Re: [libvirt] [PATCH v5 01/24] conf: allow bandwidth parsing / formatting to include class ID

2019-05-19 Thread Laine Stump
ALLOC(def) < 0) return ret; @@ -127,6 +130,22 @@ virNetDevBandwidthParse(virNetDevBandwidthPtr *bandwidth, goto cleanup; } +class_id_prop = virXMLPropString(node, "classID"); +1 on changing it from a single attribute inside its own element to a simple attribute :-)

Re: [libvirt] [PATCH] spec: fix f28 rpm without firewalld zone

2019-04-30 Thread Laine Stump
On 4/30/19 11:20 AM, Laine Stump wrote: On 4/30/19 11:08 AM, Cole Robinson wrote: Commit 3b71f2e42d added spec handling for with_firewalld_zone. We now call %firewalld_reload if with_firewalld is set. But the matching 'BuildRequires: firewalld-filesystem' is only applied if with_firewalld_zone

Re: [libvirt] [PATCH] spec: fix f28 rpm without firewalld zone

2019-04-30 Thread Laine Stump
On 4/30/19 11:08 AM, Cole Robinson wrote: Commit 3b71f2e42d added spec handling for with_firewalld_zone. We now call %firewalld_reload if with_firewalld is set. But the matching 'BuildRequires: firewalld-filesystem' is only applied if with_firewalld_zone is set. Fix the former bit to use

Re: [libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-29 Thread Laine Stump
On 4/28/19 4:11 PM, Laine Stump wrote: On 4/26/19 5:07 AM, Michal Privoznik wrote: On 4/17/19 7:19 PM, Daniel P. Berrangé wrote: Ports allocated on virtual networks with type=nat|route|open all get given an actual type of 'network'. Only ports in networks with type=bridge use an actual type

Re: [libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-28 Thread Laine Stump
On 4/26/19 5:07 AM, Michal Privoznik wrote: On 4/17/19 7:19 PM, Daniel P. Berrangé wrote: Ports allocated on virtual networks with type=nat|route|open all get given an actual type of 'network'. Only ports in networks with type=bridge use an actual type of 'bridge'. This distinction makes

Re: [libvirt] [PATCH v4 04/29] network: use 'bridge' as actual type instead of 'network'

2019-04-23 Thread Laine Stump
rname = virDomainNetGetActualBridgeName(def); /* For libivrt network connections, set the following TUN/TAP network This at first seemed really short since there are many more places that check for actualtype=network, but you add an error to all those places  in the next patch, whic

Re: [libvirt] [PATCH v4 03/29] conf: don't pass interface type into virNetDevBandwidthParse

2019-04-18 Thread Laine Stump
On 4/18/19 6:32 AM, Daniel P. Berrangé wrote: On Wed, Apr 17, 2019 at 04:33:54PM -0400, Laine Stump wrote: On 4/17/19 1:19 PM, Daniel P. Berrangé wrote: The virNetDevBandwidthParse method uses the interface type to decide whether to allow use of the "floor" parameter. Using the inte

Re: [libvirt] [PATCH v4 03/29] conf: don't pass interface type into virNetDevBandwidthParse

2019-04-17 Thread Laine Stump
floor". Also, this is one of the things that gave rise to the distinction between actualType == NETWORK and actualType == BRIDGE, and this patch allows us to eliminate that (hopefully) without causing breakage. Switch to an explicit boolean to control its usage. Reviewed-by: Lai

Re: [libvirt] [PATCH v4 02/29] network: explain reason for bandwidth floor rejection

2019-04-17 Thread Laine Stump
. Berrangé Reviewed-by: Laine Stump -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 01/29] network: ensure floor sum is reset to zero when starting networks

2019-04-17 Thread Laine Stump
floor sum back to zero when starting the network, we avoid the need for a libvirtd restart at least. Signed-off-by: Daniel P. Berrangé Reviewed-by: Laine Stump --- src/network/bridge_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network

[libvirt] [PATCH v2 0/2] network: only reload firewall after firewalld is finished restarting

2019-04-12 Thread Laine Stump
Explanation in Patch 2/2 Changes in v2: * don't (erroneously) check the fields of the message if it's a "Reload" message; only do that if it's a NameOwnerChanged Message. * merge virDBusMessageRead() and virDBusMessageDecode(), since they are now identical (new Patch 1/2) Lain

[libvirt] [PATCH v2 1/2] util: eliminate duplicate function virDBusMessageRead

2019-04-12 Thread Laine Stump
the nice API documentation comment from the Read function up to the Decode function). Signed-off-by: Laine Stump --- src/libvirt_private.syms | 1 - src/util/virdbus.c | 53 +--- src/util/virdbus.h | 4 +-- src/util/virdbuspriv.h | 4 --- src/util

[libvirt] [PATCH v2 2/2] network: only reload firewall after firewalld is finished restarting

2019-04-12 Thread Laine Stump
rules only if new_owner is non-empty (it is set to "" when firewalld is stopped, and some sort of epoch number when it is again started). Signed-off-by: Laine Stump --- src/network/bridge_driver.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff -

Re: [libvirt] [PATCH] network: only reload firewall after firewalld is finished restarting

2019-04-12 Thread Laine Stump
On 4/12/19 11:57 AM, Daniel P. Berrangé wrote: On Fri, Apr 12, 2019 at 11:35:13AM -0400, Laine Stump wrote: The network driver used to reload the firewall rules whenever a dbus NameOwnerChanged message for org.fedoraproject.FirewallD1 was received. Presumably at some point in the past

  1   2   3   4   5   6   7   8   9   10   >