Re: [PATCH v2 12/15] virtio-net: Store failover primary opts pointer locally

2021-10-19 Thread Laurent Vivier
On 08/10/2021 15:34, Kevin Wolf wrote: Instead of accessing the global QemuOptsList, which really belong to the command line parser and shouldn't be accessed from devices, store a pointer to the QemuOpts in a new VirtIONet field. This is not the final state, but just an intermediate step to get

Re: [PATCH v2 14/15] qdev: Base object creation on QDict rather than QemuOpts

2021-10-08 Thread Laurent Vivier
On 08/10/2021 15:34, Kevin Wolf wrote: QDicts are both what QMP natively uses and what the keyval parser produces. Going through QemuOpts isn't useful for either one, so switch the main device creation function to QDicts. By sharing more code with the -object/object-add code path, we can even

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-06 Thread Laurent Vivier
On 06/10/2021 12:53, Kevin Wolf wrote: Am 06.10.2021 um 11:20 hat Laurent Vivier geschrieben: On 06/10/2021 10:21, Juan Quintela wrote: Kevin Wolf wrote: Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben: Hi Usage - The primary device can be hotplugged or be part of the startup

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-06 Thread Laurent Vivier
On 06/10/2021 10:21, Juan Quintela wrote: Kevin Wolf wrote: Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben: Hi Usage - The primary device can be hotplugged or be part of the startup configuration -device virtio-net-pci,netdev=hostnet1,id=net1,

Re: [PATCH] failover: allow to pause the VM during the migration

2021-10-04 Thread Laurent Vivier
On 30/09/2021 22:17, Laine Stump wrote: On 9/30/21 1:09 PM, Laurent Vivier wrote: If we want to save a snapshot of a VM to a file, we used to follow the following steps: 1- stop the VM:     (qemu) stop 2- migrate the VM to a file:     (qemu) migrate "exec:cat > snapshot" 3-