[libvirt] The config of IP address for 'macvtap' network

2012-05-15 Thread Lei Li
Hi guys, I know the macvtap network is supported by libvirt as forward mode 'passthrough', I wonder is there anyway to configure the IP address for its interface? For example, If I create a network as below: network namevdsm-testnet/name uuid31f6b3b3-e959-0dd1-ad3a-bf95db660415/uuid

Re: [libvirt] The config of IP address for 'macvtap' network

2012-05-15 Thread Lei Li
On 05/15/2012 05:33 PM, Michal Privoznik wrote: On 15.05.2012 10:57, Lei Li wrote: Hi guys, I know the macvtap network is supported by libvirt as forward mode 'passthrough', I wonder is there anyway to configure the IP address for its interface? For example, If I create a network as below

Re: [libvirt] The config of IP address for 'macvtap' network

2012-05-15 Thread Lei Li
On 05/15/2012 11:12 PM, Laine Stump wrote: On 05/15/2012 05:33 AM, Michal Privoznik wrote: On 15.05.2012 10:57, Lei Li wrote: Hi guys, I know the macvtap network is supported by libvirt as forward mode 'passthrough', I wonder is there anyway to configure the IP address for its interface

[libvirt] [PATCH v2] Provide a helper method virDomainLiveConfigHelperMethod

2011-12-11 Thread Lei Li
. Signed-off-by: Eric Blake ebl...@redhat.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 51 src/conf/domain_conf.h |7 + src/libvirt_private.syms |1 + src/qemu/qemu_driver.c | 288 -- 4 files changed

[libvirt] [PATCH] Provide a helper method virDomainLiveHelperMethod

2011-12-07 Thread Lei Li
; } if (!(persistentDef = virDomainObjGetPersistentDef(driver-caps, vm))) goto endjob; } Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 47 src/conf/domain_conf.h |7 + src/libvirt_private.syms |1 + src/qemu/qemu_driver.c | 288

Re: [libvirt] [PATCHv6 4/7] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

2011-12-01 Thread Lei Li
On 12/01/2011 02:15 AM, Eric Blake wrote: On 11/23/2011 02:44 PM, Eric Blake wrote: From: Lei Lili...@linux.vnet.ibm.com Implement the block I/O throttle setting and getting support to qemu driver. Signed-off-by: Lei Lili...@linux.vnet.ibm.com Signed-off-by: Zhi Yong

[libvirt] [PATCH] Fix a logic error for setting block I/O

2011-12-01 Thread Lei Li
Fix a logic error, the initial value of ret = -1, if just set --config, it will goto endjob directly without doing its really job here. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/qemu

Re: [libvirt] [PATCH 3/8] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

2011-11-28 Thread Lei Li
On 11/28/2011 11:24 PM, Adam Litke wrote: On Wed, Nov 23, 2011 at 10:41:32AM -0700, Eric Blake wrote: Hmm - passing nparams==1 to set just read_bytes_sec has the side effect of wiping out any existing total_iops_sec, even though those two parameters seem somewhat orthogonal, all because we

Re: [libvirt] [PATCH 0/8 v5] Summary on block IO throttle

2011-11-21 Thread Lei Li
On 11/22/2011 08:14 AM, Eric Blake wrote: On 11/15/2011 02:02 AM, Lei Li wrote: Changes since V3 - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. - Relevant changes to remote driver, qemu driver, python support and virsh. Hmm, you didn't summarize changes since

[libvirt] [PATCH 4/8] Support block I/O throtte in XML

2011-11-15 Thread Lei Li
Enable block I/O throttle for per-disk in XML. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 101 +- src/conf/domain_conf.h | 12 ++ src/qemu/qemu_command.c

[libvirt] [PATCH 3/8] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

2011-11-15 Thread Lei Li
Implement the block I/O throttle setting and getting support to qemu driver. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 342 ++ src/qemu/qemu_monitor.c | 37

[libvirt] [PATCH 2/8] Add virDomain{Set, Get}BlockIoTune support to the remote driver

2011-11-15 Thread Lei Li
Support Block I/O Throttle setting and query to remote driver. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- daemon/remote.c | 109 ++ src/remote/remote_driver.c | 96

[libvirt] [PATCH 8/8] Add tests for blkdeviotune

2011-11-15 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- .../qemuxml2argv-blkdeviotune.args |4 ++ .../qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml | 36 tests/qemuxml2argvtest.c

[libvirt] [PATCH 5/8] Enable the blkdeviotune command in virsh

2011-11-15 Thread Lei Li
Support virsh command blkdeviotune. Can set or query a block disk I/O throttle setting. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- tools/virsh.c | 240 +++ tools/virsh.pod | 23

[libvirt] [PATCH 0/8 v5] Summary on block IO throttle

2011-11-15 Thread Lei Li
Changes since V3 - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. - Relevant changes to remote driver, qemu driver, python support and virsh. Changes since V2 - Implement the Python binding support for setting blkio throttling. - Implement --current --live --config

[libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-15 Thread Lei Li
This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in | 63 +++ src/driver.h | 20 ++ src

[libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-14 Thread Lei Li
This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in | 69 src/driver.h | 18 + src

[libvirt] [PATCH 6/8] Doc: Add description and validation for blkdeviotune

2011-11-14 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- docs/formatdomain.html.in | 31 +++ docs/schemas/domaincommon.rng | 24 2 files changed, 55 insertions(+), 0 deletions(-) diff

[libvirt] [PATCH 0/8 v4] Summary on block IO throttle

2011-11-14 Thread Lei Li
Changes since V3 - Use virTypedParameterPtr instead of specific struct in libvirt pulic API. - Relevant changes to remote driver, qemu driver, python support and virsh. Changes since V2 - Implement the Python binding support for setting blkio throttling. - Implement --current --live --config

[libvirt] [PATCH 4/8] Support block I/O throtte in XML

2011-11-14 Thread Lei Li
Enable block I/O throttle for per-disk in XML. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 101 +- src/conf/domain_conf.h | 12 ++ src/qemu/qemu_command.c

[libvirt] [PATCH 8/8] Add tests for blkdeviotune

2011-11-14 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- .../qemuxml2argv-blkdeviotune.args |5 +++ .../qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml | 37 tests/qemuxml2argvtest.c

[libvirt] [PATCH 2/8] Add virDomain{Set, Get}BlockIoTune support to the remote driver

2011-11-14 Thread Lei Li
Support Block I/O Throttle setting and query to remote driver. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- daemon/remote.c | 109 ++ src/remote/remote_driver.c | 96

[libvirt] [PATCH 7/8] Support virDomain{Set, Get}BlockIoThrottle in the python API

2011-11-14 Thread Lei Li
Python support for both setting and getting block I/O throttle. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- python/generator.py |2 + python/libvirt-override-api.xml | 16 python/libvirt-override.c | 178

[libvirt] [PATCH 3/8] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

2011-11-14 Thread Lei Li
This patch implement the block I/O throttle setting and getting support to qemu driver. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 340 ++ src/qemu/qemu_monitor.c

[libvirt] [PATCH 5/8] Enable the blkdeviotune command in virsh

2011-11-14 Thread Lei Li
Support virsh command blkdeviotune. Can set or query a block disk I/O throttle setting. Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- tools/virsh.c | 240 +++ tools/virsh.pod | 23

Re: [libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-14 Thread Lei Li
On 11/15/2011 12:46 PM, Eric Blake wrote: On 11/14/2011 09:33 PM, Lei Li wrote: This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. +/** + * virDomainSetBlockIoTune: + * @dom: pointer to domain object + * @disk: Fully-qualified disk name Hmm. Fully-qualified name

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-10 Thread Lei Li
On 11/11/2011 05:50 AM, Adam Litke wrote: Hi Lei, I've tested this and found that it works well except for one small thing. When the domain is running and I change one of the throttle settings using the --config option in virsh, the on-disk domain xml file is properly updated, but the command

[libvirt] [PATCH 5/8] Enable the blkdeviotune command in virsh

2011-11-09 Thread Lei Li
Support virsh command blkdeviotune. Can set or query a block disk I/O throttle setting. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- tools/virsh.c | 146 +++ tools/virsh.pod | 23

[libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-09 Thread Lei Li
This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in | 26 + src/driver.h | 19 +++ src/libvirt.c

[libvirt] [PATCH 3/8] Implement virDomain{Set, Get}BlockIoTune for the qemu driver

2011-11-09 Thread Lei Li
This patch implement the blk io throttle setting and getting support to qemu driver. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 216 ++ src/qemu/qemu_monitor.c

[libvirt] [PATCH 4/8] Support block I/O throtte in XML

2011-11-09 Thread Lei Li
Enable block I/O throttle for per-disk in XML. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 101 +- src/conf/domain_conf.h | 12 ++ src/qemu/qemu_command.c

[libvirt] [PATCH 2/8] Add virDomain{Set, Get}BlockIoTune support to the remote driver

2011-11-09 Thread Lei Li
Support Block I/O Throttle setting and query to remote driver. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- daemon/remote.c | 87 ++ src/remote/remote_driver.c | 80

[libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-09 Thread Lei Li
Changes since V2 - Implement the Python binding support for setting blkio throttling. - Implement --current --live --config options support to unify the libvirt API. - Add changes in docs and tests. - Some changes suggested by Adam Litke, Eric Blake, Daniel P. Berrange. - Change the XML

[libvirt] [PATCH 7/8] Support virDomain{Set, Get}BlockIoThrottle in the python API

2011-11-09 Thread Lei Li
Python support for both set and get block I/O throttle. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- python/generator.py |2 + python/libvirt-override-api.xml | 16 +++ python/libvirt-override.c | 85

Re: [libvirt] [PATCH 1/8] Add new API virDomain{Set, Get}BlockIoTune

2011-11-09 Thread Lei Li
On 11/10/2011 04:43 AM, Eric Blake wrote: On 11/09/2011 01:32 PM, Lei Li wrote: This patch add new pulic API virDomainSetBlockIoTune and virDomainGetBlockIoTune. Signed-off-by: Zhi Yong Wuwu...@linux.vnet.ibm.com Signed-off-by: Lei Lili...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in

Re: [libvirt] [RFC PATCH 0/8 v3] Summary on block IO throttle

2011-11-09 Thread Lei Li
On 11/10/2011 12:45 PM, Zhi Yong Wu wrote: On Thu, Nov 10, 2011 at 4:32 AM, Lei Lili...@linux.vnet.ibm.com wrote: Changes since V2 - Implement the Python binding support for setting blkio throttling. - Implement --current --live --config options support to unify the libvirt API. - Add

Re: [libvirt] [RFC PATCH 0/8 v2] Summary on block IO throttle

2011-10-28 Thread Lei Li
On 10/27/2011 11:45 PM, Eric Blake wrote: On 10/27/2011 03:12 AM, Lei Li wrote: 1) Enable the blkio throttling in xml when guest is starting up. Add blkio throttling in xml as follows: disk type='file' device='disk' driver name='qemu' type='raw'/ source file='/var/lib/libvirt/images/kvm

Re: [libvirt] [PATCH 7/8] Enable the blkiothrottle command in virsh

2011-10-28 Thread Lei Li
On 10/28/2011 06:02 AM, Adam Litke wrote: On Thu, Oct 27, 2011 at 05:20:09PM +0800, Lei HH Li wrote: Signed-off-by: Zhi Yong Wuwu...@linux.vnet.ibm.com Signed-off-by: Lei Lili...@linux.vnet.ibm.com --- tools/virsh.c | 99 +++

Re: [libvirt] [PATCH 6/8] Implement Get Block IO Throttle for qemu driver

2011-10-28 Thread Lei Li
On 10/28/2011 05:53 AM, Adam Litke wrote: On Thu, Oct 27, 2011 at 05:20:08PM +0800, Lei HH Li wrote: +static int +qemuMonitorJSONBlockIoThrottleInfo(virJSONValuePtr result, + const char *device, +

Re: [libvirt] [PATCH 1/8] Add new API virDomainSetBlockIoThrottle

2011-10-28 Thread Lei Li
On 10/28/2011 04:39 AM, Adam Litke wrote: On Thu, Oct 27, 2011 at 05:20:03PM +0800, Lei HH Li wrote: This patch add new pulic API virDomainSetBlockIoThrottle to src/libvirt.c enable iotune setting for a device in domain XML. You should include the API definition for both

[libvirt] [RFC PATCH 0/8 v2] Summary on block IO throttle

2011-10-27 Thread Lei Li
Changes since V1 - Implement the support to get the block io throttling for a device as read only connection - QMP/HMP. - Split virDomainBlockIoThrottle into two separate functions virDomainSetBlockIoThrottle - Set block I/O limits for a device - Requires a connection in 'write'

[libvirt] [PATCH 1/8] Add new API virDomainSetBlockIoThrottle

2011-10-27 Thread Lei Li
This patch add new pulic API virDomainSetBlockIoThrottle to src/libvirt.c enable iotune setting for a device in domain XML. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in | 17 + src/conf/domain_conf.c

[libvirt] [PATCH 4/8] Add new API virDomainGetBlockIoThrottle

2011-10-27 Thread Lei Li
Support virDomainGetBlockIoThrottle to src/libvirt.c Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in |5 +++ src/driver.h |6 src/libvirt.c| 57

[libvirt] [PATCH 5/8] Getting Block IO Throttle support to remote driver

2011-10-27 Thread Lei Li
Add getting Block IO Throttle support to remote driver. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- daemon/remote.c | 43 ++ src/remote/remote_driver.c | 42

[libvirt] [RFC PATCH 0/8 v2] Summary on block IO throttle

2011-10-27 Thread Lei Li
Changes since V1 - Implement the support to get the block io throttling for a device as read only connection - QMP/HMP. - Split virDomainBlockIoThrottle into two separate functions virDomainSetBlockIoThrottle - Set block I/O limits for a device - Requires a connection in 'write'

[libvirt] [PATCH 8/8] Support virDomainGetBlockIoThrottle in the python API

2011-10-27 Thread Lei Li
Signed-off-by:Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- python/generator.py |2 + python/libvirt-override-api.xml | 16 ++ python/libvirt-override.c | 43 +++ 3 files changed

[libvirt] [PATCH 3/8] Implement Block Io Throttle setting for the qemu driver

2011-10-27 Thread Lei Li
This patch implement the block io throtte setting for the qemu driver through - qmp/hmp command 'block_set_io_throttle'. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/qemu/qemu_command.c | 35 +++ src

[libvirt] [PATCH 7/8] Enable the blkiothrottle command in virsh

2011-10-27 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- tools/virsh.c | 99 +++ tools/virsh.pod | 13 +++ 2 files changed, 112 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b

Re: [libvirt] [PATCH v4 2/2] add interface for blkio.weight_device

2011-10-13 Thread Lei Li
On 10/12/2011 05:26 PM, Hu Tao wrote: This patch adds a parameter --weight-device to virsh command blkiotune for setting/getting blkio.weight_device. --- daemon/remote.c |2 +- include/libvirt/libvirt.h.in |9 ++ src/conf/domain_conf.c | 129

[libvirt] [RFC PATCH 0/5] Summary on QEMU I/O throttling support to libvirt

2011-10-10 Thread Lei Li
Today libvirt supports the cgroups blkio-controller, which handles proportional shares and throughput/iops limits on host block devices. blkio-controller does not support network file systems (NFS) or other QEMU remote block drivers (curl, Ceph/rbd, sheepdog) since they are not host block

[libvirt] [RFC PATCH 1/5] Add new API virDomainBlockIoThrottle

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- include/libvirt/libvirt.h.in | 22 src/conf/domain_conf.c | 77 ++ src/conf/domain_conf.h | 11 ++ src/driver.h | 11 ++ src/libvirt.c

[libvirt] [RFC PATCH 2/5] Add virDomainBlockIoThrottle support to the remote driver

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- daemon/remote.c | 51 src/remote/remote_driver.c | 53 ++ src/remote/remote_protocol.x | 24 ++-

[libvirt] [RFC PATCH 4/5] Enable the virDomainBlockIoThrottle API in virsh

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- tools/virsh.c | 86 +++ tools/virsh.pod | 13 2 files changed, 99 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 9532bc3..51487b7 100644 ---

[libvirt] [RFC PATCH 5/5] Enable virDomainBlockIoThrottle in the python API

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- python/generator.py |1 + python/libvirt-override-api.xml |9 python/libvirt-override.c | 43 +++ 3 files changed, 53 insertions(+), 0 deletions(-) diff --git

[libvirt] [RFC PATCH 3/5] Implement virDomainBlockIoThrottle for the qemu driver

2011-10-10 Thread Lei Li
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- src/qemu/qemu_command.c | 35 ++ src/qemu/qemu_driver.c | 54 + src/qemu/qemu_migration.c| 16 +++--- src/qemu/qemu_monitor.c | 19 +++ src/qemu/qemu_monitor.h |6 ++

Re: [libvirt] [libvirt-glib] API to deal with storage pool(s)

2011-09-26 Thread Lei Li
On 09/27/2011 06:19 AM, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak)zeesha...@gnome.org Add API to fetch, list, retrieve find storage pool(s) on a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 279 ++

Re: [libvirt] [PATCH v2] qemu: Allow domain reboot after core dump

2011-09-21 Thread Lei Li
On 09/21/2011 02:47 PM, Michal Privoznik wrote: This patch introduces possibility to reboot domain after core dump finishes. The new flag VIR_DUMP_REBOOT was added to virDomainCoreDumpFlags. The new functionality is accessible via virsh too: virsh dump --rebootdomain --- diff to v1: -check for

[libvirt] [PATCH v2] Source control for storage pool

2011-09-02 Thread Lei Li
Fix bug #611823 storage driver should prohibit pools with duplicate underlying storage. Add API virStoragePoolSourceFindDuplicate() to do uniqueness check based on source location infomation for pool type. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/storage_conf.c | 80

[libvirt] [PATCH] Source control for storage pool

2011-09-01 Thread Lei Li
Fix bug #611823 storage driver should prohibit pools with duplicate underlying storage. Add API virStoragePoolSourceFindDuplicate() to do uniqueness check based on source location infomation for pool type. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/storage_conf.c | 73

[libvirt] Draft document about source control for type of pools

2011-08-16 Thread Lei Li
Hi Daniel, The last version of my patch fixed bug #611823 prohibit pools with duplicate storage, you gave some comments that should do check by source info instead of target path I used. These days I view the code and existing documents about storage pool, and tried to code based on your

Re: [libvirt] [Libvirt] [PATCH v2] Fix bug #611823 prohibit pools with duplicate storage

2011-08-08 Thread Lei Li
On 08/03/2011 05:29 AM, Daniel P. Berrange wrote: On Wed, Aug 03, 2011 at 12:52:50AM +0800, Lei Li wrote: On 08/02/2011 07:11 PM, Daniel P. Berrange wrote: On Mon, Aug 01, 2011 at 02:12:51PM -0600, Eric Blake wrote: On 07/31/2011 10:58 PM, Lei Li wrote: Make sure the unique storage pool

Re: [libvirt] [Libvirt] [PATCH v2] Fix bug #611823 prohibit pools with duplicate storage

2011-08-02 Thread Lei Li
On 08/02/2011 07:11 PM, Daniel P. Berrange wrote: On Mon, Aug 01, 2011 at 02:12:51PM -0600, Eric Blake wrote: On 07/31/2011 10:58 PM, Lei Li wrote: Make sure the unique storage pool defined and create from different directory to avoid inconsistent version of volume pool created. Wrap your

Re: [libvirt] [Libvirt] [PATCH v2] Fix bug #611823 prohibit pools with duplicate storage

2011-08-02 Thread Lei Li
On 08/02/2011 07:11 PM, Daniel P. Berrange wrote: On Mon, Aug 01, 2011 at 02:12:51PM -0600, Eric Blake wrote: On 07/31/2011 10:58 PM, Lei Li wrote: Make sure the unique storage pool defined and create from different directory to avoid inconsistent version of volume pool created. Wrap your

[libvirt] [Libvirt] [PATCH v3] Fix bug #611823 prohibit pools with duplicate storage

2011-08-01 Thread Lei Li
Make sure the unique storage pool defined and create from different directory to avoid inconsistent version of volume pool created. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/storage_conf.c | 25 + src/conf/storage_conf.h |2 ++ src

[libvirt] [Libvirt] [PATCH v2] Fix bug #611823 prohibit pools with duplicate storage

2011-07-31 Thread Lei Li
Make sure the unique storage pool defined and create from different directory to avoid inconsistent version of volume pool created. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- src/conf/storage_conf.c | 36 src/conf/storage_conf.h |4

[libvirt] [PATCH] Fix bug#611823 prohibit pools with duplicate storage

2011-07-30 Thread Lei Li
Make sure the unique storage pool defined and create from different directory to avoid inconsistent version of volume pool created. Signed-off-by: Lei Lili...@linux.vnet.ibm.com --- src/conf/storage_conf.c | 36 src/conf/storage_conf.h |5

[libvirt] [PATCH] Fix bug #611823 prohibit pools with duplicate storage

2011-07-30 Thread Lei Li
Make sure the unique storage pool defined and create from different directory to avoid inconsistent version of volume pool created. Signed-off-by: Lei Lili...@linux.vnet.ibm.com --- src/conf/storage_conf.c | 36 src/conf/storage_conf.h |4

[libvirt] [PATCH] Fix bug #611823 prohibit pools with duplicate storage

2011-07-29 Thread Lei Li
To make sure the unique storage pool defined and created from different directory to avoid inconsistent version of volume pool created, I add two API be called by storage driver to check for the probable duplicate pools and refused the duplicate pool. virStoragePoolObjFindByPath() provide a