Xen supports only subset of libvirt's sound devices, and starting with
Xen 4.17 it is enforced by libxl. Verify it early.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_domain.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/libxl/libxl_domain.c b
her supported models are the same as in libvirt XML.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- move validation to libxlDomainDefValidate
---
src/libxl/libxl_conf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_con
her supported models are the same as in libvirt XML.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index d13e48abb2..b84257bc12 100644
--- a/sr
ppen from time to time, and will
be annoyed for people on involved in specific code part at all.
As a short term fix, maybe Xen's CI can build libvirt with
-Wno-error=switch-enum?
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
signature.asc
Description: PGP signature
On Tue, Sep 22, 2020 at 09:41:00PM -0600, Jim Fehlig wrote:
> On 9/18/20 9:51 AM, Daniel P. Berrangé wrote:
> > On Fri, Sep 18, 2020 at 05:41:21PM +0200, Marek Marczykowski-Górecki wrote:
> > > On Fri, Sep 18, 2020 at 05:12:52PM +0200, Michal Prívozník wrote:
> > > >
On Fri, Sep 18, 2020 at 05:12:52PM +0200, Michal Prívozník wrote:
> On 9/18/20 1:31 PM, Daniel P. Berrangé wrote:
> > On Wed, Sep 16, 2020 at 11:09:31AM +0200, Michal Privoznik wrote:
> > > On 9/10/20 6:18 AM, Marek Marczykowski-Górecki wrote:
> > > > b_info->
Xen 4.10
Xen 4.10 is the oldest version that still has security support (until
December 2020).
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 13 +
tests/libxlxml2domconfigdata/basic-hvm.json | 4 ++--
tests/libxlxml2domconfi
autodetection there would be a better idea. I don't know what libxl
maintainers would prefer, but I guess either of "not failing if
gfx_passthru=1 but IGD isn't detected" or adding "gfx_passthru=auto".
BTW Here is the discussion when the option was added to qemu:
https://lists.n
On Thu, May 07, 2020 at 09:52:44AM -0600, Jim Fehlig wrote:
> On 5/7/20 5:12 AM, Marek Marczykowski-Górecki wrote:
> > On Thu, Apr 30, 2020 at 02:31:12PM +0200, Artur Puzio wrote:
> > > When no video device is specified in config we should set both
> > > hvm.nographic to
omconfigdata/fullvirt-cpuid.json
> +++ b/tests/libxlxml2domconfigdata/fullvirt-cpuid.json
> @@ -27,6 +27,9 @@
> "apic": "True",
> "acpi": "True",
> "nographic": "True",
> +&q
Add support for xl.cfg(5) pci device 'permissive' option in
domXML-to-xenconfig converter. And a test for it.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- new patch
---
src/libxl/xen_common.c | 51 +---
tests/xlconfigdata/test-fullvirt
), in an
example include "permissive='no'" - to not expose users copying from
documentation to extra risk.
Example usage:
...
Signed-off-by: Simon Gaiser
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
Add support for xl.cfg(5) pci device 'seize' option in
domXML-to-xenconfig converter. And a test for it.
It is functional equivalent of 'managed' attribute of a hostdev, so map
it directly.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- new patch
---
src/libxl/xen_common.c
dering how does it relate to other drivers/hypervisors. Is there
any other that requires some option to be enabled to enable PCI hot
plugging? If yes, I'd try to model this one similar to existing cases.
Otherwise modeling it as a Xen feature would make sense.
--
Best Regards,
Marek Marczykowski-Górecki
From: Simon Gaiser
By setting the permissive flag the guest access to the PCI config space
is not filtered. This might be a security risk, but it's required for
some devices and the IOMMU and interrupt remapping should (mostly?)
contain it.
Signed-off-by: Simon Gaiser
Signed-off-by: Marek
On Tue, Apr 14, 2020 at 03:56:47PM -0600, Jim Fehlig wrote:
> On 4/13/20 1:17 PM, Marek Marczykowski-Górecki wrote:
> > FWIW, in Qubes we have a patches adding e820_host setting here:
> > https://github.com/QubesOS/qubes-core-libvirt/
> > (patches 8-11)
> > Not submitt
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_conf.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index b3f67f8..05d671b 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl
configuration. See xl.cfg(5) man page in the Xen documentation for more
details.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- add documentation
- use virXMLPropString
- add enum entries at the end
---
docs/formatdomain.html.in | 20 +++-
docs/schemas/domaincommon.rng | 16
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/xen_common.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c
index 9a385eb..bbb9739 100644
--- a/src/libxl/xen_common.c
+++ b/src/libxl/xen_common.c
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
tests/xlconfigdata/test-paravirt-e820_host.cfg | 13 +++-
tests/xlconfigdata/test-paravirt-e820_host.xml | 37 +++-
tests/xlconfigtest.c | 1 +-
3 files changed, 51 insertions
Context:
- old thread on xen-devel: http://xen.markmail.org/thread/awcswnywzei4s65e
- new thread here:
https://www.redhat.com/archives/libvir-list/2020-April/msg00447.html
Marek Marczykowski-Górecki (4):
conf: add xen specific feature: e820_host
libxl: make use of e820_host feature
This is Xen specific option to provide domain e820 map based on host
one. Useful when using PCI passthrough, see Xen documentation for more
details.
Signed-off-by: Marek Marczykowski-Górecki
---
docs/schemas/domaincommon.rng | 16 +-
src/conf/domain_conf.c| 106
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index b3f67f8..05d671b 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -692,6 +692,20
Signed-off-by: Marek Marczykowski-Górecki
---
tests/xlconfigdata/test-paravirt-e820_host.cfg | 13 +++-
tests/xlconfigdata/test-paravirt-e820_host.xml | 37 +++-
tests/xlconfigtest.c | 1 +-
3 files changed, 51 insertions(+)
create mode 100644
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/xen_common.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c
index 9a385eb..eedf4c7 100644
--- a/src/libxl/xen_common.c
+++ b/src/libxl/xen_common.c
@@ -592,6 +592,14
Context:
- old thread on xen-devel: http://xen.markmail.org/thread/awcswnywzei4s65e
- new thread here:
https://www.redhat.com/archives/libvir-list/2020-April/msg00447.html
Marek Marczykowski-Górecki (4):
conf: add xen specific feature: e820_host
libxl: make use of e820_host feature
years later it is still there, I think it's safe to assume it
will be there for some more. Or at least it's worth to unbreak some
configurations in the meantime.
I'll rebase them on master and post here.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
The libxl driver already tries to call shutdown inhibit callback in the
right places, but only if it's set. That last part was missing,
resulting in premature shutdown when running libvirtd
--timeout=...
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 7 +--
1 file
ice on too old Xen versions. This means will be _silently_ ignored on older Xen.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 27de67d266..0999fb5
On Mon, Sep 16, 2019 at 12:23:35PM +, Jim Fehlig wrote:
> On 9/15/19 1:43 PM, Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +-
> > tests/libx
/formatdomain.html.in]
Signed-off-by: Marek Marczykowski-Górecki
---
docs/formatdomain.html.in | 3 ++-
src/libxl/libxl_conf.c| 5 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 86a5261..c80f09a 100644
--- a/docs
Signed-off-by: Marek Marczykowski-Górecki
---
tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +-
tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml | 32 -
tests/libxlxml2domconfigtest.c | 2 +-
3 files changed, 88 insertions(+)
create
This isn't exactly equivalent setting (acpi_firmware may point to
non-SLIC ACPI table), but it's the most behavior preserving option.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/xen_xl.c | 7 ++-
tests/xlconfigdata/test-fullvirt-acpi-slic.cfg | 26
On Wed, Sep 11, 2019 at 01:31:34PM +, Jim Fehlig wrote:
> On 9/11/19 5:43 AM, Marek Marczykowski-Górecki wrote:
> > On Wed, Sep 11, 2019 at 02:34:57AM +, Jim Fehlig wrote:
> >> On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote:
> >>> On Tue, Sep 10,
On Wed, Sep 11, 2019 at 02:34:57AM +, Jim Fehlig wrote:
> On 9/10/19 5:24 PM, Marek Marczykowski-Górecki wrote:
> > On Tue, Sep 10, 2019 at 10:54:15PM +, Jim Fehlig wrote:
> >> On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote:
> >>> From: Ivan Kardykov
On Tue, Sep 10, 2019 at 10:54:15PM +, Jim Fehlig wrote:
> On 9/6/19 8:31 PM, Marek Marczykowski-Górecki wrote:
> > From: Ivan Kardykov
> >
> > Libxl driver did not support setup additional acpi firmware to xen
> > guest. It is necessary to activate OEM Windows ins
/formatdomain.html.in]
Signed-off-by: Marek Marczykowski-Górecki
---
docs/formatdomain.html.in | 3 ++-
src/libxl/libxl_conf.c| 5 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index fcb7c59c00..de612ae870 100644
Signed-off-by: Marek Marczykowski-Górecki
---
.../fullvirt-acpi-slic.json | 54 +++
.../fullvirt-acpi-slic.xml| 32 +++
tests/libxlxml2domconfigtest.c| 2 +
3 files changed, 88 insertions(+)
create mode 100644 tests
virDomainObjCheckActive() returns -1 if domain is not active, not 0.
Fixes cb50436c6f "libxl: implement virDomainPM* functions"
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libxl/libxl_
, add a ignoreDeathEvent flag
libxlDomainObjPrivate, set when the domain death is triggered by libvirt
itself.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_domain.c | 71 ++--
src/libxl/libxl_domain.h | 3 ++
2 files changed, 71 insertions(+), 3
Since domain was suspended before and on failed wakeup is destroyed,
send an event.
Also, add missing libxlDomainCleanup.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/libxl/libxl_driver.c b/src/libxl
d
(only ugly), but emitting domain lifecycle event twice would be a major
problem.
Any ideas? Some internal flag set by libxlDomainDestroyInternal() just
before libxl_domain_destroy() call? Where would be a place for such
thing?
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things La
Signed-off-by: Marek Marczykowski-Górecki
---
New patch in v5
---
docs/news.xml | 8
1 file changed, 8 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 4406aeb..d345271 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -68,6 +68,14 @@
be viewed via the domain
builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or
type="pv", which is default). Since the old one is still supported,
still use it when writing native config, so the config will work on
older Xen too (and will also not complicate tests).
Sig
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
- skip PVH test on too old Xen
Changes in v5:
- adjust for xenpvh os type
---
tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++-
tests/libxlxml2dom
e on older Xen
- exclude PVH from VIR_DOMAIN_OSTYPE_XEN <-> VIR_DOMAIN_OSTYPE_LINUX conversion
- fix reported capabilities for PVH
Changes in v4:
- change PVH support detection method
Changes in v5:
- use VIR_DOMAIN_OSTYPE_XENPVH
- add news entry
Marek Marczykowski-Górecki (6):
libxl:
Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
And add a test for it.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
Changes in v5:
- update for xenpvh ostype
---
src/xenconfig/xen_common.
-off-by: Marek Marczykowski-Górecki
---
Changes in v2 proposed by Jim:
- use new_arch_added var instead of i == nr_guest_archs for clarity
- improve comment
- adjust for now required Xen >= 4.6 (remove part for Xen < 4.5)
Changes in v3:
- limit VIR_DOMAIN_OSTYPE_XEN -> VIR_DOMAIN_OST
Make it easier to share HVM and PVH code where relevant. No functional
change.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
On Fri, Oct 19, 2018 at 04:19:21PM +0100, Daniel P. Berrangé wrote:
> On Fri, Oct 19, 2018 at 05:10:30PM +0200, Marek Marczykowski-Górecki wrote:
> > On Fri, Oct 19, 2018 at 03:59:03PM +0100, Daniel P. Berrangé wrote:
> > > On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig
18 3:11 AM, Daniel P. Berrangé wrote:
> > > > > On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> > > > > > On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
> > > > > > > On Sat, Oct 13, 2018 at 08:46:19AM -0600,
On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
> > On Sat, Oct 13, 2018 at 08:46:19AM -0600, Jim Fehlig wrote:
> > > I had some couch time at the start of the weekend and was finally able to
> >
nt to report the additional under the existing 'xen'
> blocks.
Is that virt-install limitation? In that case, IMO virt-install should
be fixed, instead of changing capabilities xml to match its limitations.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the
ures of PV
and PVH. But then, it should probably reject PV features for PVH
machine somewhere - in post parse hook? Or maybe it should forcibly
remove them - for example I see PAE is forcibly enabled for 64bit HVM
guests.
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because
On Tue, Oct 09, 2018 at 04:45:01PM -0600, Jim Fehlig wrote:
> On 10/7/18 9:39 AM, Marek Marczykowski-Górecki wrote:
> > @@ -647,6 +669,22 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
> > return -1;
> > }
> > #endif
> > +} else if (p
e on older Xen
- exclude PVH from VIR_DOMAIN_OSTYPE_XEN <-> VIR_DOMAIN_OSTYPE_LINUX conversion
- fix reported capabilities for PVH
Changes in v4:
- change PVH support detection method
Marek Marczykowski-Górecki (5):
libxl: reorder libxlMakeDomBuildInfo for upcoming PVH support
libxl: add su
Make it easier to share HVM and PVH code where relevant. No functional
change.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
- skip PVH test on too old Xen
---
tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++-
tests/libxlxml2domconfigdata/basic-pvh.xml | 28 +++
Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
And add a test for it.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
---
src/xenconfig/xen_common.c | 11 +--
src/xe
builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or
type="pv", which is default). Since the old one is still supported,
still use it when writing native config, so the config will work on
older Xen too (and will also not complicate tests).
Sig
-off-by: Marek Marczykowski-Górecki
---
Changes in v2 proposed by Jim:
- use new_arch_added var instead of i == nr_guest_archs for clarity
- improve comment
- adjust for now required Xen >= 4.6 (remove part for Xen < 4.5)
Changes in v3:
- limit VIR_DOMAIN_OSTYPE_XEN -> VIR_DOMAIN_OST
On Wed, Oct 03, 2018 at 03:13:30PM -0600, Jim Fehlig wrote:
> On 10/2/18 4:50 PM, Jim Fehlig wrote:
> > On 9/30/18 8:15 PM, Marek Marczykowski-Górecki wrote:
> > > Since this is something between PV and HVM, it makes sense to put the
> > > setting in place whe
On Tue, Oct 02, 2018 at 06:54:01PM -0600, Jim Fehlig wrote:
> On 10/2/18 5:02 PM, Marek Marczykowski-Górecki wrote:
> > On Tue, Oct 02, 2018 at 04:50:02PM -0600, Jim Fehlig wrote:
> > > My idea to add this variable for clarity now seems diluted by the need for
> > >
On Tue, Oct 02, 2018 at 04:50:02PM -0600, Jim Fehlig wrote:
> On 9/30/18 8:15 PM, Marek Marczykowski-Górecki wrote:
> > Since this is something between PV and HVM, it makes sense to put the
> > setting in place where domain type is specified.
> > To enable it, use It
Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
And add a test for it.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
---
src/xenconfig/xen_common.c | 11 +--
src/xe
Make it easier to share HVM and PVH code where relevant. No functional
change.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
-off-by: Marek Marczykowski-Górecki
---
Changes in v2 proposed by Jim:
- use new_arch_added var instead of i == nr_guest_archs for clarity
- improve comment
- adjust for now required Xen >= 4.6 (remove part for Xen < 4.5)
Changes in v3:
- limit VIR_DOMAIN_OSTYPE_XEN -> VIR_DOMAIN_OST
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v3:
- update for modified "libxl: add support for PVH"
- skip PVH test on too old Xen
---
tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++-
tests/libxlxml2domconfigdata/basic-pvh.xml | 28 +++
builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or
type="pv", which is default). Since the old one is still supported,
still use it when writing native config, so the config will work on
older Xen too (and will also not complicate tests).
Sig
eady applied patches
- use #ifdef LIBXL_DOMAIN_TYPE_PVH to detect PVH support, fix compilation
failure on older Xen
- exclude PVH from VIR_DOMAIN_OSTYPE_XEN <-> VIR_DOMAIN_OSTYPE_LINUX conversion
- fix reported capabilities for PVH
Marek Marczykowski-Górecki (5):
libxl: reorder libxlMakeDomB
On Mon, Sep 24, 2018 at 05:09:44PM -0600, Jim Fehlig wrote:
> On 9/18/18 6:50 PM, Marek Marczykowski-Górecki wrote:
> > This is a respin of my old PVHv1 patch[1], converted to PVHv2.
> > Should the code use "PVH" name (as libxl does internally), or "PVHv2
-off-by: Marek Marczykowski-Górecki
---
Changes in v2 proposed by Jim:
- use new_arch_added var instead of i == nr_guest_archs for clarity
- improve comment
- adjust for now required Xen >= 4.6 (remove part for Xen < 4.5)
---
docs/formatcaps.html.in| 4 ++--
docs/s
builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or
type="pv", which is default). Since the old one is still supported,
still use it when writing native config, so the config will work on
older Xen too (and will also not complicate tests).
Sig
Make it easier to share HVM and PVH code where relevant. No functional
change.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_conf.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
If available, use b_info->nested_hvm instead of
b_info->u.hvm.nested_hvm. This will make nested HVM config available
also for PVH domains.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_conf.c | 13 -
way from "linux" os type is offtopic to this series and
apparently is a controversial thing
- drop "docs: update domain schema for machine attribute" patch -
already applied
- apply review comments from Jim
- rebase on master
Marek Marczykowski-Górecki (8):
docs: add docume
Signed-off-by: Marek Marczykowski-Górecki
---
tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++-
tests/libxlxml2domconfigdata/basic-pvh.xml | 28 +-
tests/libxlxml2domconfigtest.c | 1 +-
3 files changed, 78 insertions(+)
create mode 100644
Otherwise starting PVH guest will result in "arch_setup_bootlate:
mapping shared_info failed (pfn=..., rc=-1, errno: 12): Internal error".
After this change the behavior is the same as in `xl`.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/li
Specifically, list sub-elements and where they can be used. In addition,
describe supported machine types for Xen.
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- clarify type@domain description, add a link to domain xml there
---
docs/formatcaps.html.in | 22
Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
And add a test for it.
Signed-off-by: Marek Marczykowski-Górecki
---
src/xenconfig/xen_common.c | 11 +--
src/xenconfig/xen_xl.c | 5 +
tests/testutilsxen.c | 3 ++-
On Fri, Sep 14, 2018 at 05:21:17PM -0600, Jim Fehlig wrote:
> On 8/5/18 3:48 PM, Marek Marczykowski-Górecki wrote:
> > Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl).
> > And add a test for it.
> >
> > Signed-off-by: Marek Marczykowski-Góreck
On Mon, Sep 10, 2018 at 04:45:50PM -0600, Jim Fehlig wrote:
> On 09/10/2018 04:02 PM, Marek Marczykowski-Górecki wrote:
> > On Mon, Sep 10, 2018 at 03:44:33PM -0600, Jim Fehlig wrote:
> > > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
> > > > Since this i
t], [libxl_ctx_alloc], [libxl.h],
> [fail="1"])
> -CFLAGS="$libxlold_CFLAGS"
> -
> -if test $fail = 1; then
> - AC_MSG_ERROR([You must install the libxl Library from Xen >= 4.4 to
> compile libxenlight driver with -lxl])
> -fi
> - fi
> -
&g
On Mon, Sep 10, 2018 at 03:44:33PM -0600, Jim Fehlig wrote:
> On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
> > Since this is something between PV and HVM, it makes sense to put the
> > setting in place where domain type is specified.
> > To enable it, use It
On Mon, Sep 10, 2018 at 10:06:09AM -0600, Jim Fehlig wrote:
> On 09/07/2018 01:29 PM, Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > Changes in v2:
> > - use virDomainObjEndAPI
> > - drop duplicated error
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- use virDomainObjEndAPI
- drop duplicated error reporting on virDomainObjIsActive
- bump version comment to 4.8.0
Changes in v3:
- fix virDomainObjIsActive -> virDomainObjCheckActive
- reuse duration not supported message f
When libvirtd is started, initialize domain objects state with its real
state, not only RUNNING/SHUTOFF.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/libxl/libxl_driver.c b
Needed libxl_domain_suspend_only is supported in Xen >= 4.11. But wakeup should
work with older versions.
Marek Marczykowski-Górecki (3):
libxl: send lifecycle event on suspend
libxl: implement virDomainPM* functions
libxl: initialize domain state with real data
src/libxl/libxl_domai
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 2ab78ac..b800bc9 100644
--- a/src/libxl
On Fri, Sep 07, 2018 at 11:10:14AM -0600, Jim Fehlig wrote:
> On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote:
>
> A few additional comments came to mind while looking at this patch again...
Perfect timing, I was just going to hit "send" on v3...
> > > >
On Thu, Sep 06, 2018 at 02:58:30PM -0600, Jim Fehlig wrote:
> On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > Changes in v2:
> > - use virDomainObjEndAPI
> > - drop duplicated error
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- use virDomainObjEndAPI
- drop duplicated error reporting on virDomainObjIsActive
- bump version comment to 4.8.0
---
src/libxl/libxl_driver.c | 121 -
1 file changed, 121 insertions(+)
diff
Needed libxl_domain_suspend_only is supported in Xen >= 4.11. But wakeup should
work with older versions.
Marek Marczykowski-Górecki (3):
libxl: send lifecycle event on suspend
libxl: implement virDomainPM* functions
libxl: initialize domain state with real data
src/libxl/libxl_domai
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 2ab78ac..b800bc9 100644
--- a/src/libxl
When libvirtd is started, initialize domain objects state with its real
state, not only RUNNING/SHUTOFF.
Signed-off-by: Marek Marczykowski-Górecki
Reviewed-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/libxl/libxl_driver.c b
On Thu, Aug 30, 2018 at 03:29:41PM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki wrote:
> > On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote:
> > > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
>
On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote:
> On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
> > Use preferred name: 'xen'.
>
> I'd be fine with this change if the actual code used the preferred name too
> :-). E.g. config containing
>
>
When libvirtd is started, initialize domain objects state with its real
state, not only RUNNING/SHUTOFF.
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
Needed libxl_domain_suspend_only is supported in Xen >= 4.11. But wakeup should
work with older versions.
Marek Marczykowski-Górecki (3):
libxl: send lifecycle event on suspend
libxl: implement virDomainPM* functions
libxl: initialize domain state with real data
src/libxl/libxl_domai
Signed-off-by: Marek Marczykowski-Górecki
---
src/libxl/libxl_driver.c | 126 -
1 file changed, 126 insertions(+)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 5a5e792..10c7aab 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl
1 - 100 of 327 matches
Mail list logo
