Re: [libvirt] [PATCH 1/3] audio: omitting audiodev= parameter is only deprecated

2019-08-28 Thread Maxim Levitsky
VM with single audiodev without specifying the audiodev in the device, but on shutdown qemu crashes with heap corruption sadly. -audiodev pa,id=snd1,server=/run/user/103992/pulse/native -device ich9-intel-hda,id=sound0,msi=on -device hda-micro,id=sound0-codec0,bus=sound0.0,cad=0 In qemu output: free(): invalid next size (fast) Best regards, Maxim Levitsky -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [Qemu-block] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-15 Thread Maxim Levitsky
ago; do we want to amend the QAPI > schema specification to allow commands to return with "Warning" strings, > or "Deprecated" stings to allow in-band deprecation notices for cases > like these? > > example: > > { "return": {}, > "deprecated": True, > "warning": "Omitting filter-node-name parameter is deprecated, it will > be required in the future" > } > > There's no "error" key, so this should be recognized as success by > compatible clients, but they'll definitely see the extra information. > > Part of my motivation is to facilitate a more aggressive deprecation of > legacy features by ensuring that we are able to rigorously notify users > through any means that they need to adjust their scripts. > > --js > This is a very good idea IMHO. Best regards, Maxim Levitsky -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list