On Mon, Feb 21, 2022 at 11:53 AM Wim de With wrote:
>
> > Since the intent of libvirt using LGPL was explicitly to allow non-GPL
> > compatible applications to use libvirt, it is a mistake to be using
> > a license that breaks this ability for Rust.
> >
> > In Golang we've used MIT license
> >
>
On Fri, Dec 31, 2021 at 1:27 AM Marc-André Lureau
wrote:
>
> Hi Neal
>
> On Fri, Dec 31, 2021 at 6:09 AM Neal Gompa wrote:
> >
> > On Wed, Dec 22, 2021 at 2:44 PM wrote:
> > >
> > > From: Marc-André Lureau
> > >
> > > Hi,
> > &g
On Wed, Dec 22, 2021 at 2:44 PM wrote:
>
> From: Marc-André Lureau
>
> Hi,
>
> This series implements supports for the uQEMU "-display dbus" support, that
> landed earlier this week for 7.0.
>
> By default, libvirt will start a private VM bus (sharing and reusing the
> existing "vmstate" VM bus
c: Drop BuildRequires on xfsprogs-devel
>
> libvirt.spec.in| 2 --
> meson.build| 4
> src/storage/storage_util.c | 14 ++
> 3 files changed, 2 insertions(+), 18 deletions(-)
>
> --
> 2.31.1
>
>
LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
194 insertions(+)
> create mode 100644 src/security/apparmor/usr.sbin.virtqemud.in
> create mode 100644 src/security/apparmor/usr.sbin.virtxend.in
>
> --
> 2.31.1
>
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
LOCALSTATEDIR, uuidstr, tpmpath);
> virBufferAsprintf(,
> " \"%s/lib/libvirt/swtpm/%s/%s/**\" rwk,\n",
> LOCALSTATEDIR, uuidstr, tpmpath);
> --
> 2.31.1
>
Patch looks fine to me.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Fri, Jul 2, 2021 at 8:35 AM Andrea Bolognani wrote:
>
> On Fri, Jul 02, 2021 at 11:54:54AM +0100, Daniel P. Berrangé wrote:
> >
> > - https://libvirt.org/git/libvirt-go.git"/>
> > + https://gitlab.com/libvirt/libvirt-go"/>
> >
> >
> > -
On Tue, Jun 8, 2021 at 1:35 PM Jim Fehlig wrote:
>
> On 6/7/21 5:43 PM, Neal Gompa wrote:
> > On Mon, Jun 7, 2021 at 6:34 PM Jim Fehlig wrote:
> >>
> >> The audit log contains the following denials from libvirtd
> >>
> >> apparmor="DE
capability audit_write,
>capability ipc_lock,
> + capability sys_rawio,
> + capability bpf,
> + capability perfmon,
>
># Needed for vfio
>capability sys_resource,
> --
> 2.31.1
>
>
The patch LGTM, but the title is confusing. Maybe the following?
"apparmor: Permit new capabilities required by libvirt"
Otherwise...
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Tue, May 25, 2021 at 11:34 AM Andrea Bolognani wrote:
>
> On Tue, May 25, 2021 at 05:06:41PM +0200, Michal Prívozník wrote:
> > On 5/25/21 12:00 PM, Andrea Bolognani wrote:
> > > On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote:
> > >> -# For storage wiping with different
-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
>
> My bad! Thanks for catching and fixing this :)
>
> Reviewed-by: Andrea Bolognani
>
Mechanically, this change is fine, so...
Reviewed-by: Neal Gompa
But, I'm kind of surprised that this is going away, since IBM has put
special attention on improving PowerKVM support specifically for RHEL,
so this seems really weird...
--
真実はいつも一つ！/ Always, there's only one truth!
; > +# Glusterfs dropped in RHEL-9, and before that only
>
> *has been dropped
>
> Reviewed-by: Andrea Bolognani
>
Press "F" to pay respects to GlusterFS
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Mon, Jan 11, 2021 at 10:52 AM Andrea Bolognani wrote:
>
> On Thu, 2021-01-07 at 13:48 -0500, Neal Gompa wrote:
> > On Thu, Jan 7, 2021 at 12:38 PM Jiri Denemark wrote:
> > > On Thu, Jan 07, 2021 at 09:58:09 -0500, Neal Gompa wrote:
> > > > +++ b/libvirt
state.
Fixes: 2244ac168d42c3fa424bae6d33ecdbb8726da7c2
Signed-off-by: Neal Gompa
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 9dea6c6787..d7a90c42f5 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -415,7
--
> mingw-libvirt.spec.in | 12 +---
> 2 files changed, 18 insertions(+), 6 deletions(-)
>
> --
> 2.26.3
>
>
This resolves my issues. Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Wed, May 5, 2021 at 4:12 PM Andrea Bolognani wrote:
>
> It's only used in one place, and it's nicer to keep the error
> message close to the check that causes it to be emitted.
>
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 12 +++-
> mingw-libvirt.spec.in | 12
; tools/bash-completion/{vsh => vsh.in} | 7 ++-
> 4 files changed, 54 insertions(+), 108 deletions(-)
> rename tools/bash-completion/{vsh => vsh.in} (91%)
>
> --
> 2.26.3
>
>
Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Mon, Apr 19, 2021 at 1:14 PM Pavel Hrdina wrote:
>
> Recent attempt to add a lot of meson options to specify different
> runtime paths motivated me enough to cleanup this from meson.
>
> Changes in v2:
> - split and rework patch 16/17 to address review comments
> - added a new patch to
On Mon, Apr 19, 2021 at 11:10 AM Pavel Hrdina wrote:
>
> On Mon, Apr 19, 2021 at 01:59:52PM +0100, Daniel P. Berrangé wrote:
> > On Mon, Apr 19, 2021 at 02:50:13PM +0200, Michal Privoznik wrote:
> > > On 4/19/21 2:24 PM, Neal Gompa wrote:
> > > > On Fri, Apr
On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote:
>
> Recent attempt to add a lot of meson options to specify different
> runtime paths motivated me enough to cleanup this from meson.
>
> Pavel Hrdina (17):
> bridge_driver: fix comment about dnsmasqCaps
> virdnsmasq: drop unused
On Fri, Apr 9, 2021 at 11:00 AM Peter Krempa wrote:
>
> May 7, 2021 is the 2nd anniversary of release of rhel-8, which means we
> no longer have to support qemu-1.5.
>
> Remove the capabilities and test data for the versions we no longer care
> about and clean up some capabilities related stuff:
->model, processorList->data->Name) < 0)
> return -1;
> -}
>
> info->memory = computerSystem->data->TotalPhysicalMemory / 1024; /* byte
> to kilobyte */
> info->mhz = processorList->data->MaxClockSpeed;
> --
> 2.31.1
>
Looks reasonable to me.
When you resend with the Signed-off-by statement added, you can also add:
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
SH2_HOSTKEY_TYPE_UNKNOWN:
> default:
> virReportError(VIR_ERR_SSH, "%s",
> --
> 2.31.0
>
LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Sun, Mar 28, 2021 at 9:17 AM Bastian Germann
wrote:
>
> libssh2 has ECDSA and ED25519 support beginning with v1.9.0. libvirt cannot
> make use of those because it will handle them as unknown key types.
>
> Add support for those host key types.
>
> Signed-off-by: Bastian Germann
> ---
>
On Fri, Mar 12, 2021 at 9:01 AM Vit Mojzis wrote:
>
>
> On 3/11/21 1:29 PM, Neal Gompa wrote:
> > On Thu, Mar 11, 2021 at 6:35 AM Daniel P. Berrangé
> > wrote:
> >> On Wed, Mar 10, 2021 at 01:50:43PM -0500, Neal Gompa wrote:
> >>> On Wed, Mar 10, 2021
On Wed, Mar 3, 2021 at 1:19 PM Daniel P. Berrangé wrote:
>
> Historically we've done almost nothing with audio backend
> configuration. In QEMU we merely set QEMU_AUDIO_DRV to one
> of sdl, spice, none depending on . We also have
> the somewhat crazy ability to let QEMU inherit the
>
On Thu, Mar 11, 2021 at 6:35 AM Daniel P. Berrangé wrote:
>
> On Wed, Mar 10, 2021 at 01:50:43PM -0500, Neal Gompa wrote:
> > On Wed, Mar 10, 2021 at 7:43 AM Nikola Knazekova
> > wrote:
> > >
> > > From: Vit Mojzis
> > >
> > > Com
On Wed, Mar 10, 2021 at 7:43 AM Nikola Knazekova wrote:
>
> From: Vit Mojzis
>
> Compile the policy using a shell script executed by meson.
>
> Signed-off-by: Vit Mojzis
> ---
> libvirt.spec.in | 12
> meson.build | 12
>
bvirt doesn't
communicate with NetworkManager for this information? That's a cross
distribution method of handling complex network configuration that we
basically know will exist and can handle parsing and configuring
networks effectively.
Otherwise...
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
0
>
>
The patch set builds and works for me locally, and I don't spot any
obvious issues in the code...
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
== 7
> --
> 2.29.2
>
I have to do this for slow hardware too, so I'm fine with it.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
++-
> src/hyperv/hyperv_private.h | 4 +-
> src/hyperv/hyperv_wmi.c | 408 +++--
> src/hyperv/hyperv_wmi.h | 4 +-
> src/hyperv/hyperv_wsman.h | 28 ++
> 6 files changed, 457 insertions(+), 758 deletions(-)
> create mode 100644 src/hyperv/hyperv_wsman.h
>
> --
> 2.30.0
Quite the doozy, but looks mostly repetitious and simple...
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Fri, Jan 8, 2021 at 5:26 AM Olaf Hering wrote:
>
> According to meson.build, and the actual code, Xen 4.6+ is required.
> Drop the version, they is mentioned in meson.build.
>
> Signed-off-by: Olaf Hering
> ---
> libvirt.spec.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
On Thu, Jan 7, 2021 at 12:38 PM Jiri Denemark wrote:
>
> On Thu, Jan 07, 2021 at 09:58:09 -0500, Neal Gompa wrote:
> > This is automatically picked up by the dependency generator, so
> > there's no reason to have this here.
> >
> > Signed-off-by: Neal Gompa
&g
Stanzas like "0%{?fedora} && 0%{?fedora} >= %{min_fedora}" contain
redundant definitions, as "0%{?fedora} >= %{min_fedora}" implies that
"%fedora" is defined and has a value. Thus, we can simplify this.
Signed-off-by: Neal Gompa
---
libvirt.spec.
This is automatically picked up by the dependency generator, so
there's no reason to have this here.
Signed-off-by: Neal Gompa
---
libvirt.spec.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 0a8b0ebad4..41e532102a 100644
--- a/libvirt.spec.in
+++ b
As part of the work to add openSUSE support to the spec file,
I discovered a couple of small fixes worth submitting separately.
Neal Gompa (2):
rpm: Simplify expression of supported platforms
rpm: Drop unnecessary libiscsi runtime dependency
libvirt.spec.in | 3 +--
1 file changed, 1
On Tue, Dec 1, 2020 at 4:23 PM Jim Fehlig wrote:
>
> On 12/1/20 2:17 AM, Daniel P. Berrangé wrote:
> > On Mon, Nov 30, 2020 at 05:28:16PM -0700, Jim Fehlig wrote:
> >> As a normal user, 'virsh connect qemu:///system' and
> >> 'virsh connect --readonly qemu:///system' will prompt for root
" &&
> +subject.isInGroup("libvirt")) {
> +return polkit.Result.YES;
> +}
> +});
>
> polkit.addRule(function(action, subject) {
> if (action.id == "org.libvirt.unix.manage" &&
> --
> 2.29.2
>
>
LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Mon, Nov 23, 2020 at 11:24 AM Andrea Bolognani wrote:
>
> On Fri, 2020-11-20 at 08:51 -0500, Neal Gompa wrote:
> > On Fri, Nov 20, 2020 at 6:25 AM Andrea Bolognani
> > wrote:
> > > On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote:
> > > > T
On Fri, Nov 20, 2020 at 6:25 AM Andrea Bolognani wrote:
>
> On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote:
> > On Fri, Nov 13, 2020 at 8:14 AM Andrea Bolognani
> > wrote:
> > > As another data point, Debian currently carries a patch[1] which
> > >
On Fri, Nov 13, 2020 at 8:14 AM Andrea Bolognani wrote:
>
> On Fri, 2020-11-13 at 12:37 +0100, Pavel Hrdina wrote:
> > On Thu, Nov 12, 2020 at 10:40:02PM +0100, Olaf Hering wrote:
> > > Since meson does not support environment variables it seems the
> > > only way to address this is to introduce
On Mon, Nov 16, 2020 at 7:12 AM yebiaoxiang wrote:
>
> Hi Team
>
> The daemon libvirtd runs as root user, which against the least privilege
> security model.
>
> root 567642 1.2 0.0 2856020 47576 ? Ssl 15:49 0:02 /usr/sbin/libvirtd --listen
>
> In addition, the "--listen" parameter exposes TCP or
On Tue, Nov 17, 2020 at 11:49 AM Christian Ehrhardt
wrote:
>
> On Mon, Nov 16, 2020 at 3:28 PM Michal Privoznik wrote:
> >
> > On 11/16/20 1:26 PM, Christian Ehrhardt wrote:
> > > 'kvm-spice' is a binary name used to call 'kvm' which actually is a
> > > wrapper
> > > around qemu-system-x86_64
On Tue, Nov 17, 2020 at 2:29 PM Andrea Bolognani wrote:
>
> On Tue, 2020-11-17 at 13:01 -0500, Neal Gompa wrote:
> > On Sun, Nov 15, 2020 at 3:43 PM Andrea Bolognani
> > wrote:
> > > -UUID=`/usr/bin/uuidgen`
> > > sed -e "s/${orig_sub}/${
\
> > %{_sysconfdir}/libvirt/qemu/networks/default.xml
> ln -s ../default.xml
> %{_sysconfdir}/libvirt/qemu/networks/autostart/default.xml
> --
> 2.26.2
>
Looks good to me, though when did we make this change?
Regardless...
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
npages/virtproxyd.rst
> create mode 100644 docs/manpages/virtqemud.rst
> create mode 100644 docs/manpages/virtsecretd.rst
> create mode 100644 docs/manpages/virtstoraged.rst
> create mode 100644 docs/manpages/virtvboxd.rst
> create mode 100644 docs/manpages/virtvzd.rst
> create mode 100644 docs/manpages/virtxend.rst
>
> --
> 2.28.0
>
>
Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
| 564 -
> tests/virmacmaptest.c | 2 +-
> 87 files changed, 690 insertions(+), 1682 deletions(-)
> delete mode 100644 tests/virdeterministichashmock.c
> delete mode 100644 tests/virhashdata.h
> delete mode 100644 tests/virhashtest.c
>
> --
> 2.26.2
>
Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
/libxl/xen_xl.c | 12 +-
> src/libxl/xen_xm.c | 10 +-
> src/lxc/lxc_driver.c | 3 +-
> src/qemu/qemu_domain.c | 5 +-
> src/qemu/qemu_driver.c | 15 +-
> src/qemu/qemu_hotplug.c | 3 +-
> src/test/test_driver.c | 3 +-
> src/vz/vz_sdk.c |
group.c| 337 ++--
> src/util/vircgroupbackend.h | 5 +
> src/util/vircgrouppriv.h| 7 +-
> src/util/vircgroupv1.c | 57 +++---
> src/util/vircgroupv2.c | 61 ---
> tests/vircgrouptest.c | 33 ++--
> 11 files
st/2020-October/msg01492.html
>
> src/remote/virt-guest-shutdown.target | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/remote/virt-guest-shutdown.target
> b/src/remote/virt-guest-shutdown.target
> index 25d4aaa267..e2efa3e63a 100644
> --- a/src/remote/virt-guest-shutdown.target
> +++ b/src/remote/virt-guest-shutdown.target
> @@ -1,3 +1,4 @@
> [Unit]
> Description=Libvirt guests shutdown
> +Requires=libvirtd.service
> Documentation=https://libvirt.org
> --
> 2.28.0
>
>
LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
+++--
> 3 files changed, 89 insertions(+), 106 deletions(-)
>
> --
> 2.27.0
>
>
Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Thu, Oct 29, 2020 at 9:03 AM Daniel P. Berrangé wrote:
>
> On Thu, Oct 29, 2020 at 09:01:05AM -0400, Neal Gompa wrote:
> > On Thu, Oct 29, 2020 at 7:39 AM Daniel P. Berrangé
> > wrote:
> > >
> > > On Thu, Oct 29, 2020 at 12:27:16PM +0100, Michal Privozni
On Thu, Oct 29, 2020 at 5:40 AM Daniel P. Berrangé wrote:
>
> On Wed, Oct 28, 2020 at 04:49:43PM -0400, Neal Gompa wrote:
> > On Wed, Oct 28, 2020 at 8:36 AM Daniel P. Berrangé
> > wrote:
> > >
> > > The %meson macro sets "--auto-features=enabled"
On Thu, Oct 29, 2020 at 7:39 AM Daniel P. Berrangé wrote:
>
> On Thu, Oct 29, 2020 at 12:27:16PM +0100, Michal Privoznik wrote:
> > On 10/28/20 9:47 PM, Neal Gompa wrote:
> > > On Wed, Oct 28, 2020 at 7:49 AM Michal Privoznik
> > > wrote:
> > > >
>
On Tue, Oct 27, 2020 at 9:30 AM Andrea Bolognani wrote:
>
> On Tue, 2020-10-27 at 14:05 +0100, Andrea Bolognani wrote:
> > I'm not convinced reverting this was the right call.
> >
> > The way RPM conditional macros work is that, if you have
> >
> > %{!?macro:value}
> >
> > that will expand to
On Wed, Oct 28, 2020 at 8:36 AM Daniel P. Berrangé wrote:
>
> The %meson macro sets "--auto-features=enabled", thus any feature in the
> RPM which has a "with_XXX" condition, needs to explicitly pass a
> "-DXXX=state" arg to %meson to override the auto features setting.
>
> The
On Wed, Oct 28, 2020 at 7:49 AM Michal Privoznik wrote:
>
> On 10/27/20 1:06 PM, Neal Gompa wrote:
> > On Tue, Oct 27, 2020 at 6:24 AM Michal Privoznik
> > wrote:
> >>
> >> On 10/26/20 11:08 PM, Neal Gompa wrote:
> >>> Contemporary versio
On Tue, Oct 27, 2020 at 6:24 AM Michal Privoznik wrote:
>
> On 10/26/20 11:08 PM, Neal Gompa wrote:
> > Contemporary versions of Fedora automatically set SOURCE_DATE_EPOCH
> > based on the changelog entry date stamp. In scenarios where it already
> > is defined, we
> -return g_strdup_printf("sh -c 'which virt-nc 1>/dev/null 2>&1; "
> +return g_strdup_printf("sh -c 'which virt-ssh-helper 1>/dev/null
> 2>&1; "
> "if test $? = 0; then "
>
libvirt 6.8.0 failed to correctly detect the availability of the new
> +``virt-ssh-helper`` command on the remote host, and thus always used the
> +fallback instead; this has now been fixed.
> +
>
> v6.8.0 (2020-10-01)
> ===
> --
> 2.26.2
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
in %_specdir, but instead in %_sourcedir.
Signed-off-by: Neal Gompa
---
libvirt.spec.in | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 2a4324b974..eb0fba4b5a 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1128,7
On Mon, Oct 26, 2020 at 2:03 PM Jiri Denemark wrote:
>
> I have just tagged v6.9.0-rc1 in the repository and pushed signed
> tarballs and source RPMs to https://libvirt.org/sources/
>
> Please give the release candidate some testing and in case you find a
> serious issue which should have a fix
inputs.
This reverts commit 31d687a3218c9072d7050dd608e013e063ca180f.
Signed-off-by: Neal Gompa
---
libvirt.spec.in | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 2a4324b974..84515cc7de 100644
--- a/libvirt.spec.in
On Fri, Oct 23, 2020 at 10:53 AM Neal Gompa wrote:
>
> On Wed, Oct 21, 2020 at 11:45 AM Michal Privoznik wrote:
> >
> > The more I look into the code the more things to fix I find. Well, here
> > are some fixes.
> >
> > Michal Prívozník (4):
>
---
> src/hyperv/hyperv_wmi.h| 15 +-
> 4 files changed, 229 insertions(+), 261 deletions(-)
>
> --
> 2.26.2
>
Series LGTM.
Reviewed-by: Neal Gompa
But... uhh... there's also this series from Matt Coleman, which I just
reviewed: https://www.redhat.com/archives/libvir-lis
hyperv: do not overwrite errors from hypervInvokeMethod()
>
> src/hyperv/hyperv_driver.c | 169 +
> src/hyperv/hyperv_wmi.c| 57 +++--
> src/hyperv/hyperv_wmi.h| 4 +
> 3 files changed, 75 insertions(+), 155 deletions(-)
>
>
On Thu, Oct 22, 2020 at 11:01 PM Matt Coleman wrote:
>
> Hello,
>
> I'm implementing domainGetVcpus and could use some guidance on what
> value to use for virVcpuInfo->cpu.
>
> Hyper-V does not allow the user to pin vCPUs to host CPUs and doesn't
> allow the user to see which host CPU a vCPU is
On Wed, Oct 14, 2020 at 9:28 PM Neal Gompa wrote:
>
> On Fri, Oct 9, 2020 at 3:47 AM Matt Coleman wrote:
> >
> > As Daniel mentioned in the thread for my commit "hyperv: make
> > Msvm_ComputerSystem WQL queries locale agnostic", we can increase the
>
| 12 +++--
> src/hyperv/hyperv_wmi.h | 1 -
> src/hyperv/hyperv_wmi_classes.h | 3 ++-
> src/hyperv/openwsman.h | 47 -
> 8 files changed, 10 insertions(+), 65 deletions(-)
> delete mode 100644 src/hyperv/openwsman.h
>
&
On Fri, Oct 9, 2020 at 4:49 AM Andrea Bolognani wrote:
>
> On Thu, 2020-10-08 at 22:17 -0400, Neal Gompa wrote:
> > On Thu, Oct 8, 2020 at 1:43 PM Andrea Bolognani wrote:
> > > We lost this coverage during the move from CentOS CI to GitLab CI,
> > > and it'
vm_arches definition
> spec: Introduce arches_*
>
> libvirt.spec.in | 116
> 1 file changed, 57 insertions(+), 59 deletions(-)
>
> --
> 2.26.2
>
>
Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Thu, Oct 8, 2020 at 1:43 PM Andrea Bolognani wrote:
>
> We lost this coverage during the move from CentOS CI to GitLab CI,
> and it's high time we brought it back.
>
> Building RPMs is currently skipped for:
>
> * openSUSE, which is not supported by our spec file;
>
I've got a patch set
BuildRequires: firewalld-filesystem
> %endif
> --
> 2.26.2
>
I'd suggest putting the comment inside the conditional, but otherwise it's fine.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
gent.c | 355 +-
> 1 file changed, 180 insertions(+), 175 deletions(-)
>
> --
> 2.26.2
>
Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
8 +-
> src/conf/virnwfilterobj.c | 9 +-
> src/conf/virsecretobj.c | 21 +-
> 35 files changed, 271 insertions(+), 511 deletions(-)
>
> --
> 2.26.2
>
Series LGTM.
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
datadir}/libvirt/schemas/cputypes.rng
> %{_datadir}/libvirt/schemas/domain.rng
> %{_datadir}/libvirt/schemas/domainbackup.rng
> --
> 2.28.0
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Tue, Oct 6, 2020 at 12:35 PM Andrea Bolognani wrote:
>
> On Tue, 2020-10-06 at 08:15 -0400, Neal Gompa wrote:
> > Then can we flip this conditional to %if 0%{?rhel} for the
> > architecture list? As it is, it's unclear that the reason that *RHEL*
> > is the less-capa
On Mon, Oct 5, 2020 at 9:07 PM Neal Gompa wrote:
>
> On Mon, Oct 5, 2020 at 12:20 PM Matt Coleman wrote:
> >
> > These patches fix a couple bugs, consolidate duplicate code, and
> > implement several APIs.
> >
> > Currently, some interactions with
On Tue, Oct 6, 2020 at 6:41 AM Andrea Bolognani wrote:
>
> On Mon, 2020-10-05 at 20:40 -0400, Neal Gompa wrote:
> > On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote:
> > > %if 0%{?fedora}
> > > +%define arches_qemu_kvm %{arches_x86} %{power6
On Tue, Oct 6, 2020 at 6:28 AM Andrea Bolognani wrote:
>
> On Mon, 2020-10-05 at 20:46 -0400, Neal Gompa wrote:
> > On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani wrote:
> > > It belongs before package-specific feature flags are defined.
> > >
> &g
On Tue, Oct 6, 2020 at 6:09 AM Andrea Bolognani wrote:
>
> On Mon, 2020-10-05 at 20:42 -0400, Neal Gompa wrote:
> > On Mon, Oct 5, 2020 at 2:40 PM Andrea Bolognani wrote:
> > > -%define with_fuse 0%{!?_without_fuse:0}
> > > -%define with_sanlock
++ b/.mailmap
> @@ -47,6 +47,7 @@
>
>
>
> +
>
> # Name consolidation:
> # Preferred author spelling
> --
> 2.27.0
>
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Mon, Oct 5, 2020 at 9:13 PM Matt Coleman wrote:
>
> > On Oct 5, 2020, at 8:54 PM, Neal Gompa wrote:
> >
> > Should we require a bump to openwsman 2.6 for this?
>
> That won’t make any difference: openwsman 2.6+ supports specifying the
> locale, but Windows igno
On Mon, Oct 5, 2020 at 12:20 PM Matt Coleman wrote:
>
> These patches fix a couple bugs, consolidate duplicate code, and
> implement several APIs.
>
> Currently, some interactions with Hyper-V systems fail when the system
> is not configured for the "en-US" locale. Additionally, some CPU names
>
inGetAutostart, /* 6.9.0 */
> .connectIsEncrypted = hypervConnectIsEncrypted, /* 0.9.5 */
> .connectIsSecure = hypervConnectIsSecure, /* 0.9.5 */
> .domainIsActive = hypervDomainIsActive, /* 0.9.5 */
> --
> 2.27.0
>
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
scription" field caused queries to fail on non-"en-US"
> +systems. The queries have been updated to avoid using localized strings.
>
> v6.8.0 (2020-10-01)
> ===
> --
> 2.27.0
>
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
SCreationClassName
> string CSDVersion
> string CSName
> -uint16 CurrentTimeZone
> +int16CurrentTimeZone
> boolean DataExecutionPrevention_Available
> boolean DataExecutionPrevention_32BitApplications
> boolean DataExecutionPrevention
> +
> + cleanup:
> +hypervFreeObject(priv, (hypervObject *) os);
> +
> +return result;
> +}
> +
> +
> +
> static char *
> hypervConnectGetHostname(virConnectPtr conn)
> {
> @@ -1721,6 +1801,7 @@ static virHypervisorDriver hypervHypervisorDriver = {
> .connectOpen = hypervConnectOpen, /* 0.9.5 */
> .connectClose = hypervConnectClose, /* 0.9.5 */
> .connectGetType = hypervConnectGetType, /* 0.9.5 */
> +.connectGetVersion = hypervConnectGetVersion, /* 6.9.0 */
> .connectGetHostname = hypervConnectGetHostname, /* 0.9.5 */
> .connectGetMaxVcpus = hypervConnectGetMaxVcpus, /* 6.9.0 */
> .nodeGetInfo = hypervNodeGetInfo, /* 0.9.5 */
> --
> 2.27.0
>
>
Ugh, this is kind of gross, but it makes sense...
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
ectGetHostname, /* 0.9.5 */
> +.connectGetMaxVcpus = hypervConnectGetMaxVcpus, /* 6.9.0 */
> .nodeGetInfo = hypervNodeGetInfo, /* 0.9.5 */
> .connectGetCapabilities = hypervConnectGetCapabilities, /* 6.9.0 */
> .connectListDomains = hypervConnectListDomains, /* 0.9.5 */
> --
> 2.27.0
>
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
fDomains, /* 0.9.5 */
> .connectListAllDomains = hypervConnectListAllDomains, /* 0.10.2 */
> diff --git a/src/hyperv/hyperv_private.h b/src/hyperv/hyperv_private.h
> index b502e71d83..cf08bf542b 100644
> --- a/src/hyperv/hyperv_private.h
> +++ b/src/hyperv/hyperv_private.h
> @@ -26,6 +26,7 @@
> #include "virerror.h"
> #include "hyperv_util.h"
> #include "openwsman.h"
> +#include "capabilities.h"
>
> typedef enum _hypervWmiVersion hypervWmiVersion;
> enum _hypervWmiVersion {
> @@ -38,4 +39,5 @@ struct _hypervPrivate {
> hypervParsedUri *parsedUri;
> WsManClient *client;
> hypervWmiVersion wmiVersion;
> +virCapsPtr caps;
> };
> --
> 2.27.0
>
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
Msvm_VirtualSystemSettingData
> **list);
> +int hypervGetWmiClassList(hypervPrivate *priv,
> + hypervWmiClassInfoListPtr wmiInfo, virBufferPtr
> query,
> + hypervObject **wmiClass);
>
> int hypervGetMsvmVirtualSystemSettingDataFromUUID(hypervPrivate *priv,
>const char *uuid_string,
>
> Msvm_VirtualSystemSettingData **list);
>
> -int hypervGetMsvmProcessorSettingDataList(hypervPrivate *priv,
> - virBufferPtr query,
> - Msvm_ProcessorSettingData **list);
> -
> -int hypervGetMsvmMemorySettingDataList(hypervPrivate *priv, virBufferPtr
> query,
> - Msvm_MemorySettingData **list);
> -
> int hypervGetMsvmMemorySettingDataFromVSSD(hypervPrivate *priv,
> const char *vssd_instanceid,
> Msvm_MemorySettingData **list);
>
> -int hypervGetMsvmKeyboardList(hypervPrivate *priv, virBufferPtr query,
> - Msvm_Keyboard **list);
> -
> /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> *
> * Msvm_ComputerSystem
> */
> --
> 2.27.0
>
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
"Msvm_ProcessorSettingData",
> - computerSystem->data.common->ElementName);
> +if (hypervGetProcSDByVSSDInstanceId(priv,
> + virtualSystemSettingData->data.common->InstanceID,
> + ) &
move " @ X.YZGHz" from the end. */
> +*tmp = '\0';
> +break;
> }
>
> ++tmp;
> --
> 2.27.0
>
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
On Mon, Oct 5, 2020 at 12:21 PM Matt Coleman wrote:
>
> There are two specific WQL queries we're using to get either a list of
> virtual machines or the hypervisor host itself from Msvm_ComputerSystem.
> Those queries rely on filtering results based on the "Description"
> field. Since the
h_lxc}
> # numad is used to manage the CPU and memory placement dynamically,
> # it's not available on many non-x86 architectures.
> -%ifnarch s390 s390x %{arm} riscv64
> +%ifnarch s390x %{arm} riscv64
> %define with_numad0%{!?_without_numad:1}
> %endif
> %en
?rhel}
> + %define with_qemu_tcg 0
> +%endif
> +
> %if ! %{with_qemu_tcg} && ! %{with_qemu_kvm}
> %define with_qemu 0
> %endif
> --
> 2.26.2
>
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
%define with_qemu_kvm %{with_qemu}
> %else
> --
> 2.26.2
>
Do we still need this anymore? Meson in EPEL 7 works without this definition...
But otherwise...
Reviewed-by: Neal Gompa
--
真実はいつも一つ！/ Always, there's only one truth!
t_dmidecode:1}
> +%endif
> +
> # Force QEMU to run as non-root
> %define qemu_user qemu
> %define qemu_group qemu
> @@ -434,7 +439,7 @@ Requires: iproute-tc
> %endif
>
> Requires: polkit >= 0.112
> -%ifarch %{ix86} x86_64
> +%if %{with_dmidecode}
> #
0%{!?_without_storage_zfs:1}
> @@ -86,6 +84,7 @@
>
> # Other optional features
> %define with_bash_completion 0%{!?_without_bash_completion:1}
> +%define with_numactl 0%{!?_without_numactl:1}
>
> # A few optional bits off by default, we enable later
> %define wi
1 - 100 of 247 matches
Mail list logo
