testing: Adjust the docs on how to run container workloads
> locally
> docs: testtck: Add a clear note on libvirt + Perl bindings dependency
> docs: testtck: Expand the 'Run TCK' section on making use of
> ci/jobs.sh
With the issues fixed:
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Wed, Sep 27, 2023 at 08:53:48PM +0200, Erik Skultety wrote:
> Ever since commit 6e9bd600 added a new GitLab job description function
Same here, please use full commit hash.
> handling the integration test suite process to ci/jobs.sh it should be
> mentioned in the docs.
> This patch splits the
On Wed, Sep 27, 2023 at 08:53:46PM +0200, Erik Skultety wrote:
> The fact that we need ci/helper script to run the workloads remains
> true, but the invocation has changed as of commit eb41e456 . We also
Use full commit hash as in the future the short one might not be unique.
> extracted GitLab j
On Mon, Sep 25, 2023 at 08:58:24PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/ch/meson.build| 27
> src/ch/virtchd.service.in | 44 ---
> 2 files changed, 23 insertions(+), 48 deletions(-)
> de
On Thu, Aug 31, 2023 at 04:39:50PM -0500, Jonathon Jongsma wrote:
> Add some helper functions to build a virCommand object and run the
> nbdkit process for a given virStorageSource.
>
> Signed-off-by: Jonathon Jongsma
> Reviewed-by: Peter Krempa
> ---
> src/qemu/qemu_nbdkit.c | 250
Function virGetConnectSecret() can return NULL so we need to check it
since in virSecretGetSecretString() it gets dereferenced.
Reported-by: coverity
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_nbdkit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_nbdkit.c b/src/qemu
Signed-off-by: Pavel Hrdina
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 926620b03f..940e6e348a 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -23,6 +23,14 @@ v9.8.0 (unreleased)
* **New features**
+ * QEMU: implement reverting external
We need to skip all disks that have snapshot type other than 'external'.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index cdc8e12cff..44bd97e564 100644
Now that deleting and reverting external snapshots is implemented we can
report that in capabilities so management applications can use that
information and start using external snapshots.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
docs/formatcaps.rst
When called from snapshot code we will need to pass snapshot object in
order to make internal snapshots work correctly.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_process.c | 9 -
src/qemu/qemu_process.h | 1 +
src/qemu/qemu_saveimage.c | 2 +-
3 files changed, 10 insertions
Original code assumed that the memory state file is only migration
stream but it has additional metadata stored by libvirt. To correctly
load the memory state file we need to reuse code that is used when
restoring domain from saved image.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c
When used with internal snapshots there is no memory state file so we
have no data to load and decompression is not needed.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_process.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/qemu
The function will no longer be used only when restoring VM as it will
be used when reverting snapshot as well so move it to qemu_process
and rename it accordingly.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_process.c | 73 +
src/qemu/qemu_process.h
When called by snapshot code we will need to use different reason.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_process.c | 6 +-
src/qemu/qemu_process.h | 1 +
src/qemu/qemu_saveimage.c | 3 ++-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a
Part of qemuSaveImageStartVM() function will be used when reverting
external snapshots. To avoid duplicating code and logic extract the
shared bits into separate function.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 96 +++
src/qemu
qemuProcessStartWithMemoryState
- change it to use cookie from memory state file instead of
using cookie from snapshot xml
- comments improvements
- introduces new helpers to start and stop decompression process
- reintroduces capability
Pavel Hrdina (10):
qemu_saveimage
These new helpers separates the code from the logic used to start new
QEMU process with memory state and will make it easier to move
qemuSaveImageStartProcess() into qemu_process.c file.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 155 +++---
src
On Fri, Sep 01, 2023 at 11:10:43AM +0200, Peter Krempa wrote:
> On Fri, Sep 01, 2023 at 10:32:12 +0200, Pavel Hrdina wrote:
> > We need to skip all disks that have snapshot type other than 'external'.
>
> Since the commit message is vague on the specific problem details
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 17 -
src/qemu/qemu_saveimage.h | 17 +
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index 41310d6a9a..eca47171c2 100644
--- a/src
qemuSaveImageStartVM() because
the external snapshot memory state is done by qemuSaveImageCreate().
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 115 +--
1 file changed, 97 insertions(+), 18 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu
Signed-off-by: Pavel Hrdina
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e40c8ac259..a3be76d6cc 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,6 +28,14 @@ v9.7.0 (unreleased)
2) pre-binding the variant driver using the ``--driver`` option
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 2 +-
src/qemu/qemu_saveimage.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index eca47171c2..44ab263144 100644
--- a/src/qemu/qemu_saveimage.c
+++ b/src
Reverting external snapshot for running VM doesn't work correctly so we
should not report this capability until it is fixed.
This reverts commit de71573bfec7f3acd22ec74794318de121716e21.
Signed-off-by: Pavel Hrdina
---
docs/formatcaps.rst| 7 ---
src
We need to skip all disks that have snapshot type other than 'external'.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index d943281e35..ff85d56572 100644
9.7.0 in case the
code fixing reverting snapshots is considered too complex.
This v2 limits the impact only to snapshot code and no longer changes
anything in qemu_saveimage except for exporting one function and one
enum.
Pavel Hrdina (6):
qemu_snapshot: fix reverting external snapshot when not
On Thu, Aug 31, 2023 at 05:43:35PM +0200, Peter Krempa wrote:
> On Thu, Aug 31, 2023 at 16:55:03 +0200, Pavel Hrdina wrote:
> > When used with internal snapshots there is no header to be used and no
> > memory state to be decompressed.
>
> I didn't yet have a look at
On Thu, Aug 31, 2023 at 04:54:59PM +0200, Pavel Hrdina wrote:
> This fixes reverting external snapshots to not error out in cases where
> it should work and makes it correctly load the memory state when
> reverting to snapshot of running VM.
Forget to mention that we need this
When called by snapshot code we will need to use different reason.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 6 --
src/qemu/qemu_saveimage.h | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index
This fixes reverting external snapshots to not error out in cases where
it should work and makes it correctly load the memory state when
reverting to snapshot of running VM.
Pavel Hrdina (7):
qemu_saveimage: extract starting process to qemuSaveImageStartProcess
We need to skip all disks that have snapshot type other than 'external'.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index d943281e35..ff85d56572 100644
When called from snapshot code we will need to pass snapshot object in
order to make internal snapshots work correctly.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 6 --
src/qemu/qemu_saveimage.h | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/qemu
Original code assumed that the memory state file is only migration
stream but it has additional metadata stored by libvirt. To correctly
load the memory state file we need to reuse code that is used when
restoring domain from saved image.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c
Signed-off-by: Pavel Hrdina
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e40c8ac259..a3be76d6cc 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,6 +28,14 @@ v9.7.0 (unreleased)
2) pre-binding the variant driver using the ``--driver`` option
When used with internal snapshots there is no header to be used and no
memory state to be decompressed.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index
Part of qemuSaveImageStartVM() function will be used when reverting
external snapshots. To avoid duplicating code and logic extract the
shared bits into separate function.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_saveimage.c | 103 ++
src/qemu
Signed-off-by: Pavel Hrdina
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e40c8ac259..a3be76d6cc 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,6 +28,14 @@ v9.7.0 (unreleased)
2) pre-binding the variant driver using the ``--driver`` option
tions(+)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
t affects basically the whole libvirt code base.
> And ideally I'd present a green pipeline but for some reason, I can't:
>
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/981105262
>
> But the problem is not with my code rather than our CI.
Unless there are objectio
Now that deleting and reverting external snapshots is implemented we can
report that in capabilities so management applications can use that
information and start using external snapshots.
Signed-off-by: Pavel Hrdina
---
docs/formatcaps.rst| 6 ++
src/conf
Libvirt supports creating snapshots for a long time but the wording of
the feature may imply that libvirt supports external snapshots in
general but that is not true as users were not able to use APIs to
delete or revert external snapshots.
Signed-off-by: Pavel Hrdina
---
docs/formatcaps.rst
Pavel Hrdina (2):
capabilities: reword disksnapshot feature to mention creating
snapshots
capabilities: report full external snapshot support
docs/formatcaps.rst| 12 +---
src/conf/capabilities.c| 1 +
src/conf/capabilities.h
On Thu, Aug 24, 2023 at 05:44:32PM +0200, Peter Krempa wrote:
> On Thu, Aug 24, 2023 at 17:29:49 +0200, Pavel Hrdina wrote:
> > Now that deleting and reverting external snapshots is implemented we can
> > report that in capabilities so management applications can use that
> >
Now that deleting and reverting external snapshots is implemented we can
report that in capabilities so management applications can use that
information and start using external snapshots.
Signed-off-by: Pavel Hrdina
---
docs/formatcaps.rst| 6 ++
src/conf
t; qemu: Generate shorter channel target paths
> qemu: Move channelTargetDir into stateDir
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
On Wed, Aug 16, 2023 at 01:18:37PM +0200, Michal Prívozník wrote:
> On 8/16/23 12:25, Pavel Hrdina wrote:
> > On Tue, Aug 15, 2023 at 02:45:37PM +0200, Michal Privoznik wrote:
> >> Signed-off-by: Michal Privoznik
> >> ---
> >> docs/meson.build
On Tue, Aug 15, 2023 at 02:45:37PM +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik
> ---
> docs/meson.build| 7 +++
> meson.build | 4 ++--
> src/access/meson.build | 6 +++---
> src/meson.build | 43 +++--
>
The new name reflects that we prepare data for external snapshot
deletion and the old name will be used later for different part of code.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
Extract the code that updates disks in domain definition while creating
external snapshots. We will use it later in the external snapshot revert
code.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 63
1 file
Extract creation of qcow2 files for external snapshots to separate
function as we will need it for external snapshot revert code.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 85 ++--
1 file changed, 56 insertions(+), 29 deletions(-)
diff --git
In this case there is no need to run block commit and using qemu process
at all.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 55 +++-
1 file changed, 32 insertions(+), 23 deletions(-)
diff --git a/src/qemu
We will need to reuse the functionality when reverting external
snapshots.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b
Now that the support to revert external snapshots is implemented we can
drop this check.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index
process doing the merge operation.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 122 +++
1 file changed, 122 insertions(+)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 0238ab2249..8d0581d33b 100644
--- a/src/qemu
Both creating and deleting snapshot are using VIR_ASYNC_JOB_SNAPSHOT but
reverting is using VIR_ASYNC_JOB_START. Let's unify it to make it
consistent for all snapshot operations.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 19 ++-
1 file changed, 10 inser
We only need the domain definition from domain object. This will allow
us to use it from snapshot code where we need to pass different domain
definition.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_backup.c | 2 +-
src/qemu/qemu_blockjob.c | 2 +-
src/qemu/qemu_domain.c | 8
src
To create new overlay files when external snapshot revert support is
introduced we will be using different domain definition than what is
currently used by the domain.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 13 +++--
1 file changed, 7
When block commit is not needed we can just simply unlink the
disk files.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 56 ++--
1 file changed, 36 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b
There will be more external snapshot checks introduced by following
patch so group them together.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/qemu
We will need to call this function from qemu_snapshot when introducing
external snapshot revert support.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 4
1 file changed, 4 insertions(+)
diff --git a/src/libvirt_private.syms b/src
he current
state before reverting they need to create a new snapshot. For now
this will only work if the current snapshot is the last.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 278 ++-
1 file changed, 274 insert
This new helper will allow us to check if we are able to delete external
snapshot after user did revert to non-leaf snapshot.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/virdomainmomentobjlist.c | 17 +
src/conf/virdomainmomentobjlist.h | 4
src
We will need to call this function from qemu_snapshot when introducing
external snapshot revert support.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/snapshot_conf.c | 2 +-
src/conf/snapshot_conf.h | 3 +++
src/libvirt_private.syms | 1 +
3 files changed, 5 insertions
When user creates a new snapshot after reverting to non-leaf snapshot we
no longer need to store the temporary overlays as they will be part of
the VM XMLs stored in the newly created snapshot.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 28 +++-
1 file
uses qemuDomainGetImageIds() to get
correct UID and GID for virStorageSourceGetMetadata() and also for
virCommandRun() as well by storing it in
`struct _qemuSnapshotDisksWithBackingStoreData`
Pavel Hrdina (25):
libvirt_private: list virDomainMomentDefPostParse
snapshot_conf: e
default external file names.
It should be still fixed to make it safe. Future external snapshot
revert code will use this to generate default file names and in this
case it would crash.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/snapshot_conf.c | 8 +---
1 file changed
This new option will be used by external snapshot revert code.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/snapshot_conf.c | 15 ---
src/conf/snapshot_conf.h | 3 ++-
src/qemu/qemu_snapshot.c | 2 +-
src/test/test_driver.c | 2 +-
4 files changed, 16
This new element will hold the new disk overlay created when reverting
to non-leaf snapshot in order to remember the files libvirt created.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/schemas/domainsnapshot.rng | 7 +++
src/conf/snapshot_conf.c| 30
creates new snapshot after reverting to non-leaf snapshot it
creates a new branch. Deleting snapshot with multiple children will
require block-stream which is not implemented for now.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 21
original
overlay files.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 40
1 file changed, 40 insertions(+)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index a67be1ae49..6dd420a53b 100644
--- a
Before external snapshot revert every delete operation did block commit
in order to delete a snapshot. But now when user reverts to non-leaf
snapshot deleting leaf snapshot will not have any overlay files so we
can just simply delete the snapshot images.
Signed-off-by: Pavel Hrdina
Reviewed-by
This part of code is about to grow to make deletion work when user
reverts to non-leaf snapshot.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 104 ++-
1 file changed, 70 insertions(+), 34 deletions(-)
diff --git a/src
active or inactive definition.
The current code would crash so use virDomainDiskByName() to get the
correct disk from the domain definition based on the disk name and make
sure it exists.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 5 -
1 file changed, 4
On Tue, Jul 25, 2023 at 03:54:54PM +0200, Peter Krempa wrote:
> On Tue, Jun 27, 2023 at 17:07:14 +0200, Pavel Hrdina wrote:
>
> So what is this actually doing?
>
>
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/qemu/qemu_snapshot.c | 19 ++-
&
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 5d2ffdeee6..1cb0ea55de 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
We will need to call this function from qemu_snapshot when introducing
external snapshot revert support.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/snapshot_conf.c | 2 +-
src/conf/snapshot_conf.h | 3 +++
src/libvirt_private.syms | 1 +
3 files changed, 5 insertions
This new helper will allow us to check if we are able to delete external
snapshot after user did revert to non-leaf snapshot.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/virdomainmomentobjlist.c | 17 +
src/conf/virdomainmomentobjlist.h | 4
src
This part of code is about to grow to make deletion work when user
reverts to non-leaf snapshot.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 89 +---
1 file changed, 55 insertions(+), 34 deletions(-)
diff --git a/src
/phrdina/libvirt/-/tree/snapshot-revert-external
Pavel Hrdina (24):
libvirt_private: list virDomainMomentDefPostParse
snapshot_conf: export virDomainSnapshotDiskDefClear
snapshot_conf: use alternate domain definition in
virDomainSnapshotDefAssignExternalNames
snapshot_conf: introduce
active or inactive definition.
The current code would crash so use virDomainDiskByName() to get the
correct disk from the domain definition based on the disk name and make
sure it exists.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 5 -
1 file changed, 4
process doing the merge operation.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 95
1 file changed, 95 insertions(+)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 2950ad7d77..337c83f151 100644
--- a/src/qemu
When user creates a new snapshot after reverting to non-leaf snapshot we
no longer need to store the temporary overlays as they will be part of
the VM XMLs stored in the newly created snapshot.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 23 ++-
1 file changed
This new option will be used by external snapshot revert code.
Signed-off-by: Pavel Hrdina
---
src/conf/snapshot_conf.c | 15 ---
src/conf/snapshot_conf.h | 3 ++-
src/qemu/qemu_snapshot.c | 2 +-
src/test/test_driver.c | 2 +-
4 files changed, 16 insertions(+), 6 deletions
original
overlay files.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 40
1 file changed, 40 insertions(+)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index b08e06d312..a206f015c4 100644
--- a
Extract the code that updates disks in domain definition while creating
external snapshots. We will use it later in the external snapshot revert
code.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 63
1 file
creates new snapshot after reverting to non-leaf snapshot it
creates a new branch. Deleting snapshot with multiple children will
require block-stream which is not implemented for now.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 21 +
1 file changed, 21
Now that the support to revert external snapshots is implemented we can
drop this check.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 9e8a7f2f9f..5150e8685a 100644
We will need to reuse the functionality when reverting external
snapshots.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
There will be more external snapshot checks introduced by following
patch so group them together.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/qemu
he current
state before reverting they need to create a new snapshot. For now
this will only work if the current snapshot is the last.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 232 ++-
1 file changed, 228 insertions(+), 4 deletions(-)
di
When block commit is not needed we can just simply unlink the
disk files.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 56 ++--
1 file changed, 36 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
In this case there is no need to run block commit and using qemu process
at all.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 55 +++-
1 file changed, 32 insertions(+), 23 deletions(-)
diff --git a/src/qemu
Extract creation of qcow2 files for external snapshots to separate
function as we will need it for external snapshot revert code.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 67 +---
1 file changed, 42 insertions(+), 25 deletions(-)
diff --git
To create new overlay files when external snapshot revert support is
introduced we will be using different domain definition than what is
currently used by the domain.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_snapshot.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff
Before external snapshot revert every delete operation did block commit
in order to delete a snapshot. But now when user reverts to non-leaf
snapshot deleting leaf snapshot will not have any overlay files so we
can just simply delete the snapshot images.
Signed-off-by: Pavel Hrdina
---
src/qemu
We will need to call this function from qemu_snapshot when introducing
external snapshot revert support.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 4
1 file changed, 4 insertions(+)
diff --git a/src/libvirt_private.syms b/src
The new name reflects that we prepare data for external snapshot
deletion and the old name will be used later for different part of code.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
default external file names.
It should be still fixed to make it safe. Future external snapshot
revert code will use this to generate default file names and in this
case it would crash.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/snapshot_conf.c | 8 +---
1 file changed
This new element will hold the new disk overlay created when reverting
to non-leaf snapshot in order to remember the files libvirt created.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/schemas/domainsnapshot.rng | 7 +++
src/conf/snapshot_conf.c| 27
p-15.sh} (100%)
> rename ci/containers/{opensuse-leap-154.Dockerfile =>
> opensuse-leap-15.Dockerfile} (100%)
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
ondition
Reviewed-by: Pavel Hrdina
signature.asc
Description: PGP signature
1 - 100 of 5473 matches
Mail list logo
