[libvirt] [ v3 2/4] 1) Loader: Add a more elaborate definition.

2018-05-21 Thread Prerna Saxena
Augment definition to include virStorageSourcePtr that more comprehensively describes the nature of backing element. Also include flags for annotating if input XML definition is old-style or new-style. 2) Parse domain XML to generate virDomainLoaderDef & virDomainNvramDef. This patch is used to

[libvirt] [ v3 4/4] Documentation: Add a blurb for the newly added XML snippets for loader and nvram.

2018-05-21 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- docs/formatdomain.html.in | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0d0fd3b..2ba2761 100644 ---

[libvirt] [ v3 3/4] Test: Add a test snippet to evaluate command line generation for loader/nvram specified via virStorageSource

2018-05-21 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- tests/qemuxml2argvdata/bios-nvram-network.args | 31 +++ tests/qemuxml2argvdata/bios-nvram-network.xml | 42 ++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 74 inse

[libvirt] [ v3 1/4] Schema: Introduce XML schema for network-backed loader and nvram elements.

2018-05-21 Thread Prerna Saxena
Today, 'loader' and 'nvram' elements are supposed to be backed by a local disk. Given that NVRAM data could be network-backed for high availability, this patch defines XML spec for serving loader & nvram disks via the network. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- do

[libvirt] [ v3 0/4] Introduce network-backed loader & NVRAM.

2018-05-21 Thread Prerna Saxena
mp; make syntax-check. Prerna Saxena (4): Schema: Introduce XML schema for network-backed loader and nvram elements. Loader: Add a more elaborate definition. Test: Add a test snippet to evaluate command line generation for loader/nvram specified via virStorageSource Documentat

[libvirt] [PATCH 07/12] Bhyve: Fix command line generation to correctly pick up local loader path.

2018-05-14 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/bhyve/bhyve_command.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 9413ae5..2b67014 100644 --- a/src/bhyve/bhyve_command.c +++ b/src

[libvirt] [PATCH 09/12] Vbox: Adjust references to 'loader' and 'nvram' elements given that these are now represented by virStorageSourcePtr.

2018-05-14 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/vbox/vbox_common.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 72a24a3..60451a3 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_co

[libvirt] [PATCH 11/12] Test: Add a test snippet to evaluate command line generation for loader/nvram specified via virStorageSource

2018-05-14 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- tests/qemuxml2argvdata/bios-nvram-network.args | 31 +++ tests/qemuxml2argvdata/bios-nvram-network.xml | 42 ++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 74 inse

[libvirt] [PATCH 05/12] Plumb the loader source into generation of QEMU command line.

2018-05-14 Thread Prerna Saxena
Given that nvram & loader elements can now be backed by a non-local source too, adjust all steps leading to generation of QEMU command line. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_cgroup.c | 13 + src/qemu/qemu_command.c

[libvirt] [PATCH 06/12] Fix the domain def inference logic to correctly account for network-backed pflash devices.

2018-05-14 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_parse_command.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c index 351425f..9b1a86e 100644 --- a/sr

[libvirt] [PATCH 01/12] Schema: Introduce XML schema for network-backed loader and nvram elements.

2018-05-14 Thread Prerna Saxena
Today, 'loader' and 'nvram' elements are supposed to be backed by a local disk. Given that NVRAM data could be network-backed for high availability, this patch defines XML spec for serving loader & nvram disks via the network. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- do

[libvirt] [PATCH 10/12] Xen: Adjust all references to loader & nvram elements given that they are now backed by virStorageSourcePtr

2018-05-14 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/xenapi/xenapi_driver.c | 4 +++- src/xenconfig/xen_sxpr.c | 19 +++ src/xenconfig/xen_xm.c | 9 ++--- 3 files changed, 20 insertions(+), 12 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/

[libvirt] [PATCH 04/12] Format the loader source appropriately.

2018-05-14 Thread Prerna Saxena
If the initial XML used the old-style declaration as follows: /path/to/file we format it as was read. However, if it used new-style declaration: The formatter identifies that this is a new-style format and renders it likewise. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --

[libvirt] [PATCH 08/12] virt-aa-helper: Adjust references to loader & nvram elements to correctly parse the virStorageSource types.

2018-05-14 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/security/virt-aa-helper.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index d0f9876..8217d67 100644 --- a/src/security/v

[libvirt] [PATCH 00/12][v2] Introduce network-backed loader & nvram.

2018-05-14 Thread Prerna Saxena
hat was read. I found that encryption seems to be a property of the storage volume. I didnt include that in this series since it does not use backing type as volume. Will include that later once the basic network support patches get done. Looking forward to feedback, Prerna Prerna Saxena (12): Schema

[libvirt] [PATCH 03/12] Parse domain XML to generate virDomainLoaderDef & virDomainNvramDef.

2018-05-14 Thread Prerna Saxena
This patch is used to interpret domain XML and store the Loader & Nvram's backing definitions as virStorageSource. It also identifies if input XML used old or new-style declaration. (This will later be used by the formatter). Signed-off-by: Prerna Saxena <saxenap@gmail.com> ---

[libvirt] [PATCH 12/12] Documentation: Add a blurb for the newly added XML snippets for loader and nvram.

2018-05-14 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- docs/formatdomain.html.in | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index caeb14e..b8cb7ac 100644 ---

[libvirt] [PATCH 02/12] Loader: Add a more elaborate definition.

2018-05-14 Thread Prerna Saxena
Augment definition to include virStorageSourcePtr that more comprehensively describes the nature of backing element. Also include flags for annotating if input XML definition is old-style or new-style. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/conf/domain_conf.

[libvirt] [PATCH] Qemu driver: Support network-backed pflash disks.

2018-04-20 Thread Prerna Saxena
-by: Prerna Saxena <saxenap@gmail.com> --- docs/schemas/domaincommon.rng | 108 +++ src/conf/domain_conf.c | 188 src/conf/domain_conf.h | 7 +- src/qemu/qemu_cgroup.c | 13 ++- src/qemu/qemu_com

[libvirt] [PATCH] Qemu driver: Support network-backed pflash disks.

2018-04-20 Thread Prerna Saxena
This implements support for firmware loader & NVRAM disks over network-backed disks. As discussed in https://www.redhat.com/archives/libvir-list/2018-March/msg01721.html, the patch embeds the spec for disks in and elements as well. Currently, the source type is annotated by introducing a

[libvirt] [PATCH] Migration: Preserve the failed job in case migration job is terminated beyond the perform phase.

2018-01-25 Thread Prerna Saxena
e to watch previously failed jobs for this VM and take corrective actions as needed. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_domain.c| 16 src/qemu/qemu_domain.h|2 ++ src/qemu/qemu_migration.c |4 ++-- 3 files changed, 20

[libvirt] [[RFC] 2/8] QEMU Event handling: Introduce async event helpers in qemu_event.[ch]

2017-10-24 Thread Prerna Saxena
These contain basic functions for setting up event lists (global as well as per-VM). Also include methods for enqueuing and dequeuing events. Per-event metadata is also encoded herewith. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/Makefile.am | 1 + src/qemu/qemu_e

[libvirt] [[RFC] 4/8] Events: Allow monitor to "enqueue" events to a queue. Also introduce a framework of handlers for each event type, that can be called when the handler is running an event.

2017-10-24 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_event.c| 11 + src/qemu/qemu_event.h| 8 + src/qemu/qemu_monitor.c | 592 +++- src/qemu/qemu_monitor.h | 80 +++-- src/qemu/qemu_monitor_json.c

[libvirt] [[RFC] 7/8] Fold back the 2-stage event implementation for a few events : Watchdog, Monitor EOF, Serial changed, Guest panic, Nic RX filter changed .. into single level.

2017-10-24 Thread Prerna Saxena
Also, the enqueuing of a new event now triggers virEventWorkerScanQueue() Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_driver.c | 61 ++-- src/qemu/qemu_process.c | 121 +++- 2 files chang

[libvirt] [[RFC] 5/8] Events: Plumb event handling calls before a domain's APIs complete.

2017-10-24 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_driver.c | 131 +++-- 1 file changed, 128 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 8a005d0..b249347 100644 --- a/sr

[libvirt] [[RFC] 8/8] Initialize the per-VM event queues in context of domain init.

2017-10-24 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_driver.c | 20 src/qemu/qemu_event.c | 2 ++ 2 files changed, 22 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 881f253..e4b6d06 100644 --- a/src/qemu/qemu_dr

[libvirt] [[RFC] 6/8] Code refactor: Move helper functions of doCoreDump*, syncNicRxFilter*, and qemuOpenFile* to qemu_process.[ch]

2017-10-24 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_driver.c | 1161 --- src/qemu/qemu_process.c | 1133 + src/qemu/qemu_process.h | 86 3 files changed, 1219 insertions(+)

[libvirt] [[RFC] 1/8] Introduce virObjectTrylock()

2017-10-24 Thread Prerna Saxena
This is a wrapper function that: (1) Attempts to take a lock on the object. (2) gracefully returns if the object is already locked. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/libvirt_private.syms | 1 + src/util/virobject.c | 26 ++ sr

[libvirt] [[RFC] 3/8] Setup global and per-VM event queues. Also initialize per-VM queues when libvirt reconnects to an existing VM.

2017-10-24 Thread Prerna Saxena
Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/conf/domain_conf.h | 3 + src/qemu/qemu_conf.h| 4 + src/qemu/qemu_driver.c | 9 ++ src/qemu/qemu_event.c | 229 src/qemu/qemu_event.h | 1 - src/qemu/qemu_pro

[libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

2017-10-24 Thread Prerna Saxena
. - An event will only be "notified" to a client once the RPC for same VM completes. - Needs careful consideration in all cases where a QMP event is used to "signal" an RPC thread, else will deadlock. Will be happy to drive more discussion in the community and completely i

[libvirt] [PATCH v2 2/2] Debug: Report VM errors more concisely.

2017-04-03 Thread Prerna Saxena
Current logs: error : qemuProcessFindDomainDiskByAlias:411 : internal error: no disk found with alias ide0-0-0 There is no way to find which VM was seeing this error. Makes debugging very hard, and the message itself is no good. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- sr

[libvirt] [PATCH v2 1/2] Debug: Add DEBUG messages for when a client has opened/closed connection.

2017-04-03 Thread Prerna Saxena
for connection closure via libvirt API. This patch introduces messages to annotate when a client connected/disconnected. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/rpc/virnetserverclient.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/s

[libvirt] [PATCH v2 0/2] Augment debug messages.

2017-04-03 Thread Prerna Saxena
list suggestions. 3) Patch 3/3 : Same as v1 Prerna Saxena (2): Debug: Add DEBUG messages for when a client has opened/closed connection. Debug: Report VM errors more concisely. src/qemu/qemu_process.c | 4 ++-- src/rpc/virnetserverclient.c | 10 +- 2 files changed, 11

[libvirt] [PATCH 3/3] Debug: Report VM errors more concisely.

2017-03-22 Thread Prerna Saxena
Current logs: error : qemuProcessFindDomainDiskByAlias:411 : internal error: no disk found with alias ide0-0-0 There is no way to find which VM was seeing this error. Makes debugging very hard, and the message itself is no good. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- sr

[libvirt] [PATCH 1/3] Debug: Add WARN'ing messages for when a client has opened/closed connection.

2017-03-22 Thread Prerna Saxena
for connection closure via libvirt API. This patch introduces messages to annotate when a client connected/disconnected. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/rpc/virnetserverclient.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

[libvirt] [PATCH 2/3] Debug: Remove unnecessary errors reported while parsing non-existent sysfs files.

2017-03-22 Thread Prerna Saxena
. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index d123248..3e2f962 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1874,7 +

[libvirt] [PATCH 0/3] Debug: Improve log messages.

2017-03-22 Thread Prerna Saxena
tantiation and closure. Prerna Saxena (3): Debug: Add WARN'ing messages for when a client has opened/closed connection. Debug: Remove unnecessary errors reported while parsing non-existent sysfs files. Debug: Report VM errors more concisely. src/qemu/qemu_process.c | 4 ++-

[libvirt] [PATCH] Qemu : Do not distinguish a 'hangup' from an 'eof'

2016-10-28 Thread Prerna Saxena
possibly make sense to mark the socket closed so that the "eof" callback may then be invoked. Is there a subtle corner case I'm missing here ? Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[libvirt] [PATCH] Debug: Record the VM PID in per-VM logs.

2016-07-18 Thread Prerna Saxena
introducing it in per-VM log. Signed-off-by: Prerna Saxena <saxenap@gmail.com> --- src/qemu/qemu_process.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 4adb14e..2d3b0f5 100644 --- a/src/qemu/qemu_process.c +++ b/sr

Re: [libvirt] [PATCH v3 1/2] Storage: Introduce shadow vol for refresh while the main vol builds.

2015-07-02 Thread Prerna Saxena
On Tuesday 30 June 2015 06:20 PM, Ján Tomko wrote: On Fri, Jun 26, 2015 at 05:05:11PM +0530, Prerna Saxena wrote: Libvirt periodically refreshes all volumes in a storage pool, including the volumes being cloned. While cloning a storage volume from parent, we drop pool locks. Subsequent

[libvirt] [PATCH v3 2/2] Storage : Fix cloning of raw, sparse volumes

2015-06-26 Thread Prerna Saxena
it was cloned. Ref: http://www.redhat.com/archives/libvir-list/2015-May/msg00050.html Also fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1130739 Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- src/storage/storage_backend.c | 23 ++- src/storage/storage_driver.c

[libvirt] [PATCH v3 1/2] Storage: Introduce shadow vol for refresh while the main vol builds.

2015-06-26 Thread Prerna Saxena
that isolates the volume object under refresh from the base which has a copy ongoing. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- src/storage/storage_driver.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_driver.c b/src

[libvirt] [PATCH 0/2] [V3] Libvirt : Storage fixes

2015-06-26 Thread Prerna Saxena
Here is V3 of storage fixes, which addresses review comments of v2. Summary: Prerna Saxena (2): Storage: Introduce shadow vol for refresh while the main vol builds. Storage : Fix cloning of raw, sparse volumes src/storage/storage_backend.c | 23 ++- src/storage

Re: [libvirt] [PATCH 1/2] Storage: Introduce shadow vol for refresh while the main vol builds.

2015-06-25 Thread Prerna Saxena
Hi Jan, Thanks for the review comments. On Tuesday 23 June 2015 06:21 PM, Ján Tomko wrote: On Mon, Jun 22, 2015 at 05:07:26PM +0530, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Thu, 18 Jun 2015 05:05:09 -0500 Libvirt periodically refreshes all volumes in a storage

Re: [libvirt] [PATCH 2/2] Storage : Fix cloning of raw, sparse volumes

2015-06-25 Thread Prerna Saxena
On Tuesday 23 June 2015 06:29 PM, Ján Tomko wrote: On Mon, Jun 22, 2015 at 05:09:18PM +0530, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 22 Jun 2015 02:54:32 -0500 When virsh vol-clone is attempted on a raw file where capacity allocation, the resulting

[libvirt] [PATCH v2 0/2] Storage fixes for libvirt.

2015-06-22 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 22 Jun 2015 06:12:24 -0500 This is the second version of storage fixes. V1 : http://www.redhat.com/archives/libvir-list/2015-May/msg00050.html Summary: Prerna Saxena (2): Storage: Introduce shadow vol for refresh while

[libvirt] [PATCH 2/2] Storage : Fix cloning of raw, sparse volumes

2015-06-22 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 22 Jun 2015 02:54:32 -0500 When virsh vol-clone is attempted on a raw file where capacity allocation, the resulting cloned volume has a size that matches the virtual-size of the parent; in place of matching its actual, disk size

[libvirt] [PATCH 1/2] Storage: Introduce shadow vol for refresh while the main vol builds.

2015-06-22 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Thu, 18 Jun 2015 05:05:09 -0500 Libvirt periodically refreshes all volumes in a storage pool, including the volumes being cloned. While cloning a storage volume from parent, we drop pool locks. Subsequent volume refresh sometimes changes

Re: [libvirt] [PATCH 1/2] Storage: Suppress metadata refresh for volumes being built.

2015-05-05 Thread Prerna Saxena
On Tuesday 05 May 2015 04:22 PM, Ján Tomko wrote: On Tue, May 05, 2015 at 03:24:31PM +0530, Prerna Saxena wrote: On Tuesday 05 May 2015 03:20 PM, Prerna Saxena wrote: On Tuesday 05 May 2015 01:52 PM, Ján Tomko wrote: On Tue, May 05, 2015 at 08:43:21AM +0530, Prerna Saxena wrote: Libvirt

Re: [libvirt] [PATCH 1/2] Storage: Suppress metadata refresh for volumes being built.

2015-05-05 Thread Prerna Saxena
On Tuesday 05 May 2015 01:52 PM, Ján Tomko wrote: On Tue, May 05, 2015 at 08:43:21AM +0530, Prerna Saxena wrote: Libvirt periodically calls 'stat' on all volumes in a storage pool, to update fields such as 'target.allocation'. The operation doesnt make sense for a volume which is curently

Re: [libvirt] [PATCH 1/2] Storage: Suppress metadata refresh for volumes being built.

2015-05-05 Thread Prerna Saxena
On Tuesday 05 May 2015 03:20 PM, Prerna Saxena wrote: On Tuesday 05 May 2015 01:52 PM, Ján Tomko wrote: On Tue, May 05, 2015 at 08:43:21AM +0530, Prerna Saxena wrote: Libvirt periodically calls 'stat' on all volumes in a storage pool, to update fields such as 'target.allocation

[libvirt] [PATCH 0/2] Storage : Fixes for cloning raw volumes

2015-05-04 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 4 May 2015 12:00:46 -0700 This series has some long-overdue fixes for copying of raw storage volumes with libvirt. Prerna Saxena (2): Storage : Suppress metadata refresh for volumes being built. Storage : Fix cloning of raw, sparse

[libvirt] [PATCH 1/2] Storage: Suppress metadata refresh for volumes being built.

2015-05-04 Thread Prerna Saxena
any (potential) corruption, libvirt must not attempt to refresh a volume currently being built. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- src/storage/storage_backend.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/storage/storage_backend.c b/src/storage

[libvirt] [PATCH 2/2] Storage : Fix cloning of raw, sparse volumes.

2015-05-04 Thread Prerna Saxena
it was cloned. Reference: https://www.redhat.com/archives/libvir-list/2014-September/msg00064.html Also fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1130739 Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- src/storage/storage_backend.c | 2 +- src/storage/storage_driver.c | 5

Re: [libvirt] [PATCH] schema: Allow multiple machines for sparc VMs

2015-04-15 Thread Prerna Saxena
random machine name, which seems somewhat odd to me. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] PowerPC: Replace hardcoded values of 'pseries-2*' machine in schema

2015-04-07 Thread Prerna Saxena
From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 6 Apr 2015 22:56:25 -0500 Qemu-system-ppc64 has introduced new variants of pseries machine type, such as 'pseries', 'pseries-2.1'..'pseries-2.3'. Replace the hardcoded values in the schema with a regex that captures this. Signed-off

Re: [libvirt] [PATCHv2.5 00/10] Add support for memory hotplug

2015-04-02 Thread Prerna Saxena
: memory model='dimm' source pagesize unit='KiB'4096/pagesize nodemask1-3/nodemask /source target size unit='KiB'524287/size node1/node /target /memory I would be happy to work on a patch to fix this. Pls provide me your thoughts. Regards, -- Prerna Saxena Linux Technology

Re: [libvirt] [PATCH] PowerPC : Do not allow an empty model spec for 'host-model'

2015-03-20 Thread Prerna Saxena
On Friday 20 March 2015 01:51 PM, Ján Tomko wrote: On Mon, Mar 16, 2015 at 04:56:49PM +0530, Prerna Saxena wrote: [PATCH] PowerPC : Do not allow an empty model spec for 'host-model' On PowerPC, a guest VM having CPU mode as 'host-model' represents a 'compat' mode VM. This cannot have a NULL

[libvirt] [PATCH] PowerPC : Do not allow an empty model spec for 'host-model'

2015-03-16 Thread Prerna Saxena
[PATCH] PowerPC : Do not allow an empty model spec for 'host-model' On PowerPC, a guest VM having CPU mode as 'host-model' represents a 'compat' mode VM. This cannot have a NULL CPU model. This commit forbids such a guest definition. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com

Re: [libvirt] [PATCH 2/2] Tests : Add test for 'ppc64le' architecture.

2015-03-04 Thread Prerna Saxena
On Wednesday 04 March 2015 09:28 PM, Ján Tomko wrote: On Thu, Feb 26, 2015 at 10:45:54PM +0530, Prerna Saxena wrote: Tests : Add test for 'ppc64le' architecture. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- .../qemuxml2argv-pseries-cpu-le.args | 7

Re: [libvirt] [PATCH 0/2] PowerPC : Miscellaneous fixes for 'ppc64le' architecture.

2015-03-03 Thread Prerna Saxena
On Tuesday 03 March 2015 03:29 PM, Michal Privoznik wrote: On 26.02.2015 18:09, Prerna Saxena wrote: From a28ef5a3e7b9cb023948cf97d9f472bb3a1e06d3 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Thu, 26 Feb 2015 22:31:05 +0530 This series adds few miscellaneous

[libvirt] Fwd: [PATCH 0/2] PowerPC : Miscellaneous fixes for 'ppc64le' architecture.

2015-03-02 Thread Prerna Saxena
Ping !` Can you pls let me know if this suffices ? Regards, Prerna Forwarded Message Subject:[libvirt] [PATCH 0/2] PowerPC : Miscellaneous fixes for 'ppc64le' architecture. Date: Thu, 26 Feb 2015 22:39:20 +0530 From: Prerna Saxena pre...@linux.vnet.ibm.com

[libvirt] [PATCH 1/2] PowerPC: Augment XML schema to include 'ppc64le' arch ; newer pseries-2.* machine types.

2015-02-26 Thread Prerna Saxena
From 7128e773058751e4d1024ef7d8e4ad286c93ba55 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Thu, 26 Feb 2015 08:10:58 -0600 Subject: [PATCH 1/2] PowerPC: Augment XML schema to include 'ppc64le' arch and newer pseries-2.* machine types. Acked-by: Ján Tomko jto

[libvirt] [PATCH 2/2] Tests : Add test for 'ppc64le' architecture.

2015-02-26 Thread Prerna Saxena
Tests : Add test for 'ppc64le' architecture. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- .../qemuxml2argv-pseries-cpu-le.args | 7 + .../qemuxml2argv-pseries-cpu-le.xml| 17 tests/qemuxml2argvtest.c | 2

[libvirt] [PATCH 0/2] PowerPC : Miscellaneous fixes for 'ppc64le' architecture.

2015-02-26 Thread Prerna Saxena
From a28ef5a3e7b9cb023948cf97d9f472bb3a1e06d3 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Thu, 26 Feb 2015 22:31:05 +0530 This series adds few miscellaneous fixes for PowerPC 64-bit Little Endian Architecture. Changelog : == v1 of Patch 1/2 already

Re: [libvirt] [Patch 0/4] PowerPC fixes for libvirt

2015-02-18 Thread Prerna Saxena
On Tuesday 17 February 2015 06:33 PM, Ján Tomko wrote: On Sun, Feb 15, 2015 at 09:45:25AM +0530, Prerna Saxena wrote: This patch set addresses some miscellaneous fixes for libvirt on PowerPC. Details: Patch 1/4 : This adds 'qemu-system-ppc64' as the default emulator for ppc64 ppc64le

[libvirt] [Patch 0/4] PowerPC fixes for libvirt

2015-02-14 Thread Prerna Saxena
: This introduces 'ppc64le' and newer pseries machine types to domain schema. Patch 4/4 : Forbids floppy devices in domain XML. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India -- libvir-list mailing list libvir-list@redhat.com https

[libvirt] [PATCH 2/4] PowerPC : Forbid NULL CPU model with 'host-model' mode.

2015-02-14 Thread Prerna Saxena
, ,compat=%s, def-cpu-model); } else { featCpu = cpu; -- 1.9.3 -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 3/4] PowerPC: Augment XML schema to include 'ppc64le' arch and pseries* machine types.

2015-02-14 Thread Prerna Saxena
PowerPC: Augment XML schema to include 'ppc64le' arch and newer pseries-2.* machine types. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- docs/schemas/basictypes.rng | 1 + docs/schemas/domaincommon.rng | 7 ++- 2 files changed, 7 insertions(+), 1 deletion

[libvirt] [PATCH 4/4] PowerPC : Do not allow floppy disks in domain XML.

2015-02-14 Thread Prerna Saxena
Subject: [PATCH 4/4] PowerPC : Do not allow floppy disks in domain XML. PowerKVM does not support floppy disks. Ensure that libvirt honours this. Fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1180486 Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 8

[libvirt] [PATCH 1/4] PowerPC : Make 'qemu-system-ppc64' the default emulator on ppc64[le].

2015-02-14 Thread Prerna Saxena
PowerPC : Explicitly associate 'qemu-system-ppc64' as the default emulator for all 64-bit PowerPC guests ( both Big Little Endian ) Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[libvirt] [RFC] [Patch] Make hugepage testcase arch-agnostic

2015-02-02 Thread Prerna Saxena
couldnt find an easy way to determine host page size. Awaiting community responses, Prerna From 8a64d4d22e2e65158d3caa45b615ca9a263f841f Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 2 Feb 2015 10:48:48 +0530 Subject: [PATCH] Commit 311b4a67 introduces a test

Re: [libvirt] [PATCH] cpu: add Freescale ppc64 CPU models

2015-01-29 Thread Prerna Saxena
bit too, or new handler functions need to be implemented for 32 bit PowerPC. I do not have a 32 bit PowerPC system to try this. Patches are welcome, and I will be happy to help with reviews :-) Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

Re: [libvirt] [PATCH] cpu: add Freescale ppc64 CPU models

2015-01-29 Thread Prerna Saxena
isnt found. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] [Build-breaker : 1.2.12] Suppress compilation without dbus headers

2015-01-26 Thread Prerna Saxena
On Monday 26 January 2015 02:47 PM, Daniel P. Berrange wrote: On Sun, Jan 25, 2015 at 05:56:25PM +0530, Prerna Saxena wrote: Hi, While testing 1.2.12 rc2 on Powerpc, Fedora 21, I hit a bunch of build failures in absence of dbus-devel : src/util/virsystemd.c:284:17: note: in expansion

[libvirt] [PATCH] [Build-breaker : 1.2.12] Suppress compilation without dbus headers

2015-01-25 Thread Prerna Saxena
://www.redhat.com/archives/libvir-list/2015-January/msg00641.html From 8c4f583b6bb47ca41866ff884af0cd55487f047d Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Sun, 25 Jan 2015 05:35:23 -0600 Subject: [PATCH] Build: Fix dbus m4 macro to correctly flag it as a required

Re: [libvirt] [PATCH] Firewall : let libvirtd proceed after verifying locking args

2015-01-09 Thread Prerna Saxena
Ping ! On Friday 26 December 2014 03:54 PM, Prerna Saxena wrote: I recently encountered a situation where an unclean ebtables shutdown caused /var/lib/ebtables/lock to be left behind. When libvirtd was started on such a system, it caused libvirtd to hang. Reason: While probing to check

[libvirt] [PATCH] Firewall : let libvirtd proceed after verifying locking args

2014-12-26 Thread Prerna Saxena
unable to start any VMs. The following patch fixes this scenario: --- From ec245eccc03e8a69dc2c2e6edbf30a7b34eb74d0 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Fri, 26 Dec 2014 15:24:45 -0500 Subject: [PATCH

Re: [libvirt] [PATCH 2/2] Tests : Make nwfilter testcases robust against optional locking flags.

2014-11-26 Thread Prerna Saxena
Hi Martin, Thanks for the feedback. On Tuesday 25 November 2014 05:57 PM, Martin Kletzander wrote: On Tue, Nov 25, 2014 at 05:12:48PM +0530, Prerna Saxena wrote: Commit dc33e6e4a5a5d42 introduces iptables/ebtables to adding locking flags if/when these are available. However, the nwfilter

Re: [libvirt] [PATCH 2/2] Tests : Make nwfilter testcases robust against optional locking flags.

2014-11-26 Thread Prerna Saxena
On Wednesday 26 November 2014 04:06 PM, Martin Kletzander wrote: On Wed, Nov 26, 2014 at 03:28:21PM +0530, Prerna Saxena wrote: Hi Martin, Thanks for the feedback. On Tuesday 25 November 2014 05:57 PM, Martin Kletzander wrote: On Tue, Nov 25, 2014 at 05:12:48PM +0530, Prerna Saxena wrote

[libvirt] [PATCH 0/2] Testcase fixes for nwfilter.

2014-11-25 Thread Prerna Saxena
This series adds fixes for nwfilter testcases. Patch 1/2 : Flips result reporting for tests/nwfilterebiptablestest.c in line with other tests. Patch 2/2 : Makes nwfilter testcases more resilient to the presence of locking flags, introduced by Commit dc33e6e4a5a5d42 Prerna Saxena (2): tests

[libvirt] [PATCH 2/2] Tests : Make nwfilter testcases robust against optional locking flags.

2014-11-25 Thread Prerna Saxena
matches the expected results. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- tests/nwfilterebiptablestest.c | 7 + tests/nwfilterxml2firewalltest.c | 3 ++ tests/testutils.c| 62 tests/testutils.h| 6 4

[libvirt] [PATCH 1/2] tests : Fix failure reporting for tests/nwfilterebiptablestest.c

2014-11-25 Thread Prerna Saxena
-by: Prerna Saxena pre...@linux.vnet.ibm.com --- tests/nwfilterebiptablestest.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tests/nwfilterebiptablestest.c b/tests/nwfilterebiptablestest.c index e04bc21..f62e046 100644 --- a/tests/nwfilterebiptablestest.c

[libvirt] [PATCH v3 0/2] Numa : Allow specification of memory units

2014-11-10 Thread Prerna Saxena
* Patch 2 : Now uses virDomainParseMemory() * Also, documentation in patch 2 is now fixed to link to memory unit specification -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

[libvirt] [PATCH v3 1/2] Extend virDomainParseMemory for use outside domain_conf

2014-11-10 Thread Prerna Saxena
From 4978c8c2df19bdf738695d6cc64864f11071a08e Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 10 Nov 2014 14:48:03 +0530 Commit 01b4de2b9f5ca82 abstracts virDomainParseMemory() for use by other functions in domain_conf.c Extend the same for use, for functions

[libvirt] [PATCH v3 2/2] Numa : Allow specification of 'units' for numa nodes.

2014-11-10 Thread Prerna Saxena
From 1ead736712eec3bd098daf222a872c67b67e94ce Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Nov 2014 07:53:59 +0530 CPU numa topology implicitly allows memory specification in 'KiB'. Enabling this to accept the 'unit' in which memory needs to be specified

Re: [libvirt] [PATCH v3 0/2] Numa : Allow specification of memory units

2014-11-10 Thread Prerna Saxena
On Monday 10 November 2014 07:36 PM, Michal Privoznik wrote: On 10.11.2014 12:49, Prerna Saxena wrote: Present XML specification of NUMA node accepts memory in 'KiB' only. This series adds support for input of cell memory in units of choice. Description: === Patch 1/2 : Export

[libvirt] [PATCH v2] Memory : Allow specification of 'units' for numa nodes.

2014-11-07 Thread Prerna Saxena
into this cumulative patch. 3) Corresponding documentation added. From 2199d97b88cf9eab29788fb0e440c4b0a0bb23ec Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Nov 2014 07:53:59 +0530 CPU numa topology implicitly allows memory specification in 'KiB'. Enabling

[libvirt] [PATCH 0/3] Libvirt memory NUMA fixes

2014-11-05 Thread Prerna Saxena
' attribute alongwith the 'memory' attribute of a NUMA cell. This enables users to easily describe how much memory needs to be allocated to each NUMA cell for a guest domain. Patch 3/3 : This augments test cases to add the 'unit' tag. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems

[libvirt] [PATCH 1/3] Memory: Use consistent type for all memory elements.

2014-11-05 Thread Prerna Saxena
From 4b3e336ea045759758b04440d75802e990506e2b Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Fri, 31 Oct 2014 16:07:21 +0530 Domain memory elements such as max_balloon and cur_balloon are implemented as 'unsigned long long', whereas the 'memory' element in NUMA

[libvirt] [PATCH 3/3]Test:Augment test cases to correctly model NUMA specification.

2014-11-05 Thread Prerna Saxena
From 2fe0e329e7224b7cd29e1252e4b4e70d9195ab2b Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Nov 2014 15:16:12 +0530 This adds the tag 'unit=KiB' for memory attribute in NUMA cells. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- tests

[libvirt] [PATCH 2/3] Numa : Allow specification of 'units' for numa nodes.

2014-11-05 Thread Prerna Saxena
From 7fe8487c5e8d24086637d2157bad25322b3654f7 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Nov 2014 07:53:59 +0530 CPU numa topology implicitly allows memory specification in 'KiB'. Enabling this to accept the 'unit' in which memory needs to be specified

Re: [libvirt] [PATCH 0/3] Libvirt memory NUMA fixes

2014-11-05 Thread Prerna Saxena
On Wednesday 05 November 2014 08:40 PM, Michal Privoznik wrote: On 05.11.2014 11:56, Prerna Saxena wrote: This patch set addresses a bunch of memory NUMA fixes. Series Description: === Patch 1/3 : Use consistent data type to represent memory elements in various XML attributes

[libvirt] [Patch v6 0/5] Libvirt CPU enhancements for Power KVM

2014-11-04 Thread Prerna Saxena
: * Added a new patch which introduces a test case for compat mode. * Fixed a whitespace in documentation patch #4. * Added listing for Power8e cpu model in cpu_map.xml Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India -- libvir-list mailing list

[libvirt] [PATCH v6 1/5] Cpu: Add support for Power LE Architecture.

2014-11-04 Thread Prerna Saxena
libvirt to spawn VMs based on 'ppc64le' architecture. Signed-off-by: Pradipta Kr. Banerjee bpra...@in.ibm.com Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com Acked-by: Michal Privoznik mpriv...@redhat.com --- src/conf/domain_conf.c | 2 +- src/cpu/cpu_powerpc.c| 2 +- src/qemu

[libvirt] [PATCH v6 2/5] PowerPC : Add support for launching VM in 'compat' mode.

2014-11-04 Thread Prerna Saxena
From 3ad5caf37bfa48e43c88660255e6a3bbb8afddeb Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Tue, 28 Oct 2014 15:05:59 +0530 PowerISA allows processors to run VMs in binary compatibility (compat) mode supporting an older version of ISA. QEMU has recently added

[libvirt] [PATCH v6 3/5]PowerPC:Improve PVR handling to fall back to cpu generation.

2014-11-04 Thread Prerna Saxena
From eebc1544e28a134ce99d39b663f09ffa89b8064a Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Tue, 28 Oct 2014 15:30:05 +0530 IBM Power processors differ uniquely across generations (such as power6, power7, power8). Each generation signifies a new PowerISA version

[libvirt] [PATCH v6 4/5] docs: Add documentation for compat mode.

2014-11-04 Thread Prerna Saxena
From 23f49711d74fae7905defa1524d7e4ab838c7838 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Fri, 31 Oct 2014 15:13:16 +0530 Add documentation to explain how compat-mode can be invoked with libvirt running on PowerPC architecture. It also mentions that this change

[libvirt] [PATCH v6 5/5]Test: Add a testcase for PowerPC compat mode cpu specification.

2014-11-04 Thread Prerna Saxena
From 88879d7eac1237b2f6ef67cb5890cb46055d56dc Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 3 Nov 2014 15:53:08 +0530 This introduces a testcase for PowerPC compat mode cpu specification. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com

Re: [libvirt] [v5][Patch 0/4] Libvirt CPU enhancements for Power KVM

2014-11-04 Thread Prerna Saxena
On Monday 03 November 2014 02:57 PM, Michal Privoznik wrote: On 31.10.2014 10:15, Prerna Saxena wrote: This patch series is a collection of enhancements for PowerPC CPUs on PowerKVM. In this iteration, I have followed Dan's suggestion on using existing cpu mode format to describe powerPC

  1   2   >