gt; wrote:
> > > > On Tue, May 23, 2023 at 11:59:41AM +0100, Richard W.M. Jones wrote:
> > > > > I just came across this thread while trying to update the libvirt
> > > > > instructions on that page. Specifically I need to add these to the
>
On Tue, May 23, 2023 at 08:12:17AM -0700, Andrea Bolognani wrote:
> On Tue, May 23, 2023 at 04:05:04PM +0300, David Abdurachmanov wrote:
> > On Tue, May 23, 2023 at 3:18 PM Andrea Bolognani
> > wrote:
> > > On Tue, May 23, 2023 at 11:59:41AM +0100, Richard W.M. Jones wr
On Tue, May 23, 2023 at 04:05:04PM +0300, David Abdurachmanov wrote:
> We run QEMU in a similar way as any other board.
>
> So it's U-Boot SPL, which then loads U-Boot ITB (which typically
> contains U-Boot proper, OpenSBI FW_DYNAMIC generic binary, and DTB).
> U-Boot SPL transfers control to
On Wed, Mar 22, 2023 at 11:37:10AM -0500, Andrea Bolognani wrote:
> On Wed, Mar 22, 2023 at 10:36:20AM -0300, Daniel Henrique Barboza wrote:
> > I'm not sure if the OS overwrites the firmware when running bare metal.
> > Usually
> > they provide different OS images for QEMU/libvirt and bare metal
On Fri, Dec 09, 2022 at 06:23:59PM +, Richard W.M. Jones wrote:
> $ guestfish --format=raw -a ssh://foo/var/tmp/fedora-36.img -i -vx
>
> ...
>
>
>
>
>
>
>
>
>
Actually I remembered in the "read-o
On Fri, Dec 09, 2022 at 11:17:22AM -0600, Jonathon Jongsma wrote:
> On 12/9/22 4:09 AM, Peter Krempa wrote:
> >On Thu, Oct 20, 2022 at 16:59:00 -0500, Jonathon Jongsma wrote:
> >>Add some helper functions to build a virCommand object and run the
> >>nbdkit process for a given virStorageSource.
>
password:
Id Name State
Essentially my argument here is that OPENSSL_CONF is sufficiently
similar in nature to KRB5CCNAME, SSH* and XAUTHORITY that we should
permit it to be passed through.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2062360
Signed-off-by
On Wed, Apr 20, 2022 at 09:36:29AM +0200, Peter Krempa wrote:
> I'll post patches to address that, but the question is whether we want
> to bother with actually supporting the password authentication or not,
> because the simpler approach to fixing the bug is to simply allow it.
Did you mean:
On Tue, Apr 19, 2022 at 03:00:58PM -0500, Jonathon Jongsma wrote:
> On 4/19/22 12:31 PM, Richard W.M. Jones wrote:
> >On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote:
> >>And now I notice that we do not actually have support for 'ssh'
> >>network disks
On Tue, Apr 19, 2022 at 11:40:49AM -0500, Jonathon Jongsma wrote:
> Well, As far as I can tell, there is no valid XML for exercising
> http auth. The schema for http(s) sources does not include any
> element [1]. And the schema for the element [2]
> requires a element with a required 'type'
On Fri, Apr 15, 2022 at 10:09:59AM +0100, Richard W.M. Jones wrote:
> I agree we should implement creation for ssh disks (not sure if it's
> possible or even makes sense for curl). Shouldn't be too difficult.
https://listman.redhat.com/archives/libguestfs/2022-April/028680.html
On Thu, Apr 14, 2022 at 05:02:46PM -0500, Jonathon Jongsma wrote:
> 1. secrets
[...]
> Fortunately, nbdkit provides a method for reading cookies and
> passwords from a file, which should be secure if the file has
> permissions set properly. So I'm currently planning to write a file
> containing
On Mon, Oct 04, 2021 at 04:50:51PM +0200, Laszlo Ersek wrote:
> On 10/04/21 11:59, Richard W.M. Jones wrote:
> > It turns out that changing the qemu implementation is painful,
> > particularly if we wish to maintain backwards compatibility of the
> > command li
/master/docs/vm-generation-id-across-hypervisors.txt
On Thu, Sep 30, 2021 at 10:16:20AM +0100, Richard W.M. Jones wrote:
> I was going to suggest something like:
>
> aa-bb-cc..
> or
> aabbcc..
After thinking about this some more, the real implementation on
Windows guest and hos
On Thu, Sep 30, 2021 at 12:53:51PM +0100, Richard W.M. Jones wrote:
> On Thu, Sep 30, 2021 at 01:12:39PM +0200, Laszlo Ersek wrote:
> > All this requires virt-v2v to parse complete elements from the
> > original domain XML, and to generate complete elements in the
> > d
On Thu, Sep 30, 2021 at 01:12:39PM +0200, Laszlo Ersek wrote:
> All this requires virt-v2v to parse complete elements from the
> original domain XML, and to generate complete elements in the
> destination domain XML. Is that feasible?
The input is not always (in fact, hardly ever) full libvirt
On Thu, Sep 30, 2021 at 09:47:01AM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 30, 2021 at 08:33:48AM +0100, Richard W.M. Jones wrote:
> > I propose we deprecate the guid parameter in:
> >
> > -device vmgenid,guid=8987940a-0951-2cc5-e815-10634ff550b9,id=vmge
More data: I found a colleague who has a Hyper-V instance with a
Windows guest and he helped me to understand how Hyper-V represents
generation IDs. Hyper-V has had support for generation IDs since long
before Microsoft proposed the feature for standardization. Originally
(I think pre-2013)
On Wed, Sep 29, 2021 at 11:10:35AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 29, 2021 at 10:57:19AM +0100, Richard W.M. Jones wrote:
> > Looking at the qemu code the problem IMHO is:
> >
> > https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b193
On Wed, Sep 29, 2021 at 10:46:38AM +0100, Richard W.M. Jones wrote:
> I don't know why we decided to use a GUID for this. The feature
> itself (https://go.microsoft.com/fwlink/?LinkId=260709) defines it as
> an 128 bit / 8 byte number. The only connection to GUIDs is the size.
*cou
On Wed, Sep 29, 2021 at 11:07:30AM +0100, Daniel P. Berrangé wrote:
> I'm not sure if we actually need the full driver or not for testing
> purposes. The the GenID is just in memory somewhere, and the somewhere
> is reported via ACPI table entry. For QEMU its easy as the data is
> exposed via
Looking at the qemu code the problem IMHO is:
https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b1930ae6c74dea/docs/specs/vmgenid.txt#L189
https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b1930ae6c74dea/hw/acpi/vmgenid.c#L37
This byte swapping makes no
On Wed, Sep 29, 2021 at 10:33:43AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 29, 2021 at 10:20:44AM +0100, Richard W.M. Jones wrote:
> > On Wed, Sep 29, 2021 at 10:01:55AM +0200, Michal Privoznik wrote:
> > > Apparently, parsing vmx.genid is not as easy as
On Wed, Sep 29, 2021 at 10:01:55AM +0200, Michal Privoznik wrote:
> Apparently, parsing vmx.genid is not as easy as I thought. Anyway, it
> was brought up in a private thread that libvirt doesn't report correct
> UUIDs. For instance for the following input:
>
> vm.genid = "-8536691797830587195"
3 +--
> 18 files changed, 25 insertions(+), 38 deletions(-)
I didn't test it, but the changes look reasonable so:
Reviewed-by: Richard W.M. Jones
Equivalent (non-)change to libguestfs is:
https://github.com/libguestfs/libguestfs/commit/e14ff937422115e23094ca4cce80ec9fb01c10b3
Ric
recommended syntax is most prominent.
>
> Suggested-by: Richard W.M. Jones
> Signed-off-by: Stefan Hajnoczi
This is much better. There are a couple of minor points below but in
general:
Reviewed-by: Richard W.M. Jones
> +Optional parameters
> +===
> +
On Mon, Aug 02, 2021 at 01:14:52PM +0100, Daniel P. Berrangé wrote:
> On Mon, Aug 02, 2021 at 12:26:56PM +0100, Richard W.M. Jones wrote:
> > On Mon, Aug 02, 2021 at 12:12:08PM +0100, Daniel P. Berrangé wrote:
> > > On Mon, Aug 02, 2021 at 12:04:49PM +0100, Richard W.M. Jones wro
On Mon, Aug 02, 2021 at 12:12:08PM +0100, Daniel P. Berrangé wrote:
> On Mon, Aug 02, 2021 at 12:04:49PM +0100, Richard W.M. Jones wrote:
> > On Mon, Aug 02, 2021 at 01:00:15PM +0200, Michal Prívozník wrote:
> > > On 7/30/21 2:02 PM, Richard W.M. Jones wrote:
> > > >
On Mon, Aug 02, 2021 at 01:00:15PM +0200, Michal Prívozník wrote:
> On 7/30/21 2:02 PM, Richard W.M. Jones wrote:
> > On Thu, Jul 29, 2021 at 10:30:30AM +0200, Michal Privoznik wrote:
> >> The VMware metadata file contains genid but we are not parsing
> >> and thus
a/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-10.xml
> +++ b/tests/vmx2xmldata/vmx2xml-esx-in-the-wild-10.xml
> @@ -1,6 +1,7 @@
>
>w2019biosvmware
>421a6177-5aa9-abb7-5924-fc376c18a1b4
> + 13c67c91-9f47-526f-b0d6-e4dd2e4bb4f9
>4194304
>4194304
>2
On Wed, Jul 28, 2021 at 11:31:13AM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 28, 2021 at 11:20:27AM +0100, Richard W.M. Jones wrote:
> >
> > commit 3c3c55be66e230ef09ad927eda038dc32f01a166
> > Author: Daniel P. Berrangé
> > Date: Thu Apr 8 11:50:30 20
commit 3c3c55be66e230ef09ad927eda038dc32f01a166
Author: Daniel P. Berrangé
Date: Thu Apr 8 11:50:30 2021 +0100
meson: don't probe for -Werror if --werror is enabled
Builds are failing in Fedora Rawhide at the moment because of a
warning being turned into an error. Fedora's spec
led
>
> NEWS.rst| 6 ++
> src/qemu/qemu_block.c | 1 +
> tests/qemuxml2argvdata/disk-copy_on_read.x86_64-latest.args | 2 +-
> 3 files changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Richard W.M. Jones
Rich.
--
Ri
Patch series looks fine to me, and we can certainly use this feature.
One question I have about it: Does this apply to all architectures
equally, or will we need to detect it from capabilities? I mean to
say, if this was added to libvirt version X, then I might mandate that
you have to use
On Tue, Feb 09, 2021 at 01:58:58PM +, Daniel P. Berrangé wrote:
> +mode name='maximum' supported='yes'
> + enum name='maximumMigratable'
> +valueon/value
> +valueoff/value
> + /enum
> +/mode
> mode name='host-model' supported='yes'
Hmmm - that
On Fri, Feb 05, 2021 at 01:25:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 04.02.2021 22:07, Eric Blake wrote:
> >Supporting '0x20M' looks odd, particularly since we have an 'E' suffix
>
> What about also deprecating 'E' suffix? (just my problem of reviewing
> previous patch)
Ha! What if
On Mon, Sep 21, 2020 at 02:54:15PM +0200, Peter Krempa wrote:
> On Mon, Sep 21, 2020 at 13:45:14 +0100, Richard W.M. Jones wrote:
> > Some general comments on using the patch:
> >
> > * For libguestfs I chose to add
> >
> > -compat deprecated-in
supported.
http://fedoraproject.org/wiki/MinGW
>From 90df6dc8a3278800f9f9dc23f626df5fa00b5950 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones"
Date: Mon, 21 Sep 2020 13:18:05 +0100
Subject: [PATCH] lib: direct: Pass qemu -compat to detect deprecated features.
In developer versions of li
On Wed, Jul 22, 2020 at 04:29:15PM +0800, Zhenyu Zheng wrote:
> Hi,
>
> Any other comments for this topic?
libguestfs, nbdkit and virt-v2v have also worked (upstream)
for years out of the box on aarch64, so there should be no
problem there.
If you're interested in RHV (ie. oVirt downstream on
nel.
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1843865
I'm sorry I don't have a way to test this patch. However it looks
reasonable from here based on the description above and the changes to
the code below, so ACK.
Rich.
> CC: Leonardo Augusto Guimarães Garcia
> CC:
(deps (:generator generator.pl))
> + (action (run %{generator})))
> +
> +(rule
> + (targets libvirt_version.ml)
> + (deps (:version_in libvirt_version.ml.in))
> + (action (with-stdout-to %{targets}
> +(run sed
> "s/@PACKAGE_NAME@/ocaml-libvirt/;s/@PACK
.. is here:
https://github.com/msys2/MINGW-packages/issues/6384
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
On Wed, Mar 18, 2020 at 01:44:18PM +0100, Pino Toscano wrote:
> (Apparently forgot to send it yesterday, so sending it with a small
> addedum.)
>
> On Tuesday, 17 March 2020 18:09:04 CET Richard W.M. Jones wrote:
> > My only worry about this patch is that it relies on fileNam
Works, so:
Tested-by: Richard W.M. Jones
I have no further comments about the patches themselves other than
what I said on the first version.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http
new file mode 100644
> index 00..af4a5ff9f6
> --- /dev/null
> +++ b/tests/vmx2xmldata/vmx2xml-cdrom-ide-empty-2.xml
> @@ -0,0 +1,23 @@
> +
> + 0000-0000-0000--
> + 32768
> + 32768
> + 1
> +
> +hvm
> +
> +
On Thu, Mar 05, 2020 at 04:54:10PM +, Daniel P. Berrangé wrote:
> In the following recent change:
>
> commit db72866310d1e520efa8ed2d4589bdb5e76a1c95
> Author: Daniel P. Berrangé
> Date: Tue Jan 14 10:40:52 2020 +
>
> util: add API for reading password from the console
>
>
Build libvirt from git (ccf7567329f).
Using the libvirt ‘run’ script, run something like
libguestfs-test-tool. I think basically any command which runs a
guest will do. NB These commands are all run as NON-root:
killall libvirtd lt-libvirtd virtlogd lt-virtlogd
./build/run
On Wed, Feb 12, 2020 at 07:03:11PM +0100, Peter Krempa wrote:
> This series fixes and improves the 'json:' pseudo-protocol parser and
> implements the 'offset' and 'size' attributes and exposes them as
> in the XML.
>
> The previous version attempted an easy route, but that didn't cover all
>
On Thu, Feb 06, 2020 at 08:51:52AM +0100, Peter Krempa wrote:
> This series fixes and improves the 'json:' pseudo-protocol parser and
> implements the 'offset' and 'size' attributes and exposes them as
> in the XML.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1791788
>
> Peter Krempa (15):
On Fri, Jan 24, 2020 at 04:13:14PM +, Daniel P. Berrangé wrote:
> On Fri, Jan 24, 2020 at 03:01:51PM +, Daniel P. Berrangé wrote:
> > On Fri, Jan 24, 2020 at 02:51:39PM +, Richard W.M. Jones wrote:
> > > On Fri, Jan 24, 2020 at 02:35:01PM +, Daniel P. Berrangé wro
On Fri, Jan 24, 2020 at 04:13:14PM +, Daniel P. Berrangé wrote:
> On Fri, Jan 24, 2020 at 03:01:51PM +, Daniel P. Berrangé wrote:
> > On Fri, Jan 24, 2020 at 02:51:39PM +, Richard W.M. Jones wrote:
> > > On Fri, Jan 24, 2020 at 02:35:01PM +, Daniel P. Berrangé wro
Seems like the CI test is passing now.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
I pushed those patches, so hopefully you should see the CI
job being fixed shortly.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing
On Fri, Jan 24, 2020 at 03:01:51PM +, Daniel P. Berrangé wrote:
> On Fri, Jan 24, 2020 at 02:51:39PM +0000, Richard W.M. Jones wrote:
> > On Fri, Jan 24, 2020 at 02:35:01PM +, Daniel P. Berrangé wrote:
> > > On Sun, Jan 19, 2020 at 01:04:07PM +0000, Richar
On Fri, Jan 24, 2020 at 02:35:01PM +, Daniel P. Berrangé wrote:
> On Sun, Jan 19, 2020 at 01:04:07PM +0000, Richard W.M. Jones wrote:
> > Basically OCaml 4.10 is much more strict about the difference between
> > string (immutable) and bytes (mutable).
>
> For all pa
This should be compatible with earlier versions of OCaml
too since we are just assigning a char * to a const char *.
---
libvirt/generator.pl| 14 +++---
libvirt/libvirt_c_oneoffs.c | 6 +++---
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/libvirt/generator.pl
In OCaml 4.10 String_val returns const char *, so we cannot use it as
the destination for memcpy. Use Bytes_val instead.
---
libvirt/generator.pl| 2 +-
libvirt/libvirt_c_oneoffs.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/libvirt/generator.pl
Basically OCaml 4.10 is much more strict about the difference between
string (immutable) and bytes (mutable).
Rich.
Strings are immutable in modern OCaml.
---
libvirt/libvirt.ml | 4 ++--
libvirt/libvirt.mli | 4 ++--
libvirt/libvirt_c_oneoffs.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/libvirt/libvirt.ml b/libvirt/libvirt.ml
index 7f9d0e4..bdb9460 100644
---
>
> The solution is to stop relying on the cached capabilities to find the
> binary and instead use the same logic we use to pick default a binary
> per arch when populating capabilities.
>
> Signed-off-by: Daniel P. Berrangé
Fixes the problem over here, so:
Tested-by: Richard W.
On Thu, Jan 16, 2020 at 05:17:43PM +, Richard W.M. Jones wrote:
> On Thu, Jan 16, 2020 at 05:56:38PM +0100, Peter Krempa wrote:
> > See patch 2 please.
> >
> > Peter Krempa (2):
> > tests: storage: Add test data for json specified raw image with
> >
Can confirm that this fixes the issue in the virt-v2v test suite.
Tested-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scr
of the library and virsh.
Signed-off-by: Richard W.M. Jones
---
run.in | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/run.in b/run.in
index 3118f9a9a4..d508e64802 100644
--- a/run.in
+++ b/run.in
@@ -21,12 +21,10 @@
# With this script you can run libvirt programs
This has been used in libguestfs and libnbd for quite a while as it
makes the ./run script easier to read and write.
See also:
http://stackoverflow.com/a/9631350
Signed-off-by: Richard W.M. Jones
---
run.in | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git
The ./run script is a very useful way to run the libguestfs and
virt-v2v test suites against a locally compiled copy of libvirt.
These two patches contain some minor fixes.
Rich.
On Thu, Jan 16, 2020 at 01:13:38PM +, Richard W.M. Jones wrote:
> On Thu, Jan 16, 2020 at 12:41:37PM +0100, Peter Krempa wrote:
> > When parsing legacy NBD backing file strings such as
> > 'nbd:unix:/tmp/sock:exportname=/' we'd fail to set the transport to
> > VIR_STORAG
On Thu, Jan 16, 2020 at 12:41:37PM +0100, Peter Krempa wrote:
> When parsing legacy NBD backing file strings such as
> 'nbd:unix:/tmp/sock:exportname=/' we'd fail to set the transport to
> VIR_STORAGE_NET_HOST_TRANS_UNIX. This started to be a problem once we
> actually started to generate config
On Thu, Nov 28, 2019 at 01:04:00PM +, Daniel P. Berrangé wrote:
> We have an RFE from libguestfs to provide a way to run as root
> *with* capabilities. I looked integrating this into the DAC security
> manager as a new flag in the security label, but then I started
> thinking about the whole
On Wed, Oct 23, 2019 at 10:18:58AM +0200, Michal Privoznik wrote:
[...]
Thanks for the explanation. In case you didn't discover it, cocci has
a very responsive upstream mailing list:
https://systeme.lip6.fr/mailman/listinfo/cocci
> 1: Thing is, while coccinelle understands C very well, it
On Wed, Oct 09, 2019 at 07:49:29PM -0400, Cole Robinson wrote:
> In that bug, I see that rjones (cc'd) said that libvirt not
> remembering labels/uid causes issues for libguestfs that requires
> workarounds. Rich, do you have links to threads or bug reports where
> this is described in more
On Thu, Sep 05, 2019 at 02:54:53PM +0200, Pino Toscano wrote:
> Raise the proper exception on malloc failures.
>
> Signed-off-by: Pino Toscano
> ---
> libvirt/libvirt_c_oneoffs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libvirt/libvirt_c_oneoffs.c
On Thu, Sep 05, 2019 at 09:59:48AM +0200, Pino Toscano wrote:
> With OCaml >= 4.09 caml_named_value() returns a const value *, so keep
> the constness to build also in this case.
>
> Signed-off-by: Pino Toscano
> ---
> libvirt/libvirt_c_oneoffs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
On Tue, Sep 03, 2019 at 01:41:16PM +0200, Pino Toscano wrote:
> Use a GCC pragma to hide all the internal helpers, so they are not
> exposed as public symbols of the stub library.
>
> Signed-off-by: Pino Toscano
> ---
> libvirt/libvirt_c.h | 11 +++
> 1 file changed, 11 insertions(+)
>
This is all fine. Should we try to use a linker script
to hide the public symbols from patch 2?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual
On Thu, Aug 29, 2019 at 05:38:05PM +0200, Pino Toscano wrote:
> On Thursday, 29 August 2019 16:52:48 CEST Richard W.M. Jones wrote:
> > When I was trying to fix this package and do a release last week I was
> > thinking how nice it would be if it used automake (or perhaps meson)
&
This patch series is fine, ACK.
When I was trying to fix this package and do a release last week I was
thinking how nice it would be if it used automake (or perhaps meson)
and we could drop the manifest etc. Hint hint!
Are you able to push this to the upstream repo or do you need me to do
| 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libvirt/generator.pl b/libvirt/generator.pl
> index 490ef9a..e850500 100755
> --- a/libvirt/generator.pl
> +++ b/libvirt/generator.pl
> @@ -1,4 +1,4 @@
> -#!/usr/bin/perl -w
> +#!/usr/bin/env perl
>
On Tue, May 28, 2019 at 10:29:43AM +0200, Pino Toscano wrote:
> This way no non-namespaced OCaml C symbols are used, reducing the risk
> of clashes with other code.
>
> Signed-off-by: Pino Toscano
> ---
> libvirt/Makefile.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Fri, Apr 05, 2019 at 06:33:52PM +0200, Pino Toscano wrote:
> Raise the libvirt version to the de-facto requirement, and add a new
> API which will be useful. Also, sync Virterror with libvirt.
>
> Pino Toscano (3):
> build: bump required libvirt to 1.2.8
> Implement
87,6 +787,8 @@ int main(int argc, char **argv)
> flags &= ~BDRV_O_RDWR;
> break;
> case 'P':
> +warn_report("The '-P' option is deprecated; use --image-opts
> with "
> +"a raw device wrapper for s
On Wed, Jan 23, 2019 at 04:18:16PM -0600, Eric Blake wrote:
> On 1/23/19 3:55 PM, Richard W.M. Jones wrote:
> > On Wed, Jan 23, 2019 at 03:19:53PM -0600, Eric Blake wrote:
> >> The existing qemu-nbd --partition code claims to handle logical
> >> partitions up to 8, sin
break;
> case 'P':
> +warn_report("The '-P' option is deprecated; use --image-opts
> with "
> +"a raw device wrapper for subset exports instead");
> if (qemu_strtoi(optarg, NULL, 0, ) < 0 ||
> partition
On Mon, Jan 21, 2019 at 03:23:59PM +, Daniel P. Berrangé wrote:
> On Mon, Jan 21, 2019 at 03:13:20PM +0000, Richard W.M. Jones wrote:
> > GCC 9 complains:
> >
> > nwfilter/nwfilter_dhcpsnoop.c: In function 'virNWFilterDHCPSnoopThread':
> > nwfilter/nwfilter
GCC 9 complains:
nwfilter/nwfilter_dhcpsnoop.c: In function 'virNWFilterDHCPSnoopThread':
nwfilter/nwfilter_dhcpsnoop.c:1456:31: error: converting a packed
'virNWFilterSnoopEthHdrPtr' {aka 'struct _virNWFilterSnoopEthHdr *'} pointer
(alignment 1) to 'const u_char *' {aka 'const unsigned char
I'm not 100% confident about either of these patches, so
please take care with them. I also think the second patch
is probaby best fixed by disabling the warning, or else a
much more fundamental rewrite of the test.
Rich.
--
libvir-list mailing list
libvir-list@redhat.com
GCC 9 gives pages of errors like:
qemumonitorjsontest.c: In function 'mymain':
qemumonitorjsontest.c:2904:9: error: jump skips variable initialization
[-Werror=jump-misses-init]
2904 | goto cleanup;
| ^~~~
qemumonitorjsontest.c:3111:2: note: label 'cleanup' defined here
I'm pleased to announce libguestfs 1.40, a library and a set of tools
for accessing and modifying virtual machine disk images.
This release represents about a year of work by many contributors.
I'd like to call out in particular substantial contributions from:
Pino Toscano, Tomáš Golembiovský,
On Fri, Nov 02, 2018 at 03:52:23PM +0100, Pino Toscano wrote:
> The actual type of an enum in C is implementation defined when there are
> no negative values, and thus it can be int, or uint. This is the case
> of the virError* enums in libvirt, as they do not have negative values.
>
> Hence, to
On Mon, Oct 15, 2018 at 04:07:01PM +0200, Pino Toscano wrote:
> This way, the OCaml snippets are colorized.
>
> The OCaml version required is higher than the first version shipping
> ocamldoc with this option, so that can be done unconditionally.
>
> Signed-off-by: Pino Toscano
> ---
>
On Mon, Oct 15, 2018 at 04:02:31PM +0200, Pino Toscano wrote:
> A round of few build system improvements:
> - use the OCaml build macros from libguestfs
> - remove generated stuff
> - use pkg-config to find & use libvirt
>
> Pino Toscano (4):
> build: move OCaml macros to a m4 subdir
> build:
On Thu, Sep 06, 2018 at 05:13:23PM +0200, Pino Toscano wrote:
> Hi,
>
> for reasons mostly lost in the history, after the libvirt-ocaml
> repository was converted to git, it was not used by its main author
> (Rich Jones); the development continued on Rich's git, at
>
On Mon, Aug 27, 2018 at 02:10:18PM +0200, Andrea Bolognani wrote:
> None of the existing models is suitable for use with
> RISC-V virt guests, and we don't want information about
> the serial console to be missing from the XML.
>
> The name is based on comments in qemu/hw/riscv/virt.c:
>
>
From: David Abdurachmanov
---
libvirt.spec.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index e7196b7d3b..5cb995a6a4 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -101,7 +101,7 @@
%endif
# Numactl is not available on
On Mon, Aug 20, 2018 at 10:40:42AM +0200, Andrea Bolognani wrote:
> On Sun, 2018-08-19 at 19:46 +0100, Richard W.M. Jones wrote:
> > On Sun, Aug 19, 2018 at 07:44:06PM +0100, Richard W.M. Jones wrote:
> > >
> > > http://fedora-riscv.tranquillity.se/koji/task
On Sun, Aug 19, 2018 at 07:44:06PM +0100, Richard W.M. Jones wrote:
>
> http://fedora-riscv.tranquillity.se/koji/taskinfo?taskID=95457
>
> There were some minor changes to the spec file:
>
> https://src.fedoraproject.org/rpms/libvirt/c/18f7b8c79c2876b2d3a6ebe2279fd6526321536
http://fedora-riscv.tranquillity.se/koji/taskinfo?taskID=95457
There were some minor changes to the spec file:
https://src.fedoraproject.org/rpms/libvirt/c/18f7b8c79c2876b2d3a6ebe2279fd6526321536b?branch=master
Rich.
--
Richard Jones, Virtualization Group, Red Hat
d the unit test coverage to validate that we are only doing FD
> passing when operating in server mode.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Daniel P. Berrangé
I suppose you might want to mention in the commit message that the bug
only affects qemu 2.12, and the bug n
On Thu, Jun 07, 2018 at 01:38:47PM +0200, Peter Krempa wrote:
> On Thu, Jun 07, 2018 at 12:20:16 +0100, Richard W.M. Jones wrote:
> >
> > I don't know whether or not we decided this was a bug, but
> > I have filed one anyway:
> >
> > https://bugzilla.redhat.com/
I don't know whether or not we decided this was a bug, but
I have filed one anyway:
https://bugzilla.redhat.com/show_bug.cgi?id=1588447
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog:
On Wed, Jun 06, 2018 at 01:25:27PM -0500, Eric Blake wrote:
> On 06/06/2018 12:29 PM, Richard W.M. Jones wrote:
> >I'm chasing down a very frustrating bug which only happens on i686 &
> >Koji during the nbdkit tests and seemingly nowhere else. Anyway this
> >is what I've
1 - 100 of 1798 matches
Mail list logo
