in some other places, mainly bhyve related.
Apply a trivial fix to resolve that.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_device.c| 6 --
tests/bhyvexml2argvmock.c | 4 ++--
tests/domaincapstest.c | 3 ++-
tests/networkxml2conftest.c | 16 +---
4 files
'__BEGIN_DECLS'
__BEGIN_DECLS
^
/usr/include/sys/cpuset.h:156:12: error: unknown type name 'cpusetid_t';
did you mean 'cpuset_t'?
int cpuset(cpusetid_t *);
and so forth.
Signed-off-by: Roman Bogorodskiy
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b
Martin Kletzander wrote:
> On Mon, Nov 22, 2021 at 03:22:11PM +0400, Roman Bogorodskiy wrote:
> > Martin Kletzander wrote:
> >
> >> On Sun, Nov 21, 2021 at 07:58:55PM +0400, Roman Bogorodskiy wrote:
> >> >Recently, FreeBSD has got sched_get/setaffinity(3) i
Martin Kletzander wrote:
> On Sun, Nov 21, 2021 at 07:58:55PM +0400, Roman Bogorodskiy wrote:
> >Recently, FreeBSD has got sched_get/setaffinity(3) implementations and
> >the sched.h header as well [1]. To make these routines visible,
> >users have to define _WITH_CPU_SET_
=160b4b922b6021848b6b48afc894d16b879b7af2
https://cgit.freebsd.org/src/commit/?id=90fa9705d5cd29cf11c5dc7319299788dec2546a
Signed-off-by: Roman Bogorodskiy
---
meson.build | 4 +++-
src/util/virprocess.c | 8
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/meson.build b/meson.build
index
able via
config file).
Signed-off-by: Roman Bogorodskiy
---
Changes from v1:
- Fixed various leaks,
- Re-implemented testing using opendir() mock.
po/POTFILES.in| 1 +
src/bhyve/bhyve_domain.c | 5 +
src/bhyve/bhyve_firmware.c
Andrea Bolognani wrote:
> On Fri, 2021-03-05 at 13:43 +0100, Ján Tomko wrote:
> > On a Friday in 2021, Andrea Bolognani wrote:
> > > On Thu, 2021-03-04 at 17:47 +0100, Ján Tomko wrote:
> > > > On a Wednesday in 2021, Roman Bogorodskiy wrote:
> > > > &
Tools depend on keycode generated sources, so declare that as an
explicit dependency, otherwise it might fail with:
../tools/virsh-completer-domain.c:35:10: fatal error: 'virkeynametable_linux.h'
file not found
^
Signed-off-by: Roman Bogorodskiy
---
I noticed
is a BSD grep to make checks
pass in a reasonable time.
Signed-off-by: Roman Bogorodskiy
---
build-aux/Makefile.in | 1 +
build-aux/meson.build | 24 +++-
build-aux/syntax-check.mk | 1 -
3 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/build-aux
Daniel P. Berrangé wrote:
> On Sun, Feb 28, 2021 at 05:00:01PM +0400, Roman Bogorodskiy wrote:
> > Peter Krempa wrote:
> >
> > > On Sun, Feb 28, 2021 at 08:24:58 +0400, Roman Bogorodskiy wrote:
> > > > Meson default timeout for test() is 30 seconds. Thi
Peter Krempa wrote:
> On Sun, Feb 28, 2021 at 08:24:58 +0400, Roman Bogorodskiy wrote:
> > Meson default timeout for test() is 30 seconds. This may be not enough
> > for some tests like sc_prohibit_nonreentrant or
> > sc_libvirt_unmarked_diagnostics, so set it to 60 seco
Meson default timeout for test() is 30 seconds. This may be not enough
for some tests like sc_prohibit_nonreentrant or
sc_libvirt_unmarked_diagnostics, so set it to 60 seconds.
Signed-off-by: Roman Bogorodskiy
---
On my system these two tests always timeout with the default value.
That's what I
able via
config file).
Signed-off-by: Roman Bogorodskiy
---
Not extremely happy about the LIBVIRT_BHYVE_FIRMWARE_DIR_OVERRIDE knob,
but not sure how to test this otherwise.
po/POTFILES.in| 1 +
src/bhyve/bhyve_domain.c | 5 +
src/bh
these attributes optional. In case if not
specified, use /dev/nmdm$UUID[AB], where $UUID is a domain's UUID.
With this schema it's unlikely nmdm device will clash with other domains
or even other non-bhyve nmdm devices.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_domain.c | 14
Michal Privoznik wrote:
> On 2/4/21 4:47 PM, Roman Bogorodskiy wrote:
> > Currently, requesting domain capabilities fails when the specified
> > emulator binary does not equal to "/usr/sbin/bhyve". Relax this check
> > to allow any path with basename &quo
Currently, requesting domain capabilities fails when the specified
emulator binary does not equal to "/usr/sbin/bhyve". Relax this check
to allow any path with basename "bhyve", as it's a common case when
binary is specified without an absolute path.
Signed-off-by: Roman
functions only when it returns -2, it fails
immediately without falling back to other methods, such as
safezero_slow().
Fix that by returning -2 if posix_fallocate() returns EINVAL, to give
safezero() a chance to try other functions.
Signed-off-by: Roman Bogorodskiy
---
src/util/virfile.c | 10
ger any need for the
> higher level functions to stuff a template name ("vnet%d") into
> ifname.
>
> Signed-off-by: Laine Stump
For this and 1/5:
Reviewed-by: Roman Bogorodskiy
Thanks for this cleanup.
> ---
> src/bhyve/bhyve_command.c | 7 ---
> 1 file changed,
Daniel P. Berrangé wrote:
> On Thu, Oct 08, 2020 at 05:06:16PM +0400, Roman Bogorodskiy wrote:
> > Recently virtio-9p support was added to bhyve.
> >
> > On the host side it looks this way:
> >
> > bhyve -s 25:0,virtio-9p,sharename=/path/to/shared/dir
Michal Privoznik wrote:
> On 10/10/20 6:13 AM, Roman Bogorodskiy wrote:
> > For the virtio-9p bhyve command line argument, the proper order
> > is mount_tag=/path/to/host/dir, not the opposite.
> >
> > Signed-off-by: Roman Bogorodskiy
> > --
Signed-off-by: Roman Bogorodskiy
---
NEWS.rst | 4
1 file changed, 4 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index e708f06e9e..bc35458f38 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -25,6 +25,10 @@ v6.9.0 (unreleased)
``virConnectGetVersion()``, and ``virDomainGetAutostart()`` APIs
For the virtio-9p bhyve command line argument, the proper order
is mount_tag=/path/to/host/dir, not the opposite.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 2 +-
tests/bhyvexml2argvdata/bhyvexml2argv-fs-9p-readonly.args | 2 +-
tests
Signed-off-by: Roman Bogorodskiy
---
docs/drvbhyve.html.in | 21 +
1 file changed, 21 insertions(+)
diff --git a/docs/drvbhyve.html.in b/docs/drvbhyve.html.in
index 49d4aa5878..228e8b2bd5 100644
--- a/docs/drvbhyve.html.in
+++ b/docs/drvbhyve.html.in
@@ -482,6 +482,27
Roman Bogorodskiy wrote:
> Recently virtio-9p support was added to bhyve.
>
> On the host side it looks this way:
>
> bhyve -s 25:0,virtio-9p,sharename=/path/to/shared/dir
>
> It could also have ",ro" suffix to make share read-only.
>
> In t
ownership and permissions on the host.
In libvirt domain XML it's modeled using the 'filesystem' element:
Optional 'readonly' sub-element enables read-only mode.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_capabilities.c| 14
src/bhyve/bhyve_capa
veargv2xmldata/bhyveargv2xml-vnc-vga-on.xml | 2 +-
> tests/bhyveargv2xmldata/bhyveargv2xml-vnc.xml| 2 +-
> 8 files changed, 9 insertions(+), 7 deletions(-)
Reviewed-by: Roman Bogorodskiy
Roman Bogorodskiy
signature.asc
Description: PGP signature
ests/bhyveargv2xmldata/bhyveargv2xml-console3.xml
> delete mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-console4.xml
Reviewed-by: Roman Bogorodskiy
Roman Bogorodskiy
signature.asc
Description: PGP signature
Daniel P. Berrangé wrote:
> On Tue, Oct 06, 2020 at 06:51:52PM +0400, Roman Bogorodskiy wrote:
> > Hi,
> >
> > Recently bhyve got virtio-9p support. Modeling it appears to be pretty
> > straight-forward, but probably I'm missing something, so decided to
> >
+
Kernel driver in use: virtio-pci
I was thinking about presenting it like this:
There's also an optional element for readonly mounts, which
is also supported by bhyve.
Does this look reasonable?
Roman Bogorodskiy
signature.asc
Description: PGP signature
- Wrap long lines in "domxml-to-native" example so it fits
content width,
- For changeset revision links, use "FreeBSD changeset rN" or
"changeset rN" instead of just "rN" to make it more readable.
Signed-off-by: Roman Bogo
ions(+), 14 deletions(-)
>
Reviewed-by: Roman Bogorodskiy
Roman Bogorodskiy
signature.asc
Description: PGP signature
Andrea Bolognani wrote:
> On Thu, 2020-09-24 at 20:18 +0400, Roman Bogorodskiy wrote:
> > +Note: VNC password authentication is known to be cryptographically weak.
> > +Additionally, the password is passed as a command line argument in clear
> > text.
> > +Make su
* Document sound device support,
* Document VNC password configuration and framebuffer resolution.
Signed-off-by: Roman Bogorodskiy
---
docs/drvbhyve.html.in | 47 +++
1 file changed, 47 insertions(+)
diff --git a/docs/drvbhyve.html.in b/docs
Roman Bogorodskiy wrote:
> From: Fabian Freyer
>
> Add a new helper function, bhyveParsePCIFbuf, to parse the bhyve-argv
> parameters for a frame-buffer device to and
> definitions.
>
> For now, only the listen address, port, and vga mode are detected.
> Unsupported
From: Fabian Freyer
The resolution of the VNC framebuffer can now be set via the resolution
definition introduced in 5.9.0.
Also, add "gop" to the list of model types the
sub-element is valid for.
Signed-off-by: Fabian Freyer
Signed-off-by: Roman Bogorodskiy
---
is not set when
formatting the domain definition.
Signed-off-by: Fabian Freyer
Signed-off-by: Roman Bogorodskiy
---
NEWS.rst | 7 +++
src/bhyve/bhyve_command.c | 33 +-
src/bhyve/bhyve_parse_command.c | 5
Changes from v2:
No functional changes, only rebase.
Fabian Freyer (4):
bhyve: support parsing fbuf PCI device
bhyve: add support for setting fbuf resolution
bhyve: probe for VNC password capability
bhyve: add VNC password support
NEWS.rst | 12
the private API to expose the
virDomainGraphicsDefNew helper function, which is used by
bhyveParsePCIFbuf.
Signed-off-by: Fabian Freyer
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_parse_command.c | 91 ++-
src/libvirt_private.syms | 1
From: Fabian Freyer
Introduces the BHYVE_CAP_VNC_PASSWORD capability, which is probed by
parsing the error message from the bhyve command. When it is not
supported, bhyve -s 0,fbuf,password= will return an error message.
Signed-off-by: Fabian Freyer
Signed-off-by: Roman Bogorodskiy
---
src
Fixes: 4277e61e22b7532dc476c44a356081053da470f8
Signed-off-by: Roman Bogorodskiy
---
Pushed as build breaker & trivial.
...yvexml2argv-addr-non-isa-controller-on-slot-1.args | 11 +++
...exml2argv-addr-non-isa-controller-on-slot-1.ldargs | 1 +
2 files changed, 12 insert
Daniel P. Berrangé wrote:
> On Sun, Sep 20, 2020 at 07:21:15PM +0400, Roman Bogorodskiy wrote:
> > Currently, slot 1 is only allowed to be used by the LPC device.
> > Relax this requirement and allow to use slot 1 if it was explicitly
> > specified by the user for
controller is not supported by bhyve,
and multiple controllers with the same index are forbidden,
so forbid ISA controllers with non-zero index for bhyve.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 27 +++---
src/bhyve/bhyve_device.c
be reserved for the LPC
device, even if it is not configured to make address assignment
consistent in case the LPC device becomes necessary (e.g. the user
adds a console or a video device which require LPC).
Signed-off-by: Roman Bogorodskiy
---
po/POTFILES.in| 1 -
src
.
No changes in 1-2/3 except rebasing.
Roman Bogorodskiy (3):
conf: add 'isa' controller type
bhyve: support 'isa' controller for LPC
bhyve: soften requirements for slot 1
docs/schemas/domaincommon.rng | 6 +++
po/POTFILES.in| 1 -
src/bhyve
Introduce 'isa' controller type. In domain XML it looks this way:
...
...
Currently, this is needed for the bhyve driver to allow choosing a
specific PCI address for that. In bhyve, this controller is used to
attach serial ports and a boot ROM.
Signed-off-by: Roman
Daniel P. Berrangé wrote:
> On Thu, Sep 17, 2020 at 05:48:38PM +0400, Roman Bogorodskiy wrote:
> > Daniel P. Berrangé wrote:
> >
> > > On Wed, Sep 16, 2020 at 07:14:39PM +0400, Roman Bogorodskiy wrote:
> > > > Daniel P. Berrangé wrote:
> > > &g
Daniel P. Berrangé wrote:
> On Wed, Sep 16, 2020 at 07:14:39PM +0400, Roman Bogorodskiy wrote:
> > Daniel P. Berrangé wrote:
> >
> > > On Sat, Aug 01, 2020 at 10:16:57AM +0400, Roman Bogorodskiy wrote:
> > > > Support modeling of the 'isa' con
Daniel P. Berrangé wrote:
> On Sat, Aug 01, 2020 at 10:16:57AM +0400, Roman Bogorodskiy wrote:
> > Support modeling of the 'isa' controller for bhyve. User can manually
> > define any PCI slot for the 'isa' controller, including PCI slot 1,
> > but other devices a
insertions(+), 9 deletions(-)
Reviewed-by: Roman Bogorodskiy
Roman Bogorodskiy
signature.asc
Description: PGP signature
Roman Bogorodskiy wrote:
> Changes from v4:
>
> - Document 'isa' controller type in docs/formatdomain.html.in.
>While here, add 'xenbus' which was also missing.
>
> Roman Bogorodskiy (2):
> conf: add 'isa' controller type
> bhyve: support 'isa' contr
;
> -nodeDeviceUnlock();
> -VIR_FREE(driver);
> -
> -return ret;
> -}
> -
> -
> -static int
> -nodeStateCleanup(void)
> -{
> -if (driver) {
> -nodeDeviceLock();
> -LibHalContext *hal_ctx = DRV_STATE_HAL_CTX(driver);
> -virNo
udev_dep.found()
> endif
>
> util_dep = cc.find_library('util', required: false)
> -if util_dep.found()
> - add_project_link_arguments('-lutil', language: 'c')
> -endif
>
> if not get_option('virtualport').disabled()
>if cc.has_header_symbol('linux/if_link.h', 'IFLA_PORT_MAX')
Roman Bogorodskiy
signature.asc
Description: PGP signature
Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 01:49:11PM +0200, Pavel Hrdina wrote:
> > On Thu, Sep 03, 2020 at 03:21:51PM +0400, Roman Bogorodskiy wrote:
> > > Daniel P. Berrangé wrote:
> > >
> > > > On Thu, Sep 03, 2020 at 02:52:41PM +0400, Roma
Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 02:52:41PM +0400, Roman Bogorodskiy wrote:
> > Daniel P. Berrangé wrote:
> >
> > > On Thu, Sep 03, 2020 at 02:21:37PM +0400, Roman Bogorodskiy wrote:
> > > > Add some FreeBSD-specific libraries (-lutil, -
Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 02:21:37PM +0400, Roman Bogorodskiy wrote:
> > Add some FreeBSD-specific libraries (-lutil, -lkvm) to tests dependencies.
> >
> > Without that, FreeBSD 11.x, which uses the GNU ld, fails to link tests.
> > I
Add some FreeBSD-specific libraries (-lutil, -lkvm) to tests dependencies.
Without that, FreeBSD 11.x, which uses the GNU ld, fails to link tests.
Interestingly, newer FreeBSD versions that use LLVM ld tolerate this
behaviour and builds successfully as is.
Signed-off-by: Roman Bogorodskiy
endif
>
> Is this enough to fix the issue? As we include readline.h in virsh.c and
> virt-admin.c as well.
>
> Pavel
It's not enough, at least to fix build on FreeBSD. Like you said, I had
to make similar change in tools/virsh.c and tools/virt-admin.c to get a
successful build.
Roman Bogorodskiy
signature.asc
Description: PGP signature
adline headers ?
> >
>
> It's part of the C99 standard:
> https://pubs.opengroup.org/onlinepubs/009695399/basedefs/stdarg.h.html
>
> (but I'm still confused why this builds on other platforms even though
> HAVE_STDARG_H is not defined anywhere)
>
> Jano
>
It fails to build on FreeBSD as well:
In file included from ../tools/vsh.c:33:
/usr/local/include/readline/readline.h:398:23: error: this function declaration
is not a prototype [-Werror,-Wstrict-prototypes]
extern int rl_message ();
^
void
1 error generated.
Roman Bogorodskiy
signature.asc
Description: PGP signature
; building on FreeBSD-10 in:
>
> commit 83131d9714db7ee77ab220186b6b0d8b6c22b09e
> configure: drop check for unsupported FreeBSD
>
> We started building the wrong side of the ifdef.
>
> Signed-off-by: Ján Tomko
> Fixes: 83131d9714db7ee77ab220186b6b0d8b6c22b09e
Re
Roman Bogorodskiy wrote:
> Roman Bogorodskiy wrote:
>
> > BSD sed(1) and GNU sed(1) syntax are not compatible, and as
> > syntax-check.mk uses the GNU flavor, set SED variable to
> > 'gsed' by default.
> >
> > Signed-off-by: Roman Bogorodskiy
> &
t; HAVE_BSD_NSS macro too. As a result, the NSS plugin built on BSD
> did not expose nss_module_register() function which made the
> plugin unusable:
>
> https://www.redhat.com/archives/libvir-list/2020-September/msg0.html
>
> Fixes: c74268705557a6781788ba011492c15df2e3df11
Michal Privoznik wrote:
> On 9/1/20 5:20 AM, Roman Bogorodskiy wrote:
> > WITH_BSD_NSS value is properly set:
> >
> > $ grep WITH_BSD_NSS build/meson-config.h
> > #define WITH_BSD_NSS 1
> > $
>
> Ah, I think this is the problem. In libvirt_nss.c we ch
-entries
-Wl,-z,defs /usr/local/lib/libxml2.so /usr/local/lib/libglib-2.0.so
/usr/local/lib/libintl.so /usr/local/lib/libgobject-2.0.so
/usr/local/lib/libgio-2.0.so /usr/local/lib/libyajl.so -Wl,--end-group
Any pointers how to debug that?
Roman Bogorodskiy
signature.asc
Description: PGP
Signed-off-by: Roman Bogorodskiy
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 2d30d5a5e8..9ded7731f8 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -25,6 +25,11 @@ v6.7.0 (unreleased)
the ``device_model_args`` setting in xl.cfg(5). The libvirt xen
There's no need to install sysconf files when init script installation
was not requested, i.e. when configured with init_script=none.
Signed-off-by: Roman Bogorodskiy
---
src/meson.build | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/meson.build b/src
Roman Bogorodskiy wrote:
> BSD sed(1) and GNU sed(1) syntax are not compatible, and as
> syntax-check.mk uses the GNU flavor, set SED variable to
> 'gsed' by default.
>
> Signed-off-by: Roman Bogorodskiy
> ---
> build-aux/syntax-check.mk | 8
> 1 fi
ctively.
Currently, schema of the 'sound' element doesn't allow specifying
neither playback nor recording devices, so for now hardcode
/dev/dsp0, which is the first audio device on the host.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_capabilities.c| 14
src/bhyve/
Changes from v3:
- In conf and bhyve code, cast audio->type to virDomainAudioType and
use switch to make compile force handling of all possible cases,
- Patch 'tests: schema: test bhyvexml2xmloutdata schemas' removed
from the series as it was pushed separately.
Roman Bogorodskiy
and output (playback).
OSS is the only backend supported so far.
Signed-off-by: Roman Bogorodskiy
---
docs/schemas/domaincommon.rng | 36 +++
src/conf/domain_capabilities.c | 4 +
src/conf/domain_conf.c | 182 -
src/conf/domain_conf.h |
Allow to map sound playback and recording devices to host devices
using "" OSS audio backend.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 35 +--
src/conf/domain_conf.c| 13 +++
src/conf/dom
Document the new element which allows to specify
host audio backend for a guest device, and update
the element description with the new
sub-element which specifies the other end of the mapping.
Signed-off-by: Roman Bogorodskiy
---
docs/formatdomain.rst | 49
Add 'ich7' sound model. This is a preparation for sound support in
bhyve, as 'ich7' is the only model it supports.
Signed-off-by: Roman Bogorodskiy
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c
Daniel P. Berrangé wrote:
> On Fri, Aug 07, 2020 at 07:09:34PM +0400, Roman Bogorodskiy wrote:
> > Signed-off-by: Roman Bogorodskiy
> > ---
> > tests/virschematest.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Reviewed-by: Daniel P. Berr
Pavel Hrdina wrote:
> On Sat, Aug 08, 2020 at 01:22:09PM +0400, Roman Bogorodskiy wrote:
> > * Add missing prerequisite headers for checking link_addr(3)
> >in net/if_dl.h,
> > * Add missing prerequisite headers for checking BRDGSFD, BRDGADD,
> >BR
/virnetdevip.c.
Signed-off-by: Roman Bogorodskiy
---
meson.build | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/meson.build b/meson.build
index 19b4795527..0913308bec 100644
--- a/meson.build
+++ b/meson.build
@@ -770,7 +770,7 @@ symbols = [
[ 'linux/if_vlan.h
Daniel P. Berrangé wrote:
> On Fri, Aug 07, 2020 at 07:09:33PM +0400, Roman Bogorodskiy wrote:
> > Allow to map sound playback and recording devices to host devices
> > using "" OSS audio backend.
> >
> > Signed-off-by: Roman Bogorodskiy
&
Changes since v2:
- Add 'ich7' sound device model,
- Convert audio id from string to integer,
- Use 'union' to store audio backend specific configuration,
- Document changes in formatdomain,
- Don't use hash for sound<->audio mapping lookups.
Roman Bogorodskiy (6):
conf: add 'ich7'
Add 'ich7' sound model. This is a preparation for sound support in
bhyve, as 'ich7' is the only model it supports.
Signed-off-by: Roman Bogorodskiy
---
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c | 1 +
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c
Signed-off-by: Roman Bogorodskiy
---
tests/virschematest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/virschematest.c b/tests/virschematest.c
index 8720031375..17eb2a4b34 100644
--- a/tests/virschematest.c
+++ b/tests/virschematest.c
@@ -201,7 +201,8 @@ mymain
and output (playback).
OSS is the only backend supported so far.
Signed-off-by: Roman Bogorodskiy
---
docs/schemas/domaincommon.rng | 36 +++
src/conf/domain_capabilities.c | 4 +
src/conf/domain_conf.c | 176 -
src/conf/domain_conf.h |
Document the new element which allows to specify
host audio backend for a guest device, and update
the element description with the new
sub-element which specified the other end of the mapping.
Signed-off-by: Roman Bogorodskiy
---
docs/formatdomain.rst | 49
ctively.
Currently, schema of the 'sound' element doesn't allow specifying
neither playback nor recording devices, so for now hardcode
/dev/dsp0, which is the first audio device on the host.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_capabilities.c| 14
src/bhyve/
Allow to map sound playback and recording devices to host devices
using "" OSS audio backend.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 26 ---
src/conf/domain_conf.c| 13 ++
src/conf/dom
BSD sed(1) and GNU sed(1) syntax are not compatible, and as
syntax-check.mk uses the GNU flavor, set SED variable to
'gsed' by default.
Signed-off-by: Roman Bogorodskiy
---
build-aux/syntax-check.mk | 8
1 file changed, 8 insertions(+)
I'm not sure if this requires a more
Commit bcbb026993 converted qemublocktest to use
g_autoptr for virQEMUCaps. To prevent it from crashing,
don't explicitly call virObjectUnref() on this object.
Signed-off-by: Roman Bogorodskiy
---
tests/qemublocktest.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/qemublocktest.c b
k->src->type = VIR_STORAGE_TYPE_BLOCK;
> else
> disk->src->type = VIR_STORAGE_TYPE_FILE;
>
> -if (!config)
> - goto error;
> -
> separator = strchr(config, ',');
> if (separator)
> disk->src->path = g_strndup(config, separator - config);
Reviewed-by: Roman Bogorodskiy
> --
> 2.26.2
>
Roman Bogorodskiy
signature.asc
Description: PGP signature
controller is not supported by bhyve,
and multiple controllers with the same index are forbidden,
so forbid ISA controllers with non-zero index for bhyve.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 27 +++---
src/bhyve/bhyve_device.c
Introduce 'isa' controller type. In domain XML it looks this way:
...
...
Currently, this is needed for the bhyve driver to allow choosing a
specific PCI address for that. In bhyve, this controller is used to
attach serial ports and a boot ROM.
Signed-off-by: Roman
Changes from v4:
- Document 'isa' controller type in docs/formatdomain.html.in.
While here, add 'xenbus' which was also missing.
Roman Bogorodskiy (2):
conf: add 'isa' controller type
bhyve: support 'isa' controller for LPC
docs/formatdomain.html.in | 6 ++--
docs
>
> Series
>
>
> Reviewed-by: Laine Stump
>
Reviewed-by: Roman Bogorodskiy
Roman Bogorodskiy
signature.asc
Description: PGP signature
Signed-off-by: Roman Bogorodskiy
---
tests/virschematest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/virschematest.c b/tests/virschematest.c
index 8720031375..17eb2a4b34 100644
--- a/tests/virschematest.c
+++ b/tests/virschematest.c
@@ -201,7 +201,8 @@ mymain
ctively.
Currently, schema of the 'sound' element doesn't allow specifying
neither playback nor recording devices, so for now hardcode
/dev/dsp0, which is the first audio device on the host.
One more simplification is to stick to "ich6" model, however
the device shows as "ich7" i
Allow to map sound playback and recording devices to host devices
using "" OSS audio backend.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 37 +--
.../bhyvexml2argv-sound.args | 2 +-
.../bhyvexml2argvdata/bhy
and output (playback).
OSS is the only backend supported so far.
Signed-off-by: Roman Bogorodskiy
---
docs/schemas/domaincommon.rng | 36
src/conf/domain_capabilities.c | 4 +
src/conf/domain_conf.c | 156 -
src/conf/domain_conf.h |
Changes from v1:
Main change is the addition of the "" element that
allows to map the "" device to the host audio backend.
Would appreciate initial feedback on this one, and then I'll proceed
with adding more validation.
Roman Bogorodskiy (4):
bhyve: implement sound d
Daniel P. Berrangé wrote:
> On Wed, Jul 15, 2020 at 07:25:45PM +0400, Roman Bogorodskiy wrote:
> > Support modeling of the 'isa' controller for bhyve. User can manually
> > define any PCI slot for the 'isa' controller, including PCI slot 1,
> > but other devices a
Daniel P. Berrangé wrote:
> On Sat, Jul 18, 2020 at 04:31:16PM +0400, Roman Bogorodskiy wrote:
> > Extend device element to accept "soundDevice"
> > sub-element which allows to map guest sound device to host
> > sound device.
> >
> > Example
>
Allow to map sound playback and recording devices to host devices
using the:
element under ''.
Signed-off-by: Roman Bogorodskiy
---
src/bhyve/bhyve_command.c | 13 +++--
tests/bhyvexml2argvdata/bhyvexml2argv-sound.args| 2 +-
tests/bhyvexml2argvdata
Signed-off-by: Roman Bogorodskiy
---
tests/virschematest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/virschematest.c b/tests/virschematest.c
index 8720031375..17eb2a4b34 100644
--- a/tests/virschematest.c
+++ b/tests/virschematest.c
@@ -201,7 +201,8 @@ mymain
ctively.
Currently, schema of the 'sound' element doesn't allow specifying
neither playback nor recording devices, so for now hardcode
/dev/dsp0, which is the first audio device on the host.
One more simplification is to stick to "ich6" model, however
the device shows as "ich7" i
1 - 100 of 997 matches
Mail list logo
