On 3/6/12 3:05 AM, Laine Stump la...@laine.org wrote:
On 03/05/2012 08:12 PM, Roopa Prabhu wrote:
This series implements the below :
01/4 pci: Add two new pci util pciDeviceGetVirtualFunctionInfo and
pciConfigAddressToSysfsFile
02/4 virtnetdev: Add support functions for mac
On 3/5/12 11:16 AM, Laine Stump la...@laine.org wrote:
I encountered two conflicts when I rebased this patch to upstream. Noted
in the comments.
On 03/04/2012 10:15 PM, Roopa Prabhu wrote:
From: Roopa Prabhu ropra...@cisco.com
This patch includes the following changes
- removes some
On 3/5/12 10:23 AM, Laine Stump la...@laine.org wrote:
On 03/04/2012 10:15 PM, Roopa Prabhu wrote:
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following:
- functions to set and get vf configs
- Functions to replace and store vf configs (Only mac address is handled
today
On 3/5/12 11:50 AM, Roopa Prabhu ropra...@cisco.com wrote:
On 3/5/12 10:23 AM, Laine Stump la...@laine.org wrote:
On 03/04/2012 10:15 PM, Roopa Prabhu wrote:
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following:
- functions to set and get vf configs
- Functions
From: Roopa Prabhu ropra...@cisco.com
This patch includes the following changes
- removes some netlink functions which are now available in virnetdev.c
- Adds a vf argument to all port profile functions
For 802.1Qbh devices, the port profile calls can use a vf argument if
passed by the caller
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following:
- functions to set and get vf configs
- Functions to replace and store vf configs (Only mac address is handled today.
But the functions can be easily extended for vlans and other vf configs)
- function to dump link dev info
From: Roopa Prabhu ropra...@cisco.com
These changes are applied only if the hostdev has a parent net device.
If the parent netdevice has virtual port information, the original virtualport
associate functions are called (these set and restore both mac and port profile
on an interface). Else, only
v3:
Changes include:
- Review comments from Laine
- rebased with latest upstream
v2:
changes include:
- feedback from stefan for 802.1Qbg. Code now prints an error if virtualport is
specified for 802.1Qbg on an interface of type hostdev
- feedback from laine for non-sriov devices. Interface
From: Roopa Prabhu ropra...@cisco.com
pciDeviceGetVirtualFunctionInfo returns pf netdevice name and virtual
function index for a given vf. This is just a wrapper around existing functions
to return vf's pf and vf_index with one api call
pciConfigAddressToSysfsfile returns the sysfile pci device
From: Roopa Prabhu ropra...@cisco.com
These changes are applied only if the hostdev has a parent net device.
If the parent netdevice has virtual port information, the original virtualport
associate functions are called (these set and restore both mac and port profile
on an interface). Else, only
v2:
changes include:
- feedback from stefan for 802.1Qbg. Code now prints an error if virtualport is
specified for 802.1Qbg on an interface of type hostdev
- feedback from laine for non-sriov devices. Interface type hostdev for
non-sriov devices
is not supported.
v1:
From: Roopa Prabhu ropra...@cisco.com
pciDeviceGetVirtualFunctionInfo returns pf netdevice name and virtual
function index for a given vf. This is just a wrapper around existing functions
to return vf's pf and vf_index with one api call
pciConfigAddressToSysfsfile returns the sysfile pci device
From: Roopa Prabhu ropra...@cisco.com
This patch includes the following changes
- removes some netlink functions which are now available in virnetdev.c
- Adds a vf argument to all port profile functions
For 802.1Qbh devices, the port profile calls can use a vf argument if
passed by the caller
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following:
- functions to set and get vf configs
- Functions to replace and store vf configs (Only mac address is handled today.
But the functions can be easily extended for vlans and other vf configs)
- function to dump link dev info
On 3/2/12 11:04 AM, Laine Stump la...@laine.org wrote:
On 03/01/2012 04:02 AM, Roopa Prabhu wrote:
This patch series is based on laines patches to support interface
type='hostdev'.
https://www.redhat.com/archives/libvir-list/2012-February/msg01126.html
It support to set mac and port
On 3/2/12 11:27 AM, Laine Stump la...@laine.org wrote:
On 03/02/2012 11:58 AM, Stefan Berger wrote:
On 03/02/2012 11:37 AM, Gerhard Stenzel wrote:
Letting the guest do the association is an option, which should work
already (even if noone probably tested it yet), but the question is
On 3/2/12 9:21 AM, Gerhard Stenzel gsten...@linux.vnet.ibm.com wrote:
On Fri, 2012-03-02 at 14:27 -0500, Laine Stump wrote:
So, at the end of this, is there *any* 802.1QbX mode that can work
using
PCI passthrough without at least one of the following things:
1) a macvtap interface on
On 3/2/12 12:45 PM, Laine Stump la...@laine.org wrote:
On 03/02/2012 03:16 PM, Roopa Prabhu wrote:
On 3/2/12 11:27 AM, Laine Stump la...@laine.org wrote:
On 03/02/2012 11:58 AM, Stefan Berger wrote:
On 03/02/2012 11:37 AM, Gerhard Stenzel wrote:
Letting the guest do the association
On 3/2/12 12:54 PM, Laine Stump la...@laine.org wrote:
On 03/02/2012 03:03 PM, Roopa Prabhu wrote:
On 3/2/12 11:04 AM, Laine Stump la...@laine.org wrote:
On 03/01/2012 04:02 AM, Roopa Prabhu wrote:
This patch series is based on laines patches to support interface
type='hostdev'.
https
From: Roopa Prabhu ropra...@cisco.com
pciDeviceGetVirtualFunctionInfo returns pf netdevice name and virtual
function index for a given vf. This is just a wrapper around existing functions
to return vf's pf and vf_index with one api call
pciConfigAddressToSysfsfile returns the sysfile pci device
From: Roopa Prabhu ropra...@cisco.com
This patch includes the following changes
- removes some netlink functions which are now available in virnetdev.c
- Adds a vf argument to all port profile functions
For 802.1Qbh devices, the port profile calls can use a vf argument if
passed by the caller
From: Roopa Prabhu ropra...@cisco.com
These changes are applied only if the hostdev has a parent net device.
If the parent netdevice has virtual port information, the original virtualport
associate functions are called (these set and restore both mac and port profile
on an interface). Else, only
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following:
- functions to set and get vf configs
- Functions to replace and store vf configs (Only mac address is handled today.
But the functions can be easily extended for vlans and other vf configs)
- function to dump link dev info
This patch series is based on laines patches to support interface
type='hostdev'.
https://www.redhat.com/archives/libvir-list/2012-February/msg01126.html
It support to set mac and port profile on an interface of type hostdev.
* If virtualport is specified, the existing virtual port functions are
On 3/1/12 4:39 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 03/01/2012 04:02 AM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch includes the following changes
- removes some netlink functions which are now available in virnetdev.c
- Adds a vf argument
On 3/1/12 7:52 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 03/01/2012 10:32 AM, Roopa Prabhu wrote:
On 3/1/12 4:39 AM, Stefan Bergerstef...@linux.vnet.ibm.com wrote:
On 03/01/2012 04:02 AM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch includes
On 1/31/12 1:16 AM, Laine Stump la...@laine.org wrote:
On 01/30/2012 08:16 PM, Roopa Prabhu wrote:
Laine, I haven't gone through your whole email yet. Was just curious about
one quick thing,
For sriov VF's, are we expecting that a net device (eth interface) be
present on the host if its
On 1/30/12 11:14 AM, Laine Stump la...@laine.org wrote:
On 01/23/2012 09:08 AM, Paolo Bonzini wrote:
devices
interface type='hostdev'
source
address type='pci' bus='0x06' slot='0x02' function='0x0'/
/source
mac address='00:16:3e:5d:c7:9e'/
address type='pci' .../
/interface
On 1/20/12 1:50 PM, Laine Stump la...@laine.org wrote:
To refresh everyone's memory, the origin of the problem I'm trying to
solve here is that the VFs of an SRIOV-capable ethernet card are given
new random MAC addresses each time the card is initialized. If those VFs
are then
On 1/27/12 11:22 AM, kmestery kmest...@cisco.com wrote:
Hi Dan:
We at Cisco have been looking at this as well, and in fact were going to
propose some things in this area as well. Our proposal (which frankly just
builds on top of what you have):
The proposal at hand is to add some
From: Roopa Prabhu ropra...@cisco.com
For direct attach devices, in qemuBuildCommandLine, we seem to be freeing
actual device on error path (with networkReleaseActualDevice). But the actual
device is not deleted.
qemuProcessStop eventually deletes the direct attach device and releases actual
From: Roopa Prabhu ropra...@cisco.com
- changed some return 1's to return -1
- changed if (rc) error checks to if (rc 0)
- fixed some other minor convention violations
I might have missed some. Can fix in another patch or can respin
Signed-off-by: Roopa Prabhu ropra...@cisco.com
Reported
On 10/26/11 8:01 PM, Roopa Prabhu ropra...@cisco.com wrote:
On 10/24/11 11:14 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 10/20/2011 01:46 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1
On 10/27/11 7:01 PM, Eric Blake ebl...@redhat.com wrote:
On 10/27/2011 05:57 PM, Roopa Prabhu wrote:
Also, looks like no where else in libvirt code we return errno. We only
print errno but always return -1. And the -ETIMEDOUT case in macvtap is an
exception, cause the upper layer
From: Roopa Prabhu ropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to what the return variable is initialized to. Can be fixed
as a separate patch if needed. The scope of this patch is just
to fix
From: Roopa Prabhu ropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to what the return variable is initialized to. Can be fixed
as a separate patch if needed. The scope of this patch is just
to fix
On 10/20/11 10:22 AM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
wrote:
On 10/20/2011 10:42 PM, Roopa Prabhu wrote:
From: Roopa Prabhu ropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
On 10/20/11 11:57 AM, Laine Stump la...@laine.org wrote:
On 10/20/2011 01:46 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
Fixes some cases where 1 was being returned instead of -1.
There are still some inconsistencies in the file with respect
to what the return variable
On 10/13/11 3:49 PM, Eric Blake ebl...@redhat.com wrote:
Detected by Coverity. Leak present since commit ca3b22b.
* src/util/macvtap.c (doPortProfileOp8021Qbh): Release device name.
---
getPhysfnDev allocates physfndev, but nothing freed it.
Pushing under the trivial rule.
On 10/14/11 1:55 PM, Eric Blake ebl...@redhat.com wrote:
On 10/14/2011 02:41 PM, Roopa Prabhu wrote:
On 10/13/11 3:49 PM, Eric Blakeebl...@redhat.com wrote:
Detected by Coverity. Leak present since commit ca3b22b.
* src/util/macvtap.c (doPortProfileOp8021Qbh): Release device
On 10/14/11 2:08 PM, Eric Blake ebl...@redhat.com wrote:
On 10/14/2011 03:05 PM, Roopa Prabhu wrote:
I had already pushed mine. Yours is missing a virReportOOMError() on
allocation failure; but ACK with that improvement.
Great. Thanks!. I will send out a patch for the bug fix and later
From: Roopa Prabhu ropra...@cisco.com
Check strdup return value and fail if error
Signed-off-by: Roopa Prabhu ropra...@cisco.com
---
src/util/pci.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/src/util/pci.c b/src/util/pci.c
index 2bbb90c..df4e6c8 100644
On 10/14/11 4:22 PM, Eric Blake ebl...@redhat.com wrote:
On 10/14/2011 04:25 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
Check strdup return value and fail if error
Signed-off-by: Roopa Prabhuropra...@cisco.com
---
src/util/pci.c |8 +++-
1 files changed
On 8/16/11 9:02 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/16/2011 12:28 AM, Roopa Prabhu wrote:
This patch tries to fix getPhysFn in macvtap.c to get the physical
function(PF) of the direct attach interface, if the interface is a SR-IOV VF.
It moves some of the sriov pci
On 8/15/11 3:58 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/12/2011 07:14 PM, Roopa Prabhu wrote:
-get_physical_function(sysfs_path, d);
-get_virtual_functions(sysfs_path, d);
+if
(!pciGetPhysicalFunction(sysfs_path,d-pci_dev.physical_function
On 8/15/11 3:47 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/12/2011 07:14 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch moves some of the sriov related pci code from node_device driver
to src/util/pci.[ch]. Some functions had to go thru name
On 8/15/11 4:03 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/12/2011 07:14 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch adds the following helper functions:
pciDeviceIsVirtualFunction: Function to check if a pci device is a sriov VF
On 8/15/11 4:13 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/12/2011 07:14 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch adds the following functions to get PF/VF relationship of an SRIOV
network interface:
ifaceIsVirtualFunction: Function to check
-by: Roopa Prabhu ropra...@cisco.com
Signed-off-by: Christian Benvenuti be...@cisco.com
Signed-off-by: David Wang dwa...@cisco.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From: Roopa Prabhu ropra...@cisco.com
This patch moves some of the sriov related pci code from node_device driver
to src/util/pci.[ch]. Some functions had to go thru name and argument list
change to accommodate the move.
Signed-off-by: Roopa Prabhu ropra...@cisco.com
Signed-off-by: Christian
From: Roopa Prabhu ropra...@cisco.com
This patch renames getPhysfn to getPhysfnDev and adds code to get the
Physical function and Virtual Function index of the direct attach linkdev (if
the direct attach interface is a SRIOV VF). The idea is to send the port
profile message to a PF if the direct
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following helper functions:
pciDeviceIsVirtualFunction: Function to check if a pci device is a sriov VF
pciGetVirtualFunctionIndex: Function to get the VF index of a sriov VF
pciDeviceNetName: Function to get the network device name
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following functions to get PF/VF relationship of an SRIOV
network interface:
ifaceIsVirtualFunction: Function to check if a network interface is a SRIOV VF
ifaceGetVirtualFunctionIndex: Function to get VF index if a network interface
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following helper functions:
pciDeviceIsVirtualFunction: Function to check if a pci device is a sriov VF
pciGetVirtualFunctionIndex: Function to get the VF index of a sriov VF
pciDeviceNetName: Function to get the network device name
From: Roopa Prabhu ropra...@cisco.com
This patch moves some of the sriov related pci code from node_device driver
to src/util/pci.[ch]. Some functions had to go thru name and argument list
change to accommodate the move.
Signed-off-by: Roopa Prabhu ropra...@cisco.com
Signed-off-by: Christian
get_physical_function and get_virtual_functions from
node_device_driver to src/util/pci*. And reworks the rest of the patches
around the new code.
Signed-off-by: Roopa Prabhu ropra...@cisco.com
Signed-off-by: Christian Benvenuti be...@cisco.com
Signed-off-by: David Wang dwa...@cisco.com
--
libvir
From: Roopa Prabhu ropra...@cisco.com
This patch adds the following functions to get PF/VF relationship of an SRIOV
network interface:
ifaceIsVirtualFunction: Function to check if a network interface is a SRIOV VF
ifaceGetVirtualFunctionIndex: Function to get VF index if a network interface
From: Roopa Prabhu ropra...@cisco.com
This patch renames getPhysfn to getPhysfnDev and adds code to get the
Physical function and Virtual Function index of the direct attach linkdev (if
the direct attach interface is a SRIOV VF). The idea is to send the port
profile message to a PF if the direct
On 8/1/11 6:00 PM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/01/2011 07:57 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This function looks at sysfs net directory to get the network interface
name associated with the pci device
Signed-off-by: Roopa
On 8/1/11 6:10 PM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/01/2011 07:57 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch adds helper functions to derive the PF/VF relationship of an sriov
network device
Signed-off-by: Roopa Prabhuropra
On 8/2/11 4:15 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Mon, Aug 01, 2011 at 09:16:09PM -0400, Dave Allan wrote:
On Mon, Aug 01, 2011 at 04:56:58PM -0700, Roopa Prabhu wrote:
This patch tries to fix getPhysFn in macvtap.c to get the physical
function(PF) of the direct attach
On 8/2/11 6:46 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
On 08/02/2011 08:46 AM, Roopa Prabhu wrote:
On 8/1/11 6:10 PM, Stefan Bergerstef...@linux.vnet.ibm.com wrote:
On 08/01/2011 07:57 PM, Roopa Prabhu wrote:
From: Roopa Prabhuropra...@cisco.com
This patch adds helper
From: Roopa Prabhu ropra...@cisco.com
This function looks at sysfs net directory to get the network interface
name associated with the pci device
Signed-off-by: Roopa Prabhu ropra...@cisco.com
Signed-off-by: Christian Benvenuti be...@cisco.com
Signed-off-by: David Wang dwa...@cisco.com
---
src
From: Roopa Prabhu ropra...@cisco.com
This patch adds code to the existing getPhysfn to get the PF device name
and VF index if the linkdev is a sriov VF.
The idea is to send the port profile message to a PF if the direct attach
interface is a VF. Eventually interface.c is probably the right place
the following
01/3 - Add function to get the network interface name of a pci device
02/3 - Add functions to get sriov PF/VF relationship of a network interface
03/3 - macvtap: Fix getPhysfn to get the PF of a direct attach network interface
Signed-off-by: Roopa Prabhu ropra...@cisco.com
Signed-off
From: Roopa Prabhu ropra...@cisco.com
This patch adds helper functions to derive the PF/VF relationship of an sriov
network device
Signed-off-by: Roopa Prabhu ropra...@cisco.com
Signed-off-by: Christian Benvenuti be...@cisco.com
Signed-off-by: David Wang dwa...@cisco.com
---
src/util
From: Roopa Prabhu ropra...@cisco.com
Current code does an IFF_UP on a 8021Qbh interface immediately after a port
profile set. This is ok in most cases except when its the migration prepare
stage. During migration we want to postpone IFF_UP'ing the interface on the
destination host until
From: Roopa Prabhu ropra...@cisco.com
Current code does not pass VM mac address to a 802.1Qbh direct attach
interface using IFLA_VF_MAC. This patch adds support in macvtap code to
send IFLA_VF_MAC netlink request during port profile association on a
802.1Qbh interface.
Stefan Cc'ed for comments
68 matches
Mail list logo
