[libvirt] [PATCH 0/5] Support Ephemeral passthrough hostdevs

2012-11-28 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. Shradha Shah (5): Added ephemeral flag for hostdev in domain conf. Adding ephemeral flag

[libvirt] [PATCH 2/5] Adding ephemeral flag for hostdev in network conf.

2012-11-28 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. --- docs/schemas/network.rng |8 src/conf/network_conf.c

[libvirt] [PATCH 3/5] Ephemeral flag mofication within the network driver.

2012-11-28 Thread Shradha Shah
--- src/network/bridge_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index fb167dc..a72f3b4 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3553,6 +3553,7 @@

[libvirt] [PATCH 4/5] Ephemeral flag modification within the qemu driver.

2012-11-28 Thread Shradha Shah
When a guest with ephemeral device is migrated the PCI- passthrough of the ephemeral device should take place after migration and hence we check for the vmop in qemuBuildCommandLine. We also dicard the PCI slot assigned by qemuCollectPCIAddress as a PCI address will be assigned later during the

[libvirt] [PATCH 1/5] Added ephemeral flag for hostdev in domain conf.

2012-11-28 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. --- docs/schemas/domaincommon.rng | 16 +

[libvirt] [PATCH 5/5] Migration support for ephemeral hostdevs.

2012-11-28 Thread Shradha Shah
--- src/qemu/qemu_migration.c | 94 +++- 1 files changed, 91 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index d52ec59..dd1a2a7 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@

[libvirt] [PATCH 3/5] Ephemeral flag mofication within the network driver.

2012-09-18 Thread Shradha Shah
--- src/network/bridge_driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 0e38016..61d5b13 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3456,6 +3456,7 @@

[libvirt] [PATCH 1/5] Added ephemeral flag for hostdev in domain conf.

2012-09-18 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. --- docs/schemas/domaincommon.rng | 16 +

[libvirt] [PATCH 2/5] Adding ephemeral flag for hostdev in network conf.

2012-09-18 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. --- docs/schemas/network.rng |8 src/conf/network_conf.c

[libvirt] [PATCH 5/5] Migration support for ephemeral hostdevs.

2012-09-18 Thread Shradha Shah
--- src/qemu/qemu_migration.c | 98 +++-- 1 files changed, 94 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 99fc8ce..f3414b0 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c

[libvirt] [PATCH 4/5] Ephemeral flag modification within the qemu driver.

2012-09-18 Thread Shradha Shah
When a guest with ephemeral device is migrated the PCI- passthrough of the ephemeral device should take place after migration and hence we check for the vmop in qemuBuildCommandLine. --- src/qemu/qemu_command.c | 48 -- 1 files changed, 25

[libvirt] [PATCH 0/5] Support ephemeral passthrough hostdevs

2012-09-18 Thread Shradha Shah
The ephemeral flag helps support migration with PCI-passthrough. An ephemeral hostdev is automatically unplugged before migration and replugged (if one is available on the destination) after migration. Shradha Shah (5): Added ephemeral flag for hostdev in domain conf. Adding ephemeral flag

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-14 Thread Shradha Shah
On 09/14/2012 12:05 PM, Laine Stump wrote: On 09/13/2012 06:16 AM, Shradha Shah wrote: On 09/11/2012 08:07 PM, Laine Stump wrote: If so, one issue I have is that one of the devices (the pci-passthrough?) doesn't have its guest-side PCI address visible anywhere in the guest's XML, does

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-13 Thread Shradha Shah
Laine, Please find my comments inline. Regards, Shradha Shah On 09/11/2012 08:07 PM, Laine Stump wrote: On 09/07/2012 12:12 PM, Shradha Shah wrote: This patch series adds the support for interface-type=hostdev-hybrid and forward mode=hostdev-hybrid. The hostdev-hybrid mode makes migration

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-13 Thread Shradha Shah
* At migration time, since guests with attached pci-passthrough devices can't be migrated, the pci-passthrough device (which is found by searching the hostdev array for items with the ephemeral flag set) is detached. This reduces the bond interface on the guest to only having the virtio-net

Re: [libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-13 Thread Shradha Shah
Please find my comments inline. Many Thanks, Regards, Shradha Shah On 09/12/2012 08:01 PM, Laine Stump wrote: On 09/12/2012 05:59 AM, Daniel P. Berrange wrote: On Tue, Sep 11, 2012 at 03:07:25PM -0400, Laine Stump wrote: On 09/07/2012 12:12 PM, Shradha Shah wrote: This patch series adds

Re: [libvirt] [PATCH 3/8] Hostdev-hybrid mode requires a direct linkdev and direct mode.

2012-09-13 Thread Shradha Shah
On 09/11/2012 08:15 PM, Laine Stump wrote: (not a full review yet, but a couple of things I noticed in passing) On 09/07/2012 12:15 PM, Shradha Shah wrote: In this mode the guest contains a Virtual network device along with a SRIOV VF passed through to the guest as a pci device. --- src

[libvirt] [PATCH 0/8] Hostdev-hybrid patches

2012-09-07 Thread Shradha Shah
: https://www.redhat.com/archives/libvir-list/2012-February/msg00309.html Shradha Shah (8): RNG updates, new xml parser/formatter code for interface type=hostdev-hybrid RNG updates, new xml parser/formatter code for forward mode=hostdev-hybrid Hostdev-hybrid mode requires a direct

[libvirt] [PATCH 1/8] RNG updates, new xml parser/formatter code for interface type=hostdev-hybrid

2012-09-07 Thread Shradha Shah
This patch introduces the new interface type='hostdev-hybrid' along with attribute managed Includes updates to the domain RNG and new xml parser/formatter code. Also introduces a ephemeral tag for hybrid hostdevs. The ephemeral tag for hybrid hostdevs will be useful for live migration support at a

[libvirt] [PATCH 2/8] RNG updates, new xml parser/formatter code for forward mode=hostdev-hybrid

2012-09-07 Thread Shradha Shah
This patch introduces the new forward mode='hostdev-hybrid' along with attribute managed Includes updates to the network RNG and new xml parser/formatter code. --- docs/formatnetwork.html.in| 46 + docs/schemas/network.rng |1

[libvirt] [PATCH 5/8] network: support hostdev-hybrid in network driver

2012-09-07 Thread Shradha Shah
This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef --- src/network/bridge_driver.c | 123 ++- 1 files changed, 110 insertions(+), 13 deletions(-) diff --git a/src/network/bridge_driver.c

[libvirt] [PATCH 7/8] Using the Ephemeral Flag to prepare for Migration Support.

2012-09-07 Thread Shradha Shah
--- include/libvirt/libvirt.h.in |1 + src/conf/domain_conf.c | 24 +++- src/qemu/qemu_domain.c |6 +- src/qemu/qemu_domain.h |3 ++- src/qemu/qemu_driver.c |6 +++--- src/qemu/qemu_hostdev.c |6 ++

[libvirt] [PATCH 8/8] Migration support for hostdev-hybrid.

2012-09-07 Thread Shradha Shah
This patch uses the ephemeral flag to prevent the hybrid hostdev from being formatted into the xml. Before migration the hybrid hostdev is hot unplugged and hotplugged again after migration is the specific hostdev is available on the destination host. --- src/qemu/qemu_migration.c | 102

[libvirt] [PATCH 6/8] qemu: support netdevs from hostdev-hybrid networks

2012-09-07 Thread Shradha Shah
For network devices allocated from a network with forward mode='hostdev-hybrid', there is a need to add the newly minted hostdev to the hostdevs array. In this case we also need to call qemuPrepareHostDevices just for this one device, as the standard call to initialize all the hostdevs that were

[libvirt] [PATCH 3/8] Hostdev-hybrid mode requires a direct linkdev and direct mode.

2012-09-07 Thread Shradha Shah
In this mode the guest contains a Virtual network device along with a SRIOV VF passed through to the guest as a pci device. --- src/conf/domain_conf.c | 38 -- src/conf/domain_conf.h |5 + src/libvirt_private.syms |1 + src/util/pci.c

[libvirt] [PATCH 4/8] ActualParent is used to store the information about the NETDEV.

2012-09-07 Thread Shradha Shah
The parent type for hostdev hybrid needs to be VIR_DOMAIN_DEVICE_NONE as the device is passed into the guest as a PCI Device. In order to store the information of the NETDEV that is the parent of the HOSTDEV in question we use a new variable actualParent. This variable also helps during VF MAC

[libvirt] make check failure

2012-09-03 Thread Shradha Shah
Hello All, I wanted to ask a question regarding the tests that are run during make check. If a particular test fails when running make check, how do we which test failed and why? Is there a log that helps when debugging such errors? -- Many Thanks, Regards, Shradha Shah -- libvir-list

Re: [libvirt] [PATCH 07/15] RNG updates, new xml parser/formatter code to support interface type=hostdev-hybrid

2012-08-28 Thread Shradha Shah
I will be rebasing this remaining patch series this week. Many Thanks, Regards, Shradha Shah On 08/21/2012 11:34 PM, Eric Blake wrote: On 08/10/2012 10:24 AM, Shradha Shah wrote: This patch introduces the new interface type='hostdev-hybrid' along with attribute managed Includes updates

Re: [libvirt] [PATCH 6/7] Forward Mode Hostdev network driver Implementation

2012-08-17 Thread Shradha Shah
I'll be posting a proposed replacement patch for this one in a few minutes. Please try it out as soon as possible. I haven't gone through 7/7 yet, but with the small changes I've squashed in elsewhere, plus the 3.5/7 I posted and the 6/7 refactor I'm about to post, definitely the first 6 are

[libvirt] [PATCH 2/7] network: helper function to create interface pool from PF

2012-08-16 Thread Shradha Shah
Existing code that creates a list of forwardIfs from a single PF was moved to the new utility function networkCreateInterfacePool. No functional change. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 82 ++- 1

[libvirt] [PATCH 1/7] conf: move DevicePCIAddress functions to separate file

2012-08-16 Thread Shradha Shah
-by: Shradha Shah ss...@solarflare.com --- include/libvirt/virterror.h |1 + src/Makefile.am |7 ++- src/conf/device_conf.c | 131 ++ src/conf/device_conf.h | 65 + src/conf/domain_conf.c | 114

[libvirt] [PATCH 6/7] Forward Mode Hostdev network driver Implementation

2012-08-16 Thread Shradha Shah
This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/formatnetwork.html.in | 62 ++ src/network/bridge_driver.c | 282

[libvirt] [PATCH 5/7] Add function virDevicePCIAddressEqual

2012-08-16 Thread Shradha Shah
This function is needed by the network driver in a later commit. This function is useful in functions like networkNotifyActualDevice and networkReleaseActualDevice --- src/conf/device_conf.c | 16 src/conf/device_conf.h |3 +++ src/libvirt_private.syms |1 + 3 files

[libvirt] [PATCH 3/7] RNG updates, new xml parser/formatter code to support forward mode=hostdev

2012-08-16 Thread Shradha Shah
This patch introduces the new forward mode='hostdev' along with attribute managed Includes updates to the network RNG and new xml parser/formatter code. Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/schemas/basictypes.rng| 46 +++ docs/schemas/domaincommon.rng

[libvirt] [PATCH 4/7] Code to return interface name or pci_addr of the VF in actualDevice

2012-08-16 Thread Shradha Shah
The network pool should be able to keep track of both, network device names nad PCI addresses, and return the appropriate one in the actualDevice when networkAllocateActualDevice is called. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 60

[libvirt] [PATCH 7/7] Forward Mode 'Hostdev' qemu driver implementation

2012-08-16 Thread Shradha Shah
For a network with forward mode='hostdev', there is a need to add the newly minted hostdev to the hostdevs array. In this case we also call qemuPrepareHostDevicesas it has already been called by the time we get to here and are building the qemu commandline Signed-off-by: Shradha Shah ss

[libvirt] [PATCH 0/7] Forward mode='hostdev' patch series

2012-08-16 Thread Shradha Shah
in a network xml, and return the appropriate one in actualDevice when networkAllocateActualDevice is called. At the top level managed attribute can be specified with identical results as when it's specified for a hostdev. Currently forward mode='hostdev' does not support USB devices. Shradha Shah (7

Re: [libvirt] [PATCH 06/15] Forward Mode 'Hostdev' qemu driver implementation

2012-08-15 Thread Shradha Shah
On 08/14/2012 07:44 AM, Laine Stump wrote: On 08/10/2012 12:24 PM, Shradha Shah wrote: Some explanation is needed in the commit log of what this is being done here. A cut-paste of the comment in the code would be a good start (any anyway, that comment can be changed since it's talking about

Re: [libvirt] [PATCH 04/15] Code to return interface name or pci_addr of the VF in actualDevice

2012-08-15 Thread Shradha Shah
On 08/14/2012 06:36 AM, Laine Stump wrote: On 08/10/2012 12:23 PM, Shradha Shah wrote: The network pool should be able to keep track of both, network device names nad PCI addresses, and return the appropriate one in the actualDevice when networkAllocateActualDevice is called. Signed-off

Re: [libvirt] [PATCH 03/15] RNG updates, new xml parser/formatter code to support forward mode=hostdev

2012-08-15 Thread Shradha Shah
On 08/14/2012 06:27 AM, Laine Stump wrote: On 08/10/2012 12:23 PM, Shradha Shah wrote: This patch introduces the new forward mode='hostdev' along with attribute managed Includes updates to the network RNG and new xml parser/formatter code. This one still needs some tweaks. See below

[libvirt] [PATCH 00/15] Hostdev and Hostdev-hybrid patches

2012-08-10 Thread Shradha Shah
methodology earlier on the libvirt mailing list. The RFC can be found here: https://www.redhat.com/archives/libvir-list/2012-February/msg00309.html Shradha Shah (15): Prerequisite Patch. virDomainDevicePCIAddress and respective functions moved to a new file called conf/device_conf.ch Moved

[libvirt] [PATCH 02/15] Moved the code to create implicit interface pool from PF to a new function

2012-08-10 Thread Shradha Shah
Just code movement no functional changes here. This makes the code reusable Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 86 ++ 1 files changed, 53 insertions(+), 33 deletions(-) diff --git a/src/network

[libvirt] [PATCH 01/15] Prerequisite Patch. virDomainDevicePCIAddress and respective functions moved to a new file called conf/device_conf.ch

2012-08-10 Thread Shradha Shah
Refactoring existing code without causing any functional changes to prepare for new code. This patch makes the code reusable. Signed-off-by: Shradha Shah ss...@solarflare.com --- include/libvirt/virterror.h |1 + src/Makefile.am |6 ++- src/conf/device_conf.c | 135

[libvirt] [PATCH 03/15] RNG updates, new xml parser/formatter code to support forward mode=hostdev

2012-08-10 Thread Shradha Shah
This patch introduces the new forward mode='hostdev' along with attribute managed Includes updates to the network RNG and new xml parser/formatter code. Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/schemas/network.rng | 82 +++-- src/conf

[libvirt] [PATCH 10/15] ActualParent is used to store the information about the NETDEV that contains HOSTDEV in hybrid case.

2012-08-10 Thread Shradha Shah
The parent type for hostdev hybrid needs to be VIR_DOMAIN_DEVICE_NONE as the device is passed into the guest as a PCI Device. In order to store the information of the NETDEV that is the parent of the HOSTDEV in question we use a new variable actualParent. This variable also helps during VF MAC

[libvirt] [PATCH 05/15] Forward Mode Hostdev network driver Implementation

2012-08-10 Thread Shradha Shah
This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/formatnetwork.html.in | 62 +++ src/network/bridge_driver.c | 237

[libvirt] [PATCH 06/15] Forward Mode 'Hostdev' qemu driver implementation

2012-08-10 Thread Shradha Shah
Signed-off-by: Shradha Shah ss...@solarflare.com --- src/qemu/qemu_command.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6f6c6cd..bb66364 100644 --- a/src/qemu/qemu_command.c +++ b/src

[libvirt] [PATCH 07/15] RNG updates, new xml parser/formatter code to support interface type=hostdev-hybrid

2012-08-10 Thread Shradha Shah
This patch introduces the new interface type='hostdev-hybrid' along with attribute managed Includes updates to the domain RNG and new xml parser/formatter code. --- docs/formatdomain.html.in | 29 ++ docs/schemas/domaincommon.rng | 50

[libvirt] [PATCH 08/15] RNG updates, new xml parser/formatter code to support forward mode=hostdev-hybrid

2012-08-10 Thread Shradha Shah
This patch introduces the new forward mode='hostdev-hybrid' along with attribute managed Includes updates to the network RNG and new xml parser/formatter code. --- docs/schemas/network.rng |1 + src/conf/network_conf.c | 12

[libvirt] [PATCH 09/15] Hostdev-hybrid mode requires a direct linkdev and direct mode.

2012-08-10 Thread Shradha Shah
In this mode the guest contains a Virtual network device along with a SRIOV VF passed through to the guest as a pci device. --- src/conf/domain_conf.c | 37 +++-- src/conf/domain_conf.h |5 + src/libvirt_private.syms |1 + src/util/pci.c

[libvirt] [PATCH 04/15] Code to return interface name or pci_addr of the VF in actualDevice

2012-08-10 Thread Shradha Shah
The network pool should be able to keep track of both, network device names nad PCI addresses, and return the appropriate one in the actualDevice when networkAllocateActualDevice is called. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 33

[libvirt] [PATCH 14/15] Using the Ephemeral Flag to prepare for Migration Support.

2012-08-10 Thread Shradha Shah
--- src/conf/domain_conf.c| 24 +++- src/qemu/qemu_domain.c|6 +- src/qemu/qemu_domain.h|3 ++- src/qemu/qemu_driver.c|6 +++--- src/qemu/qemu_hostdev.c |6 ++ src/qemu/qemu_migration.c |4 ++-- 6 files changed, 37 insertions(+),

[libvirt] [PATCH 11/15] Hybrid Hostdevs should be marked as ephemeral.

2012-08-10 Thread Shradha Shah
The ephemeral flag is checked along with the hostdev parent type before freeing a hostdev. Additionally Hostdev-Hybrid mode supports live migration with PCI Passthrough. Ephemeral flag plays a very important role in the upcoming migration suppot patch. --- include/libvirt/libvirt.h.in |1 +

[libvirt] [PATCH 13/15] Hostdev-hybrid qemu driver implementation

2012-08-10 Thread Shradha Shah
--- src/qemu/qemu_command.c | 59 +++ src/qemu/qemu_hotplug.c | 23 -- src/qemu/qemu_process.c |3 +- 3 files changed, 81 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index

[libvirt] [PATCH 15/15] Migration support for hostdev-hybrid.

2012-08-10 Thread Shradha Shah
This patch uses the ephemeral flag to prevent the hybrid hostdev from being formatted into the xml. Before migration the hybrid hostdev is hot unplugged and hotplugged again after migration is the specific hostdev is available on the destination host. --- src/qemu/qemu_migration.c | 102

[libvirt] [PATCH 12/15] Hostdev-hybrid network driver Implementation

2012-08-10 Thread Shradha Shah
This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef --- src/network/bridge_driver.c | 139 +- 1 files changed, 122 insertions(+), 17 deletions(-) diff --git a/src/network/bridge_driver.c

[libvirt] Question about networkNotifyActualDevice

2012-08-09 Thread Shradha Shah
the inactive XML and not the active XML? Does anyone have any ideas on how I should proceed on this bug? -- Many Thanks, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Question about pci-passthrough

2012-07-31 Thread Shradha Shah
Hello Laine, Thanks for your help. Please find my comments inline. On 07/27/2012 08:41 PM, Laine Stump wrote: On 07/26/2012 11:53 AM, Shradha Shah wrote: Hello All, I had a question about pci-passthrough using hostdev mode in Libvirt. When I assign hostdev-parent.type

Re: [libvirt] [PATCH 0/6 v3] Support forward mode='hostdev' and interface pools

2012-07-26 Thread Shradha Shah
Hello All, May I request a review for this patch series that supports forward mode='hostdev' with interface pools? Many Thanks, Regards, Shradha Shah On 06/29/2012 01:19 PM, Shradha Shah wrote: This patch series supports the forward mode='hostdev'. The functionality of this mode is the same

Re: [libvirt] [PATCH 0/6 v3] Support forward mode='hostdev' and interface pools

2012-07-26 Thread Shradha Shah
That's fine. Thanks. Just wanted to ping the list once and keep these patches in the loop. Many Thanks, Regards, Shradha Shah On 07/26/2012 02:59 PM, Laine Stump wrote: On 07/26/2012 06:21 AM, Shradha Shah wrote: Hello All, May I request a review for this patch series that supports forward

[libvirt] Question about pci-passthrough

2012-07-26 Thread Shradha Shah
into the guest and acts as a PCI Host device. Please can someone point me to the part of code in libvirt where this decision is made based on hostdev-parent.type? -- Many Thanks, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir

[libvirt] [PATCH 0/6 v3] Support forward mode='hostdev' and interface pools

2012-06-29 Thread Shradha Shah
in a network xml, and return the appropriate one in actualDevice when networkAllocateActualDevice is called. At the top level managed attribute can be specified with identical results as when it's specified for a hostdev. Currently forward mode='hostdev' does not support USB devices. Shradha Shah (6

[libvirt] [PATCH 1/6 v3] Prerequisite Patch. virDomainDevicePCIAddress and respective functions moved to a new file called conf/device_conf.ch

2012-06-29 Thread Shradha Shah
Refactoring existing code without causing any functional changes to prepare for new code. This patch makes the code reusable. Signed-off-by: Shradha Shah ss...@solarflare.com --- include/libvirt/virterror.h |1 + src/Makefile.am |7 ++- src/conf/device_conf.c | 135

[libvirt] [PATCH 2/6 v3] Moved the code to create implicit interface pool from PF to a new function

2012-06-29 Thread Shradha Shah
Just code movement no functional changes here. This makes the code reusable Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 84 ++ 1 files changed, 52 insertions(+), 32 deletions(-) diff --git a/src/network

[libvirt] [PATCH 3/6 v3] RNG updates, new xml parser/formatter code to support forward mode=hostdev

2012-06-29 Thread Shradha Shah
This patch introduces the new forward mode='hostdev' along with attribute managed Includes updates to the network RNG and new xml parser/formatter code. Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/schemas/network.rng | 82 +++-- src/conf

[libvirt] [PATCH 4/6 v3] Code to return interface name or pci_addr of the VF in actualDevice

2012-06-29 Thread Shradha Shah
The network pool should be able to keep track of both, network device names nad PCI addresses, and return the appropriate one in the actualDevice when networkAllocateActualDevice is called. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 33

[libvirt] [PATCH 6/6 v3] Forward Mode 'Hostdev' qemu driver implementation

2012-06-29 Thread Shradha Shah
Signed-off-by: Shradha Shah ss...@solarflare.com --- src/qemu/qemu_command.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 93c018d..0f6b714 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu

[libvirt] [PATCH 5/6 v3] Forward Mode Hostdev network driver Implementation

2012-06-29 Thread Shradha Shah
This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/formatnetwork.html.in | 62 + src/network/bridge_driver.c | 213

[libvirt] Fwd: In Use tracker for network and pci-passthrough devices

2012-06-28 Thread Shradha Shah
Thanks, Regards, Shradha Shah Original Message Subject: In Use tracker for network and pci-passthrough devices Date: Tue, 26 Jun 2012 12:23:52 +0100 From: Shradha Shah ss...@solarflare.com To: Laine Stump la...@laine.org Laine, I have submitted my v2 patches for forward mode

Re: [libvirt] Fwd: In Use tracker for network and pci-passthrough devices: Laine response

2012-06-28 Thread Shradha Shah
probably move this discussion to the mailing list sooner rather than later though, as a public discussion of the design will give you a better chance of your first revision getting successfully past review :-)) On 06/26/2012 07:23 AM, Shradha Shah wrote: Laine, I have submitted my v2 patches

Re: [libvirt] Fwd: In Use tracker for network and pci-passthrough devices: Laine response

2012-06-28 Thread Shradha Shah
tracking code. You should probably move this discussion to the mailing list sooner rather than later though, as a public discussion of the design will give you a better chance of your first revision getting successfully past review :-)) On 06/26/2012 07:23 AM, Shradha Shah wrote: Laine, I

Re: [libvirt] Fwd: In Use tracker for network and pci-passthrough devices: Laine response

2012-06-28 Thread Shradha Shah
later though, as a public discussion of the design will give you a better chance of your first revision getting successfully past review :-)) On 06/26/2012 07:23 AM, Shradha Shah wrote: Laine, I have submitted my v2 patches for forward mode='hostdev' and am planning to work

Re: [libvirt] Fwd: In Use tracker for network and pci-passthrough devices: Laine response

2012-06-28 Thread Shradha Shah
On 06/28/2012 11:33 AM, Shradha Shah wrote: This is a reply I got from Laine Stump = (NB: I'm Cc'ing Osier on this email, as he's quite knowledgeable about the PCI passthrough

Re: [libvirt] Fwd: In Use tracker for network and pci-passthrough devices: Laine response

2012-06-28 Thread Shradha Shah
Osier, Many thanks for your input. Comments inline. On 06/28/2012 11:48 AM, Shradha Shah wrote: This is a reply from Osier Yang On 2012年06月27日 04:02, Laine Stump wrote: (NB: I'm

[libvirt] [PATCH 0/6 v2] Support forward mode='hostdev' and interface pools

2012-06-25 Thread Shradha Shah
in a network xml, and return the appropriate one in actualDevice when networkAllocateActualDevice is called. At the top level managed attribute can be specified with identical results as when it's specified for a hostdev. Currently forward mode='hostdev' does not support USB devices. Shradha Shah (6

[libvirt] [PATCH 1/6 v2] Prerequisite Patch. virDomainDevicePCIAddress and respective functions moved to a new file called conf/device_conf.ch

2012-06-25 Thread Shradha Shah
Refactoring existing code without causing any functional changes to prepare for new code. This patch makes the code reusable. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/Makefile.am |7 ++- src/conf/device_conf.c | 135

[libvirt] [PATCH 3/6 v2] RNG updates, new xml parser/formatter code to support forward mode=hostdev

2012-06-25 Thread Shradha Shah
This patch introduces the new forward mode='hostdev' along with attribute managed Includes updates to the network RNG and new xml parser/formatter code. Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/schemas/network.rng | 82 +++-- src/conf

[libvirt] [PATCH 5/6 v2] Forward Mode Hostdev network driver Implementation

2012-06-25 Thread Shradha Shah
This patch updates the network driver to properly utilize the new attributes/elements that are now in virNetworkDef Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/formatnetwork.html.in | 62 + src/network/bridge_driver.c | 213

[libvirt] [PATCH 4/6 v2] Code to return interface name or pci_addr of the VF in actualDevice

2012-06-25 Thread Shradha Shah
The network pool should be able to keep track of both, network device names nad PCI addresses, and return the appropriate one in the actualDevice when networkAllocateActualDevice is called. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 33

[libvirt] [PATCH 2/6 v2] Moved the code to create implicit interface pool from PF to a new function

2012-06-25 Thread Shradha Shah
Just code movement no functional changes here. This makes the code reusable Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 84 ++ 1 files changed, 52 insertions(+), 32 deletions(-) diff --git a/src/network

[libvirt] [PATCH 6/6 v2] Forward Mode 'Hostdev' qemu driver implementation

2012-06-25 Thread Shradha Shah
Signed-off-by: Shradha Shah ss...@solarflare.com --- src/qemu/qemu_command.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 93c018d..0f6b714 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu

[libvirt] [PATCH 0/5] Support forward mode='hostdev' and interface pools

2012-06-08 Thread Shradha Shah
be specified for a pf dev or an interface dev (with identical results as when it's specified for a hostdev Shradha Shah (5): Code to return interface name or pci_addr of the VF in actualDevice Moved the code to create implicit interface pool from PF to a new function Introduce forward

[libvirt] [PATCH 3/5] Introduce forward mode='hostdev' for network XML in order to use the functionality of interface pools.

2012-06-08 Thread Shradha Shah
/ /forward /network The MAC address would be provided in the domain xml. Signed-off-by: Shradha Shah ss...@solarflare.com --- docs/schemas/network.rng|1 + src/conf/network_conf.c |3 ++- src/conf/network_conf.h |1 + src/network/bridge_driver.c |6 -- 4 files changed

[libvirt] [PATCH 1/5] Code to return interface name or pci_addr of the VF in actualDevice

2012-06-08 Thread Shradha Shah
The network pool should be able to keep track of both, network device names nad PCI addresses, and return the appropriate one in the actualDevice when networkAllocateActualDevice is called. Signed-off-by: Shradha Shah ss...@solarflare.com --- src/conf/network_conf.c | 55

[libvirt] [PATCH 2/5] Moved the code to create implicit interface pool from PF to a new function

2012-06-08 Thread Shradha Shah
This makes the code reusable Signed-off-by: Shradha Shah ss...@solarflare.com --- src/network/bridge_driver.c | 109 ++- 1 files changed, 66 insertions(+), 43 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

[libvirt] [PATCH 4/5] Forward Mode Hostdev Implementation

2012-06-08 Thread Shradha Shah
This patch chooses a free network device from the interface pool and creates a PCI HostDef to be passed to the guest, when forward mode is hostdev. networkNotifyActualDevice and networkReleaseActualDevice are modified accordingly. Signed-off-by: Shradha Shah ss...@solarflare.com --- src

[libvirt] [PATCH 5/5] Supporting managed option for forward devs when using HOSTDEV mode

2012-06-08 Thread Shradha Shah
'/ /forward /network Signed-off-by: Shradha Shah ss...@solarflare.com --- src/conf/network_conf.c | 61 -- src/conf/network_conf.h |2 + src/network/bridge_driver.c |5 +++- 3 files changed, 64 insertions(+), 4 deletions(-) diff --git a/src

Re: [libvirt] [PATCH 0/5] Support forward mode='hostdev' and interface pools

2012-06-08 Thread Shradha Shah
Shah On 06/08/2012 04:26 PM, Shradha Shah wrote: This patch series supports the forward mode='hostdev'. The functionality of this mode is the same as interface type='hostdev' but with the added benefit of using interface pools. The patch series also contains a patch to support use

Re: [libvirt] Error when running virsh version and virt-manager

2012-05-29 Thread Shradha Shah
: qemuCapsExtractVersion:1566 : internal error Cannot find suitable emulator for x86_64 I created a syslink /usr/bin/qemu-system-x86_64 to /usr/libexec/qemu-kvm and I still see the issue. Many Thanks, Regards, Shradha Shah On 05/29/2012 05:13 AM, Osier Yang wrote: On 2012年05月28日 20:27, Shradha Shah wrote

[libvirt] Error when running virsh version and virt-manager

2012-05-28 Thread Shradha Shah
@c6100o libvirt]# which libvirtd /usr/sbin/libvirtd Please may I ask for help in order to resolve this issue? -- Many Thanks, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Errors during compilation

2012-05-25 Thread Shradha Shah
if anyone has observed these errors before? What can I do to fix these issues? Thanks. -- Many Thanks, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] PXE boot issue with macvtap

2012-04-19 Thread Shradha Shah
not inspect further. -- Many Thanks, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Migration failure related to EOF from Monitor

2012-02-22 Thread Shradha Shah
the monitor and find out the reason why the qemu monitor dies? Many Thanks, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Network not Persistent

2012-02-21 Thread Shradha Shah
On 02/20/2012 06:43 PM, Laine Stump wrote: On 02/20/2012 12:37 PM, Shradha Shah wrote: Hello All, I am currently working on patches for PCI-passthrough of SRIOV VF's and I am facing an issue with the network definition not being persistent. I am using a new forward mode = hostdev

Re: [libvirt] Network not Persistent

2012-02-21 Thread Shradha Shah
On 02/21/2012 03:59 PM, Laine Stump wrote: On 02/21/2012 07:33 AM, Shradha Shah wrote: On 02/20/2012 06:43 PM, Laine Stump wrote: On 02/20/2012 12:37 PM, Shradha Shah wrote: Hello All, I am currently working on patches for PCI-passthrough of SRIOV VF's and I am facing an issue

[libvirt] Network not Persistent

2012-02-20 Thread Shradha Shah
function I am missing? May I ask for your help to solve this issue? Many Thanks, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] RFC: PCI-Passthrough of SRIOV VF's new forward mode

2012-02-08 Thread Shradha Shah
Hello Laine, Many Thanks for reviewing the RFC. Please find my reply inline. On 02/07/2012 02:36 AM, Laine Stump wrote: On 02/06/2012 12:58 PM, Shradha Shah wrote: RFC: New network forward type pci-passthrough-hybrid I saw a couple of posts regarding PCI-Passthrough usage of SRIOV VF's

[libvirt] RFC: PCI-Passthrough of SRIOV VF's new forward mode

2012-02-06 Thread Shradha Shah
RFC: New network forward type pci-passthrough-hybrid I saw a couple of posts regarding PCI-Passthrough usage of SRIOV VF's a couple of weeks ago (20th Jan 2012). Initially I was going to post this RFC along with a set of patches. I would require a few more days to clean my patches for submission

[libvirt] Qemu text monitor

2012-01-31 Thread Shradha Shah
of the device fails giving an error Duplicate id. I was wondering if any of you have hit this issue before or know about any qemu-monitor bugs I may not be aware of? Many Thanks in advance, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman

[libvirt] Hidden symbols

2012-01-19 Thread Shradha Shah
for debugging purposes? Many Thanks, Regards, Shradha Shah -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

  1   2   >