Re: [PATCH] docs: formatdomain: Document disk serial truncation status quo

On Tue, Jun 29, 2021 at 03:33:26PM +0200, Peter Krempa wrote: > On Mon, Jun 28, 2021 at 16:55:34 +0200, Tomáš Golembiovský wrote: > > Hi, > > > > I have a few questions regarding this to get better understanding on how > > this should be handled by management apps. &g

Re: [PATCH] docs: formatdomain: Document disk serial truncation status quo

limit in hypervisor will become smaller? Or is it safe to assume that the limit will only grow in future versions of the hypervisor (notably QEMU). Thanks, Tomas -- Tomáš Golembiovský

Re: [PATCH v2] qemu: Expose disk serial in virDomainGetGuestInfo()

> - Documented that the param is optional and type of string > > docs/manpages/virsh.rst | 1 + > src/libvirt-domain.c| 1 + > src/qemu/qemu_driver.c | 19 ++- > 3 files changed, 16 insertions(+), 5 deletions(-) > Reviewed-By: Tomáš Golembiovský -- Tomáš Golembiovský

[libvirt PATCH] virsh: guest-agent-timeout: set default value for optional argument

The timeout argument for guest-agent-timeout is optional but it did not have proper default value specified. Also update the virsh man page accordingly. Signed-off-by: Tomáš Golembiovský --- docs/manpages/virsh.rst | 7 --- tools/virsh-domain.c| 2 +- 2 files changed, 5 insertions(+), 4

[libvirt PATCH] docs: fix names of some commands

Some commands were improperly converted from original POD file. Their names were stripped after first dash. Signed-off-by: Tomáš Golembiovský --- docs/manpages/virsh.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages

[libvirt PATCH] docs: document proper enum for guest agent timeout

The documented enum and its values do not exits. The real enum has slightly different name. Signed-off-by: Tomáš Golembiovský --- src/libvirt-domain.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index a12809c2d5

Re: [libvirt] [RFC] Add API to change qemu agent response timeout

n't used in libvirt, can be be run via the QGA passthrough > api in libvirt-qemu.so > > So sadly I think we genuinely do have a need for per-commad timeouts, > for at least some of the API calls. I don't think all of them need it > though. > > I though we could likely add a qemu.conf setting for the globak timeout, > but then add a timeout to individual APIs in specific cases where we > know they can genuinely take a very long time to execute. I would be against any timeout that cannot be changed via API. This would not give us the flexibility we require. Hope this helps, Tomas > > We must also ensure we NEVER block any regular libvirt APIs when a > guest agent comamnd is running. > > Regards, > Daniel > -- > |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o-https://fstop138.berrange.com :| > |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- Tomáš Golembiovský -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/7] add virDomainGetGuestInfo()

On Wed, Aug 07, 2019 at 10:41:10AM -0500, Jonathon Jongsma wrote: > On Wed, 2019-08-07 at 12:39 +0200, Tomáš Golembiovský wrote: > > On Thu, Aug 01, 2019 at 08:37:03AM -0500, Jonathon Jongsma wrote: > > > This series adds several bits of guest information provided by a > >

Re: [libvirt] [PATCH 0/7] add virDomainGetGuestInfo()

his problem in a more general manner later that's probably fine too. Tomas [1] https://bugzilla.redhat.com/show_bug.cgi?id=1705426 -- Tomáš Golembiovský -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 1/1] qemu: Add entry for balloon stat stat-disk-caches

whops, I didn't notice the other email... please ignore :) Tomas On Tue, 17 Jul 2018 12:02:35 +0200 Tomáš Golembiovský wrote: > ping -- Tomáš Golembiovský -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3 1/1] qemu: Add entry for balloon stat stat-disk-caches

Thanks Tomas On Mon, 16 Jul 2018 17:45:35 -0400 John Ferlan wrote: > On 07/02/2018 07:19 AM, Tomáš Golembiovský wrote: > > QEMU commit bf1e7140e adds reporting of new balloon statistic to QEMU > > 2.12. Value represents the amount of memory that can be quickly > &

Re: [libvirt] [PATCH v3 1/1] qemu: Add entry for balloon stat stat-disk-caches

ping -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3 1/1] qemu: Add entry for balloon stat stat-disk-caches

QEMU commit bf1e7140e adds reporting of new balloon statistic to QEMU 2.12. Value represents the amount of memory that can be quickly reclaimed without additional I/O. Let's add that too. Signed-off-by: Tomáš Golembiovský --- include/libvirt/libvirt-domain.h | 9 - src/libvirt-domain.c

[libvirt] [PATCH v3 0/1] qemu: Add entry for balloon stat stat-disk-caches

ere the change occurred. - updated qemuDomainGetStatsBalloon() - moved the entry in virsh output to last position - updated virsh.pod v2: - moved item to last position in array - documented item also in libvirt-domain.c - added item to virsh listing Tomáš Golembiovský (1): qemu: Add entry for balloon s

[libvirt] [PATCH v2 1/1] qemu: add entry for balloon stat stat-disk-caches

Signed-off-by: Tomáš Golembiovský --- include/libvirt/libvirt-domain.h | 9 - src/libvirt-domain.c | 3 +++ src/qemu/qemu_monitor_json.c | 2 ++ tools/virsh-domain-monitor.c | 2 ++ 4 files changed, 15 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt

[libvirt] [PATCH v2 0/1] qemu: add entry for balloon stat stat-disk-caches

v2: - moved item to last position in array - documented item also in libvirt-domain.c - added item to virsh listing Tomáš Golembiovský (1): qemu: add entry for balloon stat stat-disk-caches include/libvirt/libvirt-domain.h | 9 - src/libvirt-domain.c | 3 +++ src/qemu

[libvirt] [PATCH] qemu: add entry for balloon stat stat-disk-caches

Signed-off-by: Tomáš Golembiovský --- include/libvirt/libvirt-domain.h | 9 - src/qemu/qemu_monitor_json.c | 2 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index da773b76cb..b96c018a90 100644

[libvirt] [PATCH python] include usable memory in virDomainMemoryStats

Signed-off-by: Tomáš Golembiovský <tgole...@redhat.com> --- libvirt-override.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 0abfc37..832e05c 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -398,6

Re: [libvirt] [PATCH 0/2] docs: Fix enum documentation

| 8 +++- > docs/newapi.xsl | 25 +++-- > 2 files changed, 22 insertions(+), 11 deletions(-) > > -- > 2.13.0 > -- Tomáš Golembiovský <tgole...@redhat.com> -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, 21 Jul 2017 13:26:14 +0200 Michal Privoznik <mpriv...@redhat.com> wrote: > On 07/21/2017 01:17 PM, Tomáš Golembiovský wrote: > > On Fri, 21 Jul 2017 12:58:55 +0200 > > Michal Privoznik <mpriv...@redhat.com> wrote: > > > >> On 07/

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, 21 Jul 2017 12:58:55 +0200 Michal Privoznik <mpriv...@redhat.com> wrote: > On 07/21/2017 12:25 PM, Tomáš Golembiovský wrote: > > On Fri, 21 Jul 2017 10:12:38 +0200 > > Michal Privoznik <mpriv...@redhat.com> wrote: > > > >> On 07/

Re: [libvirt] [PATCH] docs: fix documentation of enum constants

On Fri, 21 Jul 2017 10:12:38 +0200 Michal Privoznik <mpriv...@redhat.com> wrote: > On 07/20/2017 08:21 PM, Tomáš Golembiovský wrote: > > The documentation string has to follow the definition of a constant in > > the enum. Otherwise, the HTML documentation will be gene

[libvirt] [PATCH] docs: fix documentation of enum constants

The documentation string has to follow the definition of a constant in the enum. Otherwise, the HTML documentation will be generated incorrectly. Signed-off-by: Tomáš Golembiovský <tgole...@redhat.com> --- include/libvirt/libvirt-domain.h | 62

Re: [libvirt] [PATCH 0/2] Add support for 'raw' block driver to Qemu JSON backend parsing code

Hi, gentle reminder. Thanks, Tomas On Mon, 13 Feb 2017 23:53:41 +0100 Tomáš Golembiovský <tgole...@redhat.com> wrote: > The raw driver is not very interesting on its own but it can be layered on top > of other block drivers. New parameters that allow using only part of the

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

On Wed, 15 Feb 2017 10:55:24 + "Richard W.M. Jones" <rjo...@redhat.com> wrote: > On Tue, Feb 14, 2017 at 10:03:54PM +0100, Tomáš Golembiovský wrote: > > Hi, > > > > On Tue, 14 Feb 2017 15:58:45 + > > "Richard W.M. Jones" <rj

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

/tmp/backing.img"}}' lacks > driver name [code=8 int1=-1] > > It could be that my test case is wrong in some way. I enabled > debugging and it does appear to be using the new version of libvirt, > so I'm not sure what's up ... > > Rich. > > -- > Richard Jon

[libvirt] [PATCH 1/2] util: storage: split function for JSON backing volume parsing in two

Split virStorageSourceParseBackingJSON into two functions so that the core can be reused by other functions. The new function called virStorageSourceParseBackingJSONInternal accepts virJSONValuePtr. Signed-off-by: Tomáš Golembiovský <tgole...@redhat.com> --- src/util/virstoragefile.

[libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

in JSON is queried to get the necessary information. Signed-off-by: Tomáš Golembiovský <tgole...@redhat.com> --- src/util/virstoragefile.c | 16 tests/virstoragetest.c| 6 ++ 2 files changed, 22 insertions(+) diff --git a/src/util/virstoragefile.c b/sr

[libvirt] [PATCH 0/2] Add support for 'raw' block driver to Qemu JSON backend parsing code

with error: internal error: missing parser implementation for JSON backing volume driver 'raw' Tomáš Golembiovský (2): util: storage: split function for JSON backing volume parsing in two util: storage: add JSON backing volume parser 'raw' block driver src/util/virstoragefile.c | 51

[libvirt] [PATCH] valgrind: add suppression for bash memory leak

Add suppression for memory leak in bash observerd with bash 4.4.011 on Arch Linux. Signed-off-by: Tomáš Golembiovský <tgole...@redhat.com> --- tests/.valgrind.supp | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index d4fef857b..d47

Re: [libvirt] qemu-kvm blocked for more than 120 seconds when "libvirt-guests" is enabled

s start > > Redirecting to /bin/systemctl start libvirt-guests.service > > [root@vdicnode01 ~]# virsh list > > IdName State > > > > 1 vdicone01 running > > 2 vdicdb01 running > > > > [root@vdicnode01 ~]# > > > > But If I shutdown the host it look not work properly (I attack screenshots > > of the shutdown process). > > > > Any help will be welcome. > > > > Thanks a lot. > > > > -- Tomáš Golembiovský <tgole...@redhat.com> -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] esx: Fetch snapshot info directly for filtering

to finish the query we can request the snapshot related info directly when querying the list of domains from VMware. Signed-off-by: Tomáš Golembiovský <tgole...@redhat.com> --- src/esx/esx_driver.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/s