[libvirt] Ping Re: [PATCH V4] blockjob: Fix error checking of blockjob status

2018-01-12 Thread WangJie (Captain)
ping On 2018/1/5 10:53, Jie Wang wrote: > offset and len can also be equal to 0 on failed if blockjob return > status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", > so we need to check 'error' in this case. > --- > src/qemu/qemu_monitor_json.c | 2 +- > 1 file changed, 1

[libvirt] Ping Re: [PATCH V4] blockjob: Fix error checking of blockjob status

2018-01-09 Thread WangJie (Captain)
Ping On 2018/1/5 10:53, Jie Wang wrote: > offset and len can also be equal to 0 on failed if blockjob return > status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", > so we need to check 'error' in this case. > --- > src/qemu/qemu_monitor_json.c | 2 +- > 1 file changed, 1

[libvirt] Ping Re: A question for external snapshots with flag“VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE”

2017-02-27 Thread WangJie (Captain)
On 2017/2/25 9:41, WangJie (Captain) wrote: > Hello, I got a question here. When we create consistent active external > snapshots with flag “VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE” , the > qemuDomainSnapshotFSFreeze will be called firstly to freeze all filesystems > in vm, and

[libvirt] A question for external snapshots with flag“VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE”

2017-02-24 Thread WangJie (Captain)
Hello, I got a question here. When we create consistent active external snapshots with flag “VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE” , the qemuDomainSnapshotFSFreeze will be called firstly to freeze all filesystems in vm, and then create snapshots. For windows vm, freezing filesystems used by vss

Re: [libvirt] [PATCH] remove the dead code this patch is to remove the dead code Signed-off-by: JieWang <wangji...@huawei.com>

2016-08-24 Thread WangJie (Captain)
Thank you! This is my first time to commit patch, I'll do better next time. :) On 2016/8/22 20:46, Martin Kletzander wrote: > On Mon, Aug 22, 2016 at 01:30:08PM +0100, Richard W.M. Jones wrote: >> On Mon, Aug 22, 2016 at 08:17:37PM +0800, JieWang wrote: >>> Signed-off-by: JieWang