Re: [libvirt] [PATCHv2 0/2] Support setting the 'removable' flag for USB disks

2013-08-28 Thread anonym
27/08/13 14:40, Peter Krempa wrote: On 08/23/13 12:38, Fred A. Kemp wrote: From: Fred A. Kemp ano...@riseup.net The commit message of patch #2 explains the purpose of this patch set. A review would be greatly appreciated! Note that I've only added the new capability for

Re: [libvirt] [PATCH 1/2] qemu: Add capability flag for usb-storage

2013-08-19 Thread anonym
15/08/13 12:58, Daniel P. Berrange wrote: On Thu, Aug 15, 2013 at 12:55:26PM +0200, anonym wrote: 13/08/13 16:15, Daniel P. Berrange wrote: On Tue, Aug 13, 2013 at 01:52:33PM +0200, Fred A. Kemp wrote: From: Fred A. Kemp ano...@riseup.net diff --git a/src/qemu/qemu_command.c b/src/qemu

Re: [libvirt] [PATCH 1/2] qemu: Add capability flag for usb-storage

2013-08-15 Thread anonym
13/08/13 16:15, Daniel P. Berrange wrote: On Tue, Aug 13, 2013 at 01:52:33PM +0200, Fred A. Kemp wrote: From: Fred A. Kemp ano...@riseup.net Allow use of the usb-storage device only if the new capability flag QEMU_CAPS_DEVICE_USB_STORAGE is set, which it is for qemu(-kvm) versions =

Re: [libvirt] [PATCH 0/2] Support settings the 'removable' flag for USB disks

2013-08-13 Thread anonym
Eric Blake wrote: Does this patch still apply as is? No, so I just re-submitted a rebased patch-set: http://www.redhat.com/archives/libvir-list/2013-August/msg00581.html It should be noted that my patches constantly gets in a conflicting state versus your master since they add capabilities,

Re: [libvirt] [PATCH 0/2] Support setting the 'removable' flag for USB disks

2013-06-17 Thread anonym
Bump! Also: 31/05/13 16:23, Fred A. Kemp wrote: For reference, my first attempt at a patch for this feature was: 1363682454-32012-1-git-send-email-ano...@lavabit.com On second thought, an archive link might be a better reference for people that doesn't keep old emails in the inbox for very

Re: [libvirt] [PATCH] qemu: Support setting the 'removable' flag for USB disks

2013-03-21 Thread anonym
19/03/13 12:59, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 09:40:54AM +0100, anonym wrote: Can you use a real name instead of an anonymous psuedonym for patches. Sure. Will do in my next patch proposal. This adds an attribute named 'removable' to the 'target' element of disks, which

[libvirt] [PATCH] qemu: Support setting the 'removable' flag for USB disks

2013-03-19 Thread anonym
This adds an attribute named 'removable' to the 'target' element of disks, which controls the removable flag. For instance, on a Linux guest it controls the value of /sys/block/$dev/removable. This option is only valid for USB disks (i.e. bus='usb'), and its default value is 'off', which is the