Re: [libvirt] [PATCH] qemu: Fix comparison assignment in qemuDomainUpdateDeviceLive

[Pavel Hrdina]

On Tue, Mar 06, 2018 at 09:25:45AM +0100, Erik Skultety wrote:
> Fix this common typo and assign a value rather than implicitly
> type-casted comparison result. Introduced by commit b6a264e855.
> 
> Signed-off-by: Erik Skultety 

You could have mention this bugzilla:


Pavel


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] qemu: Fix comparison assignment in qemuDomainUpdateDeviceLive

[Erik Skultety]

Fix this common typo and assign a value rather than implicitly
type-casted comparison result. Introduced by commit b6a264e855.

Signed-off-by: Erik Skultety 
---

Pushed under the trivial rule.

 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 96454c17c..9e715e7a0 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -7919,7 +7919,7 @@ qemuDomainUpdateDeviceLive(virDomainObjPtr vm,
 break;

 case VIR_DOMAIN_DEVICE_GRAPHICS:
-if ((idx = qemuDomainFindGraphicsIndex(vm->def, dev->data.graphics) >= 
0)) {
+if ((idx = qemuDomainFindGraphicsIndex(vm->def, dev->data.graphics)) 
>= 0) {
 oldDev.data.graphics = vm->def->graphics[idx];
 if (virDomainDefCompatibleDevice(vm->def, dev, ) < 0)
 return -1;
--
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list