Re: [libvirt] [PATCH 1/4] docs: Adding 'xres' and 'yres' into qxl XML definition

2019-08-05 Thread Erik Skultety
On Sun, Aug 04, 2019 at 10:21:18PM -0300, jcfara...@gmail.com wrote:
> From: Julio Faracco 
>
> This commit adds 'xres' and 'yres' into qxl XML Domain group definition.
> Both, properties were added into properties group inside qxl model and
> they are set as optional.
>
> Signed-off-by: Julio Faracco 
> ---
>  docs/schemas/domaincommon.rng | 10 ++
>  1 file changed, 10 insertions(+)

Changes to the HTML docs are missing.

>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index a0771da45b..8d95948595 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -3606,6 +3606,16 @@
>
>  
>
> +  
> +
> +  
> +
> +  
> +  
> +
> +  
> +
> +  

Both attributes should be enclosed by a single  element, there's IMO
no compelling reason to allow usage and therefore validation of one without the
other, is there?

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 1/4] docs: Adding 'xres' and 'yres' into qxl XML definition

2019-08-04 Thread jcfaracco
From: Julio Faracco 

This commit adds 'xres' and 'yres' into qxl XML Domain group definition.
Both, properties were added into properties group inside qxl model and
they are set as optional.

Signed-off-by: Julio Faracco 
---
 docs/schemas/domaincommon.rng | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index a0771da45b..8d95948595 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -3606,6 +3606,16 @@
   
 
   
+  
+
+  
+
+  
+  
+
+  
+
+  
 
   
   
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list