Re: [libvirt] [PATCH 2/4] qemu: migration: Forbid only remote migration if autodestroy is active for VM

2019-09-24 Thread Eric Blake
On 9/24/19 8:17 AM, Peter Krempa wrote:
> Semantically we can't guarantee that we'll be able to destroy the VM on
> the remote host, thus we can't allow remote migration. All other forms
> of migration (e.g. saving to file) are okay though as they don't clash
> with semantics of the flag.
> 
> Signed-off-by: Peter Krempa 
> ---
>  src/qemu/qemu_migration.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake 

> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 3c45ba35e6..a98ec2d55a 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -1155,7 +1155,8 @@ qemuMigrationSrcIsAllowed(virQEMUDriverPtr driver,
> 
>  /* following checks don't make sense for offline migration */
>  if (!(flags & VIR_MIGRATE_OFFLINE)) {
> -if (qemuProcessAutoDestroyActive(driver, vm)) {
> +if (remote &&
> +qemuProcessAutoDestroyActive(driver, vm)) {
>  virReportError(VIR_ERR_OPERATION_INVALID,
> "%s", _("domain is marked for auto destroy"));
>  return false;
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/4] qemu: migration: Forbid only remote migration if autodestroy is active for VM

2019-09-24 Thread Peter Krempa
Semantically we can't guarantee that we'll be able to destroy the VM on
the remote host, thus we can't allow remote migration. All other forms
of migration (e.g. saving to file) are okay though as they don't clash
with semantics of the flag.

Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_migration.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 3c45ba35e6..a98ec2d55a 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1155,7 +1155,8 @@ qemuMigrationSrcIsAllowed(virQEMUDriverPtr driver,

 /* following checks don't make sense for offline migration */
 if (!(flags & VIR_MIGRATE_OFFLINE)) {
-if (qemuProcessAutoDestroyActive(driver, vm)) {
+if (remote &&
+qemuProcessAutoDestroyActive(driver, vm)) {
 virReportError(VIR_ERR_OPERATION_INVALID,
"%s", _("domain is marked for auto destroy"));
 return false;
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list