Re: [libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

2019-12-03 Thread Erik Skultety
On Tue, Dec 03, 2019 at 02:00:50PM +0100, Andrea Bolognani wrote: > On Tue, 2019-12-03 at 12:30 +0100, Erik Skultety wrote: > > On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote: > > > extra_arg = "console=ttyS0 > > > ks=file:/{}".format(install_config) > > > > On a

Re: [libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

2019-12-03 Thread Andrea Bolognani
On Tue, 2019-12-03 at 12:30 +0100, Erik Skultety wrote: > On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote: > > extra_arg = "console=ttyS0 ks=file:/{}".format(install_config) > > On a side note - I'm pretty sure I've already mentioned it in the past, but we > should

Re: [libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

2019-12-03 Thread Erik Skultety
On Tue, Dec 03, 2019 at 12:19:55PM +0100, Andrea Bolognani wrote: > It's not immediately obvious why we're using it even when installing > a distribution like Debian, so explain the motivation in a comment. > > Signed-off-by: Andrea Bolognani > --- > guests/lcitool | 4 +++- > 1 file changed, 3

[libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

2019-12-03 Thread Andrea Bolognani
It's not immediately obvious why we're using it even when installing a distribution like Debian, so explain the motivation in a comment. Signed-off-by: Andrea Bolognani --- guests/lcitool | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool