Re: [libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object

2018-04-15 Thread John Ferlan
On 04/12/2018 04:44 AM, Erik Skultety wrote: > On Thu, Apr 12, 2018 at 09:14:50AM +0200, Michal Privoznik wrote: >> In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into >> virObject. Well, this requires 'virObject' member to be stored on >> the first position of the struct. This

Re: [libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object

2018-04-15 Thread Marc Hartmayer
On Thu, Apr 12, 2018 at 09:14 AM +0200, Michal Privoznik wrote: > In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into > virObject. Well, this requires 'virObject' member to be stored on > the first position of the struct. This adjustment is missing in > the

Re: [libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object

2018-04-12 Thread Daniel P . Berrangé
On Thu, Apr 12, 2018 at 01:27:41PM +0200, Michal Privoznik wrote: > On 04/12/2018 01:08 PM, John Ferlan wrote: > > > > > > On 04/12/2018 04:44 AM, Erik Skultety wrote: > >> On Thu, Apr 12, 2018 at 09:14:50AM +0200, Michal Privoznik wrote: > >>> In 2ada9ef1465f we've tried to turn

Re: [libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object

2018-04-12 Thread Michal Privoznik
On 04/12/2018 01:08 PM, John Ferlan wrote: > > > On 04/12/2018 04:44 AM, Erik Skultety wrote: >> On Thu, Apr 12, 2018 at 09:14:50AM +0200, Michal Privoznik wrote: >>> In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into >>> virObject. Well, this requires 'virObject' member to be stored

Re: [libvirt] [PATCH] conf: Actually make virDomainChrSourceDef an object

2018-04-12 Thread Erik Skultety
On Thu, Apr 12, 2018 at 09:14:50AM +0200, Michal Privoznik wrote: > In 2ada9ef1465f we've tried to turn virDomainChrSourceDef into > virObject. Well, this requires 'virObject' member to be stored on > the first position of the struct. This adjustment is missing in > the original commit leading to