Re: [libvirt] [PATCH 7/8] qemu: Support newer ivshmem device variants

2016-10-14 Thread Martin Kletzander
On Fri, Oct 14, 2016 at 10:19:58AM -0400, John Ferlan wrote: [...] +char * +qemuBuildShmemDevStr(virDomainDefPtr def, + virDomainShmemDefPtr shmem, + virQEMUCapsPtr qemuCaps) +{ +virBuffer buf = VIR_BUFFER_INITIALIZER; + +virBufferAsprintf(,

Re: [libvirt] [PATCH 7/8] qemu: Support newer ivshmem device variants

2016-10-14 Thread John Ferlan
[...] >>> +char * >>> +qemuBuildShmemDevStr(virDomainDefPtr def, >>> + virDomainShmemDefPtr shmem, >>> + virQEMUCapsPtr qemuCaps) >>> +{ >>> +virBuffer buf = VIR_BUFFER_INITIALIZER; >>> + >>> +virBufferAsprintf(, "%s", >>>

Re: [libvirt] [PATCH 7/8] qemu: Support newer ivshmem device variants

2016-10-14 Thread Martin Kletzander
On Fri, Oct 07, 2016 at 12:20:19PM -0400, John Ferlan wrote: On 09/27/2016 08:24 AM, Martin Kletzander wrote: QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are reworked varians of legacy ivshmem that are compatible from the guest POV, but not from host's POV and have sane

Re: [libvirt] [PATCH 7/8] qemu: Support newer ivshmem device variants

2016-10-07 Thread John Ferlan
On 09/27/2016 08:24 AM, Martin Kletzander wrote: > QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are > reworked varians of legacy ivshmem that are compatible from the guest > POV, but not from host's POV and have sane specification and handling. > It seems less "added