Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities
On 09/12/2016 04:50 AM, Michal Privoznik wrote:
> On 20.07.2016 21:08, Joao Martins wrote:
>> Hey,
>>
>> This small series implements host cpu description in caps, by getting
>> topology and xen hwcaps parsing done, followed by having
>> cpu-{compare,baseline} APIs implemented. Last thing missing I think it
>> would be to libxl_cpuid_set the features to enable/disable whichever
>> format we choose plus the appropriate XML convertion to/from XM and XL
>> config formats.
>>
>> Note that since RFC[0] I removed the Get CPU model names API since it
>> would make more sense having it exported once we do support guest
>> cpu model/features setting. Changelog included in individual patches
>> (only second patch got changed)
>>
>> Cheers,
>> Joao
>>
>> [0] http://www.redhat.com/archives/libvir-list/2016-July/msg00245.html
>>
>> Joao Martins (4):
>> libxl: describe host topology in capabilities
>> libxl: describe host cpu features based on hwcaps
>> libxl: implement virConnectCompareCPU
>> libxl: implement virConnectBaselineCPU
>>
>> src/libxl/libxl_capabilities.c | 168
>> ++---
>> src/libxl/libxl_driver.c | 60 +++
>> 2 files changed, 218 insertions(+), 10 deletions(-)
>>
> Fixed all the small nits, ACKed and pushed. Sorry for the delay.
I'm the one who should be sorry for letting this sit so long :-(. I had reviewed
the patches and didn't notice any issues, but I never found time to test them.
After returning from some days off, backlogged Xen stuff on the libvirt list is
high on my queue .
Thanks a lot Michal for reviewing and committing this series!
Regards,
Jim
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities
On 09/12/2016 11:50 AM, Michal Privoznik wrote:
> On 20.07.2016 21:08, Joao Martins wrote:
>> Hey,
>>
>> This small series implements host cpu description in caps, by getting
>> topology and xen hwcaps parsing done, followed by having
>> cpu-{compare,baseline} APIs implemented. Last thing missing I think it
>> would be to libxl_cpuid_set the features to enable/disable whichever
>> format we choose plus the appropriate XML convertion to/from XM and XL
>> config formats.
>>
>> Note that since RFC[0] I removed the Get CPU model names API since it
>> would make more sense having it exported once we do support guest
>> cpu model/features setting. Changelog included in individual patches
>> (only second patch got changed)
>>
>> Cheers,
>> Joao
>>
>> [0] http://www.redhat.com/archives/libvir-list/2016-July/msg00245.html
>>
>> Joao Martins (4):
>> libxl: describe host topology in capabilities
>> libxl: describe host cpu features based on hwcaps
>> libxl: implement virConnectCompareCPU
>> libxl: implement virConnectBaselineCPU
>>
>> src/libxl/libxl_capabilities.c | 168
>> ++---
>> src/libxl/libxl_driver.c | 60 +++
>> 2 files changed, 218 insertions(+), 10 deletions(-)
>>
>
> Fixed all the small nits, ACKed and pushed. Sorry for the delay.
Thank you, Michal!
> Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities
On 20.07.2016 21:08, Joao Martins wrote:
> Hey,
>
> This small series implements host cpu description in caps, by getting
> topology and xen hwcaps parsing done, followed by having
> cpu-{compare,baseline} APIs implemented. Last thing missing I think it
> would be to libxl_cpuid_set the features to enable/disable whichever
> format we choose plus the appropriate XML convertion to/from XM and XL
> config formats.
>
> Note that since RFC[0] I removed the Get CPU model names API since it
> would make more sense having it exported once we do support guest
> cpu model/features setting. Changelog included in individual patches
> (only second patch got changed)
>
> Cheers,
> Joao
>
> [0] http://www.redhat.com/archives/libvir-list/2016-July/msg00245.html
>
> Joao Martins (4):
> libxl: describe host topology in capabilities
> libxl: describe host cpu features based on hwcaps
> libxl: implement virConnectCompareCPU
> libxl: implement virConnectBaselineCPU
>
> src/libxl/libxl_capabilities.c | 168
> ++---
> src/libxl/libxl_driver.c | 60 +++
> 2 files changed, 218 insertions(+), 10 deletions(-)
>
Fixed all the small nits, ACKed and pushed. Sorry for the delay.
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities
On 07/27/2016 02:28 PM, Cedric Bosdonnat wrote:
> Hey Joao,
>
> The series looks good to me, but I'm surely not expert enough to give a
> full ACK.
>
Thank you!
Joao
> On Wed, 2016-07-20 at 20:08 +0100, Joao Martins wrote:
>> Hey,
>>
>> This small series implements host cpu description in caps, by getting
>> topology and xen hwcaps parsing done, followed by having
>> cpu-{compare,baseline} APIs implemented. Last thing missing I think it
>> would be to libxl_cpuid_set the features to enable/disable whichever
>> format we choose plus the appropriate XML convertion to/from XM and XL
>> config formats.
>>
>> Note that since RFC[0] I removed the Get CPU model names API since it
>> would make more sense having it exported once we do support guest
>> cpu model/features setting. Changelog included in individual patches
>> (only second patch got changed)
>>
>> Cheers,
>> Joao
>>
>> [0] http://www.redhat.com/archives/libvir-list/2016-July/msg00245.html
>>
>> Joao Martins (4):
>> libxl: describe host topology in capabilities
>> libxl: describe host cpu features based on hwcaps
>> libxl: implement virConnectCompareCPU
>> libxl: implement virConnectBaselineCPU
>>
>> src/libxl/libxl_capabilities.c | 168
>> ++---
>> src/libxl/libxl_driver.c | 60 +++
>> 2 files changed, 218 insertions(+), 10 deletions(-)
>>
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities
Hey Joao,
The series looks good to me, but I'm surely not expert enough to give a
full ACK.
--
Cedric
On Wed, 2016-07-20 at 20:08 +0100, Joao Martins wrote:
> Hey,
>
> This small series implements host cpu description in caps, by getting
> topology and xen hwcaps parsing done, followed by having
> cpu-{compare,baseline} APIs implemented. Last thing missing I think it
> would be to libxl_cpuid_set the features to enable/disable whichever
> format we choose plus the appropriate XML convertion to/from XM and XL
> config formats.
>
> Note that since RFC[0] I removed the Get CPU model names API since it
> would make more sense having it exported once we do support guest
> cpu model/features setting. Changelog included in individual patches
> (only second patch got changed)
>
> Cheers,
> Joao
>
> [0] http://www.redhat.com/archives/libvir-list/2016-July/msg00245.html
>
> Joao Martins (4):
> libxl: describe host topology in capabilities
> libxl: describe host cpu features based on hwcaps
> libxl: implement virConnectCompareCPU
> libxl: implement virConnectBaselineCPU
>
> src/libxl/libxl_capabilities.c | 168
> ++---
> src/libxl/libxl_driver.c | 60 +++
> 2 files changed, 218 insertions(+), 10 deletions(-)
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
