Re: [libvirt] [PATCH 5/5] util: default to read-only in virPCIDeviceConfigOpen

2019-08-15 Thread Peter Krempa
On Thu, Aug 15, 2019 at 10:10:06 +0200, Erik Skultety wrote:
> On Tue, Aug 13, 2019 at 03:45:19PM +0200, Ján Tomko wrote:
> > All the callers left require virPCIDeviceConfigOpen to be fatal
> > and only use read-only access to the config file.
> >
> > Signed-off-by: Ján Tomko 
> > ---
> 
> FYI this patch broke make check, both virpcitest and virhostdevtest.

Actually it's the previous patch according to my bisection and it
happens only with gcc. Clang works fine. This hints to some inlining
weridness happening together with the pci mocking code.


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 5/5] util: default to read-only in virPCIDeviceConfigOpen

2019-08-15 Thread Erik Skultety
On Tue, Aug 13, 2019 at 03:45:19PM +0200, Ján Tomko wrote:
> All the callers left require virPCIDeviceConfigOpen to be fatal
> and only use read-only access to the config file.
>
> Signed-off-by: Ján Tomko 
> ---

FYI this patch broke make check, both virpcitest and virhostdevtest.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list