Re: [PATCH] Revert "remote: Add libvirtd dependency to virt-guest-shutdown.target"
On Fri, Jan 29, 2021 at 10:48 AM Daniel P. Berrangé wrote: > > On Thu, Jan 28, 2021 at 12:20:13PM -0700, Jim Fehlig wrote: > > Further testing revealed commit f035f53baa regresses Debian bug 955216 > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955216 > > > > Restarting libvirt-guests on libvirtd restart is worse than the original > > dependency issue, so revert the commit until a better solution is found. > > > > This reverts commit f035f53baa2e5dc00b8e866e594672a90b4cea78. > > > > Signed-off-by: Jim Fehlig > > --- > > src/remote/virt-guest-shutdown.target | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/src/remote/virt-guest-shutdown.target > > b/src/remote/virt-guest-shutdown.target > > index e2efa3e63a..25d4aaa267 100644 > > --- a/src/remote/virt-guest-shutdown.target > > +++ b/src/remote/virt-guest-shutdown.target > > @@ -1,4 +1,3 @@ > > [Unit] > > Description=Libvirt guests shutdown > > -Requires=libvirtd.service > > Documentation=https://libvirt.org > > Reviewed-by: Daniel P. Berrangé Thanks Jim! LGTM Reviewed-by: Christian Ehrhardt > Regards, > Daniel > -- > |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o-https://fstop138.berrange.com :| > |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| > -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd
Re: [PATCH] Revert "remote: Add libvirtd dependency to virt-guest-shutdown.target"
On Thu, Jan 28, 2021 at 12:20:13PM -0700, Jim Fehlig wrote: > Further testing revealed commit f035f53baa regresses Debian bug 955216 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955216 > > Restarting libvirt-guests on libvirtd restart is worse than the original > dependency issue, so revert the commit until a better solution is found. > > This reverts commit f035f53baa2e5dc00b8e866e594672a90b4cea78. > > Signed-off-by: Jim Fehlig > --- > src/remote/virt-guest-shutdown.target | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/remote/virt-guest-shutdown.target > b/src/remote/virt-guest-shutdown.target > index e2efa3e63a..25d4aaa267 100644 > --- a/src/remote/virt-guest-shutdown.target > +++ b/src/remote/virt-guest-shutdown.target > @@ -1,4 +1,3 @@ > [Unit] > Description=Libvirt guests shutdown > -Requires=libvirtd.service > Documentation=https://libvirt.org Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
[PATCH] Revert "remote: Add libvirtd dependency to virt-guest-shutdown.target"
Further testing revealed commit f035f53baa regresses Debian bug 955216 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955216 Restarting libvirt-guests on libvirtd restart is worse than the original dependency issue, so revert the commit until a better solution is found. This reverts commit f035f53baa2e5dc00b8e866e594672a90b4cea78. Signed-off-by: Jim Fehlig --- src/remote/virt-guest-shutdown.target | 1 - 1 file changed, 1 deletion(-) diff --git a/src/remote/virt-guest-shutdown.target b/src/remote/virt-guest-shutdown.target index e2efa3e63a..25d4aaa267 100644 --- a/src/remote/virt-guest-shutdown.target +++ b/src/remote/virt-guest-shutdown.target @@ -1,4 +1,3 @@ [Unit] Description=Libvirt guests shutdown -Requires=libvirtd.service Documentation=https://libvirt.org -- 2.29.2
