Re: [PATCH] tests: Enable virpcimock on macOS

2020-10-31 Thread Roman Bolshakov
On Wed, Oct 28, 2020 at 08:09:51PM +0100, Andrea Bolognani wrote: > On Sun, 2020-10-25 at 17:26 +0300, Roman Bolshakov wrote: > > @@ -1123,6 +1123,8 @@ opendir(const char *path) > > int > > close(int fd) > > { > > +init_syms(); > > This hunk is completely independent of the other one. Can

Re: [PATCH] tests: Enable virpcimock on macOS

2020-10-28 Thread Andrea Bolognani
On Sun, 2020-10-25 at 17:26 +0300, Roman Bolshakov wrote: > @@ -1123,6 +1123,8 @@ opendir(const char *path) > int > close(int fd) > { > +init_syms(); This hunk is completely independent of the other one. Can you please split this into two separate patches? Both changes look good, they

[PATCH] tests: Enable virpcimock on macOS

2020-10-25 Thread Roman Bolshakov
In general, it has little sense to use Linux pci mock on macOS but virPCIDeviceAddressGetIOMMUGroupNum() is relying on the filesystem layout mocked by virpcimock. And all tests that rely on correct execution of virPCIDeviceAddressGetIOMMUGroupNum() fail. Additionally, missing initialization is