Re: [PATCH] tests: cover disk, interface

2020-10-05 Thread Michal Privoznik 

On 10/4/20 9:05 PM, Cole Robinson wrote:

There is present no XML test coverage for this.
Add genericxml parse + formatting coverage.

Signed-off-by: Cole Robinson 
---
  .../device-backenddomain.xml  | 30 +++
  .../device-backenddomain.xml  |  1 +
  tests/genericxml2xmltest.c|  1 +
  3 files changed, 32 insertions(+)
  create mode 100644 tests/genericxml2xmlindata/device-backenddomain.xml
  create mode 12 tests/genericxml2xmloutdata/device-backenddomain.xml


Reviewed-by: Michal Privoznik 

Michal

[PATCH] tests: cover disk, interface

2020-10-04 Thread Cole Robinson 
There is present no XML test coverage for this.
Add genericxml parse + formatting coverage.

Signed-off-by: Cole Robinson 
---
 .../device-backenddomain.xml  | 30 +++
 .../device-backenddomain.xml  |  1 +
 tests/genericxml2xmltest.c|  1 +
 3 files changed, 32 insertions(+)
 create mode 100644 tests/genericxml2xmlindata/device-backenddomain.xml
 create mode 12 tests/genericxml2xmloutdata/device-backenddomain.xml

diff --git a/tests/genericxml2xmlindata/device-backenddomain.xml 
b/tests/genericxml2xmlindata/device-backenddomain.xml
new file mode 100644
index 00..8e89c7fec3
--- /dev/null
+++ b/tests/genericxml2xmlindata/device-backenddomain.xml
@@ -0,0 +1,30 @@
+
+  foo
+  c7a5fdbd-edaf-9455-926a-d65c16db1809
+  219136
+  219136
+  1
+  
+hvm
+
+  
+  
+  destroy
+  restart
+  destroy
+  
+
+  
+  
+  
+  
+  
+
+
+
+  
+  
+  
+
+  
+
diff --git a/tests/genericxml2xmloutdata/device-backenddomain.xml 
b/tests/genericxml2xmloutdata/device-backenddomain.xml
new file mode 12
index 00..f19471e3b5
--- /dev/null
+++ b/tests/genericxml2xmloutdata/device-backenddomain.xml
@@ -0,0 +1 @@
+../genericxml2xmlindata/device-backenddomain.xml
\ No newline at end of file
diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c
index 102abfdec2..5110bfba86 100644
--- a/tests/genericxml2xmltest.c
+++ b/tests/genericxml2xmltest.c
@@ -233,6 +233,7 @@ mymain(void)
 DO_TEST("launch-security-sev");
 
 DO_TEST_DIFFERENT("cputune");
+DO_TEST("device-backenddomain");
 
 #define DO_TEST_BACKUP_FULL(name, intrnl) \
 do { \
-- 
2.28.0