Re: [PATCH 08/19] storage: Format qcow2v3 volumes by default

2021-02-12 Thread Jiri Denemark
On Fri, Feb 12, 2021 at 12:13:58 +, Daniel P. Berrangé wrote: > On Fri, Feb 12, 2021 at 11:55:36AM +0100, Peter Krempa wrote: > > On Fri, Feb 12, 2021 at 10:49:02 +, Daniel Berrange wrote: > > > On Thu, Feb 11, 2021 at 04:37:47PM +0100, Peter Krempa wrote: > > > > Format the new volumes

Re: [PATCH 08/19] storage: Format qcow2v3 volumes by default

2021-02-12 Thread Daniel P . Berrangé
On Fri, Feb 12, 2021 at 11:55:36AM +0100, Peter Krempa wrote: > On Fri, Feb 12, 2021 at 10:49:02 +, Daniel Berrange wrote: > > On Thu, Feb 11, 2021 at 04:37:47PM +0100, Peter Krempa wrote: > > > Format the new volumes with 'compat=1.1' since the minimum supported > > > qemu version is now 1.5

Re: [PATCH 08/19] storage: Format qcow2v3 volumes by default

2021-02-12 Thread Peter Krempa
On Fri, Feb 12, 2021 at 10:49:02 +, Daniel Berrange wrote: > On Thu, Feb 11, 2021 at 04:37:47PM +0100, Peter Krempa wrote: > > Format the new volumes with 'compat=1.1' since the minimum supported > > qemu version is now 1.5 rather the pre-historic compat=0.10. > > I understand the desire to

Re: [PATCH 08/19] storage: Format qcow2v3 volumes by default

2021-02-12 Thread Daniel P . Berrangé
On Thu, Feb 11, 2021 at 04:37:47PM +0100, Peter Krempa wrote: > Format the new volumes with 'compat=1.1' since the minimum supported > qemu version is now 1.5 rather the pre-historic compat=0.10. I understand the desire to do this, but this is none the less a semantic change to the behaviour of

Re: [PATCH 08/19] storage: Format qcow2v3 volumes by default

2021-02-12 Thread Jiri Denemark
On Thu, Feb 11, 2021 at 16:37:47 +0100, Peter Krempa wrote: > Format the new volumes with 'compat=1.1' since the minimum supported > qemu version is now 1.5 rather the pre-historic compat=0.10. > > Signed-off-by: Peter Krempa > --- > src/storage/storage_util.c

[PATCH 08/19] storage: Format qcow2v3 volumes by default

2021-02-11 Thread Peter Krempa
Format the new volumes with 'compat=1.1' since the minimum supported qemu version is now 1.5 rather the pre-historic compat=0.10. Signed-off-by: Peter Krempa --- src/storage/storage_util.c | 2 +-