Re: [PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-04-09 Thread Eric Farman
On 4/9/21 10:14 AM, Pavel Hrdina wrote: On Fri, Apr 09, 2021 at 09:13:32AM -0400, Eric Farman wrote: I still fail to see how calling virCgroupRemove(group->nested) in virCgroupRemove() would help at all. The original issue you mentioned in the commit message is that we log this error:

Re: [PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-04-09 Thread Pavel Hrdina
On Fri, Apr 09, 2021 at 09:13:32AM -0400, Eric Farman wrote: > > I still fail to see how calling virCgroupRemove(group->nested) in > > virCgroupRemove() would help at all. The original issue you mentioned in > > the commit message is that we log this error: > > > > unable to open > >

Re: [PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-04-09 Thread Eric Farman
On 4/9/21 6:02 AM, Pavel Hrdina wrote: On Thu, Apr 08, 2021 at 10:00:32PM -0400, Eric Farman wrote: On 4/8/21 8:12 AM, Pavel Hrdina wrote: On Wed, Apr 07, 2021 at 11:28:48PM -0400, Eric Farman wrote: On 4/7/21 9:07 AM, Pavel Hrdina wrote: On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric

Re: [PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-04-09 Thread Pavel Hrdina
On Thu, Apr 08, 2021 at 10:00:32PM -0400, Eric Farman wrote: > > > On 4/8/21 8:12 AM, Pavel Hrdina wrote: > > On Wed, Apr 07, 2021 at 11:28:48PM -0400, Eric Farman wrote: > > > > > > > > > On 4/7/21 9:07 AM, Pavel Hrdina wrote: > > > > On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric Farman

Re: [PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-04-08 Thread Eric Farman
On 4/8/21 8:12 AM, Pavel Hrdina wrote: On Wed, Apr 07, 2021 at 11:28:48PM -0400, Eric Farman wrote: On 4/7/21 9:07 AM, Pavel Hrdina wrote: On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric Farman wrote: The introduction of nested cgroups used a little macro virCgroupGetNested() to retrieve

Re: [PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-04-08 Thread Pavel Hrdina
On Wed, Apr 07, 2021 at 11:28:48PM -0400, Eric Farman wrote: > > > On 4/7/21 9:07 AM, Pavel Hrdina wrote: > > On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric Farman wrote: > > > The introduction of nested cgroups used a little macro > > > virCgroupGetNested() to retrieve the nested cgroup > > >

Re: [PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-04-07 Thread Eric Farman
On 4/7/21 9:07 AM, Pavel Hrdina wrote: On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric Farman wrote: The introduction of nested cgroups used a little macro virCgroupGetNested() to retrieve the nested cgroup pointer, if one exists. But this macro isn't used when removing cgroups, resulting in

Re: [PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-04-07 Thread Pavel Hrdina
On Fri, Mar 26, 2021 at 05:25:03PM +0100, Eric Farman wrote: > The introduction of nested cgroups used a little macro > virCgroupGetNested() to retrieve the nested cgroup > pointer, if one exists. But this macro isn't used when > removing cgroups, resulting in some messages: > > Mar 25 20:55:17

[PATCH 1/1] vircgroup: Cleanup nested cgroups

2021-03-26 Thread Eric Farman
The introduction of nested cgroups used a little macro virCgroupGetNested() to retrieve the nested cgroup pointer, if one exists. But this macro isn't used when removing cgroups, resulting in some messages: Mar 25 20:55:17 fedora33 libvirtd[955]: unable to open