Re: [PATCH 1/4] network: firewalld: convert to policies

2022-05-12 Thread Eric Garver
I'm adding this text here in hopes that Mimecast no longer thinks this email is s-p-a-m. My replies are inline below. :) On Thu, May 12, 2022 at 07:35:03PM +0100, Daniel P. Berrangé wrote: > On Wed, May 11, 2022 at 11:41:52AM -0400, Eric Garver wrote: > > Convert the existing behavior into

Re: [PATCH 1/4] network: firewalld: convert to policies

2022-05-12 Thread Eric Garver
On Thu, May 12, 2022 at 01:53:00PM -0400, Laine Stump wrote: > On 5/12/22 12:53 PM, Eric Garver wrote: > > On Wed, May 11, 2022 at 05:15:25PM +0100, Daniel P. Berrangé wrote: > > > On Wed, May 11, 2022 at 11:41:52AM -0400, Eric Garver wrote: > > > > Convert the existing behavior into policies. > >

Re: [PATCH 1/4] network: firewalld: convert to policies

2022-05-12 Thread Daniel P . Berrangé
On Wed, May 11, 2022 at 11:41:52AM -0400, Eric Garver wrote: > Convert the existing behavior into policies. > > This commit has no functional changes. > > Signed-off-by: Eric Garver > --- > src/network/libvirt-nat-out.policy | 12 > src/network/libvirt-to-host.policy | 20

Re: [PATCH 1/4] network: firewalld: convert to policies

2022-05-12 Thread Laine Stump
On 5/12/22 12:53 PM, Eric Garver wrote: On Wed, May 11, 2022 at 05:15:25PM +0100, Daniel P. Berrangé wrote: On Wed, May 11, 2022 at 11:41:52AM -0400, Eric Garver wrote: Convert the existing behavior into policies. Has this split of .zone vs .policy been something firewalld always supported,

Re: [PATCH 1/4] network: firewalld: convert to policies

2022-05-12 Thread Eric Garver
On Wed, May 11, 2022 at 05:15:25PM +0100, Daniel P. Berrangé wrote: > On Wed, May 11, 2022 at 11:41:52AM -0400, Eric Garver wrote: > > Convert the existing behavior into policies. > > Has this split of .zone vs .policy been something firewalld > always supported, or is it a "new" feature for some

Re: [PATCH 1/4] network: firewalld: convert to policies

2022-05-11 Thread Daniel P . Berrangé
On Wed, May 11, 2022 at 11:41:52AM -0400, Eric Garver wrote: > Convert the existing behavior into policies. Has this split of .zone vs .policy been something firewalld always supported, or is it a "new" feature for some value of "new" ? Essentially wonder if this has any historical back compat

[PATCH 1/4] network: firewalld: convert to policies

2022-05-11 Thread Eric Garver
Convert the existing behavior into policies. This commit has no functional changes. Signed-off-by: Eric Garver --- src/network/libvirt-nat-out.policy | 12 src/network/libvirt-to-host.policy | 20 src/network/libvirt.zone | 23 +--