Re: [PATCH 1/8] Added a few attach-disk parameters

2020-11-10 Thread Peter Krempa
On Tue, Nov 10, 2020 at 15:56:13 -0600, Ryan Gahagan wrote: Please describe your changes in the commit message. > Signed-off-by: Ryan Gahagan > --- > tools/virsh-domain.c | 76 +++- > 1 file changed, 68 insertions(+), 8 deletions(-) > > diff --git

Re: [PATCH 1/8] Added a few attach-disk parameters

2020-11-10 Thread Han Han
It is better to format the patch summary like this format: "SUBSYSTEM: TITLE" For example, this patch could be "virsh: Added a few attach-disk parameters" You can see the git log of libvirt for more reference: https://libvirt.org/git/?p=libvirt.git;a=summary On Wed, Nov 11, 2020 at 5:58 AM Ryan

[PATCH 1/8] Added a few attach-disk parameters

2020-11-10 Thread Ryan Gahagan
Signed-off-by: Ryan Gahagan --- tools/virsh-domain.c | 76 +++- 1 file changed, 68 insertions(+), 8 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 12b35c037d..16227085cc 100644 --- a/tools/virsh-domain.c +++