Re: [PATCH 10/15] virNetLibsshAuthenticateKeyboardInteractive: Use virAuthAskCredential

2023-01-17 Thread Jonathon Jongsma
I personally would've preferred to have this patch combined with the previous one so that it's easier to verify that the refactored code maintains the same functionality as the replaced code. But I understand that you're refactoring more cases in the upcoming commits, so I guess there's not

[PATCH 10/15] virNetLibsshAuthenticateKeyboardInteractive: Use virAuthAskCredential

2023-01-17 Thread Peter Krempa
Rework the code to use the new helper instead of open coding the auth callback interaction. Signed-off-by: Peter Krempa --- src/rpc/virnetlibsshsession.c | 47 ++- 1 file changed, 7 insertions(+), 40 deletions(-) diff --git a/src/rpc/virnetlibsshsession.c