Re: [PATCH 32/37] qemuSlirpStart: Simplify parameters

2022-05-13 Thread Peter Krempa
On Thu, May 12, 2022 at 13:37:45 -0500, Jonathon Jongsma wrote: > On 5/10/22 10:20 AM, Peter Krempa wrote: > > The 'driver' can be taken from the private data of 'vm' and 'slirp' can > > be taken from private data of 'net', both of which we need anyways. > > > > Additionally by checking whether

Re: [PATCH 32/37] qemuSlirpStart: Simplify parameters

2022-05-12 Thread Jonathon Jongsma
On 5/10/22 10:20 AM, Peter Krempa wrote: The 'driver' can be taken from the private data of 'vm' and 'slirp' can be taken from private data of 'net', both of which we need anyways. Additionally by checking whether slirp needs to be started inside the function we don't need to do this logic in

[PATCH 32/37] qemuSlirpStart: Simplify parameters

2022-05-10 Thread Peter Krempa
The 'driver' can be taken from the private data of 'vm' and 'slirp' can be taken from private data of 'net', both of which we need anyways. Additionally by checking whether slirp needs to be started inside the function we don't need to do this logic in the callers. Signed-off-by: Peter Krempa