Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-20 Thread Zhenyu Zheng
Yes, I will do that. On Mon, Apr 20, 2020 at 10:12 PM Jiri Denemark wrote: > On Fri, Apr 17, 2020 at 16:53:18 +0800, Zhenyu Zheng wrote: > > Ping for reviews > > Could you please resend the new version of patches as a separate series > (don't forget to update the subject to v3)? Hunting for the

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-20 Thread Jiri Denemark
On Fri, Apr 17, 2020 at 16:53:18 +0800, Zhenyu Zheng wrote: > Ping for reviews Could you please resend the new version of patches as a separate series (don't forget to update the subject to v3)? Hunting for the new patches hidden in random replies to the reviewers comments or original patches is

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-17 Thread Zhenyu Zheng
Ping for reviews On Fri, Apr 10, 2020 at 5:55 PM Andrea Bolognani wrote: > On Thu, 2020-04-09 at 13:03 +0200, Jiri Denemark wrote: > > On Thu, Apr 02, 2020 at 17:03:59 +0800, Zhenyu Zheng wrote: > > > +static int > > > +armCpuDataFromRegs(virCPUarmData *data) > > > +{ > > > +/* Generate

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-10 Thread Andrea Bolognani
On Thu, 2020-04-09 at 13:03 +0200, Jiri Denemark wrote: > On Thu, Apr 02, 2020 at 17:03:59 +0800, Zhenyu Zheng wrote: > > +static int > > +armCpuDataFromRegs(virCPUarmData *data) > > +{ > > +/* Generate human readable flag list according to the order of */ > > +/* AT_HWCAP bit map */ > > +

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-10 Thread Zhenyu Zheng
Hi Daniel, Jirka Thanks alot for the review and info, I have updated the code to only compile on aarch64 platform, and I've done the gitlab CI testing as suggested: https://gitlab.com/ZhengZhenyu/libvirt/pipelines/134657317 and manually tested on aarch64. BR, On Fri, Apr 10, 2020 at 4:21 PM

[PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-10 Thread ZhengZhenyu
Introduce getHost support for ARM CPU driver, read CPU vendor_id, part_id and flags from registers directly. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 202 +- 1 file changed, 201 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_arm.c

[PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-09 Thread Zhenyu Zheng
Introduce getHost support for ARM CPU driver, read CPU vendor_id, part_id and flags from registers directly. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 193 +- 1 file changed, 192 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_arm.c

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-09 Thread Zhenyu Zheng
Thanks for the info, as for ARM testing, we are happy to provide some machines if the community likes. BR, On Thu, Apr 9, 2020 at 8:03 PM Daniel P. Berrangé wrote: > On Thu, Apr 09, 2020 at 07:52:27PM +0800, Zhenyu Zheng wrote: > > Hi, > > > > Thanks alot for all the reviews, I'm updating the

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-09 Thread Daniel P . Berrangé
On Thu, Apr 09, 2020 at 07:52:27PM +0800, Zhenyu Zheng wrote: > Hi, > > Thanks alot for all the reviews, I'm updating the codes, as for those > headers, > hwcap.h is here: > https://github.com/torvalds/linux/blob/v5.6/arch/arm/include/asm/hwcap.h and > should be available for 5.6, > auxv.h is

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-09 Thread Zhenyu Zheng
Hi, Thanks alot for all the reviews, I'm updating the codes, as for those headers, hwcap.h is here: https://github.com/torvalds/linux/blob/v5.6/arch/arm/include/asm/hwcap.h and should be available for 5.6, auxv.h is from glibc:

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-09 Thread Jiri Denemark
On Thu, Apr 02, 2020 at 17:03:59 +0800, Zhenyu Zheng wrote: > Introduce getHost support for ARM CPU driver, read > CPU vendor_id, part_id and flags from registers > directly. > > Signed-off-by: Zhenyu Zheng > --- > src/cpu/cpu_arm.c | 194 +- > 1 file

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-09 Thread Jiri Denemark
On Thu, Apr 09, 2020 at 11:28:04 +0100, Daniel P. Berrangé wrote: > On Thu, Apr 02, 2020 at 05:03:59PM +0800, Zhenyu Zheng wrote: > > Introduce getHost support for ARM CPU driver, read > > CPU vendor_id, part_id and flags from registers > > directly. > > > > Signed-off-by: Zhenyu Zheng > > --- >

Re: [PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-09 Thread Daniel P . Berrangé
On Thu, Apr 02, 2020 at 05:03:59PM +0800, Zhenyu Zheng wrote: > Introduce getHost support for ARM CPU driver, read > CPU vendor_id, part_id and flags from registers > directly. > > Signed-off-by: Zhenyu Zheng > --- > src/cpu/cpu_arm.c | 194 +- > 1

[PATCH V2 5/5] cpu: Introduce getHost support for ARM CPU driver

2020-04-02 Thread Zhenyu Zheng
Introduce getHost support for ARM CPU driver, read CPU vendor_id, part_id and flags from registers directly. Signed-off-by: Zhenyu Zheng --- src/cpu/cpu_arm.c | 194 +- 1 file changed, 193 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_arm.c